profile
viewpoint
Jeffrey Way JeffreyWay Laracasts Winter Park, FL https://laracasts.com Laracasts owner.

JeffreyWay/laravel-mix 3856

An elegant wrapper around Webpack for the 80% use case.

JeffreyWay/Laravel-4-Generators 2981

Rapidly speed up your Laravel workflow with generators

JeffreyWay/council 561

An open source forum built on Laravel.

JeffreyWay/laravel-elixir-vueify 159

This is a very thin wrapper for Laravel Elixir and the Browserify Vueify plugin.

JeffreyWay/laravel-elixir-stylus 80

Elixir Wrapper Around Stylus

foxted/Larabook 47

Following Jeffrey Way's Laracast Larabook series.

JeffreyWay/laravel-elixir-vue 41

Laravel Elixir Vue integration.

JeffreyWay/Laravel-Elixir-Rollup 28

Official Rollup extension for Laravel Elixir. (Includes support for .vue files).

push eventlaracasts/gilded-rose-with-phpunit

Jeffrey Way

commit sha 1f3e84c37ff8e12b79adc177e51fad564d79ace6

Update readme

view details

push time in 6 days

push eventlaracasts/gilded-rose-with-phpunit

Jeffrey Way

commit sha 4933c6b639edb4017d969ff53feda5a5565c8984

Update readme

view details

push time in 6 days

create barnchlaracasts/gilded-rose-with-phpunit

branch : completed

created branch time in 6 days

create barnchlaracasts/gilded-rose-with-phpunit

branch : master

created branch time in 6 days

pull request commentJeffreyWay/laravel-mix

Remove notification timeout, fixes #2161

Thanks @AdrienPoupa. Sorry for the wait.

AdrienPoupa

comment created time in a month

push eventJeffreyWay/laravel-mix

Adrien Poupa

commit sha b0c2960b433d2d3790c45e46c428643a59649d1a

Remove notification timeout, fixes #2161 (#2179)

view details

push time in a month

issue closedJeffreyWay/laravel-mix

Notifications not showing in KDE 5.16 because of hardcoded timeout

<!-- Before posting this issue, please perform the following steps, and confirm that the issue is still present.

  1. Update Laravel Mix to the latest version. (npm update laravel-mix or yarn upgrade laravel-mix --latest)
  2. Nuke your dependencies, and reinstall from scratch: rm -rf node_modules && npm cache clear && npm install.
  3. Check your package.json file, and ensure that there are no old Laravel Elixir dependencies that might be interfering with Mix. -->
  • Laravel Mix Version: 4.1.2 (npm list --depth=0)
  • Node Version (node -v): v12.6.0
  • NPM Version (npm -v): 6.10.1
  • OS: Kubuntu 19.04 with KDE 5.16

Description:

I can see the notification for 2 ms instead of 2 seconds.

See screencast:

mix

The problem is coming from Mix because if I use WebpackNotifierPlugin directly it works:

var WebpackNotifierPlugin = require('webpack-notifier');

mix.webpackConfig(webpack => {
    return {
        plugins: [
            new WebpackNotifierPlugin({alwaysNotify: true}),
        ]
    };
});

results in

image

After digging further, I understood that for KDE, setting a timeout to 2 is 2ms.

https://github.com/JeffreyWay/laravel-mix/blob/master/src/components/Notifications.js#L18

If I set it to 2000 then I'm getting 2 seconds:

mix.webpackConfig(webpack => {
    return {
        plugins: [
            new WebpackNotifierPlugin({
                title: 'Laravel Mix 2',
                alwaysNotify: Config.notifications.onSuccess,
                hint:
                    process.platform === 'linux'
                        ? 'int:transient:1'
                        : undefined,
                timeout: 2000, // 2000 instead of 2
                contentImage: Mix.paths.root(
                    'node_modules/laravel-mix/icons/laravel.png'
                ),
            }),
        ]
    };
});

Interestingly if I set the title to Laravel Mix and not Laravel Mix 2, then the notification only shows for 2 ms. I guess this is because KDE suppresses duplicate notifications.

This PR is to blame: https://github.com/JeffreyWay/laravel-mix/pull/1890

Please revert it as it is not working universally, or make it configurable with no value by default.

KDE allows setting a timeout per program so it should not be done there IMO.

Thanks

closed time in a month

AdrienPoupa

PR merged JeffreyWay/laravel-mix

Remove notification timeout, fixes #2161

Remove timeout notification, this breaks the notifications on KDE

https://github.com/JeffreyWay/laravel-mix/issues/2161

+0 -1

4 comments

1 changed file

AdrienPoupa

pr closed time in a month

PullRequestEvent

pull request commentJeffreyWay/laravel-mix

[WIP] Webpack 5 Support

Going over this today. 👍

thecrypticace

comment created time in a month

pull request commentJeffreyWay/laravel-mix

Remove notification timeout, fixes #2161

Not without a description why we're removing it.

AdrienPoupa

comment created time in a month

push eventJeffreyWay/laravel-mix

Trevor Fitzgerald

commit sha ddd3834eae01bb2d40fe186d8a72ab23d8830f51

Browsersync snippet regex for lookbehinds (#2227)

view details

push time in 2 months

PR merged JeffreyWay/laravel-mix

Update Browsersync snippet regex to use a lookbehind

The current regex is /(<\/body>|<\/pre>)/i so it will find either the first </body> or </pre> tag, but it should really find the last.

This PR adds a lookbehind to the regex to grab the last one instead.

This would be the effect of this change on a page that contains a </pre> and a </body>:

<html>
<body>
    <pre>
--        <script src="browsersync.js"></script>
    </pre>
++  <script src="browsersync.js"></script>
</body>
</html>

Fixes #2239 Fixes laravel/framework#29909 Fixes laravel/framework#30018 Fixes facade/ignition#16 Fixes BrowserSync/browser-sync#1459

+30 -1

1 comment

2 changed files

fitztrev

pr closed time in 2 months

issue closedJeffreyWay/laravel-mix

[Laravel 6.0] Error display broken for view error with mix.browserSync

  • Laravel Mix Version: 4.1.4
  • Node Version (node -v): 12.9.1
  • NPM Version (npm -v): 6.10.2
  • OS: Windows

Description:

Raw display of JS file on view error: Raw JS file instead of error

Steps To Reproduce:

  • Fresh install of Laravel 6.0
  • Add mix.browserSync({proxy: 'localhost:8000'}); to webpack.mix.js
  • Replace welcome.blade.php content with {{ 1/0 }} (to trigger Division by zero exception)
  • Run npm run watch
  • Open http://localhost:3000/

Expected

The nice error display we have in http://localhost:8000/ (dispay with Facade\Ignition\Exceptions\ViewException)

Observed

Raw JS file instead of error

Original issue: https://github.com/laravel/framework/issues/29909

closed time in 2 months

kylekatarnls

push eventJeffreyWay/laravel-mix

Sashko Guz

commit sha 0a31b17cad8f1469124042df1203c38632e059f8

Update CssPurifier to laravel resources structure (#2180) Update CssPurifier to new laravel resources structure resources/assets/js => resources/js

view details

push time in 2 months

PR merged JeffreyWay/laravel-mix

Update CssPurifier to laravel resources structure

Update CssPurifier to new laravel resources structure resources/assets/js => resources/js

+1 -1

0 comment

1 changed file

Somethingideally

pr closed time in 2 months

push eventJeffreyWay/laravel-mix

Trevor Fitzgerald

commit sha 21efecb7a466051fbd0a81be7dfeb2f7d2cdd3b1

Update travis.yml to supported Node.js versions (#2248) * travis.yml update tested node.js versions * Add Node.js v13

view details

push time in 2 months

PR merged JeffreyWay/laravel-mix

Update travis.yml to supported Node.js versions

The currently supported Node.js versions are: 8, 10, 12, and 13.

+2 -2

0 comment

1 changed file

fitztrev

pr closed time in 2 months

PR closed JeffreyWay/laravel-mix

Javascript component only for Javascript

When I create new laravel project and build assets install vue-template-compiler dependency but It's not necessary if there are no Vue files, also It can be install when user use Vue presets so mix.vue() is good to apply Vue dependencies.

please advice me.

+1 -25

1 comment

1 changed file

pavinthan

pr closed time in 2 months

push eventJeffreyWay/laravel-mix

João Magalhães

commit sha 46afaa2bb1bdcba79c57829af18411e9091f9e99

Pass options to ts-loader using a third argument (#2287) * Pass options to ts-loader using a third argument * change spread operator to Object.assign()

view details

push time in 2 months

PR merged JeffreyWay/laravel-mix

Pass options to ts-loader using a third argument

This pull request makes it possible to pass a third argument to ts-loader, for example:

.ts('resources/ts/app.ts', 'public/js', { transpileOnly: !mix.inProduction() })
+31 -3

0 comment

2 changed files

jphms

pr closed time in 2 months

push eventJeffreyWay/laravel-mix

Troels Madsen

commit sha 5e332f0289478812ad3a3c7259a541b7102a9b4a

Update dependency to avoid security flawness (#2291) * Update dependency to avoid security flawness It is a upgrade of a dependency to resolve the [CVE-2019-16769](https://github.com/advisories/GHSA-h9rv-jmmf-4pgx) security issue. * added lock file to the changes

view details

push time in 2 months

PR merged JeffreyWay/laravel-mix

Update dependency to avoid security flawness

It is an upgrade of a dependency to resolve the CVE-2019-16769 security issue.

+260 -93

7 comments

2 changed files

Thanerik

pr closed time in 2 months

create barnchlaracasts/Widget

branch : master

created branch time in 4 months

created tagJeffreyWay/laravel-mix

tagv5.0.0

An elegant wrapper around Webpack for the 80% use case.

created time in 5 months

release JeffreyWay/laravel-mix

v5.0.0

released time in 5 months

push eventJeffreyWay/laravel-mix

Dave Shoreman

commit sha 719edb104b2ce28817bb51e1923ba539adaa7b18

Update to support sass-loader 8.x (#2223) * Update to support sass-loader 8.x Fixes the ValidationError when building, caused by sass-loader moving node/dart-sass options to a special `sassOptions` property. * Update shrinkwrap to satisfy Travis/AppVeyor * Fix tests

view details

push time in 5 months

PR merged JeffreyWay/laravel-mix

Update to support sass-loader 8.x

Wraps the options for Dart/Node-sass in a sassOptions object and updates versions of certain packages according to requirements for sass-loader 8.0.0.

Fixes #2206

+648 -382

2 comments

5 changed files

dshoreman

pr closed time in 5 months

issue closedJeffreyWay/laravel-mix

Compatibility with sass-loader 8.0.0

  • Laravel Mix Version: 4.1.2

Description:

A heads up that Laravel mix doesn't seem to be compatible with sass-loader 8.0.0 (just released) which has some breaking changes.

Steps To Reproduce:

See build failure in https://github.com/danielbachhuber/simple-event-tracking/pull/3

closed time in 5 months

danielbachhuber

pull request commentlaravel/framework

[6.x] Wrap MySQL default values in parentheses

Heads up that this broke one of my migrations after updating from 6.0.1 to 6.0.2.

browner12

comment created time in 5 months

CommitCommentEvent

issue commentJeffreyWay/laravel-mix

After updating laravel-mix to version 4.1.3

More information please.

Wremeker

comment created time in 6 months

more