profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/IanVaughan/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ian Vaughan IanVaughan Outfund London, England https://twitter.com/IanVaughan I have a bio

IanVaughan/dotfiles 2

Configuration files

IanVaughan/damnproxy 1

a app that checks which sites are being blocked by our proxy server!

IanVaughan/diffserve 1

Serves up your uncommitted changes.

IanVaughan/eis-parser 1

Parse proprietary EIS binary files

IanVaughan/email-reponse 1

Little ruby script to auto-respond to certain emails

ElectricVisions/f8app 0

Source code of the official F8 app of 2016, powered by React Native and other Facebook open source projects.

ElectricVisions/sonarapp 0

An alternative guide for Sonar Barcelona written with React Native

IanVaughan/app_conf 0

Simplest YAML Backed Application Wide Configuration (AppConfig)

startedSlazanger/SMT

started time in 5 days

fork IanVaughan/esi-docs

The official repository for ESI documentation

fork in a month

issue closedcollectiveidea/audited

Why not store created_at and updated_at by default?

Just curious as to why created_at and updated_at are not saved as default? When I wanted to extract a revision, I only then noticed we have not been saving this data. I guess I can include these via audited only: [], but then I need to also manually list all the other attributes. What do you folks think about adding date fields as standard if present?

closed time in a month

IanVaughan

issue commentcollectiveidea/audited

Why not store created_at and updated_at by default?

Thanks for your reply... Sorry for missing this completely, but of course, the created_at is within the first revision! And yes, I see now that updated_at will be the destroy itself. Thanks again for your time and for this gem!

IanVaughan

comment created time in a month

issue openedcollectiveidea/audited

How to restore with original id?

I was looking to restore some records, and found I had to do this little dance to get the record saved with the original ID:

Audited::Audit.where(action: "destroy").revision.update!(id: found.auditable_id)

Is that the intended method or am I doing something wrong?

Similar to :

you could no longer restore a record to its original state (with original id). That isn't a design goal of Audited, but I do think it is something people use it for.

https://github.com/collectiveidea/audited/pull/294#issuecomment-248387470

created time in a month

issue openedcollectiveidea/audited

Why not store created_at and updated_at by default?

Just curious as to why created_at and updated_at are not saved as default? When I wanted to extract a revision, I only then noticed we have not been saving this data. I guess I can include these via audited only: [], but then I need to also manually list all the other attributes. What do you folks think about adding date fields as standard if present?

created time in a month

push eventIanVaughan/ex_kills

Ian Vaughan

commit sha 9b5bdce9de4abde347efa36d978f7c04d6a64590

updates

view details

Ian Vaughan

commit sha 7efe05719b77c2b380dce26a1d95687c1686fc83

Update npm and deps

view details

Ian Vaughan

commit sha 755ecf3439e314a30f1764fff33b6d8a42d6cfac

Use Kills repo no ExKills

view details

Ian Vaughan

commit sha 226789deabd9918c9f75cbfe39d607ab7b4017a5

Tidy

view details

Ian Vaughan

commit sha 19b45dbe1f3b5ce4e7fd9a5564187a1749859819

Add migrations

view details

Ian Vaughan

commit sha 2769a37bfda4d3edcdfcb6351c51d20d3e6b8151

fix js issues

view details

push time in a month

push eventIanVaughan/ex_kills

Ian Vaughan

commit sha 78abbb30a582636b911581a83f9f57d1bfc4c18b

Add tool versions

view details

push time in a month

push eventIanVaughan/ex_kills

Ian Vaughan

commit sha b609cb15a0a6525b002118c477cb9d958fa1fa55

info

view details

push time in a month

issue closedactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

Description
Our CI pipeline started failing our builds this morning, with errors relating to not running JavaScript. Rerunning any previously passing CI builds also fails with the same errors. This occurred a few times over the last year, of which last time it just started working again after a period of days. See here for previous time https://github.community/t/rails-feature-tests-have-stopped-running-javascript/129485

Question, Bug, or Feature?:
Bug

Virtual environments affected

  • [ ] Ubuntu 16.04
  • [ ] Ubuntu 18.04
  • [x] Ubuntu 20.04
  • [ ] macOS 10.15
  • [ ] macOS 11
  • [ ] Windows Server 2016 R2
  • [ ] Windows Server 2019

Image version

Environment: ubuntu-20.04
Version: 20210531.0

Repro steps
Workflow yml and build log output: https://gist.github.com/IanVaughan/3add69d297d1f237f653ff8f65bdae54

closed time in a month

IanVaughan

issue commentactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

We found the issue, a cleaver colleague than me, dig into the logs and spotted 2 issues, the first I think being the cause.

  1. running out of inotify watchers:
        FATAL: Listen error: unable to monitor directories for changes.
        Visit https://github.com/guard/listen/blob/master/README.md#increasing-the-amount-of-inotify-watchers for info on how to fix this.

1.1 The fix was to set DISABLE_SPRING: true in GitHub actions

  1. syntax error in test.js
Compiling...
Compilation failed:
/home/runner/work/org/repo/config/webpack/test.js:7
import $ from 'jquery';

2.1 test.js hasn't changed for nearly a year, but JS libraries have been upgraded each week.

IanVaughan

comment created time in a month

issue commentactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

Hi, while reducing my current codebase to a simple example test repo, I found that it started working when removing some tests. So far its non-deterministic, in that, I have 10 commits removing sub-folders of tests, and one commit onwards it starts passing. If I rebase that commit to the end, then it starts working onwards from a different commit.

What I've seen is that the assets have not loaded, eg there is no css or javascript loaded. If I get the failed test artifact from GitHub a part of it looks like this: Screenshot 2021-06-23 at 17 45 55 Verses what it looks like when ran locally: Screenshot 2021-06-23 at 17 46 48

The tests are run with the same command both on CI and locally, via bundler exec rspec.

I'm still learning the internals of the asset pipeline so there might be something I'm missing, so I'm sure you might be tempted to mark this as a user issue. But the fact that it works locally and not on GitHub Actions is odd to me, and the fact previous older commits that once passed now fail on re-runs should point to something outside the repo source and outside my control. Its looking unlikely though that I will be able to produce a public repo to demonstrate this, so on those grounds I guess you may have to close this, and I fully understand that reasoning. But regardless of the issue state, I will continue to dig in and report any findings on this, I'm on this task all this week!

IanVaughan

comment created time in a month

issue commentactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

Hiya @dsame , thanks for your comments. The raise occurs because the POST request that the JS should be doing is now doing a GET, which there is no route for. When the tests are run locally or the action used via the server, it correctly does a POST and works fine. Its only in the now current running GitHub Actions do these tests fail, and I've scheduled time this week to create a public repo to reproduce this issue, sorry for the delay so far.

IanVaughan

comment created time in a month

issue commentactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

Hi @miketimofeev I really appreciate that, sorry for not sorting it out before raising it, but I wanted to get it logged sooner in case it correlated to anything. I will extract code from my private repo into a public one over the next few days to reproduce this.

IanVaughan

comment created time in 2 months

issue openedactions/virtual-environments

Rails feature tests have stopped running javascript feature tests

Description
Our CI pipeline started failing our builds this morning, with errors relating to not running JavaScript. Rerunning any previously passing CI builds also fails with the same errors. This occurred a few times over the last year, of which last time it just started working again after a period of days. See here for previous time https://github.community/t/rails-feature-tests-have-stopped-running-javascript/129485

Question, Bug, or Feature?:
Bug

Virtual environments affected

  • [ ] Ubuntu 16.04
  • [ ] Ubuntu 18.04
  • [x] Ubuntu 20.04
  • [ ] macOS 10.15
  • [ ] macOS 11
  • [ ] Windows Server 2016 R2
  • [ ] Windows Server 2019

Image version

Environment: ubuntu-20.04
Version: 20210531.0

Repro steps
Workflow yml and build log output: https://gist.github.com/IanVaughan/3add69d297d1f237f653ff8f65bdae54

created time in 2 months

issue commentchobits/ngx_http_proxy_connect_module

authorization for https connections?

Do you recommend using OpenResty to get lua-nginx-module and compiling that with ngx_http_proxy_connect_module? Or the other way round? As I have Nginx built with this module, but am having issues following install instructions https://github.com/openresty/lua-nginx-module/#installation

legale

comment created time in 2 months

push eventout-fund/nginx_proxy

Ian Vaughan

commit sha e22a58b23e545a0a977c3cb8d9dd65e3092e6f9a

Config for servers that need proxying

view details

push time in 2 months

issue commentRubyMoney/money

Dated Exchange rates

I'm not sure how a separate gem would work, as the interface needs to change. It might end up be a fork of this gem, which would need keeping up to date with the core. I will take a look at how that might be done though, as sounds interesting. If that does not seem workable, I will push a branch with ideas about bring it into the core gem.

IanVaughan

comment created time in 2 months

issue openedRubyMoney/money

Dated Exchange rates

I have requirements to exchange money based on exchange rates on specific dates. This is working fine currently by using manual converting code, rather than the Exchange rate stores. What I'm thinking is if this is something that could/should be brought into Money gem? I'm happy to implement it and raise a PR, but wanted to check first if its likely to be accepted.

I'm thinking that the interface should be extended, for the Store interface

def add_rate(iso_from, iso_to, rate, date: nil); end  # Or normal default date = nil defaults
def get_rate(iso_from, iso_to, date: nil); end

And a Money class update

def exchange_to(other_currency, date: nil, &rounding_method)

Of corce lots of other changes will be needed as well, but raising this to get feedback on if the idea is even doable!

created time in 2 months

issue openedGoogleCloudPlatform/community

Issue with tutorials/nginx-reverse-proxy-docker.md

It jumps from creating an instance to running docker... Its a little unclear, but as a guess, before Setting up the reverse proxy, we should connect via SSH to the new instance?

created time in 3 months

issue commentfacebook/facebook-ruby-business-sdk

Issue with gem version 0.10.0 creating unwanted custom events instead of using standard events

I think you are tagging the wrong person, sorry I cannot help.

matthieua

comment created time in 3 months