profile
viewpoint
Herrington Darkholme HerringtonDarkholme Rainbow Alliance ShinNippori 闇と森の妖精

acgotaku/BaiduExporter 13955

Assistant for Baidu to export download links to aria2/aria2-rpc

HerringtonDarkholme/av-ts 211

A modern, type-safe, idiomatic Vue binding library

HerringtonDarkholme/auto-fu.zsh 13

#zsh automatic complete-word and list-choices. Originally incr-0.2.zsh by y.fujii <y-fujii at mimosa-pudica.net>

HerringtonDarkholme/atom-vue 6

vue-language-server demo for Atom

HerringtonDarkholme/av-ts-template 6

av-ts template for vue-cli

AminoApps/hashids-bn 1

JavaScript library to generate random ids from numbers. Support BigNumber!

HerringtonDarkholme/byon 1

Angular2 demo

startedStructureBuilder/react-keep-alive

started time in 2 days

startedy0ssar1an/q

started time in 4 days

issue commentHerringtonDarkholme/yats.vim

Weird performance issue with assignment/arrow function/object spread combination

Would you like provide a minimal vimrc for this bug? Minimal vimrc means you need to remove all other plugins and only keep yats.

sandhose

comment created time in 7 days

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 97f53f67097ddc87ab64bf8931c2798ea56e6184

Fix highlight for multi-line union types (fixes #162)

view details

push time in 7 days

issue closedHerringtonDarkholme/yats.vim

Incorrect syntax highlighting

yats.vim highlights this incorrectly:

type Foo =
    | { bar: string }
    | { baz?(): number }

function bat() {
    // stuff...
}

const x = y + 1;

Screenshot:

Screen Shot 2020-02-06 at 8 08 28 PM

This doesn't happen if baz? is replaced with baz:

Screen Shot 2020-02-06 at 8 08 41 PM

closed time in 7 days

mhmdanas

pull request commentHerringtonDarkholme/yats.vim

Fix highlight for multi-line union types

Thanks!

rhysd

comment created time in 7 days

pull request commentHerringtonDarkholme/yats.vim

Support ECMAScript private fields added from TS 3.8

Hi @NullVoxPopuli, it won't be hard to add private method support once it is available in TypeScript. Let's wait for its adoption.

rhysd

comment created time in 17 days

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha ae182ee2449db2cce3055f7430b3adf6c0867948

Update notice for old regexp

view details

push time in a month

issue commentHerringtonDarkholme/yats.vim

Performance issues?

@AZanellato Sure! I will update it!

esamattis

comment created time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 1b0d73a1f6f5a09749119972a23db520e402a011

Math

view details

push time in a month

pull request commentHerringtonDarkholme/yats.vim

Fix highlighting on ':' after regex literal

Thanks!

rhysd

comment created time in a month

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 88a189f26638630d8585d14cd0095fd90177925c

Fix highlighting on ':' after regex literal

view details

push time in a month

PR merged HerringtonDarkholme/yats.vim

Reviewers
Fix highlighting on ':' after regex literal

Current yats.vim does not consider : after / of regex literals. This PR fixes the highlighting as follows:

Before:

スクリーンショット 2020-01-28 20 21 02

After:

スクリーンショット 2020-01-28 20 20 32

+1 -1

0 comment

1 changed file

rhysd

pr closed time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 2017be7093fb08bb52c31552d7f3e87cf1f310bb

Math

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 3ede424a798551dfe5a65f19901fc499327397ce

Create 92_reverse_linked_list_ii.rs

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 27c5b15788ebdf6e733edf495c336a4fbb2e2fa8

Use bitmap to track status

view details

push time in a month

CommitCommentEvent

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha fc7c25002c9499042fb7392069faddcdc474568f

DFS

view details

push time in a month

CommitCommentEvent

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 33157c128a9c18cea8ca8d820cd486f35c5a651b

Breadth first

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 430f4a2d37302d5b7c2018d519be931ee450186d

String

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha a0d4fc887d5abbd456e542e766fb65e4ae0fd4ff

DP

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha b308acad0bab0fd60d73f5b28523bb00ad2bbd35

Alas we can use bit ops

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha d6bd8fc4ccad3fc0071bb3eef1a2f051e09afc3f

dp Currently it is exponential LOL

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha abdf66dfafb683cd89c9b6af5f6f01bbd3be53bc

Mono Stack + linked list

view details

push time in a month

CommitCommentEvent

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 0158268f6ac920004b227392c0921582df3feaaa

Create 332_reconstrucrt_itinerary.rs

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha c31c4ee1065f2e5ab3ad118a4cea4631fcf03eb6

depth first search

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 2288530271185fc835f6cfa5f9125bab785acd2f

math problem

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha baa13fea0c65f36cfcb09ed656847adb63099a1d

hashmap + hashset

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 14a1064493e1d34a813a106c0f280f45b1dc0ee6

Simple Math

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 676ad36d892d722933c80d6e4a37d956c49b1b72

binary search

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha ce49589d333b6e50c1368f171676af15c6ef6d3b

String

view details

push time in a month

startedagarrharr/awesome-cli-apps

started time in a month

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 52cf5101425329ea338e1ced37c8e6abb8a46613

Support type-only import and export staements this was added at TypeScript 3.8 ref: https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#type-only-imports-exports

view details

rhysd

commit sha 976d10ee24ce4d8790bcd80b3f7c6b8bbc9ec76d

Add typescriptImportType for `type` following `import`

view details

push time in a month

PR merged HerringtonDarkholme/yats.vim

Fix highlighting is broken on type-only import and export statements added at TS 3.8

From TS 3.8, type-only import/export syntax is available:

import type { SomeThing } from "./some-module.js";

export type { SomeThing };

https://devblogs.microsoft.com/typescript/announcing-typescript-3-8-beta/#type-only-imports-exports

This syntax breaks current highlighting as follows:

スクリーンショット 2020-01-11 20 50 08

yats.vim recognizes type keyword as type alias statement.

This PR fixes the type-only import/export statements. Now type in import type and export type is highlighted as part of import/export statements.

スクリーンショット 2020-01-11 20 49 47

+31 -1

6 comments

3 changed files

rhysd

pr closed time in a month

issue commentHerringtonDarkholme/yats.vim

Syntax breaks where () are used for function delcaration in object

That's because vim polyglot has its own fork of yats! It would be nice if it can be updated!

subev

comment created time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 5b5ede3f0566213540070e1366b74e0087660495

HashTable

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 7a185ca1deb2f0cd0636ece7ce28ab3f5fa89f23

Create 594_longest_harmonious_subsequence.rs

view details

push time in a month

issue commentHerringtonDarkholme/yats.vim

Syntax breaks where () are used for function delcaration in object

This is what I see in reduced example. Screen Shot 2020-01-11 at 10 42 57 PM

subev

comment created time in 2 months

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 81137eba4f2b3ed093e60dbba7d29b6d3ae4c988

Support ECMAScript private fields added from TS 3.8

view details

push time in 2 months

PR merged HerringtonDarkholme/yats.vim

Support ECMAScript private fields added from TS 3.8

ECMAScript private fields spec was implemented in TypeScript and released at v3.8 beta.

https://github.com/microsoft/TypeScript/issues/33925

class C {
    #foo = 10;
    bar = true;

    piyo() {
        return this.#foo;
    }
}
  • Previously the private name field declaration #foo in #foo = 10 was not highlighted. This PR adds highlight to it
  • Now '#' is part of identifiers in TypeScript. So this PR adds it to iskeyword option. Vim can recognize #foo as one identifier by it.
+16 -1

1 comment

3 changed files

rhysd

pr closed time in 2 months

pull request commentHerringtonDarkholme/yats.vim

Support ECMAScript private fields added from TS 3.8

Thanks!

rhysd

comment created time in 2 months

pull request commentHerringtonDarkholme/yats.vim

Fix highlighting is broken on type-only import and export statements added at TS 3.8

Thanks for the fix! Meanwhile, it might be an easier fix to make import and export to have nextGroup of a new syntax group of type, which has nextGroup of bracket.

rhysd

comment created time in 2 months

push eventHerringtonDarkholme/Vimfile

Herrington Darkholme

commit sha 49083ef71e339bfcc281f06923525343223b4827

update editorconfig

view details

push time in 2 months

issue closedHerringtonDarkholme/yats.vim

Syntax breaks where () are used for function delcaration in object

When we have function defined like this:

    someFun(): someType {
    }

inside a class - the syntax braeks. See attached screenshots. line 45 - function name default

Screenshot 2019-10-30 at 18 27 16 Screenshot 2019-10-30 at 18 27 05

The file to play with: sample.ts.txt

closed time in 2 months

subev

push eventHerringtonDarkholme/Vimfile

Herrington Darkholme

commit sha 12ccbba5ba31aa5ada563771a62b0d3673c40c15

update

view details

push time in 2 months

push eventHerringtonDarkholme/Vimfile

Herrington Darkholme

commit sha 024911801653df4bff3e0b4111e24db70151e88d

update denite

view details

push time in 2 months

push eventHerringtonDarkholme/Vimfile

Herrington Darkholme

commit sha 2e8671f3f75b9363b58989c6281cf99a203b7d38

update jsx and thrift

view details

push time in 2 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha af5be4087737bcf3887c6cbcb05bee334ff8f798

[fix] fix decorator function call

view details

push time in 2 months

issue commentHerringtonDarkholme/yats.vim

Syntax breaks where () are used for function delcaration in object

This should not be hard to fix.

The decorator call isn't highlighted as function call so the object literal is highlighted as block.

subev

comment created time in 2 months

issue commentHerringtonDarkholme/yats.vim

Return type in JSX handlers breaks highlighting

I found the ecma standard has limited what identifier can follow arrow function parameter.

https://tc39.es/ecma262/#prod-ArrowParameters

It might help us to find some pattern in arrow function.

Vanuan

comment created time in 2 months

push eventHerringtonDarkholme/yats.vim

vanuan

commit sha a6a26b2564e63e6b2170876d53f31af21a5f7ddb

Add a failing test for parenthesized arrow function

view details

vanuan

commit sha e97f38c9fe1e674781ab14f5f99d2140e3fc3344

Fix parenthesized arrow functions

view details

vanuan

commit sha 48184a10ecdda3efce0131aa73495f1edc449a33

Add more tests for arrow function

view details

push time in 2 months

PR merged HerringtonDarkholme/yats.vim

Fix parenthesized arrow function

A test case for #155

+44 -1

2 comments

2 changed files

Vanuan

pr closed time in 2 months

pull request commentHerringtonDarkholme/yats.vim

Fix parenthesized arrow function

Thanks for the fix!
Can you add test for something like ( () => {} ) and ( arg: string ) => { console.log(arg) } ?

Vanuan

comment created time in 2 months

Pull request review commentHerringtonDarkholme/yats.vim

Fix parenthesized arrow function

 syntax match   typescriptArrowFuncDef          contained /\K\k*\s*=>/   \ skipwhite skipempty  " TODO: optimize this pattern-syntax region   typescriptArrowFuncDef          contained start=/(\_[^)]*):/ end=/=>/+syntax region   typescriptArrowFuncDef          contained start=/(\_[^(^)]*):/ end=/=>/

I wonder if we need multiple ^ here?

Vanuan

comment created time in 2 months

issue commentHerringtonDarkholme/yats.vim

Return type in JSX handlers breaks highlighting

Hi! Thanks for your deep investigation!

I think the problem should be the fundamental issue in how yats detects arrow function… I am considering how vscode handle such problem…

Vanuan

comment created time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha c55f609c930c7dc0f1356e6e3bc16355fa74b395

Create 152_maximum_product.rs

view details

push time in 2 months

startedGoogleContainerTools/skaffold

started time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 808952a4de67483818d7db0e75fd3ce3cb580cfa

Create 395_longest_substring.rs

view details

push time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha be5e2008ec70f8b063e2721b7c1bf9ae573ee022

Create 55_jump_game.rs

view details

push time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 2eece72f1fa78e529b4f84521916c015ffb8c787

Create 754_reach_number.rs

view details

push time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 017ce6b8c2e99858fef95c322cd28f72561131cc

mono stack

view details

push time in 2 months

issue commentneoclide/coc.nvim

No highlight for code blocks in floating documentation

The reverse color problem in floating window is caused by Solarized indeed. Solarized set front color to reverse in Pmenu.

Pmenu          xxx cterm=reverse ctermfg=11 ctermbg=7 guibg=LightMagenta

Change it to

hi CocFloating ctermbg=8

should fix it.

Avi-D-coder

comment created time in 2 months

issue commentHerringtonDarkholme/yats.vim

tsx html syntax not work

Sorry I cannot understand what you mean.

Do you mean your file x.tsx is actually an html file?

feix760

comment created time in 2 months

startedbetta-cyber/netease-music-tui

started time in 2 months

push eventHerringtonDarkholme/Vimfile

mingyang

commit sha a860de8083891b5426abfe26d18a300e01c27e0f

update

view details

push time in 2 months

push eventHerringtonDarkholme/Vimfile

mingyang

commit sha a8da3a520a019b7d83c990cac10140aa35b69dd5

update denite

view details

push time in 2 months

startedposva/pinia

started time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 7f2673b4aec3512db07042ee5420dbe90911ffc9

greedy

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 25183184532bd7bf26c0fc079e534022f9085151

bit

view details

Herrington Darkholme

commit sha b225833b32f9364de2955f6a8019143d3c94d308

update

view details

Herrington Darkholme

commit sha 9149a45fb56087b5eac9229df8844bcfa6bf5109

knapsack

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha e08c612c53fcd2b2551c8f5b780de235046c72ac

inplace swap

view details

Herrington Darkholme

commit sha 176b96f260a127570dda8fb156fc3c39756898fb

brute force doesn't mean it is dumb

view details

push time in 3 months

fork HerringtonDarkholme/front-end-interview-handbook

🕸 Almost complete answers to "Front-end Job Interview Questions" which you can use to interview potential candidates, test yourself or completely ignore

fork in 3 months

startedyangshun/front-end-interview-handbook

started time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 0fc22eeb5f7e4a6ae3572eac1f0b58e87ab492d2

recursion + no stack + no reverse

view details

Herrington Darkholme

commit sha ada05c993f337e7702a0869349febd098b9c6c4a

even/odd iterator

view details

Herrington Darkholme

commit sha ab4850dd24bc316c2e618b44428f32a3ccc4d8e4

update

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha a3c9f150e911342439d930bb97a5490ca35e65bb

dp + binary search something like LIS

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha d75d8e78ed52c60d318f563c09d16f1745a04757

simulation

view details

Herrington Darkholme

commit sha 61400efc60588c971491fb034b00f1fdd270172f

dp

view details

Herrington Darkholme

commit sha 41eeb8c2381fa54fffc3ed940c3a5c7a08659ef5

optimize

view details

Herrington Darkholme

commit sha e51f4dc6c8fb56607b1de0004dff508befb3e828

use len to index strings

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 8da3c98756c7de70cf99f47490642104ea673b99

dynamic programming

view details

Herrington Darkholme

commit sha c8204a8ce5661f948451797f543a5a441720516f

update desc

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha d56ad8716e8fb311f0e7fc4419dab97015ef2d23

dynamic programming

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 9abbe64cf07d03520c5fb3806e22f097404bf8d7

hash + set

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 010184fe839fc5996186c5eadefc7cfec25c2fad

dfs + BTreeMap + sort

view details

push time in 3 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 1c29f80aca2e72d096c956a44fa42eb09807d8a1

counting and sort

view details

push time in 3 months

PR opened dandavison/delta

[refactor] change zip to enumerate

Hi, thanks for the awesome plugin!

I found some minor improvements while reading the code. (1..=len).zip can be rewritten with enumerate.

Thanks!

+6 -6

0 comment

1 changed file

pr created time in 3 months

push eventHerringtonDarkholme/delta

Herrington Darkholme

commit sha fd6901431518fff9f98859652703bd7f74e6dbe1

[refactor] change zip to enumerate

view details

push time in 3 months

fork HerringtonDarkholme/delta

A syntax-highlighting pager for git

fork in 3 months

startedtaurusai/kungfu

started time in 3 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha e9d8813c02b8bdb81b63aeb576b9eaadf0dd4445

update merged file

view details

push time in 3 months

starteddandavison/delta

started time in 3 months

issue commentHerringtonDarkholme/yats.vim

Support async object property methods

I have updated it!

dsifford

comment created time in 3 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha 520454c3ea220c9217612dd30581d165799f438d

[fix #108] mark async in object literal as keyword

view details

push time in 3 months

issue closedHerringtonDarkholme/yats.vim

Support async object property methods

Just writing this here so that it's being tracked. I might attempt to take a stab at this if time allows one of these days....

Here's a small example of what's broken...

const foobar = {
    async foo() {
//  ^^^^^
        return Promise.resolve('foo');
    },
    bar: 'bar',
}

Should be pretty self-explanatory.

closed time in 3 months

dsifford

issue commentHerringtonDarkholme/yats.vim

Typscript: Immediately invoked function expression with return type annotation broken.

This is a fundamental difficulty in the arrow function detection....

kid-icarus

comment created time in 3 months

issue commentHerringtonDarkholme/yats.vim

Generic with default generic breaks rest of highlighting for declaration

Sorry for the late reply, I have fixed the problem!

dsifford

comment created time in 3 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha 7162cadffe97431982f60b5cd1641cdbb66f2f9b

[fix #122] fix Generic with default generic

view details

push time in 3 months

issue closedHerringtonDarkholme/yats.vim

Generic with default generic breaks rest of highlighting for declaration

Just getting this written down so I don't forget. Might take a stab on this later.

Quick example:

  interface FooBar<T extends Record<string, any> = Record<string, any>> {
//                                                                    ^ breaks here
      foo: string;
      bar: number;
  }

It appears the syntax thinks the generic stops at the first > and it doesn't know what to do with the next one.

closed time in 3 months

dsifford
more