profile
viewpoint
Herrington Darkholme HerringtonDarkholme Rainbow Alliance ShinNippori 闇と森の妖精

HerringtonDarkholme/av-ts 213

A modern, type-safe, idiomatic Vue binding library

HerringtonDarkholme/auto-fu.zsh 14

#zsh automatic complete-word and list-choices. Originally incr-0.2.zsh by y.fujii <y-fujii at mimosa-pudica.net>

HerringtonDarkholme/atom-vue 6

vue-language-server demo for Atom

HerringtonDarkholme/av-ts-template 6

av-ts template for vue-cli

HerringtonDarkholme/byon 1

Angular2 demo

HerringtonDarkholme/2017hosts 0

这里更新最新可用的googlehosts,这里更新的分为手机版和电脑版。

startedfacebookexperimental/Recoil

started time in 10 days

pull request commentHerringtonDarkholme/yats.vim

Fix highlighting number literal with exponent part

Thanks!

rhysd

comment created time in 12 days

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 4ca2fb1fc72675a7c9241fa2a78d545182c0ba87

Fix number literal with exponent part

view details

rhysd

commit sha fbbb4b2fa346f556aee8424c98ee51e849949bb1

Fix highlighting delimiter in number literals

view details

push time in 12 days

PR merged HerringtonDarkholme/yats.vim

Fix highlighting number literal with exponent part

#185 introduced regression when highlighting number literals with exponent part. For example, 1e2 is not highlighted as typescriptNumber

This is because yats.vim now requires \> after fraction part of number literal (1 in 1e2), however it does not match when e is following.

This PR fixes it by merging typescriptExponent into typescriptNumber. Simply removing \> from typescriptNumber highlight definition reproduces #184 so we cannot do that. Now all number literals are highlighted correctly as follows:

screenshot

+60 -5

1 comment

3 changed files

rhysd

pr closed time in 12 days

issue closedHerringtonDarkholme/yats.vim

Highlight return keyword

Doesn't get the syntax group of return image

closed time in 15 days

glepnir

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 621c9d1d80051c9b6d26a9db3bf5f106338f0a88

Fix number literals with 0b, 0o, 0x prefixes (fix #184)

view details

push time in 15 days

PR merged HerringtonDarkholme/yats.vim

Fix number literals with 0b, 0o, 0x prefixes (fix #184)

Fixes #184 as follows:

スクリーンショット 2020-05-12 10 38 05

+10 -1

1 comment

2 changed files

rhysd

pr closed time in 15 days

issue closedHerringtonDarkholme/yats.vim

Number literals with 0b, 0o, 0x are broken

Here is screenshot:

スクリーンショット 2020-05-12 10 31 53

Code:

0xc0ffee
0b101010
0o755644

I'll investigate this issue and will make a PR.

closed time in 15 days

rhysd

pull request commentHerringtonDarkholme/yats.vim

Fix number literals with 0b, 0o, 0x prefixes (fix #184)

Thanks!

rhysd

comment created time in 15 days

issue commentHerringtonDarkholme/yats.vim

Highlight return keyword

@glepnir could you please paste the whole file and keep your vimrc minimal? Minimal means you have to disable all other plugins and just keep yats active.

glepnir

comment created time in 15 days

fork HerringtonDarkholme/spec

WebAssembly specification, reference interpreter, and test suite.

https://webassembly.github.io/spec/

fork in 21 days

pull request commentHerringtonDarkholme/yats.vim

Fix note on setting `re=1`

thanks

jketcham

comment created time in 22 days

push eventHerringtonDarkholme/yats.vim

Jack Ketcham

commit sha 4333bafec3a32713aae2b0d3b1e756d6f705f825

Fix note on setting `re=1` Per discussion from this issue: https://github.com/HerringtonDarkholme/yats.vim/issues/25, having `set re=1` in .vimrc causes performance issues. The README should recommend setting `re=0`, not `re=1` to avoid these problems.

view details

push time in 22 days

PR merged HerringtonDarkholme/yats.vim

Fix note on setting `re=1`

Per discussion from this issue: https://github.com/HerringtonDarkholme/yats.vim/issues/25, having set re=1 in .vimrc causes performance issues.

The README should recommend setting re=0, not re=1 to avoid these problems.

+1 -1

0 comment

1 changed file

jketcham

pr closed time in 22 days

issue commentmicrosoft/TypeScript

Surprising circularity error in 3.9 RC

It seems to be an issue about mapping type and function overload.

I can reproduce the issue in a minimal fashion:

type Func<T> = () => T

type Mapped<T> = {
  [K in keyof T]: Func<T[K]> // error
  // [K in keyof T]: () => T[K] // this compiles
}

declare function reproduce(options: number): void // removing this line also compiles
declare function reproduce<T>(options: Mapped<T>): T


reproduce({
  name: () => 123
})

Curiously, without the type alias Func<T>, the code above compiles. Also, removing the overload also makes the code compile.

amcasey

comment created time in 22 days

PR opened vuejs/vite

test: add test for json and css
+67 -12

0 comment

6 changed files

pr created time in 24 days

create barnchHerringtonDarkholme/vite

branch : test-json

created branch time in 24 days

fork HerringtonDarkholme/vite

No-bundle Dev Server for Vue 3 Single-File Components

fork in 24 days

startedvuejs/vite

started time in 25 days

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha d8024ad85ff356e76b5dac4e873d2cb21124331e

Create 698_can_partition_k_subsets.rs

view details

push time in a month

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 68f36b177d193d5acb38b01bba87fdb2afbcab9a

greedy better solution is to build result by adding new dishes

view details

push time in a month

push eventHerringtonDarkholme/yats.vim

rhysd

commit sha 7978f7d52e1cfbdba1d17951c7bd4be527807e4e

Support @ts-ignore and @ts-expect-error magic comments

view details

push time in a month

PR merged HerringtonDarkholme/yats.vim

Support @ts-ignore and @ts-expect-error magic comments

TypeScript 2.6 introduced @ts-ignore magic comment and TypeScript 3.9 will introduce @ts-expect-error.

They have special meaning and will affect the compiler behavior though they are comments. So I think they should be highlighted as special as well as doc comments.

This PR highlights them with SpecialComment highlight group.

+19 -1

1 comment

3 changed files

rhysd

pr closed time in a month

pull request commentHerringtonDarkholme/yats.vim

Support @ts-ignore and @ts-expect-error magic comments

Thanks! I'm just going to support these comments!

rhysd

comment created time in a month

delete branch HerringtonDarkholme/yats.vim

delete branch : test-pr

delete time in a month

push eventHerringtonDarkholme/yats.vim

HerringtonDarkholme

commit sha d5c60217a27bba799b0ed5a2f16c61ea0a9b314e

fix: remove github flow

view details

push time in a month

PR merged HerringtonDarkholme/yats.vim

fix: remove github workflow

I'm sorry but github workflow does not support fork repo comment yet...

+1 -84

0 comment

4 changed files

HerringtonDarkholme

pr closed time in a month

push eventHerringtonDarkholme/yats.vim

HerringtonDarkholme

commit sha a6ec7b07f1543dcd2d71b1cbeea855a17dc5119c

chore: update pr name

view details

HerringtonDarkholme

commit sha e291b5b04def0f35480698b26fc3eb6e048d0520

Merge branch 'master' of github.com:HerringtonDarkholme/yats.vim into test-pr

view details

push time in a month

PR opened HerringtonDarkholme/yats.vim

fix: remove github workflow

I'm sorry but github workflow does not support fork repo comment yet...

+1 -84

0 comment

4 changed files

pr created time in a month

push eventHerringtonDarkholme/yats.vim

HerringtonDarkholme

commit sha a92de6478fbfae47ae8e31f4923eab1a0715afcc

fix: remove github flow

view details

push time in a month

pull request commentSchniz/yats.vim

do not merge: test pull request from forked

@Schniz looks like comment on pr won't work for pull-requests of which the owner has no write access to the repo...

HerringtonDarkholme

comment created time in 2 months

PR opened Schniz/yats.vim

do not merge: test pull request from forked
+89 -2

0 comment

5 changed files

pr created time in 2 months

create barnchHerringtonDarkholme/comment-on-pr

branch : HerringtonDarkholme-patch-1

created branch time in 2 months

fork HerringtonDarkholme/comment-on-pr

A GitHub Action to comment on the relevant open PR when a commit is pushed.

fork in 2 months

push eventHerringtonDarkholme/yats.vim

HerringtonDarkholme

commit sha a6ec7b07f1543dcd2d71b1cbeea855a17dc5119c

chore: update pr name

view details

push time in 2 months

push eventHerringtonDarkholme/yats.vim

HerringtonDarkholme

commit sha 6c86c11c930c9ef629081b6dc9634fca270a42c9

chore: update pr name

view details

push time in 2 months

push eventHerringtonDarkholme/yats.vim

吴名扬

commit sha 6cac59de22b18c57bb333ff591d94bb344b8a91f

chore: change workflow name

view details

push time in 2 months

create barnchHerringtonDarkholme/yats.vim

branch : test-pr

created branch time in 2 months

pull request commentHerringtonDarkholme/yats.vim

GitHub actions workflow

Hi @Schniz , I found the comment on pr action cannot be executed on latest #175. The error message reads:

Resource not accessible by integration

Could you please give it a look?

Schniz

comment created time in 2 months

issue closedHerringtonDarkholme/yats.vim

Linebreaks after '>' continue to insert an additional '>' on every line

  • Tested using Vim 8+ and NVIM 0.4.3
  • Completely empty .vimrc except for the yats.vim plugin (Using vim-plug to enable)

If a *.ts or *.tsx file contains a >, any linebreaks that are inserted after that line will automatically append another >

This doesn't happen with self closing tags (/>) or if the line includes anything other than >

yats-linebreaks

closed time in 2 months

mttrms

push eventHerringtonDarkholme/yats.vim

Matt Ramos

commit sha 60d83874ebca9aed6dc26398f3232efeda22823f

Only format JavaScript comments

view details

push time in 2 months

PR merged HerringtonDarkholme/yats.vim

Only format JavaScript comments

This PR sets the comments variable so that comment formatting will only effect:

  • //
  • /*
  • */

This fixes the issue brought up here which was incorrectly formatting certain characters as comments.

+2 -0

2 comments

1 changed file

mttrms

pr closed time in 2 months

pull request commentHerringtonDarkholme/yats.vim

Only format JavaScript comments

Thanks I have read Vim's manual and got know the detail. Thanks for the pull request!

mttrms

comment created time in 2 months

pull request commentHerringtonDarkholme/yats.vim

Only format JavaScript comments

Thanks! Could you please explain the fix for me? I don't quite understand the comment option here.

mttrms

comment created time in 2 months

startedkateinoigakukun/wasminspect

started time in 2 months

startedrhysd/wain

started time in 2 months

startednahamsec/Resources-for-Beginner-Bug-Bounty-Hunters

started time in 2 months

startedthlorenz/deoptigate

started time in 2 months

push eventHerringtonDarkholme/yats.vim

Gal Schlezinger

commit sha bc99d0d900fe68686d7656e1210fd0d25f13a0fc

Create styling.yml A github action that would comment on any PR with a screenshot of the test cases

view details

Gal Schlezinger

commit sha 339d624b65623512d5c9550fd516d4a6c644fef1

remove comments and redundant github workflow items

view details

push time in 2 months

PR merged HerringtonDarkholme/yats.vim

GitHub actions workflow

Attaches an image of the test cases on every PR. Fixes #171

+85 -2

0 comment

4 changed files

Schniz

pr closed time in 2 months

issue closedHerringtonDarkholme/yats.vim

GitHub workflow to show syntax changes

Hi, I have a fork with an open PR that shows a GitHub workflow that attaches images of the current state of the plugin, using the test cases (test/test.ts and test/test.tsx):

Workflow demo

I think it's a good way to easily show the differences with an automated way, and also can help when providing "failing" test cases. I'm using the default Vim colorscheme but it can change as well (maybe to use the same colorscheme as you use in the readme?)

It's currently working on my fork, but should work once I'll make a PR/merge to your repo. Does it make any sense to you?

Again, thanks for the awesome plugin! 👏

closed time in 2 months

Schniz

Pull request review commentHerringtonDarkholme/yats.vim

GitHub actions workflow

+name: Styling+on: [pull_request]++jobs:+  build:+    runs-on: ubuntu-latest++    steps:+    - uses: actions/checkout@v2+    - name: install deps+      run: npm install++    - name: Store html files+      run: |+        for file in "test/test.tsx" "test/test.ts"; do+          vim -u ./.github/vimrc +TOhtml "+w %" '+qall!' $file > /dev/null+        done++    - name: Generate images+      id: report+      run: |+        node .github/generate-issue-comment.js test/*.html > ./.github/report.md++    - name: Comment on PR+      uses: Schniz/comment-on-pr@master

I wonder what if the repository is tampered or deleted?

Schniz

comment created time in 2 months

issue commentvuejs/vue-cli

Import without .vue extension in ts files

@sodatea @l00k You probably need to change ts-loader's source code to make ts-loader recognize vue file without extension.

My suggestion would be start by hacking ts-loader's resolveModule function https://github.com/TypeStrong/ts-loader/blob/ce39c25a00641cb708efcd2e31556cb3f7afa771/src/servicesHost.ts#L768-L776.

l00k

comment created time in 2 months

startedluruke/browser-2020

started time in 2 months

issue commentHerringtonDarkholme/yats.vim

GitHub workflow to show syntax changes

Cool! Would you like submit a pull request? Thanks a lot!

Schniz

comment created time in 2 months

pull request commentHerringtonDarkholme/yats.vim

tsx comment block indentation

Thanks!

dcchuck

comment created time in 2 months

push eventHerringtonDarkholme/yats.vim

dcchuck

commit sha 74cebceda5250b0c157de84fccc9deb08062243b

tsx comment block indentation

view details

push time in 2 months

issue closedHerringtonDarkholme/yats.vim

Comment block not triggered in `.tsx` files

In a .ts file I can start typing /** and a new line will read *, letting me type in a comment block.

Doing the same in a .tsx, a new line just shows up, no indentation.

In a .ts file

/**
 * You end up here
 * and I can write multiline comments
 * <- CURSOR POSITION

In a .tsx file

/**
<- CURSOR ENDS UP HERE

closed time in 2 months

dcchuck

pull request commentHerringtonDarkholme/yats.vim

tsx comment block indentation

I'm not familiar with the option here. Would you like give me a brief explanation?

dcchuck

comment created time in 2 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha 4d3f69a3a5f56bae9475a96c3291ffdcbd9ff0b1

update merged file

view details

push time in 2 months

issue closedHerringtonDarkholme/yats.vim

JSX return value misidentified as arrow function

I'm using vim --clean to reproduce this.

const x = () => {
  return (
      <Component
        onChange={(): void => {}}
      />
    );
};

In this example <Component is identified as a typescriptArrowFuncDef region. It should be identified as a tsxTag.

(I'm using :echo map(synstack(line("."), col(".")), "synIDattr(v:val, 'name')") to diagnose this).

I was in a file where the syntax highlighting got completely off track at a specific point, such that vim eventually ended up highlighting the the entire rest of the file as a typescriptTemplate region. I boiled it down to this issue.

closed time in 2 months

jonsmithers

issue closedHerringtonDarkholme/yats.vim

syntax highlight incorrect when use backtick inside a function and use destrcuting argument in the function

My neovim config:

if empty($XDG_DATA_HOME)
    let $XDG_DATA_HOME = $HOME . '/.config'
endif

let mapleader = "\<Space>"

function! s:checkPlug()
	let vimplug_exists=expand('~/.config/nvim/autoload/plug.vim')

	if !filereadable(vimplug_exists)
	  if !executable("curl")
	    echoerr "You have to install curl or first install vim-plug yourself!"
	    execute "q!"
	  endif
	  echo "Installing Vim-Plug..."
	  echo ""
	  silent !\curl -fLo ~/.config/nvim/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim
	  let g:not_finish_vimplug = "yes"

	  autocmd VimEnter * PlugInstall
	endif
endfunction

call s:checkPlug()

" Required:
call plug#begin(expand('~/.config/nvim/plugged'))

Plug 'HerringtonDarkholme/yats.vim'

call plug#end()

pls check last few lines in the screenshot: image

closed time in 2 months

maple-leaf

issue commentHerringtonDarkholme/yats.vim

syntax highlight incorrect when use backtick inside a function and use destrcuting argument in the function

fixed in 99d3554fb6f958256e61bbcfcf79a5ac5f6a9c36

maple-leaf

comment created time in 2 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha 99d3554fb6f958256e61bbcfcf79a5ac5f6a9c36

fix: fix multiple function args

view details

push time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 780a07499fcaf161084edf004135f611cc63f42d

Cleaner code

view details

push time in 2 months

push eventHerringtonDarkholme/leetcode

Herrington Darkholme

commit sha 94f66c4b643f264ae42c2eef8882b8c77d23dd7d

Math

view details

push time in 3 months

startedbinhnguyennus/awesome-scalability

started time in 3 months

startedecomfe/react-hooks

started time in 3 months

issue commentHerringtonDarkholme/yats.vim

syntax highlight incorrect when use backtick inside a function and use destrcuting argument in the function

MInimal production

[].map(({num}, index) => {
    const key = `${num}`
})

maple-leaf

comment created time in 3 months

issue commentHerringtonDarkholme/yats.vim

JSX return value misidentified as arrow function

Hi, thanks for reporting. However I cannot reproduce the problem. Could you please use a minimal vimrc and update yats to latest version?

image

jonsmithers

comment created time in 3 months

push eventHerringtonDarkholme/yats.vim

Herrington Darkholme

commit sha 1a34f1bf3db205fb47246b43936a5474a23a3878

fix: change basic

view details

Herrington Darkholme

commit sha 68ef9623656fe9aaa53c1d9ab906f09c2c095f06

Merge branch 'master' of github.com:HerringtonDarkholme/yats.vim

view details

push time in 3 months

issue commentHerringtonDarkholme/yats.vim

Issue when opening basic files

Thanks for reporting! I will first apply the hotfix mentioned in the linked issue.

Later I will rename the directory! Thanks!

sheerun

comment created time in 3 months

more