profile
viewpoint
Hans Aarne Liblik HansAarneLiblik Estonia

HansAarneLiblik/django 0

The Web framework for perfectionists with deadlines.

HansAarneLiblik/downshift 0

🏎 Primitive to build simple, flexible, WAI-ARIA compliant enhanced input React components

pull request commentDefinitelyTyped/DefinitelyTyped

[yup] add generic to .test()

Hey!

Shouldn't test(options: TestOptions<Record<string, any>>): this; be test(options: TestOptions<T | undefined | null>): this; for BasicArraySchema (probably something similar to other Schemas as well) ?

Also I think you missed generic <P> for test: TestFunction; in interface BaseTestOptions<P extends Record<string, any>>

This is breaking our build currently

ejose19

comment created time in 2 months

more