profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Gastove/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Ross Donaldson Gastove @squarespace Portland, OR http://www.gastove.com Data plumber, functional programmer, heirloom-varietal tyrannosaurus.

Gastove/drinkery 16

My little black bartending book

Gastove/doctopus 7

An un-opinionated framework for Docs on the Webs

Gastove/binarian 1

You wont believe this either: knitting pattern generator

Gastove/.emacs.d 0

My emacs configs/settings/subprojects

Gastove/bidi 0

Bidirectional URI routing

Gastove/blogric 0

Tiny Little Blogging Tools in Fabric

Gastove/bumblebee-status 0

bumblebee-status is a modular, theme-able status line generator for the i3 window manager.

Gastove/cascading-thrift 0

Serializer and comparator for using Thrift objects in Cascading or Cascalog

Gastove/chronomancer 0

An emacs minor mode for working with time

issue openedhaf/expecto

F# 5 String Interpolation Causes Spurrious Test Failures

If a method under test uses F# 5 string interpolation (e.g. sprintf $"{myVar}"), the test will throw a method not found error and fail, whether the actual outcome of the test was a failure. This is due to Expecto pinning F# Core 4 in its paket.dependencies.

I've forked the project, updated the F# Core version to 5.0.2, and run both the build and the test suite; both pass with no errors. I'm very happy to PR that change, but I wanted to ask first: are there any other checks, build steps, or other things I should verify to make sure the change is safe? Very happy to help however I can.

Thanks so much for Expecto! It really is a delight to use.

created time in 14 days

push eventGastove/orary

Ross Donaldson

commit sha 0e912b2f0fd5910c435665aaa809da1c55469e07

Minor F# and LSP tweaks

view details

push time in 2 months

push eventGastove/emacs-fsharp-mode

Ross Donaldson

commit sha 385b1cad1be244b3b7b5e8cfa85b0f36bc367d9b

Whitespace cleanup Clean up tabs, indentation.

view details

Ross Donaldson

commit sha 1074a3ddb5e94ce90e9f2debf186e49b27bd8438

Merge `indent-smie` and `indent` These are two modules that do tightly related things. In two separate files, they can't cleanly share variables (`indent-smie` re-defined an indent offset var also defined in `indent`). This commit merges them together and re-names the variable used for offset by the `smie` configs, but does nothing else.

view details

Ross Donaldson

commit sha e5f8dd70f9ae8fdf1df763170bda69b6206d1996

Alias now-removed fsharp-indent-level

view details

Ross Donaldson

commit sha eee6bdfb6b98c90ec805979a75708e00c659e1ed

Rename `fsharp-mode-indent` to `fsharp-mode-structure` and clean up This commit renames `fsharp-mode-indent` and cleans up references to it. It also scoots `fsharp-eval-phrase` next to `fsharp-eval-region` in `fsharp-mode`, where it makes a bit more sense. Tests are all currently passing.

view details

Ross Donaldson

commit sha 91c0ace33c72eabad1502836976aa97c58626235

So Much Whitespace Cleanup

view details

Ross Donaldson

commit sha 151579312a9a252562e4d338fcd9c0cdf06df61e

A little extra commentary, attributions

view details

Ross Donaldson

commit sha 56e5a4bf4f86c58a4ee5080be00e11adced57912

Move var, remove old stuff This commit removes some old "major mode boilerplate" from `fsharp-mode-structure`: - The abbrev table is moved in to `fsharp-mode`, where it belongs. - `fsharp-safe` is _only_ used to wrap calls to `search-backwards`; the only value it provides is to swallow errors and instead return `nil`. However: this can now be much more idiomatically achieved by passing `t` as the `NOERROR` argument to `search-backward`. - XEmacs hasn't had a release in ten years. The extra region setting calls of `fsharp-keep-region-active` aren't needed -- it's just extra noise.

view details

Ross Donaldson

commit sha 00785f0f9f70710ad6459219091bdc81ef46bbe1

Clear out commented-out code, ^Ls

view details

Ross Donaldson

commit sha 6d1ade87ac53a3efdbd41cff397de91533e53afe

Whitespace and comment cleanup

view details

Ross Donaldson

commit sha 05b4bba06422213ac3b725ed03b886656b66c204

Update `fsharp-point` to use `save-mark-and-excursion` This allows it to do precisely the same thing, while making very sure to fulfill the guarantee of not changing whatever point and mark the user set.

view details

Ross Donaldson

commit sha 82e61d62131e433a6441672e9e019af528a8e226

More comments and whitespace

view details

Ross Donaldson

commit sha cc91913f763174446a79b7c3aa56dafa51130f8a

Refactoring Pass: Extract Method from `fsharp-compute-indentation` `fsharp-compute-indentation` is one of the critical driving methods of this mode's indentation system. At the start of this commit, it was also a very long, very complex method. It needs better documentation and it needs to be under test. Therefore: extract method. This commit pulls a variety of method out of `fsharp-compute-indentation`, seeking to preserve basically identical functionality while capturing pieces of logic in smaller, better documented pieces. Functions are currently named after my best read of what they _do_, but that's hard to be confident about. The _next_ piece of work will be getting these functions under test, which will allow me to pin down and describe their functionality (and its limits!).

view details

Ross Donaldson

commit sha cb55d1ccb6986d4e77aa2772107b173f7685bf0d

First working tests for structure This puts `fsharp-nesting-level` under test, and updates the docstring of that function with information secured during testing.

view details

Ross Donaldson

commit sha c08039a9b432a6383be7df1d3cb38067266844e5

`continuation-p` transparently duplicates `fsharp-continuation-line-p` We don't need it. Remove and update calls.

view details

Ross Donaldson

commit sha 05c1ff18a6006e8deea3dc607382d13fa3c5d271

this gives far clearer output without the layer of indirection

view details

Ross Donaldson

commit sha 948a7f3e70b4dbcc72344988849bfc2cfa6f06d8

Implement a basic test for the bewildering `fsharp-backslash-continuation-line-p`

view details

Ross Donaldson

commit sha 407c3537b3eb44f2818a7727e28d20e32255f367

HUGE notes and comments pass This is all notes, comments, docstrings, spacing. Preparation for further work.

view details

Ross Donaldson

commit sha 331778cf0770d33273cfd4d746efcc68ef59d9db

Organization Pass Group related functions; move some `info-look` configs into `fsharp-mode.el`. This is getting to be a lot easier to navigate, look at, understand all together.

view details

Ross Donaldson

commit sha d7e6c5807c124a8e7b7ddc4caa93dca6e6175fae

Ignore a few files commonly generated by opening or evaluating F# files

view details

Ross Donaldson

commit sha 360f380b3e6e9c7f6c90cabe1606f1e032f60772

Extensive notes; wrap body in save-excursion Originally, all of these functions were inside one huge save-excursion form. To my surprise, they typically need their _own_ save excursion wrapping to make sure everything is consistent, particularly under test. Also added, a great deal of notes about the function itself and how it works.

view details

push time in 3 months

push eventGastove/lsp-mode

Eric Dallo

commit sha 8e25018efbc3e8386376046224b8568e4df0198a

[webpage] remove beta feature 'instant'

view details

Eric Dallo

commit sha 926d1024c2595e2fbed6ebe13e9cf7dbbbd5a6bf

[webpage] fix lsp-python-ms link

view details

kiennq

commit sha eff9e5636462d8bd5b4849a59b26907ce6d0f988

lsp--auto-configure: enable yas-inhibit-overlay-modification-protection by default (#1646)

view details

Brian Leung

commit sha 9aa0e55902d2d29cc522da52b31dd7a4a97edb3a

Typo: 'lsp-folding-range --> 'lsp--folding-range (#1645)

view details

kiennq

commit sha 3a2165888b687079e339d8783c0aa214d8d8053b

lsp-capf: allow customize showing completion detail (#1649)

view details

Cameron Boehmer

commit sha 3b4b3b03db6a0303f8bbf78b24155c22406d52ec

add note to readme re how to install emacs w/native json (#1650)

view details

kiennq

commit sha 1b20877e58d43da40fb5f995699a4159f326029a

doc: escape double hypen in org table (#1651)

view details

Ivan Yonchovski

commit sha 1307e59f6c7bbf49185d52fd0cd57ff923b7dc2b

Add FAQ entry for flex filtering and emacs26 - fixes https://github.com/emacs-lsp/lsp-mode/issues/1652

view details

kiennq

commit sha ec19cd825c3b8d01db5e3e4aff4a168ca9469361

lsp-capf: Support clangd score attribute extension (#1654)

view details

Akihiro Takai

commit sha 6f7a35431225e331e06664d3cba3c2eddd91b6d0

Fix MarkDown style link (#1656)

view details

Eric Dallo

commit sha 0ac72ec8e48b378f859e81eb138da4bc6c17a36d

Add auto doc generation (#1655) * Add template * Add initial script * Add all suported LSPs * Finish LSP basic integrations * Update templates * Finish docs generation with variables * Add github action * Move changelog to root * Remove old doc * Fix doc strings * Fix travis * Fix language index

view details

Eric Dallo

commit sha 82894db82acfb0221dc76224e59c5503eec33cce

[docs] Separate into tabs

view details

Eric Dallo

commit sha 372d1a0d65b8e5f25831155a47f0319b62c2b084

Change changelog heading

view details

Eric Dallo

commit sha 1caf3856bbb6f25dcfb760789522c0347df52e77

[docs] remove instant experimental feature

view details

Eric Dallo

commit sha de3f11b4798aab295ebd05ed47b88c568c080b31

[docs] refactor docs migrating to a page folder

view details

Alan Zimmerman

commit sha 31d5d8f1e0f4085e3aaaec1d2856cd9a4e083f02

Change lsp-erlang-server-connection-type to symbol For customisation. As reported at https://github.com/emacs-lsp/lsp-mode/pull/1166/files/54e5c310eb679ead539896e4751fe8ae875b1384#r419802972

view details

Eric Dallo

commit sha 8a9a3fd01818b9580d459768766bbfc2422ed1bd

[docs] fix readme path

view details

Eric Dallo

commit sha 4735213a8104fa49635da92a5c9fa705c85481a0

[docs] move readme to root of docs

view details

Eric Dallo

commit sha e1f879de56b728921c7693e40d208cdae5a80dd3

[docs] fix github action

view details

Eric Dallo

commit sha f1f7a6b9bfed4ae4d76a9703fc178fd20278fbbd

[docs] fix link to languages page

view details

push time in 3 months