profile
viewpoint
Fedor Isakov FrodoTheTrue Google Moscow, Russia Engineer at Google | ex-Yandex

FrodoTheTrue/crypto-lab 3

Computer Security Laboratory

FrodoTheTrue/butch-pulp-fiction 2

Facebook Mention Bot (Butch)

FrodoTheTrue/algorithms 0

Minimal examples of data structures and algorithms in Python

FrodoTheTrue/api-airport 0

Simple API for airport

FrodoTheTrue/bem-react-core 0

Core library for develop with React and BEM methodology

FrodoTheTrue/bxslider-4 0

Responsive jQuery content slider

FrodoTheTrue/cryptoprob 0

Elements of the theory of probability in cryptanalysis

FrodoTheTrue/deploy-cloudrun 0

This action deploys your container image to Cloud Run.

FrodoTheTrue/devmap 0

Карта развития веб-разработчика

push eventFrodoTheTrue/nodejs-compute

Fedor Isakov

commit sha b69daaf59199e13de67d4ce8484e43a03a004baf

fix lint

view details

push time in 2 days

Pull request review commentgoogleapis/nodejs-compute

chore(samples): add custom hostname instances samples

+// Copyright 2021 Google LLC+//+// Licensed under the Apache License, Version 2.0 (the "License");+// you may not use this file except in compliance with the License.+// You may obtain a copy of the License at+//+//      http://www.apache.org/licenses/LICENSE-2.0+//+// Unless required by applicable law or agreed to in writing, software+// distributed under the License is distributed on an "AS IS" BASIS,+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+// See the License for the specific language governing permissions and+// limitations under the License.++/**+ * Creates an instance with custom hostname.+ *+ * @param {string} projectId - ID or number of the project you want to use.+ * @param {string} zone - Name of the zone you want to check, for example: us-west3-b+ * @param {string} instanceName - Name of the new machine.+ * @param {string} hostname - Custom hostname of the new machine.+ *    Custom hostnames must conform to RFC 1035 requirements for valid hostnames.+ * @param {string} machineType - Machine type you want to create in following format:+ *    "zones/{zone}/machineTypes/{type_name}". For example:+ *    "zones/europe-west3-c/machineTypes/f1-micro"+ *    You can find the list of available machine types using:+ *    https://cloud.google.com/sdk/gcloud/reference/compute/machine-types/list+ * @param {string} sourceImage - Path the the disk image you want to use for your boot+ *    disk. This can be one of the public images+ *    (e.g. "projects/debian-cloud/global/images/family/debian-10")+ *    or a private image you have access to.+ *    You can check the list of available public images using:+ *    $ gcloud compute images list+ * @param {string} networkName - Name of the network you want the new instance to use.+ *    For example: global/networks/default - if you want to use the default network.+ */+function main(+  projectId,+  zone,+  instanceName,+  hostname,+  machineType = 'n1-standard-1',+  sourceImage = 'projects/debian-cloud/global/images/family/debian-10',+  networkName = 'global/networks/default'+) {+  // [START compute_instances_create_custom_hostname]+  /**+   * TODO(developer): Uncomment and replace these variables before running the sample.+   */+  // const projectId = 'YOUR_PROJECT_ID';+  // const zone = 'europe-central2-b'+  // const instanceName = 'YOUR_INSTANCE_NAME'+  // const hostname = 'host.example.com'+  // const machineType = 'n1-standard-1';+  // const sourceImage = 'projects/debian-cloud/global/images/family/debian-10';+  // const networkName = 'global/networks/default';++  const compute = require('@google-cloud/compute');+  const computeProtos = compute.protos.google.cloud.compute.v1;++  // Create a new instance with the values provided above in the specified project and zone.+  async function createInstanceWithCustomHostname() {+    const instancesClient = new compute.InstancesClient();++    console.log(+      `Creating the ${instanceName} instance in ${zone} with hostname ${hostname}...`+    );++    const [response] = await instancesClient.insert({+      instanceResource: {+        name: instanceName,+        // Custom hostnames are not resolved by the automatically created records+        // provided by Compute Engine internal DNS.+        // You must manually configure the DNS record for your custom hostname.+        hostname,+        disks: [+          {+            // Describe the size and source image of the boot disk to attach to the instance.+            initializeParams: {+              diskSizeGb: '10',+              sourceImage,+            },+            autoDelete: true,+            boot: true,+            type: computeProtos.AttachedDisk.Type.PERSISTENT,+          },+        ],+        machineType: `zones/${zone}/machineTypes/${machineType}`,+        networkInterfaces: [+          {+            // Use the network interface provided in the networkName argument.+            name: networkName,+          },+        ],+      },+      project: projectId,+      zone,+    });+    let operation = response.latestResponse;+    const operationsClient = new compute.ZoneOperationsClient();++    // Wait for the create operation to complete.+    while (operation.status !== 'DONE') {+      [operation] = await operationsClient.wait({+        operation: operation.name,+        project: projectId,+        zone: operation.zone.split('/').pop(),+      });+    }++    console.log('Instance created.');+  }++  createInstanceWithCustomHostname();+  // [END compute_instances_create_custom_hostname]+}++main(...process.argv.slice(2));

Sounds reasonable! Added.

FrodoTheTrue

comment created time in 3 days

PullRequestReviewEvent

push eventFrodoTheTrue/nodejs-compute

Fedor Isakov

commit sha 899379fd52b6c0f6940c3faa1765447bf884c46b

add handlers

view details

push time in 3 days

PR merged googleapis/python-security-private-ca

feat(samples): add subordinate CA samples cla: yes samples api: security-privateca

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

+367 -0

2 comments

4 changed files

FrodoTheTrue

pr closed time in 3 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 94b68019a4d9a83dcada4a01fb33599e3f71a283

feat(samples): add subordinate CA samples

view details

push time in 3 days

delete branch googleapis/python-security-private-ca

delete branch : subordinate-samples

delete time in 3 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 7cf6fbeb505222e95cdd891fefd4b101c90d4abf

fix case

view details

push time in 3 days

issue closedGoogleCloudPlatform/golang-samples

compute: samples should use accessors

Instead of fetching the fields directly, we should use accessor methods like GetName(), GetMachineType()

For example, in https://github.com/GoogleCloudPlatform/golang-samples/blob/d6e572168a429e67987f6f1046856ff2041c1f24/compute/list_instances.go#L54

closed time in 6 days

vchudnov-g

issue commentGoogleCloudPlatform/golang-samples

compute: samples should use accessors

Was done here: https://github.com/GoogleCloudPlatform/golang-samples/pull/2261

vchudnov-g

comment created time in 6 days

pull request commentgoogleapis/python-security-private-ca

feat(samples): add subordinate CA samples

@dinagraves thanks for the review. updated!

FrodoTheTrue

comment created time in 7 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 38f18a406af219f6cf1342ff0c79c3725232d6c4

fix review comments

view details

push time in 7 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 3c400177ec9c8d3ba82949695fc8a81e9c44e651

fix review comments

view details

push time in 7 days

PR opened googleapis/nodejs-compute

chore(samples): add custom hostname instances samples

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

+244 -0

0 comment

3 changed files

pr created time in 7 days

create barnchFrodoTheTrue/nodejs-compute

branch : sample-custom-hostname

created branch time in 7 days

pull request commentactions/starter-workflows

Update google deployment starter workflow (partner_templates)

@anuragc617 can we merge it?

FrodoTheTrue

comment created time in 9 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 9fee4d391e33558bd1d851c45bfe40f03cd0e82a

fixes

view details

push time in 9 days

pull request commentactions/starter-workflows

Update google deployment starter workflow

@anuragc617 @bishal-pdMSFT I have updated properties.json and created a new PR to the partner_templates branch. We can close this one.

https://github.com/actions/starter-workflows/pull/1259

FrodoTheTrue

comment created time in 13 days

PR opened actions/starter-workflows

Update google deployment starter workflow (partner_templates)

<!-- IMPORTANT:

This repository contains configuration for what users see when they click on the Actions tab and the setup page for Code Scanning.

It is not:

  • A playground to try out scripts
  • A place for you to create a workflow for your repository -->

Pre-requisites

  • [ ] Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.

Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

  • [ ] Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
  • [ ] Should use sentence case for the names of workflows and steps (for example, "Run tests").
  • [ ] Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
  • [ ] Should include comments in the workflow for any parts that are not obvious or could use clarification.

For CI workflows, the workflow:

  • [ ] Should be preserved under the ci directory.
  • [ ] Should include a matching ci/properties/*.properties.json file (for example, ci/properties/docker-publish.properties.json).
  • [ ] Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
  • [ ] Packaging workflows should run on release with types: [ created ].
  • [ ] Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).

For Code Scanning workflows, the workflow:

  • [ ] Should be preserved under the code-scanning directory.
  • [ ] Should include a matching code-scanning/properties/*.properties.json file (for example, code-scanning/properties/codeql.properties.json), with properties set as follows:
    • [ ] name: Name of the Code Scanning integration.
    • [ ] organization: Name of the organization producing the Code Scanning integration.
    • [ ] description: Short description of the Code Scanning integration.
    • [ ] categories: Array of languages supported by the Code Scanning integration.
    • [ ] iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
  • [ ] Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).

Some general notes:

  • [ ] This workflow must only use actions that are produced by GitHub, in the actions organization, or
  • [ ] This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
    # This workflow uses actions that are not certified by GitHub.
    # They are provided by a third-party and are governed by
    # separate terms of service, privacy policy, and support
    # documentation.
    
  • [ ] Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
  • [ ] Automation and CI workflows cannot be dependent on a paid service or product.
+27 -22

0 comment

2 changed files

pr created time in 13 days

create barnchFrodoTheTrue/starter-workflows

branch : update-google-deployment-2

created branch time in 13 days

push eventFrodoTheTrue/starter-workflows

Fedor Isakov

commit sha 839900272a517e8ec14ac9735f4351b08b9a6727

Update properties

view details

push time in 13 days

PR opened googleapis/python-security-private-ca

feat(samples): add subordinate CA samples

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ ] Ensure the tests and linter pass
  • [ ] Code coverage does not decrease (if any source code was changed)
  • [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

+376 -0

0 comment

4 changed files

pr created time in 13 days

push eventgoogleapis/python-security-private-ca

Fedor Isakov

commit sha 17e5dc79f12ebbfbf770f68cd9e991577451dcb5

feat(samples): add subordinate CA samples

view details

push time in 13 days

create barnchgoogleapis/python-security-private-ca

branch : subordinate-samples

created branch time in 13 days

create barnchgoogleapis/python-security-private-ca

branch : code-samples-ca

created branch time in 13 days

Pull request review commentactions/starter-workflows

Update google deployment starter workflow

 jobs:     - name: Checkout       uses: actions/checkout@v2 -    # Setup gcloud CLI-    - uses: google-github-actions/setup-gcloud@v0.2.0+    # Configure Workload Identity Federation and generate an access token.+    - id: 'auth'+      name: 'Authenticate to Google Cloud'+      uses: 'google-github-actions/auth@v0.4.0'       with:-        service_account_key: ${{ secrets.GKE_SA_KEY }}-        project_id: ${{ secrets.GKE_PROJECT }}+        token_format: 'access_token'+        workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'+        service_account: 'my-service-account@my-project.iam.gserviceaccount.com'++    # Install gcloud CLI+    - name: 'Install gcloud CLI'+      uses: 'google-github-actions/setup-gcloud@master'++    # Log in to gcloud CLI+    - name: Log in to gcloud CLI+      run: |-+        gcloud auth login --quiet --brief --cred-file="${{ steps.auth.outputs.credentials_file_path }}"      # Configure Docker to use the gcloud command-line tool as a credential-    # helper for authentication-    - run: |--        gcloud --quiet auth configure-docker+    # helper for authentication (https://cloud.google.com/artifact-registry/docs/docker/authentication)+    - name: Docker configuration+      run: |-+        gcloud --quiet auth configure-docker $GAR_LOCATION-docker.pkg.dev+      # Get the GKE credentials so we can deploy to the cluster-    - uses: google-github-actions/get-gke-credentials@v0.2.1

Added!

FrodoTheTrue

comment created time in 16 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentactions/starter-workflows

Update google deployment starter workflow

 jobs:     - name: Checkout       uses: actions/checkout@v2 -    # Setup gcloud CLI-    - uses: google-github-actions/setup-gcloud@v0.2.0+    # Configure Workload Identity Federation and generate an access token.+    - id: 'auth'+      name: 'Authenticate to Google Cloud'+      uses: 'google-github-actions/auth@v0.4.0'       with:-        service_account_key: ${{ secrets.GKE_SA_KEY }}-        project_id: ${{ secrets.GKE_PROJECT }}+        token_format: 'access_token'+        workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider'+        service_account: 'my-service-account@my-project.iam.gserviceaccount.com'++    # Install gcloud CLI+    - name: 'Install gcloud CLI'+      uses: 'google-github-actions/setup-gcloud@master'++    # Log in to gcloud CLI+    - name: Log in to gcloud CLI+      run: |-+        gcloud auth login --quiet --brief --cred-file="${{ steps.auth.outputs.credentials_file_path }}"      # Configure Docker to use the gcloud command-line tool as a credential-    # helper for authentication-    - run: |--        gcloud --quiet auth configure-docker+    # helper for authentication (https://cloud.google.com/artifact-registry/docs/docker/authentication)+    - name: Docker configuration+      run: |-+        gcloud --quiet auth configure-docker $GAR_LOCATION-docker.pkg.dev

Sounds reasonable. Added!

FrodoTheTrue

comment created time in 16 days

push eventFrodoTheTrue/starter-workflows

Fedor Isakov

commit sha 3fc21c7a00232325e691c871a88bffcda7245b69

fix typo and add get-gke-credentials action

view details

push time in 16 days

more