profile
viewpoint
Francesco Borzì FrancescoBorzi @AzerothCore Netherlands https://www.linkedin.com/in/francesco-borzi/ Live and let live. -- Shin

azerothcore/Keira3 73

Cross-platform Database Editor for AzerothCore

FrancescoBorzi/Bootstrap-image-upload-form 28

Example of image upload form without page refresh using Bootstrap, jQuery AJAX and PHP.

azerothcore/mod-duel-reset 11

Duel reset module for AzerothCore

FrancescoBorzi/ArenaStats 4

TrinityCore tool to show Arena statistics

FrancescoBorzi/brew 3

Brew theme for my blog

FrancescoBorzi/bootstrap-mail 2

work in progress...

FrancescoBorzi/ckjm 2

Fragm calculation tool

AzerothShard/azerothcore-wotlk 1

AzerothCore - Continuing Sunwell Core Project! Based on Mangos -> TrinityCore -> SunwellCore

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 08653594b9e0ea5a44a45e57eb8bc132a218756c

WIP

view details

push time in 3 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 070a4d1409a1646cd5aef995c62e090974831814

WIP

view details

FrancescoBorzi

commit sha d9a9b1fcca0cdc144ed6d2a46c7a662c6b230507

WIP

view details

FrancescoBorzi

commit sha 00ef0f2522b5628dcb3be7a04eab9e5857753355

WIP

view details

FrancescoBorzi

commit sha 0c784d39cc638c1f12323024f7a669fd20d112ab

WIP

view details

FrancescoBorzi

commit sha ccd4bd5c13a90fc12b1cfd7f9983dd0ced1722d8

test: fix

view details

push time in 3 hours

issue commentazerothcore/Keira3

Save multiple login sessions

Currently blocked by: https://github.com/valor-software/ngx-bootstrap/issues/5727

FrancescoBorzi

comment created time in 4 hours

delete branch azerothcore/Keira3

delete branch : replace_icon

delete time in 4 hours

push eventazerothcore/Keira3

Stefano Borzì

commit sha e43a0e00a59243da49d890362e0a9035bc9ddd58

fix(item-preview): improve icon, fix spell description (#579)

view details

push time in 4 hours

PR merged azerothcore/Keira3

fix(item-preview): improve icon, fix spell description

Closes #575

+35 -46

0 comment

8 changed files

Helias

pr closed time in 4 hours

issue closedazerothcore/Keira3

ItemPreview: Replace hardcoded image with component

image

Replace with <keira-icon> Component

closed time in 4 hours

FrancescoBorzi

delete branch azerothcore/Keira3

delete branch : check_inventorytype

delete time in 4 hours

push eventazerothcore/Keira3

Stefano Borzì

commit sha 5dabc6f647f1e5bfadd79deee700130b69bfd985

fix(item-preview): add null check for inventory type (#580)

view details

push time in 4 hours

issue closedazerothcore/Keira3

Item preview, bug report

  • InventoryType, wrong value -> prevent undefined - check Map field when value is 0 (Eastern Kingdom)

closed time in 4 hours

Helias

issue commentvalor-software/ngx-bootstrap

Lose height of <ul> with ngFor in Dropdown component

Also tested in 5.6.1, same bug

Daniyar111

comment created time in 4 hours

issue commentvalor-software/ngx-bootstrap

Lose height of <ul> with ngFor in Dropdown component

Confirmed

I have the same using version 5.5.0

Angular CLI: 9.1.0
Node: 12.14.0
OS: linux x64

Angular: 9.1.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.901.0
@angular-devkit/build-angular   0.901.0
@angular-devkit/core            9.1.0
@angular-devkit/schematics      9.1.0
@schematics/angular             9.1.0
@schematics/update              0.901.0
rxjs                            6.5.5
typescript                      3.8.3
Daniyar111

comment created time in 4 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 5529950a2dfda48ef445d9e67a5ca1403b752f97

WIP

view details

push time in 5 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha ea7087bce7a9075beb62b337879710b80a597373

WIP

view details

push time in 5 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 72ddd34b476bb39f244c25442c2ae35c7e330e98

WIP

view details

push time in 6 hours

PR opened azerothcore/Keira3

feat(login): save connection details WIP
+35 -6

0 comment

3 changed files

pr created time in 6 hours

create barnchazerothcore/Keira3

branch : login-save

created branch time in 6 hours

PR opened azerothcore/Keira3

feat(SAI): improve Search by Entity
  • Closes https://github.com/azerothcore/Keira3/issues/568
+116 -65

0 comment

5 changed files

pr created time in 8 hours

create barnchazerothcore/Keira3

branch : improve-select-smartai

created branch time in 8 hours

issue closedazerothcore/Keira3

Improve editors design

closed time in 12 hours

FrancescoBorzi

delete branch azerothcore/Keira3

delete branch : renovate/angular-builders-custom-webpack-9.x

delete time in 14 hours

PR closed azerothcore/Keira3

chore(deps): update dependency @angular-builders/custom-webpack to v9.1.0

This PR contains the following updates:

Package Type Update Change
@angular-builders/custom-webpack devDependencies minor 9.0.0 -> 9.1.0

Release Notes

<details> <summary>just-jeb/angular-builders</summary>

v9.1.0

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+91 -1976

1 comment

2 changed files

renovate[bot]

pr closed time in 14 hours

pull request commentazerothcore/Keira3

chore(deps): update dependency @angular-builders/custom-webpack to v9.1.0

closed in favour of:

https://github.com/azerothcore/Keira3/pull/576

renovate[bot]

comment created time in 14 hours

create barnchazerothcore/Keira3

branch : update-dependencies

created branch time in 14 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha d8ef7bfc5a1ee46ac84c1848194e262cb9cf1f5f

WIP

view details

push time in 15 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 46201d135d8432dfc801ea4ef8dfbf7a31f6fafe

WIP

view details

push time in 15 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 5eefaa4c4149421009d25ed57201bb6b69fb21b3

WIP

view details

FrancescoBorzi

commit sha 3f90f499973eafd0a1464c8a67654f2e7f8060ca

WIP

view details

FrancescoBorzi

commit sha 34977e591b46c9a27454b406d4f496cad572423b

WIP

view details

FrancescoBorzi

commit sha 8131a2ef15e2ead8a49c87b2e7bd7a593e29a38f

WIP

view details

push time in 15 hours

issue openedazerothcore/Keira3

ItemPreview: Replace hardcoded image with component

image

Replace with <keira-icon> Component

created time in 15 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 7bb6c4d3dc1cb8153d8b9f83b3f37fa115dc1128

WIP

view details

FrancescoBorzi

commit sha 053c49fd1062db2185d6c87ae881c60be7f86564

WIP

view details

FrancescoBorzi

commit sha ac6ca2c20b0e29c8df42ce5596ae1d850a36804e

WIP

view details

push time in 16 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 4adb07476a18bec1d8e19a06266e847f10fa41dd

WIP

view details

FrancescoBorzi

commit sha b53f5c1746e2b324600e73a9b8dace7a7e7cef2c

WIP

view details

push time in 16 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha dce1939231cbfa7649fbf514ac334b397cc8f5ff

WIP

view details

push time in 17 hours

CommitCommentEvent

pull request commentazerothcore/azerothcore-wotlk

fix(DB/creature): Add waypoint for Morin Cloudstalker

@BarbzYHOOL I didn't know that, I thought that fix was final. Sorry

aleigood

comment created time in 18 hours

delete branch FrancescoBorzi/ngx-duration-picker

delete branch : renovate/ts-node-8.x

delete time in 18 hours

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 0637160908157ff9a50b76b3d289707cfa1a2852

chore(deps): update dependency ts-node to v8.8.2 (#216) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 18 hours

PR merged FrancescoBorzi/ngx-duration-picker

chore(deps): update dependency ts-node to v8.8.2

This PR contains the following updates:

Package Type Update Change
ts-node devDependencies patch 8.8.1 -> 8.8.2

Release Notes

<details> <summary>TypeStrong/ts-node</summary>

v8.8.2

Compare Source

Fixed

  • Avoid pushing to rootFileNames with version

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 18 hours

delete branch azerothcore/Keira3

delete branch : renovate/ts-node-8.x

delete time in 18 hours

PR merged azerothcore/Keira3

chore(deps): update dependency ts-node to v8.8.2

This PR contains the following updates:

Package Type Update Change
ts-node devDependencies patch 8.8.1 -> 8.8.2

Release Notes

<details> <summary>TypeStrong/ts-node</summary>

v8.8.2

Compare Source

Fixed

  • Avoid pushing to rootFileNames with version

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+5 -5

0 comment

2 changed files

renovate[bot]

pr closed time in 18 hours

push eventazerothcore/Keira3

renovate[bot]

commit sha 27d5273565f68e8c76eaecb2d1f06b6e5d81b55f

chore(deps): update dependency ts-node to v8.8.2 (#573) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 18 hours

delete branch azerothcore/server-status

delete branch : dependabot/npm_and_yarn/acorn-6.4.1

delete time in 18 hours

push eventazerothcore/server-status

dependabot[bot]

commit sha 95150d7a7b9711afa559b8b468030a6ce65cb1dd

Bump acorn from 6.4.0 to 6.4.1 (#1) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 18 hours

PR merged azerothcore/server-status

Bump acorn from 6.4.0 to 6.4.1 dependencies

Bumps acorn from 6.4.0 to 6.4.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li> <li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce351b54f956e2c4ed27cca9631284"><code>90a9548</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/6.4.0...6.4.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 18 hours

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 083407535c842ce2c725eab5cc2f362be2c998e0

WIP

view details

push time in a day

PR opened azerothcore/Keira3

Reviewers
feat(editor): improve design WIP
+2651 -2636

0 comment

57 changed files

pr created time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 04cb09e17e3b680766835542f6ef65d135eec575

WIP

view details

FrancescoBorzi

commit sha fe57f7f15a3d6b360ab67baaf8d98ba2c30c4208

WIP

view details

FrancescoBorzi

commit sha 04c4991e7117e5786e9d6f5e040707d26037d5d7

WIP

view details

FrancescoBorzi

commit sha 619e38b79668d10f8d634dd053a069dba6445717

WIP

view details

FrancescoBorzi

commit sha df8d0d594dcb6615ab0a643bf666ee4db8069b50

WIP

view details

push time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 3d24a293c2d894d50365cd0386e7ec552bf8209a

WIP

view details

FrancescoBorzi

commit sha 9073dfca76b1b0df8ba93c685b4c9e8b644ebf38

WIP

view details

FrancescoBorzi

commit sha f614130aecb0c5a1f510a92a647b4f0c900a785c

WIP

view details

push time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 1abdcb7ae6e3aacd644f9a5508a347c141a2227e

chore: wip

view details

push time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 580da68fcee01276cb92793b07fc9011e6999b6a

chore: wip

view details

push time in a day

create barnchazerothcore/Keira3

branch : improve-design

created branch time in a day

delete branch azerothcore/azerothcore.github.io

delete branch : fix-links

delete time in a day

push eventazerothcore/azerothcore.github.io

Francesco Borzì

commit sha 5266de113fb5ae0b9165f599c96803ee64bd9e0f

fix: links (#34)

view details

push time in a day

PR merged azerothcore/azerothcore.github.io

fix: links

thanks @Kitzunu for reporting this

+3 -3

0 comment

1 changed file

FrancescoBorzi

pr closed time in a day

PR opened azerothcore/azerothcore.github.io

fix: links

thanks @Kitzunu for reporting this

+3 -3

0 comment

1 changed file

pr created time in a day

create barnchazerothcore/azerothcore.github.io

branch : fix-links

created branch time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 2ecd95d4803227d203dac48379d8785201467029

chore: update screenshot

view details

push time in a day

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 864b7d998d81d859ddcc970b90800edb54d0c88c

doc(README.md): update preview

view details

push time in a day

issue commentazerothcore/forum

[TOOL] Keira3 Beta

We've been working hard to release a new version of Keira3, the Beta 4.

The most interesting feature of this release is the Item Preview, created by @Helias#9347 during months of development. The feature is available when creating or editing Item Templates.

We also added other minor features like Showing unsaved changes in the Sidebar, showing Item names in loots and other improvements to the SAI Editors. In addition, we added a new set of Selectors that can help you when selecting IDs (Quest, ExtendedCost, RequiredSkill, ItemLimitCategory, Language, Holiday, Area, SocketBonus, Map, Spell). All of these new selectors are available in the Item Template editor as well as in other editors of Keira3.

Despite not being UX Design our best speciality, we've started to put some efforts into improving the UI. This resulted in a total rewrite of the Login screen UI as well as improvements to the Sidebar layout. Both the Login screen and the Sidebar are now featuring random backgrounds (thanks @Viste#2237 for suggesting some of them).

You can download the latest version of Keira3 here: https://github.com/azerothcore/Keira3/releases

In the next release, we plan to implement the Quest Preview as well as doing more UI improvements for a better developer experience.

FrancescoBorzi

comment created time in a day

created tagazerothcore/Keira3

tagv3.0.0-beta.4

Cross-platform Database Editor for AzerothCore

created time in a day

pull request commentazerothcore/azerothcore-wotlk

fix(DB/creature): Add waypoint for Morin Cloudstalker

well done @aleigood @BarbzYHOOL @Si1ker

aleigood

comment created time in a day

push eventazerothcore/azerothcore-wotlk

aleigood

commit sha d22251bcabd475eacd0ddee17b49cfc077b5f69b

fix(DB/creature): Add waypoint for Morin Cloudstalker (#2837)

view details

push time in a day

PR merged azerothcore/azerothcore-wotlk

fix(DB/creature): Add waypoint for Morin Cloudstalker Bash DB Priority - Critical To Be Merged

Adding a waypoint for the NPC Morin Cloudstalker

CHANGES PROPOSED..:

  • DATABASE

ISSUES ADDRESSED:

Morin Cloudstalker is currently missing a waypoint like official data.

TESTS PERFORMED:

Tested on a Linux server, NPC can walk with the waypoint.

HOW TO TEST THE CHANGES:

.go creature id 2988 transmits to NPC location and observes its route of movement.

KNOWN ISSUES AND TODO LIST:

None

Target branch(es):

  • [x] Master

How to test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here in the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

+32 -4

8 comments

2 changed files

aleigood

pr closed time in a day

issue closedazerothcore/forum

WoW Background image hunt for Keira3

I'm working hard on Keira3 and its first release is behind the corner. Since my time is always limited (and my design skills are not that great), I'm sharing this task with the community since anyone can help with it.

This image:

https://github.com/azerothcore/Keira3/blob/ddbe2a00b937e7cb4af7986d11e8b8a8e4181eba/src/assets/img/bg1.jpg

Is currently the background of the sidebar of Keira3:

image

Now I would like to replace it with something more AC and/or WoW related. I will select initially one image (but in future I could put a group of images, each time choosing randomly among team at Keira3 startup) to be the new background image of the sidebar.

I was thinking about some screenshot taken in game of some nice landscape, view, or whatever... but I'm open to any suggestions.

Requirements:

  • The image size (width and height) should be approximately the same as the current one, otherwise it doesn't fit well
  • The smaller file size the better (currently is 40 KB)
  • The colours should fit with its usage (dark in the top, a bit lighter in the bottom... well, you got what I mean)

Would you like to help me selecting a new image (or a group of images)?

Please post your suggestions!

How to test images

  1. Run Keira3 in development mode (instructions available [here])(https://github.com/azerothcore/Keira3#development)

  2. Add your image(s) in the src/assets/img/ directory

  3. Change this line of code to try different images https://github.com/azerothcore/Keira3/blob/master/src/app/components/main-window/sidebar/sidebar.component.html#L5

Keira will automatically recompile and show your image.

closed time in a day

FrancescoBorzi

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 317643e4e2f80576d495a8c2e4231fa974501a19

release: 3.0.0-beta.4

view details

push time in a day

startedwine-mirror/wine

started time in a day

startedValveSoftware/wine

started time in a day

delete branch FrancescoBorzi/angular-9-issue-reproduction

delete branch : dependabot/npm_and_yarn/acorn-6.4.1

delete time in 2 days

push eventFrancescoBorzi/angular-9-issue-reproduction

dependabot[bot]

commit sha ff8a3a5d7d3db6ea057fb4e85dc3939bd9a9ab65

chore(deps): bump acorn from 6.4.0 to 6.4.1 (#1) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

push time in 2 days

PR merged FrancescoBorzi/angular-9-issue-reproduction

chore(deps): bump acorn from 6.4.0 to 6.4.1 dependencies

Bumps acorn from 6.4.0 to 6.4.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/9a2e9b6678e243d66846b91179d650d28453e70c"><code>9a2e9b6</code></a> Mark version 6.4.1</li> <li><a href="https://github.com/acornjs/acorn/commit/90a9548ea0ce351b54f956e2c4ed27cca9631284"><code>90a9548</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/6.4.0...6.4.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 days

CommitCommentEvent

pull request commentazerothcore/azerothcore-wotlk

fix(DB/creature): Add waypoint for Morin Cloudstalker

@BarbzYHOOL cool, build passed

aleigood

comment created time in 2 days

push eventazerothcore/azerothcore-wotlk

Amin.MasterkinG

commit sha 378cd6fe289a418e637f1dbc2750b06ed07c168a

fix(core): "Silenced - You can only chat with GMs" spell (#2716)

view details

push time in 2 days

PR merged azerothcore/azerothcore-wotlk

fix(Core): "Silenced - You can only chat with GMs" spell. To Be Merged

Fix spell : Silenced

How to test:

.aura 1852 and try to chat as normal/other players and with GMs.

+9 -10

4 comments

1 changed file

masterking32

pr closed time in 2 days

delete branch azerothcore/Keira3

delete branch : item-preview-integration

delete time in 2 days

push eventazerothcore/Keira3

Stefano Borzì

commit sha 6210e7154f8b924e43edc0a4326dff8268f4e1c6

test(item-preview): add integration test (#567)

view details

push time in 2 days

Pull request review commentazerothcore/Keira3

test(item-preview): add integration test

 export class ItemPreviewService {     let dmg = '';      if (itemClass === ITEM_TYPE.AMMUNITION && dmgmin && dmgmax) {-      if (sc1) {+      if (sc1 && sc1 < 7 && sc1 > 0) {

wrap 7 into a constants

Helias

comment created time in 2 days

PR opened azerothcore/azerothcore-wotlk

Reviewers
fix(bash/db_assembler): fix files being imported twice

This was causing these PRs to fail because the new SQL file was being imported twice:

https://github.com/azerothcore/azerothcore-wotlk/pull/2837 https://github.com/azerothcore/azerothcore-wotlk/pull/2835

+1 -4

0 comment

2 changed files

pr created time in 2 days

create barnchFrancescoBorzi/azerothcore-wotlk

branch : fix-bash

created branch time in 2 days

pull request commentazerothcore/azerothcore-wotlk

fix(DB/creature): Add waypoint for Morin Cloudstalker

Guys, what it's happening it's quite simple and it's nothing sophisticated nor strictly related to Travis.

The bash script that installs the DB is giving the following error when trying to import the SQL code:

ERROR 1062 (23000) at line 77682: Duplicate entry '1585892474413237800' for key 'PRIMARY'

This means there is already a row having its ID (sql_rev) as 1585892474413237800 in the version_db_world.

We need to understand why this is happening. I don't have such an ID on a clean, latest-master DB

SELECT * FROM version_db_world WHERE sql_rev = '1585892474413237800'

aleigood

comment created time in 2 days

push eventFrancescoBorzi/azerothcore-wotlk

LukasVolgger

commit sha 2fd2984cb2c1661380a366a80c73f9fb4ff38e3a

fix(DB/creature_formations): Moon Priestess Amara pathing (#2711)

view details

AzerothCoreBot

commit sha 386ee6f162dacea64286c99fc9d40d2179b98c43

Import pending SQL update file... Referenced commit(s): 2fd2984cb2c1661380a366a80c73f9fb4ff38e3a

view details

LukasVolgger

commit sha 71f98abc2c1653d9f91c34811bc3f9735fe1fba6

fix(DB/creature_formations): Thal'trak Proudtusk pathing (#2724) Use creature_formations instead of pathing for each npc. This avoids that they get out of sync after a while or get stuck.

view details

AzerothCoreBot

commit sha 633ef83b47851c5d78176f16525c623879f0dd39

Import pending SQL update file... Referenced commit(s): 71f98abc2c1653d9f91c34811bc3f9735fe1fba6

view details

Stefano Borzì

commit sha 19c3a70d4159656ce197b36d5e068a4bed0e67c6

feat(Core/Config): make stop time for creatures with WP movement configurable #2715 (#2829) Original author Stoabrogga

view details

Barbz

commit sha ea709de58baf6339fd2e589ad51c54d9f901736a

fix(app/db_assembler): Allow recursion with bash (#2731) - Before that commit, the recursion with "**" stopped after the first directory

view details

arenacraftwow

commit sha cfdbf00afebc79607473ea59c6a70395158812fd

fix(Core/Hook): OnFirstLogin can now make persistent changes (#2793) PlayerScript#OnFirstLogin was broken in that if you tried to teach the player a spell or give an item to him that change wouldn't persist. Meaning that the next time the Player would log in, his awarded spells or items would be gone. Meanwhile PlayerScript#OnLogin didn't have this behavior meaning that the sematics of PlayerScript#OnFirstLogin and PlayerScript#OnLogin where very different, which is unexpected. This issue was caused by an implementation detail in Player#learnSpell (and similiar) which behaves differently depending on Player#isBeingLoaded phase. This code change makes its that PlayerOnFirstLogin hook executes when Player#isBeingLoaded == false fixing the issue. Alternatives: The fact that Player#learnSpells and others behave differently depending on the load phase is questionable and from my research it seems like this impl detail is only used when giving the player his template spells. We could add a overload to Player#learnSpell with a flag like `isSpellTemporary` and make the template spells loading use it. Then we would be able to remove this implicit temporary spell mechanism when Player#isBeingLoaded thing. However this is a deeper change and not worth the risk.

view details

Barbz

commit sha 9d0ebcd8ea3e14d78ef5d33a6ec12e1d3f632482

style(DB): battelground_template entries now commented by type (arena or bg) (#2722) - Can be useful for people who don't know WOW by heart - Can be used to select only arenas or only battlegrounds - Added full name for Nagrand Arena

view details

AzerothCoreBot

commit sha 397c5d916fe1330510b1d815d23d18eaa18116a7

Import pending SQL update file... Referenced commit(s): 9d0ebcd8ea3e14d78ef5d33a6ec12e1d3f632482

view details

push time in 2 days

push eventFrancescoBorzi/ngx-duration-picker

renovate[bot]

commit sha 0f787074061ac6ab7595703f15917e904e9afa93

fix(deps): update dependency rxjs to v6.5.5 (#215) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 days

delete branch azerothcore/Keira3

delete branch : renovate/rxjs-6.x

delete time in 3 days

PR merged FrancescoBorzi/ngx-duration-picker

fix(deps): update dependency rxjs to v6.5.5

This PR contains the following updates:

Package Type Update Change
rxjs dependencies patch 6.5.4 -> 6.5.5

Release Notes

<details> <summary>reactivex/rxjs</summary>

v6.5.5

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+4 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

push eventazerothcore/Keira3

renovate[bot]

commit sha 0fd774842900a3dc4b891347079044b65771d243

chore(deps): update dependency rxjs to v6.5.5 (#566) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

push time in 3 days

PR merged azerothcore/Keira3

chore(deps): update dependency rxjs to v6.5.5

This PR contains the following updates:

Package Type Update Change
rxjs devDependencies patch 6.5.4 -> 6.5.5

Release Notes

<details> <summary>reactivex/rxjs</summary>

v6.5.5

Compare Source

</details>


Renovate configuration

:date: Schedule: At any time (no schedule defined).

:vertical_traffic_light: Automerge: Disabled by config. Please merge this manually once you are satisfied.

:recycle: Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

+64 -4

0 comment

2 changed files

renovate[bot]

pr closed time in 3 days

push eventazerothcore/Keira3

FrancescoBorzi

commit sha 9af10cb9ed74e08203751c01f5389fbefcd57863

chore: make it darker

view details

push time in 3 days

PR opened azerothcore/Keira3

feat(sidebar): dynamic backgrounds
  • Closes: https://github.com/azerothcore/Keira3/issues/554
+3 -1

0 comment

9 changed files

pr created time in 3 days

create barnchazerothcore/Keira3

branch : sidebar-backgrounds

created branch time in 3 days

delete branch azerothcore/Keira3

delete branch : prepare-quest

delete time in 3 days

push eventazerothcore/Keira3

Francesco Borzì

commit sha 1ccd5febc5645bca0dcbb61ca9f31538b4c4b4a6

chore: prepare foundations for quest-preview (#564)

view details

push time in 3 days

push eventazerothcore/Keira3

FrancescoBorzi

commit sha fce8553d417f57cd516d89ba41777e923116044a

chore: fix tests

view details

push time in 3 days

push eventazerothcore/Keira3

Stefano Borzì

commit sha c656c69f6b991cf02142f7a8f2dbbf77d71429c1

feat(item-preview): add item-preview (#533)

view details

Francesco Borzì

commit sha 4e1b81deffe1b1b9559c45db3d8115efb7259686

Merge branch 'master' into prepare-quest

view details

push time in 3 days

push eventazerothcore/Keira3

Stefano Borzì

commit sha c656c69f6b991cf02142f7a8f2dbbf77d71429c1

feat(item-preview): add item-preview (#533)

view details

push time in 3 days

delete branch azerothcore/Keira3

delete branch : item-preview-2

delete time in 3 days

PR merged azerothcore/Keira3

feat(item-preview): add item-preview

Add item preview to the item_template editor

Closes #456

Inspired by AoWoW

+2554 -122

0 comment

28 changed files

Helias

pr closed time in 3 days

more