Sorry for the vague issue, but I'm not really sure how to debug firefox extensions.

The extension works fine on another computer, so my guess is that it's because I keep 2 weeks around (work and non-work) on this laptop. Toggling the extension off and back on fixes it.

@f0zi I suppose the RSS feed of the repo releases/tags is the closest you'll get: https://github.com/electron/electron-notarize/releases.atom

@malept fair enough, one or two small extra dependencies doesn't seem like a lot when talking about electron though haha

This would be useful for people not using this add-on as a JS hook in electron-builder. Similar to how electron-osx-sign has them.

Someone has made a separate electron-notatize-cli package, but it's inconvenient because of being tied to whatever version of this package it specifies as a dependency. I asked them to open a PR here instead but it seems like they're not interested: https://gitlab.com/fozi/electron-notarize-cli/issues/1

this didn't exist and these don't seem to be in any particular order, so I just chucked it on the end here

Opened a PR to fix this: https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/pull/250

Fixes https://github.com/buildkite-plugins/docker-compose-buildkite-plugin/issues/197.

Wrote some tests here but also tested with our project and it's working.

Let me know if I've missed anything I need to change, I just grepped for the configuration property names.

build_params construction could probably be a shared method but oh well.

:+1: noticed this too. If there's no preceeding build step, the run step needs to build the service, but doesn't use the args configuration when doing so. I've worked around it by just shoving it in docker-compose.yml too, but it prevents being able to use values from the buildkite environment, so definitely a problem.

Also, I think the reason the build and then run thing didn't work is because build doesn't set the meta-data run uses to find the pre-built image unless you use a image-repository etc. This doesn't make sense to do anyway of course, should only need run if only using local cache.

Since it uses $PWD inside the hook it ends up with an emulated path like /c/.../repo which doesn't work when passed to -v, it has to be a native windows path like C:\...\repo.

Of course you can just use a relative path in docker-compose.yml instead but it's a bit inconsistent, so might be worth mentioning in the volumes docs at least?

oh, I haven't tried this yet myself (I have an spare old macbook at the moment), but I read somewhere that passing through an entire USB controller to the guest works, rather than just the device

alright I'm relatively happy with the logging now, not sure if there's a good way to test the main changes, any ideas? otherwise this should be good to go

Been using this a bit more, still working well.

The only thing I think could go wrong here is if there's overlapping options for build/run, but the only such one is pull-retries which is pretty redundant for run since you pull in build instead. Even in that case users can still use the old split steps if they really want to anyway.

This fixes https://github.com/isleofcode/corber/issues/604.

Turns out cordova-lib doesn't actually log to stdout/stderr by default, unlike cordova-cli, instead it emits events which I've hooked up.

Now the problem is it's hard to preserve the newlines, I've got it sort of working for cordova raw stdout, but it's a bit ugly. The same problem applies to e.g. the bash wrapper too, and I've probably broken the logger tests, so still needs a bit more work but interesting in initial thoughts.

Inspired by #224, this removes the final restriction on using build and run together.

The use case for this is that for simply running a script in docker with a cached build, having to have docker-compose build > wait > docker-compose run overcomplicates the pipeline unnecessarily. In particular it prevents running many similar steps in parallel because of the wait.

As far as I can see there's no reason this shouldn't work: build sets the magic meta-data, run then immediately reads it like normal. It's worked so far in our testing.

Probably need to update the README and plugin schema including the changes from #224, not sure if I'm the right person to do that though.

/dev:/dev as a volume worked well enough for me

tried with latest master, seems to work with some apps (e.g. signal) which get installed to /opt :clap:

our app is available for download here: https://www.vivi.io/downloads

if I open the binary with debugtron, a tab for the app appears for a split second then goes away

fair enough, would be nice to be able to load one manually in the meantime at least.

and yeah it's VS Code: https://www.archlinux.org/packages/community/x86_64/code/

I also tried with my own app built using this packager: https://github.com/electron-userland/electron-installer-debian

Bumps nokogiri from 1.10.3 to 1.10.5. <details> <summary>Release notes</summary>

Sourced from nokogiri's releases.

1.10.5 / 2019-10-31

Dependencies

• [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
• [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34

1.10.4 / 2019-08-11

Security

Address CVE-2019-5477 (#1915)

A command injection vulnerability in Nokogiri v1.10.3 and earlier allows commands to be executed in a subprocess by Ruby's Kernel.open method. Processes are vulnerable only if the undocumented method Nokogiri::CSS::Tokenizer#load_file is being passed untrusted user input.

This vulnerability appears in code generated by the Rexical gem versions v1.0.6 and earlier. Rexical is used by Nokogiri to generate lexical scanner code for parsing CSS queries. The underlying vulnerability was addressed in Rexical v1.0.7 and Nokogiri upgraded to this version of Rexical in Nokogiri v1.10.4.

This CVE's public notice is sparklemotion/nokogiri#1915

</details> <details> <summary>Changelog</summary>

Sourced from nokogiri's changelog.

1.10.5 / 2019-10-31

Dependencies

• [MRI] vendored libxml2 is updated from 2.9.9 to 2.9.10
• [MRI] vendored libxslt is updated from 1.1.33 to 1.1.34

1.10.4 / 2019-08-11

Security

Address CVE-2019-5477 (#1915)

A command injection vulnerability in Nokogiri v1.10.3 and earlier allows commands to be executed in a subprocess by Ruby's Kernel.open method. Processes are vulnerable only if the undocumented method Nokogiri::CSS::Tokenizer#load_file is being passed untrusted user input.

This vulnerability appears in code generated by the Rexical gem versions v1.0.6 and earlier. Rexical is used by Nokogiri to generate lexical scanner code for parsing CSS queries. The underlying vulnerability was addressed in Rexical v1.0.7 and Nokogiri upgraded to this version of Rexical in Nokogiri v1.10.4.

This CVE's public notice is sparklemotion/nokogiri#1915 </details> <details> <summary>Commits</summary>

• 1bc2ff9 version bump to v1.10.5
• 383c1f8 update CHANGELOG
• 43a1753 dependency: update libxslt to 1.1.34 final
• 99d8a6b dependency: update libxml to 2.9.10 final
• 2a86496 add suppressions for ruby 2.7
• dca794a update CHANGELOG with correct release date for v1.10.4
• 077e010 update rake-compiler commands to install bundler
• beb832e version bump to v1.10.4
• 5d30128 Merge branch '1915-css-tokenizer-load-file-vulnerability_v1.10.x' into v1.10.x
• c86b5fc update CHANGELOG
• Additional commits viewable in compare view </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
• @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
• @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
• @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
• @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

no spam thanks

@pd4d10 thanks, I just tried it out (running from yarn start, can't be bothered installing on arch linux), but it doesn't detect any apps. I tried manually navigating to an app such as /usr/bin/code, but it didn't seem to do anything, nothing in dev tools console either. what am I doing wrong?

here you go https://aur.archlinux.org/packages/input-redirection-client-qt/

I can do that pretty easily, but is this tool unstable? only a few commits extra on master and hasn't been changed in years

in case it's helpful I just made an AUR package: https://aur.archlinux.org/packages/input-redirection-client-qt-git/

only took an hour of config and one prior AUR package of experience for the record :wink:

still as wrong as it always was for me on arch, qt seems to be assuming 43" 4k is "hidpi" even though I'm running X at 1x, not keepass's fault though

:pepemug:

btw, I ended up using yarn resolutions as well and it seems to be working, can't really track down why the major version got bumped anyway

@Superlucas517 what changes in particular are you making? I only tried giving myself items, some things may not work because I disabled half of the files

I think this has broken our use case of passing electron-builder a pre-built but unsigned .app and turning it into a .pkg, signing both the .app and .pkg. It no longer signs the .app at all now. I guess this is a bit of a dumb use case anyway, I can just run electron-osx-sign and electron-notarize first instead, but just mentioning anyway.

Seems to be caused by updates being pushed via pubsub recreating them. Should be a matter of keeping the deleted videos around for a while, at least until the threshold to ignore pushes is reached.

mismatched quotes, still seems to come out right though

 $ python ~/src/extract_android_ota_payload/extract_android_ota_payload.py payload.bin payload
Traceback (most recent call last):
  File "/home/jake/src/extract_android_ota_payload/extract_android_ota_payload.py", line 14, in <module>
    raise Exception("Python 2.x is required")
Exception: Python 2.x is required

and warning from pip2 install -r requirements.txt

DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7

@crobinson42 I don't think it's possible to change with the env var without restarting the process, the only way to change it dynamically would be to change the actual system timezone and not use an env var at all.

Environment

Windows build number: 10.0.18362.295
PowerToys version: 0.11.0
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Use any default zone configuration, such as focused grid, with the default 16 space around zones.

Expected behavior

The space between windows is the same as the space between windows and the edge of the desktop.

I expect this because it looks symmetrical, and it's how i3-gaps works.

Actual behavior

The space between windows is double, since each window gets its own space "around" itself within each zone, and it doesn't collapse with adjacent zones.

Screenshots

FancyZones

i3-gaps