profile
viewpoint

finnsson/pagerjs 278

The Single Page Application Framework for KnockoutJS

PacktPublishing/Real-world-Projects-with-Vue.js 16

Real world Projects with Vue.js [video], published by Packt

DKhalil/coffeescript-vue-browserify-grunt 5

Example repo for a coffeescript, vuejs, browserify and grunt stack

sealas/elixir-standardfile-server 2

Standard File server implemented in Elixir

DKhalil/jquery.rest 1

A jQuery plugin for easy consumption of RESTful APIs

DKhalil/qcode-decoder 1

QR Code decoder using Lazar Laszlo's decoder

DKhalil/base_model 0

ActiveRecord for Ecto

DKhalil/cookie-universal 0

Universal cookie plugin, perfect for SSR

DKhalil/firecomments 0

Self-hostable comment system with firebase database

pull request commentai/nanoid

Fix customAlphabet call causing infinite loop if called without size param

What signatures?

I'm just saying, an improper or missing function argument shouldn't cause an infinite loop and total failure without notice or warning. Does that not make sense to you? Am I missing something here? In my opinion bundle size shouldn't just completely trump over proper API/UX design. And in this case, calling customAlphabet('abcdef1235') like that, would simply crash the application entirely.

Now, if you disagree with that and allowing your users to run into a brick wall is a consequence you are willing to allow, then let's be done with it and close this and maybe add a warning to the documentation about custom alphabets then.

DKhalil

comment created time in 16 days

pull request commentai/nanoid

Fix customAlphabet call causing infinite loop if called without size param

I mean, this kind of check is probably going to weigh a few bytes in the final bundle, plus what about people who don't use typescript?

DKhalil

comment created time in 16 days

pull request commentai/nanoid

Fix customAlphabet call causing infinite loop if called without size param

It was rather painful, since it just gets stuck in an infinite loop and doesn't break in any predictable way - which in a larger application can be pretty difficult to find. So if you don't want to have a default size, maybe just exit the function with an error if the size param isn't provided instead?

DKhalil

comment created time in 16 days

startedai/nanoid

started time in 17 days

PR opened ai/nanoid

Fix customAlphabet call causing infinite loop if called without size param

…param

+1 -1

0 comment

1 changed file

pr created time in 17 days

push eventDKhalil/nanoid

Daniel Khalil

commit sha a95373029c0ad7809b14b908eff9f5a27aa87c8d

Fix customAlphabet call causing infinite loop if called without size param

view details

push time in 17 days

fork DKhalil/nanoid

A tiny (108 bytes), secure, URL-friendly, unique string ID generator for JavaScript

https://zelark.github.io/nano-id-cc/

fork in 17 days

PR merged Brainsware/sealas-site

Update highlight.js to the latest version 🚀 greenkeeper

☝️ Important announcement: Greenkeeper will be saying goodbye 👋 and passing the torch to Snyk on June 3rd, 2020! Find out how to migrate to Snyk and more at greenkeeper.io


The dependency highlight.js was updated from 9.18.1 to 10.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: isagalaev License: BSD-3-Clause

Find out more about this release.


<details> <summary>FAQ and help</summary>

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper. </details>


Your Greenkeeper bot :palm_tree:

+147 -84

1 comment

2 changed files

greenkeeper[bot]

pr closed time in a month

push eventBrainsware/sealas-site

greenkeeper[bot]

commit sha cc3057489257f19e840c35fe3da3c6d9f0ca7a71

fix(package): update highlight.js to version 10.0.0

view details

greenkeeper[bot]

commit sha 3d2d41b683505284d119335e54a6bd90f2c84d3e

chore(package): update lockfile package-lock.json

view details

Daniel Khalil

commit sha 12ba473d8f103c8f96d858dc9805a59368117e2e

Merge pull request #43 from Brainsware/greenkeeper/highlight.js-10.0.0 Update highlight.js to the latest version 🚀

view details

push time in a month

issue commentnuxt/nuxt.js

Global mixin memory leak leading to RangeError Maximum call stack size exceeded

Playing around with it further, I came to the conclusion that it was this piece of code that led to the leak:

  Vue.mixin({
    methods: {
      doTheLeakyThing () {
        return ''
      }
    }
  })
}```

Changing it to

```Vue.mixin({
  methods: {
    doTheLeakyThing () {
      return ''
    }
  }
})```

fixes it.
DKhalil

comment created time in a month

push eventDKhalil/dayjs-locale-memory-leak-repro

Daniel Khalil

commit sha 3ba30abe82aa353d121099f9853c2ef392029065

chore: remove dayjs

view details

push time in a month

issue openednuxt/nuxt.js

Global mixin memory leak leading to RangeError Maximum call stack size exceeded

Version

v2.12.2

Reproduction link

https://github.com/DKhalil/dayjs-locale-memory-leak-repro

Steps to reproduce

$ yarn install
$ yarn build && yarn start
$ artillery run stress.yml

What is expected ?

A normal execution of requests.

What is actually happening?

The first thing you'll see is the requests getting slower and slower, after some point it'll crash with a Maximum call stack size exceeded error.

<!--cmty--><!--cmty_prevent_hook--> <div align="right"><sub><em>This bug report is available on <a href="https://cmty.app/nuxt">Nuxt</a> community (<a href="https://cmty.app/nuxt/nuxt.js/issues/c10561">#c10561</a>)</em></sub></div>

created time in a month

issue closediamkun/dayjs

Memory leak in locales

Describe the bug Running dayjs as a plugin in Nuxt (but possibly any node project) and loading a locale through .locale()

Reproduction repository: https://github.com/DKhalil/dayjs-locale-memory-leak-repro

The first thing you'll see is the requests getting slower and slower, after some point it'll crash with a Maximum call stack size exceeded error.

This is probably related to #154 but in this case it's not loading a new arbitrary locale, but the same one every time.

Information

  • Day.js Version 1.8.25
  • Nuxt Version 1.12.2

closed time in a month

DKhalil

issue commentiamkun/dayjs

Memory leak in locales

Sorry, nope, this is an issue in nuxt itself, dayjs was entirely innocent here.

DKhalil

comment created time in a month

issue openediamkun/dayjs

Memory leak in locales

Describe the bug Running dayjs as a plugin in Nuxt (but possibly any node project) and loading a locale through .locale()

Reproduction repository: https://github.com/DKhalil/dayjs-locale-memory-leak-repro

The first thing you'll see is the requests getting slower and slower, after some point it'll crash with a Maximum call stack size exceeded error

Information

  • Day.js Version 1.8.25
  • Nuxt Version 1.12.2

created time in a month

push eventDKhalil/dayjs-locale-memory-leak-repro

Daniel Khalil

commit sha 3bda000d260aaf8db639dc803bd14f0df300b074

Update README.md

view details

push time in a month

create barnchDKhalil/dayjs-locale-memory-leak-repro

branch : master

created branch time in a month

created repositoryDKhalil/dayjs-locale-memory-leak-repro

created time in a month

push eventsealas/elixir-standardfile-server

dependabot[bot]

commit sha 843eed97704840db7c48229f194d309ed906756a

chore(deps): bump acorn from 5.7.3 to 5.7.4 in /assets Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](https://github.com/acornjs/acorn/compare/5.7.3...5.7.4) Signed-off-by: dependabot[bot] <support@github.com>

view details

Daniel Khalil

commit sha 8b9cf1c20eed501474ca558dd6213c5b17bd4d9f

Merge pull request #1 from sealas/dependabot/npm_and_yarn/assets/acorn-5.7.4 chore(deps): bump acorn from 5.7.3 to 5.7.4 in /assets

view details

push time in 2 months

PR merged sealas/elixir-standardfile-server

chore(deps): bump acorn from 5.7.3 to 5.7.4 in /assets dependencies

Bumps acorn from 5.7.3 to 5.7.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/acornjs/acorn/commit/6370e90067552022710190319cbbbd8c43001957"><code>6370e90</code></a> Mark version 5.7.4</li> <li><a href="https://github.com/acornjs/acorn/commit/fbc15b1344f6dfb992f67b4bbf1357436247c8a0"><code>fbc15b1</code></a> More rigorously check surrogate pairs in regexp validator</li> <li>See full diff in <a href="https://github.com/acornjs/acorn/compare/5.7.3...5.7.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

more