profile
viewpoint
Gergely Csatari CsatariGergely @nokia Helsinki

koute/not-perf 530

A sampling CPU profiler for Linux

knix-microfunctions/knix 121

Serverless computing platform combining container-based resource isolation and lightweight execution model with processes to significantly reduce function startup latency and improve resource efficiency. Works in Knative and bare metal/VM environments.

cntt-n/CNTT 82

CNTT

CsatariGergely/danm 1

TelCo grade network management in a Kubernetes cluster

nokia/caas-ingress 1

This is a helm chart which exposes REC internal CaaS services over external interfaces for monitoring purposes.

nokia/kubernetes-community 1

Kubernetes community content

issue openedcntt-n/CNTT

[RM CH5] Minor editorial changes

created time in a minute

pull request commentkubernetes/kubernetes

fix nodelifecyle controller not add NoExecute taint bug

thanks for the fix and test, will route this to node reviewers

/unassign /assign @derekwaynecarr /sig node

howieyuen

comment created time in 4 minutes

pull request commentcntt-n/CNTT

[RC1 Ch3] CPU SKU options -> CPU types

@EditKoselak This correction is being made in a commented off section. The change should be made to RI-1 Chapter03 Section 3.5: req.inf.com.04

@pgoyal01, thanks, we have created a new issue for that correction: #2111

EditKoselak

comment created time in 6 minutes

pull request commentkubernetes/kubernetes

[WIP] force pods to use TCP for dns resolution

@chrisohaver some of the papers talk about the scalability problems on the dns resolver due to the use of TCP, do you think this can be a problem for CoreDNS?

There is more overhead with TCP vs UDP due to the nature of the protocol (more packets), but there is nothing specific in the CoreDNS implementation that would add to that.

aojea

comment created time in 8 minutes

issue commentkubernetes/kubernetes

leader-elect-resource-lock should be leases

Was backported to 1.18 https://github.com/kubernetes/kubernetes/pull/94511

pires

comment created time in 9 minutes

PR opened cntt-n/CNTT

Reviewers
[RI1 Ch3] CPU SKU options -> CPU types

Closes #2111

+53 -53

0 comment

1 changed file

pr created time in 10 minutes

issue closedkubernetes/kubernetes

leader-elect-resource-lock should be leases

What happened:

Documentation states kube-scheduler and kube-controller-manager have a flag --leader-elect-resource-lock which can be set to endpoints (default) or configmaps. This is way outdated. Possible values seem to be configmapleases, endpointleases and, more importantly leases. The latter should be the default by now given the multi-lock implementations were there for migration purposes, unless the concern is introducing a breaking change.

What you expected to happen:

The documentation should state clearly all the options and, hopefully, the cost of going w/ each.

How to reproduce it (as minimally and precisely as possible):

  • https://kubernetes.io/docs/reference/command-line-tools-reference/kube-scheduler/
  • https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/

Anything else we need to know?:

I don't think so.

Environment:

  • Kubernetes version (use kubectl version): v1.17.5

/sig sig-docs

closed time in 10 minutes

pires

issue openedcntt-n/CNTT

[RI1 Ch3] CPU SKU options -> CPU types

created time in 13 minutes

issue commentkubernetes/kubernetes

Changes in Pod.spec.containers.ports aren't recognized by API server

Because a pod submitted with duplicate ports can actually produce a functioning pod, the case for rejecting requests that previously produced working pods is less clear.

Rejecting in server-side apply paths seems fine, but I would probably issue warnings in create/update paths rather than reject.

Moser-ss

comment created time in 13 minutes

pull request commentkubernetes/kubernetes

api: Allow MaxSurge to be set on DaemonSets during update

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-node-e2e 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce-100-performance 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-alpha-features 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-alpha-features

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

smarterclayton

comment created time in 16 minutes

pull request commentkubernetes/kubernetes

api: Allow MaxSurge to be set on DaemonSets during update

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-ubuntu-containerd 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-node-e2e 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce-100-performance 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

smarterclayton

comment created time in 16 minutes

pull request commentkubernetes/kubernetes

api: Allow MaxSurge to be set on DaemonSets during update

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-alpha-features 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-100-performance 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-ubuntu-containerd 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-node-e2e 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

smarterclayton

comment created time in 16 minutes

pull request commentkubernetes/kubernetes

api: Allow MaxSurge to be set on DaemonSets during update

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-node-e2e 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-node-e2e
pull-kubernetes-e2e-gce-alpha-features 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-100-performance 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-e2e-gce-ubuntu-containerd 67a487164e181a3f9780cdd41cf00f3e931e2343 link /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

smarterclayton

comment created time in 16 minutes

pull request commentkubernetes/kubernetes

api: Allow MaxSurge to be set on DaemonSets during update

/retest This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

smarterclayton

comment created time in 18 minutes

pull request commentkubernetes/kubernetes

Set ContainerStatuses[i].Ready to false when container not started

@chenyw1990: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-ubuntu-containerd 801871374466d527605527eecc0a83cc2ad4d700 link /test pull-kubernetes-e2e-gce-ubuntu-containerd
pull-kubernetes-bazel-test 801871374466d527605527eecc0a83cc2ad4d700 link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

chenyw1990

comment created time in 24 minutes

issue openedcntt-n/CNTT

[RI1] Removing outdated comments

The chapters of the documentation contains large outdated comments. These could be removed for easier navigation in the source files and to avoid maintenance issues.

created time in 24 minutes

Pull request review commentkubernetes/kubernetes

improve watchCache metric

 func NewCacherFromConfig(config Config) (*Cacher, error) { 			}, time.Second, stopCh, 		) 	}()-+	+	objectType := objType.String()+	watchCacheCapacity.WithLabelValues(objectType).Set(float64(cacher.watchCache.capacity))

OK - the later looks fine.

But please move this one to newWatchCache function

yuanhuaiwang

comment created time in 39 minutes

pull request commentkubernetes/kubernetes

CHANGELOG: Fix typo for release-note in 1.20

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/kubernetes/pull/96835#pullrequestreview-540845187" title="LGTM">hasheddan</a>, <a href="https://github.com/kubernetes/kubernetes/pull/96835#" title="Author self-approved">qingsenLi</a>, <a href="https://github.com/kubernetes/kubernetes/pull/96835#pullrequestreview-540675686" title="LGTM">saschagrunert</a>, <a href="https://github.com/kubernetes/kubernetes/pull/96835#pullrequestreview-540878162" title="LGTM">xmudrii</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

qingsenLi

comment created time in an hour

pull request commentkubernetes/kubernetes

Recover CSI volumes from dangling attachments

/hold

Hey there, 1.20 release lead here. We are way too close to the release date to land anything but the most critical, release blocking items. This does not appear to meet that criteria. Could you explain why this absolutely needs to be in 1.20? Or move it to 1.21?

yuga711

comment created time in an hour

pull request commentkubernetes/kubernetes

fix deletionTimestamp issue in CSI VolumeAttachment

@andyzhangx: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind 7e0355f774e0106c87e02edd229a94ca38c74d60 link /test pull-kubernetes-e2e-kind

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

andyzhangx

comment created time in an hour

pull request commentkubernetes/kubernetes

Code optimization for add additional information to log trace in api server

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/kubernetes/kubernetes/pull/96802#" title="Author self-approved">lala123912</a>, <a href="https://github.com/kubernetes/kubernetes/pull/96802#issuecomment-735755045" title="Approved">sttts</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

lala123912

comment created time in an hour

issue commentkubernetes/kubernetes

In cetos 7.6 arm V8 64 environment, kubemark always crashes due to null pointer exception

this bug has fix in commit d46daf891cc57c3ca8128d467a834277df1cbd48

li-yi-cloud

comment created time in an hour

pull request commentkubernetes/kubernetes

apiserver: add --permit-address-sharing flag to listen with SO_REUSEADDR

/remove-lifecycle stale

sttts

comment created time in an hour

pull request commentkubernetes/kubernetes

Set ContainerStatuses[i].Ready to false when container not started

@chenyw1990: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 801871374466d527605527eecc0a83cc2ad4d700 link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-gce-ubuntu-containerd 801871374466d527605527eecc0a83cc2ad4d700 link /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

chenyw1990

comment created time in an hour

Pull request review commentkubernetes/kubernetes

plumb context with request deadline

 func testWebhookTimeout(t *testing.T, watchCache bool) { 		}, 		{ 			name:           "timed out client requests skip later mutating webhooks (regardless of failure policy) and fail",-			timeoutSeconds: 3,+			timeoutSeconds: 4,

why 4 and not 3?

tkashem

comment created time in an hour

Pull request review commentkubernetes/kubernetes

plumb context with request deadline

+/*+Copyright 2020 The Kubernetes Authors.++Licensed under the Apache License, Version 2.0 (the "License");+you may not use this file except in compliance with the License.+You may obtain a copy of the License at++    http://www.apache.org/licenses/LICENSE-2.0++Unless required by applicable law or agreed to in writing, software+distributed under the License is distributed on an "AS IS" BASIS,+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+See the License for the specific language governing permissions and+limitations under the License.+*/++package filters++import (+	"errors"+	"fmt"+	"net/http"++	apierrors "k8s.io/apimachinery/pkg/api/errors"+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"+	"k8s.io/apimachinery/pkg/runtime"+	"k8s.io/apimachinery/pkg/runtime/schema"+	utilruntime "k8s.io/apimachinery/pkg/util/runtime"+	auditinternal "k8s.io/apiserver/pkg/apis/audit"+	"k8s.io/apiserver/pkg/audit"+	"k8s.io/apiserver/pkg/audit/policy"+	"k8s.io/apiserver/pkg/endpoints/handlers/responsewriters"+	"k8s.io/apiserver/pkg/endpoints/request"+)++// AuditWrapperFunc returns an http.Handler that audits a failed request.+// The filters that appear before the audit filter in the handler chain can use it+// to audit a failed request.+// The specified errorHandler is invoked to render an error response to the request.+// The specified stringer adapter provides an error message that is to be set in the+// ResponseStatus field of the audit event.+type AuditWrapperFunc func(errorHandler http.Handler, stringer func() string) http.Handler

Similarly for stringer. What does it convert to a string and when?

tkashem

comment created time in an hour

Pull request review commentkubernetes/kubernetes

plumb context with request deadline

+/*+Copyright 2020 The Kubernetes Authors.++Licensed under the Apache License, Version 2.0 (the "License");+you may not use this file except in compliance with the License.+You may obtain a copy of the License at++    http://www.apache.org/licenses/LICENSE-2.0++Unless required by applicable law or agreed to in writing, software+distributed under the License is distributed on an "AS IS" BASIS,+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.+See the License for the specific language governing permissions and+limitations under the License.+*/++package filters++import (+	"errors"+	"fmt"+	"net/http"++	apierrors "k8s.io/apimachinery/pkg/api/errors"+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"+	"k8s.io/apimachinery/pkg/runtime"+	"k8s.io/apimachinery/pkg/runtime/schema"+	utilruntime "k8s.io/apimachinery/pkg/util/runtime"+	auditinternal "k8s.io/apiserver/pkg/apis/audit"+	"k8s.io/apiserver/pkg/audit"+	"k8s.io/apiserver/pkg/audit/policy"+	"k8s.io/apiserver/pkg/endpoints/handlers/responsewriters"+	"k8s.io/apiserver/pkg/endpoints/request"+)++// AuditWrapperFunc returns an http.Handler that audits a failed request.+// The filters that appear before the audit filter in the handler chain can use it+// to audit a failed request.+// The specified errorHandler is invoked to render an error response to the request.+// The specified stringer adapter provides an error message that is to be set in the+// ResponseStatus field of the audit event.+type AuditWrapperFunc func(errorHandler http.Handler, stringer func() string) http.Handler

A wrapper wraps something. What?

tkashem

comment created time in an hour

more