profile
viewpoint

taocpp/PEGTL 1153

Parsing Expression Grammar Template Library

ColinH/PEGTL-0.32 0

Fork to enable minor modifications to the v0.32 (old) version of the Parsing Expression Grammar Template Library

ColinH/testing 0

For testing some things.

ColinH/velocypack 0

A fast and compact format for serialization and storage

issue closedtaocpp/PEGTL

`contrib/integer.hpp` should include `<numeric_limits>`

#include <tao/pegtl/contrib/integer.hpp>
int main () {}

Gives

In file included from a.cpp:1:
../../../external/taocpp/pegtl/include/tao/pegtl/contrib/integer.hpp:63:60: error: ‘numeric_limits’ is not a member of ‘std’
   63 |       template< typename Integer, Integer Maximum = ( std::numeric_limits< Integer >::max )() >

closed time in 7 hours

le-migou

issue commenttaocpp/PEGTL

`contrib/integer.hpp` should include `<numeric_limits>`

Sorry, my bad I was really too far behind !

le-migou

comment created time in 7 hours

issue commenttaocpp/PEGTL

`contrib/integer.hpp` should include `<numeric_limits>`

But we do include <limits>. Can you dig deeper and figure out what is actually going on on your system?

le-migou

comment created time in 8 hours

issue commenttaocpp/PEGTL

Fix or nix Android CI builds

@d-frey I created a proposal. See PR #233

d-frey

comment created time in 8 hours

PR opened taocpp/PEGTL

Fix Android CI builds

This is a proposal to fix failing android CI builds. See issue #216

It uses a docker where the android NDK r22 beta 1 is installed to build PEGTL.

See also travis build: https://travis-ci.org/github/Bjoe/PEGTL/jobs/745332637

It needs maybe some "cleanup" regarding to the output.

Maybe some output of the current NDK/SDK version would be useful.

+16 -26

0 comment

1 changed file

pr created time in 8 hours

issue commenttaocpp/PEGTL

`contrib/integer.hpp` should include `<numeric_limits>`

Sorry, I meant <limits> of course.

le-migou

comment created time in 9 hours

issue openedtaocpp/PEGTL

`contrib/integer.hpp` should include `<numeric_limits>`

#include <tao/pegtl/contrib/integer.hpp>
int main () {}

Gives

In file included from a.cpp:1:
../../../external/taocpp/pegtl/include/tao/pegtl/contrib/integer.hpp:63:60: error: ‘numeric_limits’ is not a member of ‘std’
   63 |       template< typename Integer, Integer Maximum = ( std::numeric_limits< Integer >::max )() >

created time in 9 hours

push eventtaocpp/json

Daniel Frey

commit sha da6d3e70f93ccb96df5455856bf6ff583e696dae

Removed access of moved-from objects

view details

Daniel Frey

commit sha fe2b4d1335266673fa43d59eff03b423127cc46f

Fix usage of moved-from objects

view details

push time in a day

push eventtaocpp/json

Daniel Frey

commit sha 17b108b474b6cb5dfc8a06769365794c00adf3cb

Multiple namings seem to be possible and cause conflicts

view details

push time in a day

PR closed taocpp/PEGTL

Updated contrib/json so that it is not greedy.

contrib/json no longer consumes the whitespace after the json value.

+13 -7

5 comments

2 changed files

kelvinhammond

pr closed time in a day

pull request commenttaocpp/PEGTL

Updated contrib/json so that it is not greedy.

Your changes fixed my issue. Thank you.

kelvinhammond

comment created time in a day

push eventtaocpp/json

Daniel Frey

commit sha c218c9f8a677c4579a007eb01cc2e56f1ca154cf

Go back to clang-format-10 for now

view details

Daniel Frey

commit sha 39d96c1273c18d5aa18f44a9e3a957f742d85e8a

Silence clang-tidy

view details

push time in a day

push eventtaocpp/json

Daniel Frey

commit sha 0a740a50fb9862260b28af1cf20c50b3616df033

Fix another compile issue

view details

push time in a day

push eventtaocpp/json

Daniel Frey

commit sha d2d64df96949a411855deb00dc44bd0c35adfda3

Oops

view details

push time in a day

push eventtaocpp/json

Daniel Frey

commit sha 8aee8ec883f75931f19f1d23aed67f7821ebe397

Fix clang warnings

view details

Daniel Frey

commit sha d7318199f1e7c0f5473e8852cc41130869a8b9d4

Use algorithm

view details

Daniel Frey

commit sha fa0c6254f9ea924ed4856f908148a22917419e0a

Silence clang-tidy

view details

push time in 2 days

push eventtaocpp/json

Daniel Frey

commit sha be6a1b6ce55189267954179678c9f95370b6fcdf

Fix version number

view details

push time in 2 days

push eventtaocpp/json

Daniel Frey

commit sha 84447cae98911bbfde2ca0b46796001306e0281c

Disable warning for GCC only

view details

push time in 2 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha 8cdfd40c24e1197a00068037d663b58564859019

Disable warning for GCC only

view details

push time in 2 days

push eventtaocpp/json

Daniel Frey

commit sha 3f8f73a9ba2a30999354d7ded21997c64c56e62f

Silence a false positive

view details

Daniel Frey

commit sha a69a289ec18faa9fcf996aa6d0e1c447ff2998ae

Add clang-11, Xcode 12.2

view details

push time in 2 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha 80b3d78fd2f70eea1b3ac9fe5b0159fbc8832235

Silence a false positive

view details

push time in 2 days

push eventtaocpp/json

Daniel Frey

commit sha d7ece90855e3776c4d21100cc07118e6da3dbb2e

Update embedded PEGTL

view details

push time in 2 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha 899a405ae9289d35e340144172a235872d801027

We love recursion

view details

push time in 2 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha fbe2014fa485033e32ae81b179d824cc57c969b7

Update Xcode 11.4 to 11.6

view details

push time in 3 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha 03017159a658715cb5ddea4532f5d2d92bcccc3f

Add Xcode 12.2

view details

push time in 3 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha feef067fe2558e6025e002d96cda5a3e1330a2f1

Fix version

view details

push time in 3 days

issue commenttaocpp/PEGTL

Fix or nix Android CI builds

I agree that we should use the new r22 instead of wacky work-arounds like -lstdc++fs and I think it is reasonable to just point out to users that this is the minimum version that is supported for Android with the PEGTL 3.x branch. People on older Android systems will have to use the 2.x branch. I'm looking forward for the PR, thanks again for helping out with this!

d-frey

comment created time in 3 days

issue commenttaocpp/PEGTL

Fix or nix Android CI builds

@d-frey Thank you for condolence ... it's three months ago so we are getting back to normal...

I found some more information about the NDK r22 release. So there exists a NDK "22.0.6917172-beta1" version. There are also a changlog for this version.

I used this version locally to build PEGTL for android and it compiles ! :-)

I try now to add this beta version in travis .. see https://travis-ci.org/github/Bjoe/PEGTL/builds/744958133

It will help you to test if PEGTL is compiling for android. It won't help your "customer" as NDK r22 is not yet released.

To introduce -llibstdc++fs in the NDK, I do not recommend this. If you really will have "now" a solution for your "customer", then I purpose to use boost::filesystem. This works 100% on android. I already use boost::filesystem on android. But this means, your project is depended on a third party lib, not sure if you like it.

If recommended following: Use the NDK r22 "Beta" in travis, so you know that PEGTL will compile on android (I'm already on it). Add a hint for the android users that your project can compile/use on android when NDK r22 is released (or if they like use the beta NDK r22). I think it will not take a long time if NDK r22 is released.

d-frey

comment created time in 3 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha bd586209195517ae40f6eb1e37d2640224d0ead4

Added more contributors

view details

push time in 3 days

push eventtaocpp/PEGTL

Daniel Frey

commit sha dcf18a4aa6693e4fd69af6d2e1417b7ef2c42fb5

Temporarily disable Android CI jobs, see #216

view details

Daniel Frey

commit sha d748eeb8d25722fc3e0e303139a69e5d9af76a71

clang-format

view details

Daniel Frey

commit sha 037aab371ed8b8c95997ee9267aeb0dddffc1e6e

Add clang-11

view details

push time in 3 days

issue commenttaocpp/PEGTL

Fix or nix Android CI builds

@Bjoe We appreciate your help with our little project, but of course people are more important than machines, so please take all the time you need to help your family - the PEGTL can wait. I am looking forward to see you again in person in the C++ user group once the pandemic is hopefully dealt with in spring/summer next year. For now, I'll disable the CI jobs for Android. Once r22 becomes available, we can try again to create a new CI job for it. Thanks again for your support!

d-frey

comment created time in 3 days

more