profile
viewpoint
Сковорода Никита Андреевич ChALkeR Moscow https://twitter.com/skovorodan Node.js TSC Member. Occasionally breaking things. :smiley_cat:

ChALkeR/admin 0

Facilitating joint collaboration amongst the TSC and CommComm

ChALkeR/asn1.js 0

ASN.1 Decoder/Encoder/DSL

ChALkeR/async 0

Composable asynchronous I/O for Ruby.

ChALkeR/babel 0

:tropical_fish: Babel is a compiler for writing next generation JavaScript.

ChALkeR/bootstrap-show-password 0

Show/hide password plugin for twitter bootstrap.

ChALkeR/buffer 0

The buffer module from node.js, for the browser.

ChALkeR/carlo 0

Web rendering surface for Node applications

ChALkeR/citgm 0

Canary in the Gold Mine

issue openedelectron/electron

webRequest.onBeforeRequest stopped working with file:// urls since 7.0.0 (and up to 9.0.0-beta.2 at least)

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 7.0.0
    • 7.1.13
    • 8.0.1
    • 9.0.0-beta.2
  • Operating System:
    • Linux xps 5.5.4-arch1-1 #1 SMP PREEMPT Sat, 15 Feb 2020 00:36:29 +0000 x86_64 GNU/Linux, Arch Linux current
  • Last Known Working Electron version:
    • 6.1.8

Expected Behavior

E.g. how 6.x behaves: onBeforeRequest callback gets fired before requests are made.

Electron 6.1.8
Request: file:///tmp/1.html
Load finished!

See code to reproduce below.

Actual Behavior

With file:///tmp/1.html (does not work):

Electron 7.0.0
Load finished!
Electron 7.1.13
Load finished!
Electron 8.0.1
Load finished!
Electron 9.0.0-beta.2
Load finished!

With https://example.com/ (works):

Electron 9.0.0-beta.2
Request: https://example.com/
Load finished!
Electron 7.0.0
Request: https://example.com/
Load finished!

To Reproduce

const { BrowserWindow, app } = require('electron')

app.on('ready', () => {
  const window = new BrowserWindow({})
  console.log(`Electron ${process.versions.electron}`)
  window.webContents.session.webRequest.onBeforeRequest((details, callback) => {
    console.log(`Request: ${details.url}`)
    callback({})
  })
  window.webContents.loadURL('file:///tmp/1.html') // compare with https://example.com/
  window.webContents.on('did-finish-load', () => {
    console.log('Load finished!')
  })
  window.show()
})

created time in 17 hours

issue commentlaurent22/joplin

Joplin freezing/unresponsive on Arch Linux when syncing; Anyone else have this issue?

@bedwardly-down is there a reproducible way to trigger this on your system without connecting Dropbox / performing manual actions? I.e. to clone, build, launch and observe the problem?

dimyself

comment created time in 21 hours

issue commentlaurent22/joplin

Synchronize fails after a few seconds

@bedwardly-down the fix for this has been merged to Electron 7.x branch today, just updating to 7.x patch when it gets out would be enough here.

matcharles

comment created time in a day

issue commentlaurent22/joplin

Joplin freezing/unresponsive on Arch Linux when syncing; Anyone else have this issue?

@bedwardly-down then #2507 should be reopened because seems that it's a different from this one, and I can clearly reproduce that issue on JoplinDesktop.AppImage 1.0.179 on Arch Linux.

dimyself

comment created time in a day

issue openedelectron/electron

safeDialogs option is broken since 7.0.0 (up to 9.0.0-beta.2, at least)

Preflight Checklist

  • [x] I have read the Contributing Guidelines for this project.
  • [x] I agree to follow the Code of Conduct that this project adheres to.
  • [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 9.0.0-beta.2
    • 8.0.1
    • 7.1.13
    • 7.0.0
  • Operating System:
    • Linux xps 5.5.4-arch1-1 #1 SMP PREEMPT Sat, 15 Feb 2020 00:36:29 +0000 x86_64 GNU/Linux
    • macOS 10.15.3
  • Last Known Working Electron version:
    • 6.1.8 -- fine, not affected

Expected Behavior

  • When safeDialogs option is used, I expect to see a "Prevent this app from creating additional dialogs" checkbox on all alerts after the first one, like it happened in Electron 6.1.8.
  • I expect safeDialogs option to do at least something.

Actual Behavior

  • That checkbox does not appear on second alert, or on any other subsequent alert (tried about 10).
  • There seems to no observable difference at all between turning that option on or off.

To Reproduce

const { BrowserWindow, app } = require('electron')
app.on('ready', () => {
  const window = new BrowserWindow({
    webPreferences: {
      //partition: 'memory',
      safeDialogs: true,
    }
  })
  window.webContents.loadURL('about:blank') // also could be e.g. https://example.com/
  window.webContents.on('did-finish-load', () => {
    window.webContents.executeJavaScript(`
      document.body.innerText = window.navigator.userAgent // (not required)
      alert(0)
      setTimeout(() => { alert(1) }, 100) // timeout for UA to be shown
    `)
  })
  window.show()
})

Screenshots

v6.1.8 (correct behaviour)

Screenshot_20200223_221526

v7.0.0

Screenshot_20200223_222330

v7.1.13

Screenshot_20200223_221938

v8.0.1

Screenshot_20200223_222409

9.0.0-beta.2

Screenshot_20200223_222754

Additional Information

  • Documented here: https://www.electronjs.org/docs/api/browser-window#new-browserwindowoptions
  • This does not seem to be a duplicate of closed #17543, as this affects only versions starting from v7.0.0.
  • This does not seem to be a problem of specific configuration/url/scheme/whatever -- I was not able to make that option work on a recent Electron version with any attempted configuration.

created time in 2 days

issue commentlaurent22/joplin

Joplin freezing/unresponsive on Arch Linux when syncing; Anyone else have this issue?

@bedwardly-down try opening devtools (not detached) and resizing the window (might need several attempts).

dimyself

comment created time in 2 days

issue commentEloston/ungoogled-chromium

Crashing with error "seccomp-bpf failure"

This is fixed in Chromium 80, it's a Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1025739, not a glibc bug.

https://github.com/chromium/chromium/commit/54407b422a9cbf775a68c1d57603c0ecac8ce0d7 is the fix that can be backported.

IamPARANOID

comment created time in 2 days

issue commentelectron/electron

Electron apps freeze on linux 5.x kernel

As for linux 5.5, there is another significant issue there which could be related to random freezes: https://gitlab.freedesktop.org/drm/intel/issues/1201

vbatts

comment created time in 3 days

issue commentelectron/electron

Electron apps freeze on linux 5.x kernel

The recent Arch (and other glibc 2.31 distros) issue is https://github.com/electron/electron/issues/22291, but it does not affect Electron 8 -- and that's where upgrading to 8 (or waiting for #22338 / #22339) helps.

If this affects Electron 8, then it's an entirely separate issue (which means that there are two issues affecting Arch).

vbatts

comment created time in 3 days

issue commentlaurent22/joplin

Joplin freezing/unresponsive on Arch Linux when syncing; Anyone else have this issue?

@bedwardly-down Hi! =)

I got here because #2507 (which was marked as a duplicate of this), and which was clearly affected by the glibc incompatibility which surfaced on Arch (and other up-to-date distros). That does not affect Electron 8 though, so if Electron 8 still has the problem, this seems to be separate problems.

dimyself

comment created time in 3 days

issue commentlaurent22/joplin

Joplin freezing/unresponsive on Arch Linux when syncing; Anyone else have this issue?

Can anyone reproduce this with glibc < 2.31?

If not (or if you are seeing **CRASHING**:seccomp-bpf failure in syscall 0230 in the terminal), https://github.com/electron/electron/issues/22291 might be related.

dimyself

comment created time in 3 days

issue commentlaurent22/joplin

Synchronize fails after a few seconds

CRASHING:seccomp-bpf failure in syscall 0230

This is https://github.com/electron/electron/issues/22291 and is caused by an incompatibility between older Chromium/Electron and glibc >=2.31 (which recently landed in Arch).

Electron 8 is not affected, but this repo uses 7.

Backport PRs for Electron 7/6 already exist (see the link above), but are not landed/released yet.

matcharles

comment created time in 3 days

issue commentfutpib/pagraphcontrol

**CRASHING**:seccomp-bpf failure in syscall 0230

This is caused by https://github.com/electron/electron/issues/22291 and caused by incompatibility between older Chromium/Electron and glibc >=2.31. Electron 8 is not affected, but this repo uses 6. Backport PRs for Electron already exist (see the above link), but not landed yet.

rodlessa

comment created time in 3 days

issue openedelectron/electron

Backport glibc 2.31 compatibility fix from Chromium to v7 (and other supported branches)?

Currently, in Electron 7 apps, windows randomly go blank and print:

../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0230
../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0230
../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0230
../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 0230

This seems to be caused by Chromium bug, https://bugs.chromium.org/p/chromium/issues/detail?id=1025739, and could be fixed by floating https://bugs.chromium.org/p/chromium/issues/attachmentText?aid=421799 (which is a trivial 2-line change).

Electron 8 should be fine.

Also see https://bugzilla.redhat.com/show_bug.cgi?id=1773289.

glibc 2.31 was recently released (2020-02-01) and is already hitting some distros (e.g. Arch Linux).

created time in 6 days

issue commentelectron/electron

[bug?] [linux] Resizing electron window causes previous window to go blank

Do you perhaps have glibc 2.31 installed?

trusktr

comment created time in 6 days

issue commentnodejs/TSC

Node.js future directions - any interest in online or in person summit?

@mhdawson should this be pinned, perhaps?

mhdawson

comment created time in 6 days

issue commentnodejs/TSC

Ability for website team to transfer issues to nodejs/help

We could either create a sub-team which could move issues, or just give write access to the help repo to the website team. Both sounds good to me, and the latter would probably be easier.

nschonni

comment created time in 6 days

issue commentnodejs/TSC

Review meeting date times ?

Given the current data, it's likely that we will have either 2 or 3 (out of 3) timeslots on Thursdays. We don't have about half of the data confirmed yet. @nodejs/tsc ping =).

mhdawson

comment created time in 6 days

issue commentnodejs/TSC

Archival of the node-chakracore repo

+1 to archive as soon as there is confirmation, but let's wait for a while until that happens

cjihrig

comment created time in 6 days

push eventChALkeR/io.js

Anna Henningsen

commit sha a489583eda4d7cebc06516834b31dc2a4cedb1b6

src: remove keep alive option from SetImmediate() This is no longer necessary now that the copyable `BaseObjectPtr` is available (as opposed to the only-movable `v8::Global`). PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 1317ac65b4f001588b86002aa22431719683beb4

src: remove HandleWrap instances from list once closed This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: https://github.com/nodejs/quic/pull/165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: https://github.com/nodejs/node/pull/30374 Refs: https://github.com/nodejs/quic/pull/141 Refs: https://github.com/nodejs/quic/pull/149 Refs: https://github.com/nodejs/quic/pull/141 Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha 6cb8e4b12cd16ae8ed126f98458efb78312cabf6

src: mark ArrayBuffers with free callbacks as untransferable More precisely, make them untransferable if they were created through *our* APIs, because those do not follow the improved free callback mechanism that V8 uses now. All other ArrayBuffers can be transferred between threads now, the assumption being that they were created in a clean way that follows the V8 API on this. This addresses a TODO comment. Refs: https://github.com/nodejs/node/pull/30339#issuecomment-552225353 PR-URL: https://github.com/nodejs/node/pull/30475 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Anna Henningsen

commit sha e5d3c8121dd0bcc4dbf52c7b3a0521e359363a05

src: expose ArrayBuffer version of Buffer::New() This can be useful to create `Buffer` instances for already-existing `ArrayBuffer`s, e.g. ones created manually from a backing store with a free callback (of which our variant in the public API has some limitations). PR-URL: https://github.com/nodejs/node/pull/30476 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Jesse O'Connor

commit sha 7cecac669f05f36016c684dcee381cf21ab188d2

doc: update http.md mention of socket This commit is addressing the problem in issue #29948. Fixes: https://github.com/nodejs/node/issues/29948 PR-URL: https://github.com/nodejs/node/pull/30155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Jeremy Apthorp

commit sha 4f434187ff06cc8ac9e2022e65d6f6bf2fb8a19e

src: add file name to 'Module did not self-register' error PR-URL: https://github.com/nodejs/node/pull/30125 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

view details

Lucas Holmquist

commit sha 535e9571f5252ea9ce6f5db12f700f73af6df055

fs: make FSStatWatcher.start private An instance of FSStatWatcher is returned when a user calls fs.watchFile, which will call the start method. A user can't create an instance of a FSStatWatcher directly. If the start method is called by a user it is a noop since the watcher has already started. This "Class" is currently undocumented. PR-URL: https://github.com/nodejs/node/pull/29971 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>

view details

Robert Nagy

commit sha 9d09969f4c29b7f2bacc9cb44e210c4e269945a4

stream: always invoke end callback Ensure that the callback passed into end() is always invoke in order to avoid bug such as deadlock the user. PR-URL: https://github.com/nodejs/node/pull/29747 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha b0cf62b3a05cf1b207441de2ce3d33a3a57acd5f

https: add client support for TLS keylog events The keylog event is implemented on TLS sockets, but client HTTPS uses TLS sockets managed by an agent, so accessing the underlying socket before the TLS handshake completed was not possible. Note that server HTTPS already supports the keylog event because it inherits from the TLS server. PR-URL: https://github.com/nodejs/node/pull/30053 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

VinceOPS

commit sha 205046af7eb6be0b4a7a785082962586ed6f1dec

lib: replace var with let and const in readline.js PR-URL: https://github.com/nodejs/node/pull/30377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

David OLIVIER

commit sha f4ea9189501743797d1ab8f5ed07027dd71f59bd

lib: replace var with let PR-URL: https://github.com/nodejs/node/pull/30381 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Sam Roberts

commit sha 80efb80f3f9dffb412aa1a41ab36c843c90c60e5

tls: cli option to enable TLS key logging to file Debugging HTTPS or TLS connections from a Node.js app with (for example) Wireshark is unreasonably difficult without the ability to get the TLS key log. In theory, the application can be modified to use the `'keylog'` event directly, but for complex apps, or apps that define there own HTTPS Agent (like npm), this is unreasonably difficult. Use of the option triggers a warning to be emitted so the user is clearly notified of what is happening and its effect. PR-URL: https://github.com/nodejs/node/pull/30055 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Tobias Nießen

commit sha c63af4fea041673eb7c33f6df3c474d4537fe5eb

crypto: add support for IEEE-P1363 DSA signatures PR-URL: https://github.com/nodejs/node/pull/29292 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Marcel Laverdet

commit sha c712fb7cd6222018cf615fd0071998bde6f16da9

src: add abstract `IsolatePlatformDelegate` Adds a new abstract class for module authors and embedders to register arbitrary isolates with `node::MultiIsolatePlatform`. PR-URL: https://github.com/nodejs/node/pull/30324 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

view details

cjihrig

commit sha 3871cc5f0c791632d2555e159873530bfdd02d4f

src: fix -Winconsistent-missing-override warning This commit addresses the following warning: ../src/node_api.cc:28:19: warning: 'mark_arraybuffer_as_untransferable' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] v8::Maybe<bool> mark_arraybuffer_as_untransferable( ^ ../src/js_native_api_v8.h:42:27: note: overridden virtual function is here virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( PR-URL: https://github.com/nodejs/node/pull/30549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

view details

Denys Otrishko

commit sha a30a9f8193ddd61dfadc2d5d79784b682027b319

test: clean up http-set-trailers * remove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was taken into account resulting in ECONNREFUSED due to premature server.close() * slightly move code for better cohesion * fix error comment in testHttp10 'Trailer ...' -> 'No trailer ...' PR-URL: https://github.com/nodejs/node/pull/30522 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

view details

claudiahdz

commit sha a7c7c703aff362f06ef5d49451a0f79fd289910f

deps: upgrade npm to 6.13.1 PR-URL: https://github.com/nodejs/node/pull/30533 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

view details

Luigi Pinca

commit sha f4b240f01276126b76978bb1d69cf79dd9e2cf6c

doc: fix overriding of prefix option Make the example in the "Building a debug build" section work as intended. Fixes: https://github.com/nodejs/node/issues/30477 PR-URL: https://github.com/nodejs/node/pull/30518 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

view details

Denys Otrishko

commit sha c8d00d9ed06a9983c02d7a250d96c81980e0e3a6

doc: explain GIT_REMOTE_REF in COLLABORATOR_GUIDE PR-URL: https://github.com/nodejs/node/pull/30371 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

Denys Otrishko

commit sha 8138e9ce508df75a9bef66dcbb7389bfceb71c23

doc: add mention for using promisify on class methods Fixes: https://github.com/nodejs/node/issues/30344 PR-URL: https://github.com/nodejs/node/pull/30355 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

view details

push time in 7 days

pull request commentnodejs/node

process: add .stillSynchronous

@BridgeAR This got stuck on the naming. I'll just pick initialEventLoop for now.

ChALkeR

comment created time in 7 days

issue commentnodejs/node

Node fails

@cscrum I suggest moving this to https://github.com/nodejs/help (with more information), as this doesn't seem to be an issue with Node.js itself.

cscrum

comment created time in 7 days

issue commentnodejs/TSC

Review meeting date times ?

Please also update the valid at column even if your timeslots were not updated so that we can tell how actual the data is =).

mhdawson

comment created time in 13 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-12

Ah, what @MylesBorins said. Perhaps we cancel and review the meeting times?

mhdawson

comment created time in 13 days

issue commentnodejs/TSC

Node.js Technical Steering Committee (TSC) Meeting 2020-02-12

I can't join the meeting for some reason.

mhdawson

comment created time in 13 days

Pull request review commentExodusMovement/monero-core-custom

Drop currently unused code

 namespace epee {   namespace serialization   {+    //-----------------------------------------------------------------------------------------------------------+    template<class t_struct>+    bool load_t_from_json(t_struct& out, const std::string& json_buff)

Is this used in react-native-fast-crypto?

Is react-native-fast-crypto/native-libs/test/main.cpp the only portable_storage user? If yes, perhaps we can drop portable_storage altogether?

Sekhmet

comment created time in 22 days

pull request commentExodusMovement/monero-core-custom

Drop some unused code

Updated, no insertions now, only deletions. No actual code changes since the review, only formatting.

Should be ready now, sorry for the delay.

ChALkeR

comment created time in 25 days

push eventExodusMovement/monero-core-custom

Сковорода Никита Андреевич

commit sha 250cf8356bd5004df2d28f64d16b5981f028e566

Drop some unused code

view details

push time in 25 days

startedChALkeR/parcel-cache-fail

started time in a month

startedmicrosoft/playwright

started time in a month

startedollypwn/CVE-2020-0601

started time in a month

startedsaleemrashid/badecparams

started time in a month

pull request commentExodusMovement/cross-zip

Fix double escape on windows

For posterity, that concern is resolved in #3.

maxogden

comment created time in a month

pull request commentfeross/cross-zip

Use execFile/execFileSync to avoid shell security issues

I cleaned this up in https://github.com/feross/cross-zip/pull/18 and added another fix on top.

maxogden

comment created time in a month

PR opened feross/cross-zip

Fix security issues

Based on work by @maxogden in #16, adding another fix for Windows. Also cleaned the branch.

Should be all good now.

+44 -17

0 comment

1 changed file

pr created time in a month

create barnchChALkeR/cross-zip

branch : execfile-fixed

created branch time in a month

push eventChALkeR/cross-zip

Сковорода Никита Андреевич

commit sha 9a09d3b7a01e8adf36db0d02def10abebe131a1c

Fix arbitrary PS command execution on Windows

view details

push time in a month

PR opened maxogden/cross-zip

Fix arbitrary PS command execution on Windows
+14 -2

0 comment

1 changed file

pr created time in a month

push eventChALkeR/cross-zip

Сковорода Никита Андреевич

commit sha 92690b88fad1cd1b3095d399fe19ae39bc880e34

Fix arbitrary PS command execution on Windows

view details

push time in a month

fork ChALkeR/cross-zip

Cross-platform .zip file creation

fork in a month

pull request commentExodusMovement/cross-zip

Fix double escape on windows

Note: while this fixes the direct issue here, the logic on these lines doesn't seem entirely correct. I.e. what will happen if paths contain '?

maxogden

comment created time in a month

pull request commentnodejs/node

os: add constrainedmem()

Status update: Fedora 31 was released in October, has Cgroups v2 enabled by default. And they removed Docker because of the lack of Cgroups v2 support.

evanlucas

comment created time in a month

fork ChALkeR/rcedit

Command line tool to edit resources of exe

fork in 2 months

push eventExodusMovement/styled-jsx

Сковорода Никита Андреевич

commit sha 8605419144b9a65599b07b2d3a23f900c151c80f

v3.2.3-exodus0

view details

push time in 2 months

created tagExodusMovement/styled-jsx

tagv3.2.3-exodus0

Full CSS support for JSX without compromises

created time in 2 months

push eventExodusMovement/styled-jsx

Сковорода Никита Андреевич

commit sha dc00ec85c0f360b16bbbb18776d5853bb9a65012

package.json: unwrap dirs in 'files'

view details

Сковорода Никита Андреевич

commit sha 9e95f2f81c0c9fff8cf075d4a67037d7893d53c1

Drop readme

view details

Сковорода Никита Андреевич

commit sha ccfe7999205b6775df7e7ecd692bd3e7b0a00993

package.json: don't package server-side rendering

view details

Сковорода Никита Андреевич

commit sha 076adf362424d1538561e3a084d43470ec3ddf6d

Move into Exodus npm scope

view details

push time in 2 months

create barnchExodusMovement/styled-jsx

branch : v3.2.3-exodus

created branch time in 2 months

issue openedzeit/styled-jsx

No source tag for version 3.2.4

Version 3.2.4 was published on npm two months ago, but not present here.

It apparently has been cut from 66f3b36ef53f3e576f0ec40ef782a2b87a7f015a plus the version update in package.json, builds reproduce.

created time in 2 months

issue openedzeit/styled-jsx

.DS_Store is present in styled-jsx@3.2.4 as packaged on npm.

To reproduce:

$ npm pack styled-jsx@3.2.4
npm notice
npm notice 📦  styled-jsx@3.2.4
npm notice === Tarball Contents ===
npm notice 6.1kB  dist/.DS_Store
npm notice 599B   dist/_constants.js
npm notice 22.3kB dist/_utils.js
npm notice 8.2kB  dist/babel-external.js
npm notice 46B    babel-test.js
npm notice 753B   dist/babel-test.js
npm notice 41B    babel.js
npm notice 10.4kB dist/babel.js
npm notice 469B   css.js
npm notice 4.4kB  dist/macro.js
npm notice 41B    macro.js
npm notice 1.1kB  dist/server.js
npm notice 42B    server.js
npm notice 3.0kB  dist/lib/style-transform.js
npm notice 56B    lib/style-transform.js
npm notice 2.2kB  dist/style.js
npm notice 41B    style.js
npm notice 7.1kB  dist/stylesheet-registry.js
npm notice 8.3kB  dist/lib/stylesheet.js
npm notice 51B    lib/stylesheet.js
npm notice 1.5kB  dist/webpack.js
npm notice 65B    webpack.js
npm notice 2.4kB  package.json
npm notice 1.1kB  license.md
npm notice 29.6kB readme.md
npm notice === Tarball Details ===
npm notice name:          styled-jsx
npm notice version:       3.2.4
npm notice filename:      styled-jsx-3.2.4.tgz
npm notice package size:  29.7 kB
npm notice unpacked size: 109.9 kB
npm notice shasum:        cbcdedcfb81d717fd355c4a0d8443f8e74527b60
npm notice integrity:     sha512-UMclQzI1lss38[...]tv+6K/553ANdg==
npm notice total files:   25
npm notice
$ tar -xf styled-jsx-3.2.4.tgz
$ find package -name .DS_Store
package/dist/.DS_Store

Ideally, it should be ignored via files option, .gitignore, or .npmignore.

Also -- I don't see a 3.2.4 commit or tag on GitHub that would correspond to the 3.2.4 version distributed via npm?

created time in 2 months

startedSHA-mbles/SHA-mbles.github.io

started time in 2 months

push eventExodusMovement/exodus-lottie-web

Сковорода Никита Андреевич

commit sha c6767a993ab9ee50668b111ff0632c9612828be9

Import selected files from lottie-web v5.5.9 as lottie-web-light-canvas As published on npm

view details

Сковорода Никита Андреевич

commit sha f9d9e509c482db0cd5fef2c3fe40baeb9a69fb07

Initial project setup for exodus-lottie-web-light-canvas

view details

Сковорода Никита Андреевич

commit sha f76b13103af22c3e80aba582426ccb93b5070d75

Import missing .d.ts files from lottie-web 5.5.9 As published on npm.

view details

Сковорода Никита Андреевич

commit sha 51ec50e4470f50dc9f001194abf9060a53a9eeed

v5.5.9-exodus1

view details

push time in 2 months

created tagExodusMovement/exodus-lottie-web

tagv5.5.9-exodus1

lottie-web bundle fork

created time in 2 months

pull request commentindutny/asn1.js

Use Buffer.(from|alloc) instead of deprecated Buffer API

By now I think it's ok to just drop Node.js < 4.5 support, together with the polyfill, and make it a major version (as noted in the original post).

Thoughts?

ChALkeR

comment created time in 2 months

created tagExodusMovement/ethjs-unit

tagv0.1.6-exodus0

A simple module for handling Ethereum units.

created time in 2 months

push eventExodusMovement/ethjs-unit

Сковорода Никита Андреевич

commit sha d14fda3b7d085bf3dac711892f7c2bb728c99238

package only lib/index.js and src/index.js Remove some scripts.

view details

Сковорода Никита Андреевич

commit sha f3124bb452283e54de128bf2deadef556f250d28

Move into exodus scope

view details

push time in 2 months

push eventExodusMovement/ethjs-unit

push time in 2 months

PR opened MaiaVictor/eth-lib

Remove files from lib/ that are not present in src/

Fixes: #16.

That includes:

  • Math.rand-based rng in lib/types.js
  • requiring of module not present in package.json

None of that seem used anywhere inside this package, nor present in src/.

+0 -382

0 comment

3 changed files

pr created time in 2 months

created tagExodusMovement/eth-lib

tagv0.2.7-exodus0

Lightweight Ethereum libraries

created time in 2 months

create barnchExodusMovement/eth-lib

branch : remove-extra-lib-files

created branch time in 2 months

push eventExodusMovement/eth-lib

Сковорода Никита Андреевич

commit sha f389fe941f53196432c011518cf65b50070e0405

Remove files from lib/ that are not present in src/

view details

push time in 2 months

pull request commentnodejs/node

deps: V8: cherrypick 4eee88051bd4 0aee27f5f753 cb51845b7440

There are three commits but only two of them bump v8_embedder_string?

devnexen

comment created time in 2 months

push eventExodusMovement/babel-plugin-transform-remove-require

dependabot[bot]

commit sha 3d7b6ef73eeae5bb94d1466407082bec4efe30f9

build(deps): bump handlebars from 4.1.2 to 4.5.3 (#2) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com> Updated handlebars and uglify-js resolutions.

view details

push time in 2 months

PR merged ExodusMovement/babel-plugin-transform-remove-require

build(deps): bump handlebars from 4.1.2 to 4.5.3 dependencies

Bumps handlebars from 4.1.2 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+11 -11

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventExodusMovement/text-encoding-utf8

dependabot[bot]

commit sha 74584a5aab96e7e8c61e40b97a005f91af2c1a19

Bump handlebars from 4.1.2 to 4.5.3 (#2) Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.1.2 to 4.5.3. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/wycats/handlebars.js/blob/master/release-notes.md) - [Commits](https://github.com/wycats/handlebars.js/compare/v4.1.2...v4.5.3) Signed-off-by: dependabot[bot] <support@github.com> Bumped handlebars and uglify-js resolutions.

view details

push time in 2 months

PR merged ExodusMovement/text-encoding-utf8

Bump handlebars from 4.1.2 to 4.5.3 dependencies

Bumps handlebars from 4.1.2 to 4.5.3. <details> <summary>Changelog</summary>

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies, deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ have been added to the list of "properties that must be enumerable". If a property by that name is found and not enumerable on its parent, it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper. This will prevent new Remote-Code-Execution exploits that have been published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only increase the patch-version, because the incompatible use-cases are not intended, undocumented and far less important than fixing Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+13 -8

1 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

pull request commentExodusMovement/text-encoding-utf8

Bump handlebars from 4.1.2 to 4.5.3

Bumping handlebars and uglify-js produces the exact same yarn.lock. Not sure why uglify-js got bumped here, though.

dependabot[bot]

comment created time in 2 months

issue closednodejs/node

`Buffer` and `ArrayBuffer`-based objects trigger mark-sweeps instead of scavenges

Testcase:

'use strict';

var count = 0, limit = 800000;

function call() {
    var _buffer = new Buffer(16 * 1024);
    count++;
    if (count > limit) {
        process.exit(0);
    }
    setImmediate(call);
}

for (var i = 0; i < 20; i++) {
    call();
}

var gcs = new (require('gc-stats'))();
gcs.on('stats', function(stats) {
    console.log(JSON.stringify(stats));
});

You could see that this causes a lot of gctype: 2 GC events.

closed time in 2 months

ChALkeR

issue commentnodejs/node

`Buffer` and `ArrayBuffer`-based objects trigger mark-sweeps instead of scavenges

I believe this is now resolved with https://github.com/nodejs/node/pull/31007. Will reopen if I will see any major issues with that, but so far I don't see a reason to keep this open.

ChALkeR

comment created time in 2 months

startedmgrankin/ru_transformers

started time in 2 months

delete tag ExodusMovement/number-to-bn

delete tag : 1.7.0-exodus1

delete time in 2 months

created tagExodusMovement/number-to-bn

tagv1.7.0-exodus1

Converts a number to a BN.js object, throw if invalid number.

created time in 2 months

created tagExodusMovement/number-to-bn

tag1.7.0-exodus1

Converts a number to a BN.js object, throw if invalid number.

created time in 2 months

create barnchExodusMovement/number-to-bn

branch : exodus

created branch time in 2 months

PR opened ExodusMovement/zip-up

Move fs-extra to devDependencies

It seems used only in tests.

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchExodusMovement/zip-up

branch : chalker/fs-extra-devdep

created branch time in 2 months

Pull request review commentnodejs/node

buffer: use dynamic buffer pool

 function createUnsafeBuffer(size) {   } } -function createPool() {-  poolSize = Buffer.poolSize;+// This is faster than using the bigint version.

Is the difference measurable? If so, would just using process.hrtime()[0] and now - last > 1 (amort 1.5) make sense? Probably not, asking just in case.

BridgeAR

comment created time in 2 months

PR opened nodejs/node

Reviewers
Revert "deps: V8: cherry-pick 687d865fe251" V8 Engine revert

This reverts commit 0e21c1e637bf6d844473d09dca3508f2bf547b89.

It landed without a proper v8_embedder_string bump, reverting to re-land #31007 cleanly after that.

Refs: 0e21c1e637bf6d844473d09dca3508f2bf547b89 Refs: https://github.com/nodejs/node/pull/31007

Possible alternative actions:

  1. revert and re-land -- this approach
  2. just bump the v8_embedder_string separately (PR: #31096)
  3. do nothing at all (as @addaleax mentioned, v8_embedder_string has been just updated by another V8 patch).

Either of those seems fine to me, opening all the possible ones to speed up things.

+12 -45

0 comment

4 changed files

pr created time in 2 months

push eventChALkeR/io.js

Сковорода Никита Андреевич

commit sha f05823105db8dfb8c7dd1ccc093fb67f4ebe3f0d

Revert "deps: V8: cherry-pick 687d865fe251" This reverts commit 0e21c1e637bf6d844473d09dca3508f2bf547b89. It landed without a proper v8_embedder_string bump, reverting to re-land cleanly. Refs: 0e21c1e637bf6d844473d09dca3508f2bf547b89 Refs: https://github.com/nodejs/node/pull/31007

view details

push time in 2 months

create barnchChALkeR/io.js

branch : chalker/revert-0e21c1e637bf

created branch time in 2 months

pull request commentnodejs/node

deps: V8: cherry-pick 687d865fe251

This PR is now updated to include v8_embedder_string change, but it can land only after a revert.

An alternative is to update v8_embedder_string separately, PR: #31096.

ChALkeR

comment created time in 2 months

push eventChALkeR/io.js

Trivikram Kamat

commit sha ddedf8eaac7f4914deea10397c5a15824c84626d

http: use for...of in http library code PR-URL: https://github.com/nodejs/node/pull/30958 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Myles Borins

commit sha 8bfa4d048085eacc858ab979438565c15978f852

2019-12-17, Version 8.17.0 'Carbon' (LTS) This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 https://github.com/nodejs/node/pull/30904 PR-URL: https://github.com/nodejs/node/pull/30941

view details

Myles Borins

commit sha 178c5d86b09ac6aab18fa3a118dbd99b48157c31

2019-12-17, Version 10.18.0 'Dubnium' (LTS) This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 https://github.com/nodejs/node/pull/30904 PR-URL: https://github.com/nodejs/node/pull/30940

view details

Myles Borins

commit sha 75c5de22182f85f709615dd7cfcc667967010496

2019-12-17, Version 12.14.0 'Erbium' (LTS) This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: update npm to 6.13.4 https://github.com/nodejs/node/pull/30904 PR-URL: https://github.com/nodejs/node/pull/30938

view details

Myles Borins

commit sha bef1e87e1cf3f5cd4f5ff22c787a0f3adc2c2b7b

2019-12-17, Version 13.4.0 (Current) This is a security release. For more details about the vulnerability please consult the npm blog: https://blog.npmjs.org/post/189618601100/binary-planting-with-the-npm-cli Notable Changes: * deps: * update npm to 6.13.4 https://github.com/nodejs/node/pull/30904 * update uvwasi (Anna Henningsen) https://github.com/nodejs/node/pull/30745 * upgrade to libuv 1.34.0 (Colin Ihrig) https://github.com/nodejs/node/pull/30783 * doc: * docs deprecate http finished (Robert Nagy) https://github.com/nodejs/node/pull/28679 * events: * add captureRejection option (Matteo Collina) https://github.com/nodejs/node/pull/27867 * http: * add captureRejection support (Matteo Collina) https://github.com/nodejs/node/pull/27867 * llhttp opt-in insecure HTTP header parsing (Sam Roberts) https://github.com/nodejs/node/pull/30567 * http2: * implement capture rection for 'request' and 'stream' events (Matteo Collina) https://github.com/nodejs/node/pull/27867 * net: * implement capture rejections for 'connection' event (Matteo Collina) https://github.com/nodejs/node/pull/27867 * repl: * support previews by eager evaluating input (Ruben Bridgewater) https://github.com/nodejs/node/pull/30811 * stream: * add support for captureRejection option (Matteo Collina) https://github.com/nodejs/node/pull/27867 * tls: * implement capture rejections for 'secureConnection' event (Matteo Collina) https://github.com/nodejs/node/pull/27867 * expose IETF name for current cipher suite (Sam Roberts) https://github.com/nodejs/node/pull/30637 * worker: * add argv constructor option (legendecas) https://github.com/nodejs/node/pull/30559 PR-URL: https://github.com/nodejs/node/pull/30937

view details

Soar

commit sha 145116b3a16905291f3f1c96646aa89730271002

assert: use for...of Refs: #30960 PR-URL: https://github.com/nodejs/node/pull/30983 Refs: https://github.com/nodejs/node/pull/30960 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

view details

cjihrig

commit sha b6c589fde50b5b69a77fa6f316bccbc9ff259f48

deps,src,test: update to uvwasi 0.0.3 This commit updates to uvwasi 0.0.3, which implements a newer version of the WASI spec, snapshot_1. Since the WASI API has changed, this also requires updating the WebAssembly memory interfacing logic and recompiling the WASI tests with a version of wasi-libc that supports snapshot_1. PR-URL: https://github.com/nodejs/node/pull/30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha 2b06166c76758e9394e2136b724f10ba9eb44589

doc,lib,src,test: rename WASI CLI flag The WASI API has moved from preview0 to preview1. This commit updates the CLI flag accordingly. PR-URL: https://github.com/nodejs/node/pull/30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

cjihrig

commit sha ec4bf4ae9b7d9b155492b6e0c3c7e049708c3966

test: remove obsolete WASI test test-wasi-binding.js was added during the initial WASI development, but it is now considered obsolete. It also does not provide any additional test coverage. This commit removes it. PR-URL: https://github.com/nodejs/node/pull/30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Robert Nagy

commit sha ea86f8c902e13d8cff0e01007ed0d978f59fe132

benchmark: update manywrites back pressure Make manywrites benchmark a bit more realistic by taking back pressure into account. Otherwise memory usage would no correspond well with real world usage. PR-URL: https://github.com/nodejs/node/pull/30977 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Tadao Iseki

commit sha eaf59754be421498287a7bf2471b83e629da1911

doc: update message.url example in http.IncomingMessage Update message.url example to use The WHATWG URL API. This is because the old example suggests using deprecated url API. Fixes: https://github.com/nodejs/node/issues/30048 PR-URL: https://github.com/nodejs/node/pull/30830 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Richard Lau

commit sha e23aebc684a45f725811211f9740bcee3bcdbe26

test: use tmpdir.refresh() in test-esm-windows.js Use `tmpdir.refresh()` in `test/es-module/test-esm-windows.js` so that the temporary directory is cleaned before use and when the test exits. PR-URL: https://github.com/nodejs/node/pull/30997 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 2b9847c63784c4adf65ed1fa8fcdee823da546ec

fs: allow overriding fs for streams Allow overriding open, write, and close when using createReadStream() and createWriteStream(). PR-URL: https://github.com/nodejs/node/pull/29083 Refs: https://github.com/nodejs/node/issues/29050 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Myles Borins

commit sha 24263ff7182e04b68ba8445e000e6a5dc9dd406c

2019-12-18, Version 13.5.0 (Current) Notable Changes: * cli: * add --trace-exit cli option (legendecas) https://github.com/nodejs/node/pull/30516 * http,https: * increase server headers timeout (Tim Costa) https://github.com/nodejs/node/pull/30071 * readline: * update ansi-regex (Ruben Bridgewater) https://github.com/nodejs/node/pull/30907 * promote \_getCursorPos to public api (Jeremy Albright) https://github.com/nodejs/node/pull/30687 * repl: * add completion preview (Ruben Bridgewater) https://github.com/nodejs/node/pull/30907 * util: * add Set and map size to inspect output (Ruben Bridgewater) https://github.com/nodejs/node/pull/30225 * wasi: * require CLI flag to require() wasi module (Colin Ihrig) https://github.com/nodejs/node/pull/30963 PR-URL: https://github.com/nodejs/node/pull/31010

view details

legendecas

commit sha 8b5b61a9a14b364dc702cdaa9f0cb49ad4310e03

doc: reference worker threads on signal events PR-URL: https://github.com/nodejs/node/pull/30990 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Lucas Azzola

commit sha 3e5967bacb199fcffd9ec080adc62e1382e0cd76

doc: clarify required flag for extensionless esm Fixes: https://github.com/nodejs/node/issues/30655 PR-URL: https://github.com/nodejs/node/pull/30657 Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

view details

Anna Henningsen

commit sha ff5664b83b89c55e4ab5d5f60068fb457f1f5872

src: fix compiler warning in env.cc This fixes the following warning: ../src/env.cc: In member function ‘void node::Environment::Exit(int)’: ../src/env.cc:946:77: warning: format ‘%llu’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘uint64_t {aka long unsigned int}’ [-Wformat=] fprintf(stderr, "(node:%d, thread:%llu) ", uv_os_getpid(), thread_id()); ~~~~~~~~~~~^ PR-URL: https://github.com/nodejs/node/pull/31020 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

view details

Juan José Arboleda

commit sha db9539bba4d62db3b73baf1575a9c3dfcd4d1f32

src: list used functions on headers PR-URL: https://github.com/nodejs/node/pull/30827 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

Robert Nagy

commit sha 20d009d2fdab313bb2cfb789881f1f9364474a62

stream: pipe should not swallow error PR-URL: https://github.com/nodejs/node/pull/30993 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

view details

Gerhard Stoebich

commit sha fcd4c2e37d510ea362b4225849b25ac958390091

events: allow monitoring error events Installing an error listener has a side effect that emitted errors are considered as handled. This is quite bad for monitoring/logging tools which tend to be interested in errors but don't want to cause side effects like swallow an exception. There are some workarounds in the wild like monkey patching emit or remit the error if monitoring tool detects that it is the only listener but this is error prone and risky. This PR allows to install a listener to monitor errors with the side effect to consume the error. To avoid conflicts with other events it exports a symbol on EventEmitter which owns this special meaning. Refs: https://github.com/open-telemetry/opentelemetry-js/issues/225 PR-URL: https://github.com/nodejs/node/pull/30932 Refs: https://github.com/open-telemetry/opentelemetry-js/issues/225 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

view details

push time in 2 months

PR opened nodejs/node

Reviewers
deps: V8: bump v8_embedder_string for 0e21c1e637bf V8 Engine

0e21c1e637bf6d844473d09dca3508f2bf547b89 has landed without a proper v8_embedder_string bump, this is a follow-up fix.

Refs: 0e21c1e637bf6d844473d09dca3508f2bf547b89 Refs: https://github.com/nodejs/node/pull/31007

The alternative would be to revert 0e21c1e637bf6d844473d09dca3508f2bf547b89 and re-land #31007 (PR incoming). I would prefer that, but filing both to speed up things.

+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchChALkeR/io.js

branch : chalker/v8-cherrypick-scavenges-update-string

created branch time in 2 months

pull request commentnodejs/node

deps: V8: cherry-pick 687d865fe251

@BridgeAR Oh, my bad re: v8_embedder_string.

The problem is that it did not work -- it's present in master: https://github.com/nodejs/node/commits/master

Will file two alternative PRs to fix that now.

ChALkeR

comment created time in 2 months

issue openedMaiaVictor/eth-lib

Don't package files from previous versions

eth-lib 0.2.7 and 0.2.8 include lib/provider.js, which requires a package not specified in package.json dependencies field.

Apparently, that's a leftover from previous version -- there is no corresponding file in the src/ dir.

Perhaps it would make sense to not package it in the next version.

created time in 2 months

issue commentnodejs/admin

archive nodejs/members respository

Belated +1.

Trott

comment created time in 2 months

created repositoryChALkeR/alt-LibreSSL

created time in 2 months

create barnchChALkeR/alt-LibreSSL

branch : sisyphus

created branch time in 2 months

created repositoryChALkeR/alt-LibreSSL

test

created time in 2 months

issue commentnpm/rfcs

[RRFC] Module block list

@ruyadorno Upon thinking about this further, just "blocking" a module could be not sufficient in some cases. E.g.:

  1. for some packages, "blocking" would be just preventing it from being installed (chokidar -> fsevents),
  2. and for some cases, it might need to be replaced with a dummy module that could be required, but returns e.g. an empty object -- e.g. if the module is required, but not actually used. Those situations are not interchangeable -- e.g. chokidar will get confused if require('fsevents') succeeds but returns an empty object.
  3. some might need more complex replacements that could be done only via resolutions.

Wdyt?

All of those could be done by the user via resolutions if/when those would be supported, but a more limited option that would support either just (1) or both of (1) and (2) should be easier to implement and more straightforward to use.

ruyadorno

comment created time in 2 months

issue commentnpm/rfcs

[RRFC] delete node_modules folder on `npm ci` failure

Thanks for the update!

isaacs

comment created time in 2 months

pull request commentExodusMovement/monero-core-custom

Drop some unused code

This has whitespace issues, don't merge until those are resolved. There shouldn't be a hurry to merge this (per @sonaye comment).

ChALkeR

comment created time in 2 months

PR opened ExodusMovement/monero-core-custom

Drop some unused code

This is not final yet, but testing if this builds/works would help.

+46 -2468

0 comment

19 changed files

pr created time in 2 months

pull request commentnodejs/node

deps: V8: cherry-pick 687d865fe251

For now (benchmark incomplete):

 buffers/buffer-compare-instance-method.js n=1000000 args=5 size=16                      *      7.00 %       ±6.81%  ±9.14% ±12.08%
 buffers/buffer-compare-offset.js n=1000000 size=16386 method='slice'                    *     -6.24 %       ±5.99%  ±8.05% ±10.63%
 buffers/buffer-concat.js n=800000 withTotalLength=0 pieceSize=256 pieces=16           ***     24.22 %      ±11.06% ±14.71% ±19.15%
 buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=1 pieces=4                *      1.96 %       ±1.65%  ±2.19%  ±2.86%
 buffers/buffer-concat.js n=800000 withTotalLength=1 pieceSize=256 pieces=16            **     19.40 %      ±11.76% ±15.65% ±20.37%
 buffers/buffer-copy.js n=6000000 partial='false' bytes=8                                *     -2.07 %       ±1.78%  ±2.37%  ±3.08%
 buffers/buffer-copy.js n=6000000 partial='true' bytes=128                               *      2.65 %       ±2.34%  ±3.12%  ±4.07%
 buffers/buffer-creation.js n=600000 len=8192 type='fast-alloc-fill'                   ***     27.21 %      ±11.59% ±16.16% ±22.62%
 buffers/buffer-creation.js n=600000 len=8192 type='fast-alloc'                        ***     31.31 %       ±9.28% ±12.79% ±17.58%
ChALkeR

comment created time in 2 months

pull request commentnodejs/node

deps: V8: cherry-pick 687d865fe251

Benchmarks:

  • buffer: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/484/
  • net: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/485
ChALkeR

comment created time in 2 months

issue commentnodejs/node

`Buffer` and `ArrayBuffer`-based objects trigger mark-sweeps instead of scavenges

https://github.com/nodejs/node/pull/31007 (or an update to never V8 version with the corresponding commit) might actually close this issue.

ChALkeR

comment created time in 2 months

pull request commentnodejs/node

deps: V8: cherry-pick 687d865fe251

/cc @nodejs/benchmarking

ChALkeR

comment created time in 2 months

PR opened nodejs/node

Reviewers
deps: V8: cherry-pick 687d865fe251 V8 Engine memory performance

Opening this to test performance benefits.

This should reduce the memory load and improve the speed in cases that heavily rely on Buffer usage.

Refs: https://github.com/v8/v8/commit/687d865fe251602ad1219cde7ae7cb38d4cb7471 Refs: https://github.com/nodejs/node/issues/1671

Original commit message:

    [heap] Perform GCs on v8::BackingStore allocation

    This adds heuristics to perform young and full GCs on allocation
    of external ArrayBuffer backing stores.

    Young GCs are performed proactively based on the external backing
    store bytes for the young generation. Full GCs are performed only
    if the allocation fails. Subsequent CLs will add heuristics to
    start incremental full GCs based on the external backing store bytes.

    This will allow us to remove AdjustAmountOfExternalMemory for
    ArrayBuffers.

    Bug: v8:9701, chromium:1008938
    Change-Id: I0e8688f582989518926c38260b5cf14e2ca93f84
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803614
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: Hannes Payer <hpayer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65480}
+45 -12

0 comment

4 changed files

pr created time in 2 months

more