profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/Blond11516/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

Blond11516/ex_yarn 1

Elixir library for parsing Yarn lockfiles.

Blond11516/AdventOfCode2020 0

My solutions to the 2020 Advent of Code.

Blond11516/AdventOfCode2020-1 0

My solutions for https://adventofcode.com 2020

Blond11516/cachex 0

A powerful caching library for Elixir with support for transactions, fallbacks and expirations

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha feb1a4e140484aa5e28785ef39306c5c89e830d6

feat: Implement the delete_own_reaction action (#113)

view details

push time in a day

delete branch ZeLarpMaster/Mobius

delete branch : feat/delete_own_reaction_action

delete time in a day

PR merged ZeLarpMaster/Mobius

feat: Implement the delete_own_reaction action
  • Implements the delete_own_reaction action.
  • Adds a simple argument preprocessor to actions. Right now it is only used to get the identifier from an emoji.
  • Adds an emoji action validator

Part of #29

+91 -4

0 comment

4 changed files

Blond11516

pr closed time in a day

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha d2ef635cc920403223b0698a73466080fd1c684e

feat: Implement the delete_own_reaction action

view details

push time in 4 days

Pull request review commentZeLarpMaster/Mobius

feat: Implement the delete_own_reaction action

 defmodule Mobius.Actions do           {atom(), ActionValidations.validator()}   defp type_tuple_to_validator_tuple({name, type}),     do: {name, ActionValidations.get_validator(type)}++  @spec pre_process_params(Endpoint.t(), keyword()) :: keyword()+  defp pre_process_params(%Endpoint{params: params}, params_values) do+    Enum.map(params_values, fn {name, value} ->+      processed_value =+        params[name]+        |> then(fn type -> pre_process_param_value(type, value) end)++      {name, processed_value}+    end)+  end++  @spec pre_process_param_value(ActionValidations.validator_type(), any()) :: any()+  defp pre_process_param_value(:emoji, %Emoji{} = emoji),+    do: Emoji.get_identifier(emoji)++  defp pre_process_param_value(_, value), do: value

We could, although I'm not quite sure what we have to gain here. In my mind protocols are great for dependency injection-type stuff (i.e. letting the user provide their own implementation). I don't think this is such a case, though maybe there's another advantage I'm not seeing.

Blond11516

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentZeLarpMaster/Mobius

feat: Implement the delete_own_reaction action

 defmodule Mobius.Actions do           {atom(), ActionValidations.validator()}   defp type_tuple_to_validator_tuple({name, type}),     do: {name, ActionValidations.get_validator(type)}++  @spec pre_process_params(Endpoint.t(), keyword()) :: keyword()+  defp pre_process_params(%Endpoint{params: params}, params_values) do+    Enum.map(params_values, fn {name, value} ->+      processed_value =+        params[name]+        |> then(fn type -> pre_process_param_value(type, value) end)

Good point. I think I initially had it as part of a bigger pipe, not sure :thinking:

Blond11516

comment created time in 4 days

PullRequestReviewEvent

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha cb1cfd4672f970e4d0af57d991f25247a51a9f0a

feat: Implement the delete_own_reaction action

view details

push time in 7 days

PR opened ZeLarpMaster/Mobius

Reviewers
feat: Implement the delete_own_reaction action
  • Implements the delete_own_reaction action.
  • Adds a simple argument preprocessor to actions. Right now it is only used to get the identifier from an emoji.
  • Adds an emoji action validator

Part of #29

+96 -4

0 comment

4 changed files

pr created time in 7 days

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha 885be3de396b0ee2ef9d61934d352ec2f0b7c9bf

feat: Implement the delete_own_reaction action

view details

push time in 7 days

create barnchZeLarpMaster/Mobius

branch : feat/delete_own_reaction_action

created branch time in 7 days

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha e898d93a82dc4b735a150f4c136702870928e638

feat: Add get_message action (#111)

view details

push time in 15 days

delete branch ZeLarpMaster/Mobius

delete branch : feat/get_message

delete time in 15 days

PR merged ZeLarpMaster/Mobius

feat: Add get_message action

Implements the get_message action. This is part of https://github.com/ZeLarpMaster/Mobius/issues/29.

+47 -2

0 comment

3 changed files

Blond11516

pr closed time in 15 days

issue openedZeLarpMaster/Mobius

Change all snowflake usages to integers

In many locations throughout the code (mostly actions) snowflakes are expected to be strings, but in the models we actually convert the strings received from Discord to integers. We should change all usages to integers to ensure consistency in the usage of snowflakes. See https://github.com/ZeLarpMaster/Mobius/pull/111#discussion_r703067856 for details.

created time in 15 days

PullRequestReviewEvent

Pull request review commentZeLarpMaster/Mobius

feat: Add get_message action

 defmodule Mobius.Actions.MessageTest do       assert messages == [Models.Message.parse(ctx.raw_message)]     end   end++  describe "get_message/2" do+    setup :handshake_shard++    setup do+      channel_id = random_snowflake()+      message_id = random_snowflake()+      raw = message(channel_id: channel_id, id: message_id)+      url = Client.base_url() <> "/channels/#{channel_id}/messages/#{message_id}"+      mock(fn %{method: :get, url: ^url} -> json(raw) end)+      [channel_id: channel_id, message_id: message_id, raw_message: raw]+    end++    test "returns an error if channel_id is not a snowflake", ctx do+      {:error, errors} = Message.get_message(1324, ctx.message_id)+      assert_has_error(errors, "Expected channel_id to be a snowflake")

Huh, for some reason I actually thought we went out of our way to use strings instead of integers 🤔 I agree we should change it to be more consistent 👍 I'll open an issue.

Blond11516

comment created time in 15 days

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha 515a1ff450dc1624604b2afe88708f56433db11c

Fix example typo

view details

push time in 15 days

Pull request review commentZeLarpMaster/Mobius

feat: Add get_message action

 defmodule Mobius.Actions.Message do           {:ok, [%Mobius.Models.Message{} = message]}       """,       model: Mobius.Models.Message+    },+    %Endpoint{+      name: :get_message,+      url: "/channels/:channel_id/messages/:message_id",+      method: :get,+      params: [{:channel_id, :snowflake}, {:message_id, :snowflake}],+      discord_doc_url:+        "https://discord.com/developers/docs/resources/channel#get-channel-message",+      doc: """+      Fetches a single message in a channel++      ## Example++          iex> get_message("123456789", "987654321")+          {:ok, %Mobius.Molels.Message{} = message}

Woops 😅

Blond11516

comment created time in 15 days

PullRequestReviewEvent

push eventBlond11516/sole-and-ankle-revisited

Étienne Lévesque

commit sha 832c1f2e86766fbdafe3165d3c0c2178e188d204

exercise 6: css variables

view details

push time in 16 days

push eventBlond11516/sole-and-ankle-revisited

Étienne Lévesque

commit sha 65cda70e00785f22347d428fa5ee06ab29c6c79a

exercise 5: fluid desktop

view details

push time in 16 days

PR opened ZeLarpMaster/Mobius

Reviewers
feat: Add get_message_action

Implements the get_message action. This is part of https://github.com/ZeLarpMaster/Mobius/issues/29.

+47 -2

0 comment

3 changed files

pr created time in 16 days

push eventZeLarpMaster/Mobius

Étienne Lévesque

commit sha 6daf8fecdefd9ae28fca753be82c336293ab8b45

feat: Add get_message_action

view details

push time in 16 days

create barnchZeLarpMaster/Mobius

branch : feat/get_message

created branch time in 16 days

pull request commentZeLarpMaster/Mobius

feat: Supporting stage channels

I may be blind but I didn't find any instance of a single pipe :thinking:

ZeLarpMaster

comment created time in 20 days

PullRequestReviewEvent

push eventBlond11516/sole-and-ankle-revisited

Étienne Lévesque

commit sha db2cd92420a9fa81ef1572f62ad91c0d8e111889

exercise 4: mobile menu

view details

push time in 21 days

push eventBlond11516/sole-and-ankle-revisited

Étienne Lévesque

commit sha 0f4826beafd68b00ca792b4b5beeb064890ddf3c

exercise 3: main view

view details

push time in 21 days