profile
viewpoint
Benjamin Philip Benjamin-Philip Bangalore, India

Benjamin-Philip/benjamin-philip.github.io 3

:sparkles: My personal blog

Benjamin-Philip/tcpl 1

My attempt on "The C Programming Language" by Brian Kernighan and Dennis Ritchie

Benjamin-Philip/textbook 1

Textbook is a theme designed to be used with sites which have solutions to Textbooks like Sicp

Benjamin-Philip/.doom.d 0

My doom config

Benjamin-Philip/elixir 0

Elixir is a dynamic, functional language designed for building scalable and maintainable applications

Benjamin-Philip/explorer 0

Dataframes for Elixir

Benjamin-Philip/fprime 0

F' - A flight software and embedded systems framework

Benjamin-Philip/hex 0

Package manager for the Erlang VM

Benjamin-Philip/hexpm 0

API server and website for Hex

pull request commenthexpm/hexpm

WebAuth Proof of Concept

@ericmj, and @wojtekmach

Do review this PR and the Client side PR please.

Benjamin-Philip

comment created time in 3 days

startedruby/rake

started time in 15 days

fork Benjamin-Philip/fprime

F' - A flight software and embedded systems framework

https://nasa.github.io/fprime

fork in 16 days

pull request commenthexpm/hexpm

WebAuth Proof of Concept

@ericmj and @wojtekmach,

Please review the Server side MVP and the Client MVP please.

Benjamin-Philip

comment created time in 19 days

pull request commenthexpm/hex

WebAuth Client MVP

@ericmj, @wojtekmach Ping.

Benjamin-Philip

comment created time in 21 days

issue commentlivebook-dev/livebook

Disconnecting a remote runtime should remove livebook node from Node.list

@Benjamin-Philip nah, it's about Node.list(), which lists the names of remote BEAM nodes that Livebook is connected to (or more specifically Node.list(:hidden)).

Yeah, I realised. Hence deleted the message.

josevalim

comment created time in 23 days

issue commentlivebook-dev/livebook

Disconnecting a remote runtime should remove livebook node from Node.list

When you say Node list, do you mean the Node Pool at https://github.com/livebook-dev/livebook/blob/f5309d2b9a3984dafad9d1975c68ad0632f17ce0/lib/livebook/runtime/node_pool.ex?

josevalim

comment created time in 23 days

issue commentlivebook-dev/livebook

Add scroll to Error Modal

Can I send a PR?

eksperimental

comment created time in 23 days

issue commentlivebook-dev/livebook

Close previous modal errors when compilation succeeds

The output will be in the terminal but we likely shouldn’t say so because the terminal won’t be available in certain deployment options (fly, Desktop, etc).

I think we should update the error modal to show terminal output (if any). Like you mentioned, certain deployments do not have a terminal, so even basic debugging can be difficult.

eksperimental

comment created time in 23 days

pull request commenthexpm/hex

WebAuth Client MVP

Any comments @ericmj?

Benjamin-Philip

comment created time in a month

issue commentlivebook-dev/livebook

Close previous modal errors when compilation succeeds

In short, @eksperimental highlights 2 problems/bugs:

  1. The error flash is not cleared.
  2. There is no compilation output given despite the error message refering to such.
eksperimental

comment created time in a month

PR opened livebook-dev/livebook

Disable Ecto stats in Phoenix Live Dashboard

Livebook does not use Ecto, so disable Ecto stats.

+2 -1

0 comment

1 changed file

pr created time in a month

create barnchBenjamin-Philip/livebook

branch : bp-no-ecto-stats

created branch time in a month

push eventBenjamin-Philip/livebook

Benjamin Philip

commit sha e2729202b24f10ceeaec6d283b9ed1b40cb969de

Revert "Decide if choose is disabled on handle info" This reverts commit 43a2cbc5ea05f6304d8d5e18b7b37b2d17074416.

view details

Benjamin Philip

commit sha d4e5b44418db5d301199fb736ff6e1390c27f4a7

Use the disabled attribute

view details

push time in a month

Pull request review commentlivebook-dev/livebook

Disable Choose button if draft file is a directory

 defmodule LivebookWeb.SessionLive.PersistenceLive do                     tabindex="-1">                     Cancel                   </button>-                  <button class="button-base button-blue"-                    phx-click="confirm_file"-                    tabindex="-1">

Ah okay, I misunderstood "attribute" for assigns. Correcting.

Benjamin-Philip

comment created time in a month

PullRequestReviewEvent

pull request commentlivebook-dev/livebook

Disable Choose button if draft file is a directory

@jonatanklosko, I have pushed a commit using assigns. The only concern I have is that I have is that the "check if chose is disabled" code is repeated when we open the file component and when a path is set, which I think it's not a major issue.

Benjamin-Philip

comment created time in a month

push eventBenjamin-Philip/livebook

Benjamin Philip

commit sha 43a2cbc5ea05f6304d8d5e18b7b37b2d17074416

Decide if choose is disabled on handle info

view details

push time in a month

push eventBenjamin-Philip/livebook

Benjamin Philip

commit sha 3147714fb78d725e55199d657046295049477745

Fix warnings

view details

push time in a month

pull request commentlivebook-dev/livebook

Disable Choose button if draft file is a directory

I've got a working version ready, though we might need to tweak the css a little bit.

Benjamin-Philip

comment created time in a month

PR opened livebook-dev/livebook

Disable Choose button if draft file is a directory

Also close https://github.com/livebook-dev/livebook/issues/814

+11 -5

0 comment

1 changed file

pr created time in a month

create barnchBenjamin-Philip/livebook

branch : bp-do-not-choose-if-dir

created branch time in a month

issue commentlivebook-dev/livebook

When saving livebook, if not name is chosen, file is saved as ".livemd"

Sorry for the late reply, I think we should instead make the Choose button disabled when the draft file is a directory. This way we make sure the user gives it some name, which we should be doing in the first place :) WDYT?

Do you mean the "Save File" button?

On second thoughts I think this should be the ideal way to go. The user would have to rename the file to something meaningful at some point of time, so making them to give a meaningful name at first is probably better.

However, if you look at LibreOffice and all it's apps, Google (Docs, Sheets, Presentations), and MS (Word, Excel, PowerPoint), they all name untitled files "Untitled foo.file_extention" or something along those lines. I think there may be a reason why they all do that (other than mimicking each other). User convenience maybe? I'm not saying that we should mimic the above, but there may be valid reason for doing that.

All in all, +1 for forcing the user to give it a name.

eksperimental

comment created time in a month

fork Benjamin-Philip/phoenix_live_dashboard

Realtime dashboard with metrics, request logging, plus storage, OS and VM insights

fork in a month

PR opened livebook-dev/livebook

Do not show choose file button if file select component is active

Currently in the persistence live view, the "Choose file" button is shown when the file select component is active:

choose-0

This PR changes the persistence live view to not show the "Choose file" button when the file select component is active:

choose

+6 -4

0 comment

1 changed file

pr created time in a month

create barnchBenjamin-Philip/livebook

branch : bp-do-not-show-choose-file-button

created branch time in a month

create barnchBenjamin-Philip/livebook

branch : bp-untitled-livebook

created branch time in a month

startedrails/rails

started time in a month

push eventBenjamin-Philip/hex

Benjamin Philip

commit sha 30ee7842ca12bf80b59662a03b24bad67a3e12c2

Get submit url from WebAuth task

view details

push time in a month

more