profile
viewpoint
Andreas Madsen AndreasMadsen Computationally Demanding Copenhagen, Denmark https://andreasmadsen.github.io/

AndreasMadsen/clarify 121

Remove nodecore related stack trace noise

alexgorbatchev/node-browser-builtins 58

Browser altenatives to built-in node.js modules

AndreasMadsen/async-hook 32

Inspect the life of handle objects in node

AndreasMadsen/distributions 29

A collection of probability distribution functions

AndreasMadsen/article 28

Analyze a stream of HTML and outputs the article title, text, and image

AndreasMadsen/course-02456-sparsemax 14

TensorFlow and Numpy implementation of sparsemax

AndreasMadsen/dgram-emitter 12

Very simple EventEmitter on top of a UDP server/client

AndreasMadsen/domstream 5

HTML manipulation with progressiv output stream

AndreasMadsen/configme 4

Simplest possible configuration tool. without conflict - with defaulting!

AndreasMadsen/cahier 3

static file conversion, writing and reading

issue commentAndreasMadsen/ttest

Feature Request: "BigNum/BigDecimal" interface

That would be really challenging, and by that I mean: you could write peer-reviewed papers on this. The Student-t distribution depends on several mathmathical special functions, these are approximations of mathematical functions that can not be computed exactly. However, they can be approximated to a given precision.

In this case, I use cephes (https://github.com/nearform/node-cephes) that approximates to double precision. In theory, one could choose a more precise representation, fx 128bit doubles. However, one has to choose a precision there will never be such a thing as exact for these functions.

mscdex

comment created time in 11 days

fork AndreasMadsen/tensor2tensor

Library of deep learning models and datasets designed to make deep learning more accessible and accelerate ML research.

fork in 20 days

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 8a0197047e262326674ceb10ee764120bd1e0b54

ignore doc files

view details

push time in a month

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2020-01-14-1324

delete time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha fc90219803b7f12da15661f16f5a19187b6008da

Updates from Overleaf

view details

Andreas Madsen

commit sha 6d9a6ef3f70c4cff83ff94a090ebd4181367197a

Merge overleaf-2020-01-14-1324 into master

view details

push time in a month

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2020-01-14-1324

created branch time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 7c722aaadc8f49dd23abe8012fc2107f03245dd2

dots in nmu drawing

view details

push time in a month

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2020-01-14-1308

delete time in a month

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2020-01-14-1308

created branch time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha a4d8048bdd4485c2c93294277ca6be687c7fdacd

remote projection lines from nmu drawing

view details

push time in a month

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2020-01-14-1305

delete time in a month

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2020-01-14-1305

created branch time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha ac90fa6b5522c71f1bd86bb25c02729b9f79667b

fix isometrics

view details

push time in a month

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2020-01-14-1259

delete time in a month

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2020-01-14-1259

created branch time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 691881a8ab09e83cfd55dd809e9bb6814f6f3153

small fixes to nmu drawing

view details

push time in a month

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2020-01-14-1232

delete time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 3ca85462774af4f867de344a4f751b6105581120

Updates from Overleaf

view details

Andreas Madsen

commit sha 19611940483f66834c34a434171cc636c913285a

Merge overleaf-2020-01-14-1232 into master

view details

push time in a month

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2020-01-14-1232

created branch time in a month

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 1a86c915ffe00d0ce53a1e908b6292601f6b36d3

update nmu drawing

view details

Andreas Madsen

commit sha 3e31a1db655afe26d42d24dac30104223751b716

add mnist-add experiment

view details

push time in a month

push eventAndreasMadsen/course-02456-sparsemax

Andreas Madsen

commit sha 629f7bb9576b79783655a49c3f46bbcc7f970df7

upload report

view details

push time in 2 months

issue closedAndreasMadsen/python-lrcurve

Encoding Error

I tried using this package on a Windows machine on Jupyter (python 3.7.4, 64 bit) and faced the following issue when trying out the dummy example:

image

closed time in 2 months

iamgroot42

issue closedAndreasMadsen/ttest

Precision issue with small p-value

Repro:

const ttest = require('ttest');

const ref = [3.861147687082808,4.1833109086557325,3.973594179324881,4.067660887263925,3.7661981850423203,3.8407050592346477,3.983494353110395,3.791224198364107,3.7573201433330223,3.6326953678695757,3.649353001081396,4.008367559943343,3.642362926456249,3.9386159539971635,3.965380930294604,3.720419087302582,4.019779785322333,3.916874280250766,3.9826331513375517,3.8487184246955795,3.9777597010041306,3.9301399596581796,3.3977074280624233,4.016225096648127,3.9947182452600187,3.7147293468453944,3.9650116229578796,4.15261985914954,4.072283338272716,4.018258042542346,4.275900504663435,4.247052603538485,3.8632869646479966,4.195181524801175,4.061338223974988,3.997470766890559,4.151394128832368,3.956574144537081,4.102028418283781,3.895513445852064,4.294429613680861,4.147884159109542,4.324981618980995,3.9225663296782742,3.9036535245451747,3.996488485132162,4.068017402803237,3.9086757816917657,4.1985806684438485,4.215712687842988,4.141082407873602,4.130592122446437,3.9844787517550766,4.055413115719177,4.295688728970604,3.9295909891273317,4.018853727187908,4.211687367710041,4.039532923487119,4.150267003760778,3.9571008871840943,4.250207443005561,3.6432440226648395,4.0926554219335065,3.9671228831029244,4.050496312050845,4.08886200014234,3.9569368332194244,3.973713976092726,4.078102228403546,3.8457644781798885,4.063690907132751,4.072802425585134];
const other = [4.196088504937897,4.297600006725063,4.380931627957188,4.229470416380346,4.51424161894835,4.15374761736698,4.185259220991428,4.1184978606339735,4.242710204234378,4.357880244428704,4.2342678907235465,4.417689232509152,4.391094295930451,4.270372284867759,4.404107881034074,4.088192613114767,4.327923994691726,4.094632609126974,4.169154407256733,4.291471956751135,3.9389016863511612,4.236946427323764,4.429129606388344,4.362366516924023,4.15712520715034,4.273894263027447,4.291340851721514,4.156093971770384,4.18322608310349,4.242268731414564,4.282951092770966,4.250751025033699,4.1722021750486595,4.223035449341226,4.236514858116207,4.370006322215913,4.2523040462607495,4.418104161273623,4.005054694044181,4.332140449797302,4.114901342239478,4.235374982468168,4.189091743846535,4.391354534957378,4.395337620628255,4.331974041511989,4.406671154699146,4.399646144051766,4.2813460855899175,4.289620122487038,4.390782160631226,4.229368785039166,4.006587130212967,4.179324028691534,4.126061175939888,4.2893865958789,4.26270828836601,4.439895292474625,4.221064697480762,4.1670134964393455,4.123864672737084,4.416479313108734,4.253537292991181,4.141417410861353,4.239734666096584,4.263623754941469,3.9763012135882425,4.251617630059521,4.292616064339593,4.498105896751339,4.266088146494694,4.175256450633397,4.375893778023997,4.2857149056812665,4.298162810306891,4.40570741930156,4.332451872647763];

const result = ttest(ref, other, { varEqual: false }).pValue();

Expected result (according to R): 9.192939e-20 Actual result: 0

I believe the problem is here: https://github.com/AndreasMadsen/distributions/blob/a8e2601c0919c9d28c2945b084464568fc0a7b3b/distributions/studentt.js#L34-L38

If p is small enough, 1 - p returns 1, so precision is lost because in the end, what is done is 1 - (1 - p), which should return p but instead returns 0.

closed time in 2 months

targos

issue commentAndreasMadsen/ttest

Precision issue with small p-value

Thanks. https://github.com/AndreasMadsen/ttest/commit/361f26f59c467dca06cd00464aa0678fab9836ad should fix it.

targos

comment created time in 2 months

push eventAndreasMadsen/ttest

dependabot[bot]

commit sha fc5e7d66f9b0b4b4cd8525e8af85c9079b009c04

Bump eslint from 3.19.0 to 6.7.2 (#11) Bumps [eslint](https://github.com/eslint/eslint) from 3.19.0 to 6.7.2. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v3.19.0...v6.7.2) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 months

PR merged AndreasMadsen/ttest

Bump eslint from 3.19.0 to 6.7.2 dependencies

Bumps eslint from 3.19.0 to 6.7.2. <details> <summary>Release notes</summary>

Sourced from eslint's releases.

v6.7.2

  • bc435a9 Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614) (#12616) (Toru Nagashima)
  • 4928d51 Fix: don't ignore the entry directory (fixes #12604) (#12607) (Toru Nagashima)
  • b41677a Docs: Clarify suggestion's data in Working with Rules (refs #12606) (#12617) (Milos Djermanovic)
  • ea16de4 Fix: Support tagged template literal generics in no-unexpected-multiline (#11698) (Brad Zacher)
  • fa6415d Sponsors: Sync README with website (ESLint Jenkins)
  • e1e158b Sponsors: Sync README with website (ESLint Jenkins)

v6.7.1

  • dd1e9f4 Fix: revert changes to key-spacing due to regression (#12598) (Kai Cataldo)
  • c644b54 Docs: Update README team and sponsors (ESLint Jenkins)

v6.7.0

  • 312a88f New: Add grouped-accessor-pairs rule (fixes #12277) (#12331) (Milos Djermanovic)
  • 5c68f5f Update: Add 'lexicalBindings' to no-implicit-globals and change messages (#11996) (Milos Djermanovic)
  • 6eaad96 New: Add suggestions API (#12384) (Will Douglas)
  • b336fbe Fix: indent rule with JSX spread props (#12581) (Nathan Woltman)
  • 97c745d Update: Report assignment expression location in no-cond-assign (#12465) (Milos Djermanovic)
  • 0f01f3d Update: Check member expressions with this in operator-assignment (#12495) (Milos Djermanovic)
  • 62c7038 Fix: invalid token checking in computed-property-spacing (fixes #12198) (#12533) (YeonJuan)
  • 4f8a1ee Update: Add enforceForClassMembers option to no-useless-computed-key (#12110) (ark120202)
  • 1a2eb99 New: new rule no-constructor-return (fixes #12481) (#12529) (Pig Fang)
  • ca3b2a6 New: ignorePatterns in config files (refs eslint/rfcs#22) (#12274) (Toru Nagashima)
  • 60204a3 Docs: Added another Textmate 2 bundle. (#12580) (Ryan Fitzer)
  • 62623f9 Fix: preserve whitespace in multiline-comment-style (fixes #12312) (#12316) (Kai Cataldo)
  • 17a8849 New: Add no-dupe-else-if rule (fixes #12469) (#12504) (Milos Djermanovic)
  • 41a78fd Update: improve location for semi and comma-dangle (#12380) (Chiawen Chen)
  • 0a480f8 Docs: Change "Code Conventions" link in pull-requests.md (#12401) (Denis Sikuler)
  • fed20bb Fix: require-await crash on global await (#12571) (Brad Zacher)
  • b8030fc Update: deprecate personal config (fixes #11914, refs eslint/rfcs#32) (#12426) (Toru Nagashima)
  • 40c8c32 Fix: improve report location for object-curly-spacing (#12563) (Milos Djermanovic)
  • 1110045 Fix: ignore marker-only comments in spaced-comment (fixes #12036) (#12558) (Milos Djermanovic)
  • 6503cb8 Update: Fix uglified object align in key-spacing (fixes #11414) (#12472) (YeonJuan)
  • 40791af Docs: clarify ignoreDestructuring option in the camelcase rule (#12553) (Milos Djermanovic)
  • 07d398d Chore: Add GitHub organization to Sponsor button (#12562) (Brandon Mills)
  • a477707 Chore: Format style guide links so they can be clicked (#12189) (Ivan V)
  • 0f7edef Update: add react plugin config for eslint init (#12446) (Ibrahim Rouis)
  • 448ff1e Update: Report '\08' and '\09' in no-octal-escape (fixes #12080) (#12526) (Milos Djermanovic)
  • 45aa6a3 New: Add no-setter-return rule (fixes #12285) (#12346) (Milos Djermanovic)
  • 0afb518 Fix: invalid autofix in function-call-argument-newline (fixes #12454) (#12539) (YeonJuan)
  • 90305e0 Update: Depcrecate isSpaceBetweenTokens() (#12519) (Kai Cataldo)
  • 41b1e43 New: add option for camelcase (fixes #12527) (#12528) (Pig Fang)
  • f49f1e0 Upgrade: upgrade optionator to avoid license issue (fixes #11536) (#12537) (Pig Fang)
  • 0286b57 Docs: Clean up Getting Started Guide (#12544) (Nicholas C. Zakas)
  • 575a98d Chore: Add funding field to package.json (#12543) (Nicholas C. Zakas)
  • 9e29e18 Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens (#12491) (Kai Cataldo)
  • 5868550 Docs: add notice about function keyword in keyword-spacing (#12524) (Pig Fang)
  • bb556d5 Fix: curly multi reports single lexical declarations (fixes #11908) (#12513) (Milos Djermanovic)
  • ac60621 Fix: unexpected autofix in prefer-const (fixes #12514) (#12521) (YeonJuan)
  • 990065e Update: curly multi-or-nest flagging semis on next line (fixes #12370) (#12378) (cherryblossom000) </tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from eslint's changelog.

v6.7.2 - November 30, 2019

  • bc435a9 Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614) (#12616) (Toru Nagashima)
  • 4928d51 Fix: don't ignore the entry directory (fixes #12604) (#12607) (Toru Nagashima)
  • b41677a Docs: Clarify suggestion's data in Working with Rules (refs #12606) (#12617) (Milos Djermanovic)
  • ea16de4 Fix: Support tagged template literal generics in no-unexpected-multiline (#11698) (Brad Zacher)
  • fa6415d Sponsors: Sync README with website (ESLint Jenkins)
  • e1e158b Sponsors: Sync README with website (ESLint Jenkins)

v6.7.1 - November 24, 2019

  • dd1e9f4 Fix: revert changes to key-spacing due to regression (#12598) (Kai Cataldo)
  • c644b54 Docs: Update README team and sponsors (ESLint Jenkins)

v6.7.0 - November 22, 2019

  • 312a88f New: Add grouped-accessor-pairs rule (fixes #12277) (#12331) (Milos Djermanovic)
  • 5c68f5f Update: Add 'lexicalBindings' to no-implicit-globals and change messages (#11996) (Milos Djermanovic)
  • 6eaad96 New: Add suggestions API (#12384) (Will Douglas)
  • b336fbe Fix: indent rule with JSX spread props (#12581) (Nathan Woltman)
  • 97c745d Update: Report assignment expression location in no-cond-assign (#12465) (Milos Djermanovic)
  • 0f01f3d Update: Check member expressions with this in operator-assignment (#12495) (Milos Djermanovic)
  • 62c7038 Fix: invalid token checking in computed-property-spacing (fixes #12198) (#12533) (YeonJuan)
  • 4f8a1ee Update: Add enforceForClassMembers option to no-useless-computed-key (#12110) (ark120202)
  • 1a2eb99 New: new rule no-constructor-return (fixes #12481) (#12529) (Pig Fang)
  • ca3b2a6 New: ignorePatterns in config files (refs eslint/rfcs#22) (#12274) (Toru Nagashima)
  • 60204a3 Docs: Added another Textmate 2 bundle. (#12580) (Ryan Fitzer)
  • 62623f9 Fix: preserve whitespace in multiline-comment-style (fixes #12312) (#12316) (Kai Cataldo)
  • 17a8849 New: Add no-dupe-else-if rule (fixes #12469) (#12504) (Milos Djermanovic)
  • 41a78fd Update: improve location for semi and comma-dangle (#12380) (Chiawen Chen)
  • 0a480f8 Docs: Change "Code Conventions" link in pull-requests.md (#12401) (Denis Sikuler)
  • fed20bb Fix: require-await crash on global await (#12571) (Brad Zacher)
  • b8030fc Update: deprecate personal config (fixes #11914, refs eslint/rfcs#32) (#12426) (Toru Nagashima)
  • 40c8c32 Fix: improve report location for object-curly-spacing (#12563) (Milos Djermanovic)
  • 1110045 Fix: ignore marker-only comments in spaced-comment (fixes #12036) (#12558) (Milos Djermanovic)
  • 6503cb8 Update: Fix uglified object align in key-spacing (fixes #11414) (#12472) (YeonJuan)
  • 40791af Docs: clarify ignoreDestructuring option in the camelcase rule (#12553) (Milos Djermanovic)
  • 07d398d Chore: Add GitHub organization to Sponsor button (#12562) (Brandon Mills)
  • a477707 Chore: Format style guide links so they can be clicked (#12189) (Ivan V)
  • 0f7edef Update: add react plugin config for eslint init (#12446) (Ibrahim Rouis)
  • 448ff1e Update: Report '\08' and '\09' in no-octal-escape (fixes #12080) (#12526) (Milos Djermanovic)
  • 45aa6a3 New: Add no-setter-return rule (fixes #12285) (#12346) (Milos Djermanovic)
  • 0afb518 Fix: invalid autofix in function-call-argument-newline (fixes #12454) (#12539) (YeonJuan)
  • 90305e0 Update: Depcrecate isSpaceBetweenTokens() (#12519) (Kai Cataldo)
  • 41b1e43 New: add option for camelcase (fixes #12527) (#12528) (Pig Fang)
  • f49f1e0 Upgrade: upgrade optionator to avoid license issue (fixes #11536) (#12537) (Pig Fang)
  • 0286b57 Docs: Clean up Getting Started Guide (#12544) (Nicholas C. Zakas)
  • 575a98d Chore: Add funding field to package.json (#12543) (Nicholas C. Zakas)
  • 9e29e18 Fix: sourceCode#isSpaceBetweenTokens() checks non-adjacent tokens (#12491) (Kai Cataldo)
  • 5868550 Docs: add notice about function keyword in keyword-spacing (#12524) (Pig Fang) </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>
  • dbbba83 6.7.2
  • bc54d15 Build: changelog update for 6.7.2
  • bc435a9 Fix: isSpaceBetweenTokens() recognizes spaces in JSXText (fixes #12614) (#12616)
  • 4928d51 Fix: don't ignore the entry directory (fixes #12604) (#12607)
  • b41677a Docs: Clarify suggestion's data in Working with Rules (refs #12606) (#12617)
  • ea16de4 Fix: Support tagged template literal generics in no-unexpected-multiline (#11...
  • fa6415d Sponsors: Sync README with website
  • e1e158b Sponsors: Sync README with website
  • af95154 6.7.1
  • 9361824 Build: changelog update for 6.7.1
  • Additional commits viewable in compare view </details> <details> <summary>Maintainer changes</summary>

This version was pushed to npm by eslintbot, a new releaser for eslint since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventAndreasMadsen/ttest

Andreas Madsen

commit sha 361f26f59c467dca06cd00464aa0678fab9836ad

fix numerical error in pValue()

view details

Andreas Madsen

commit sha 045da7232ea55fc737a971760ba429908e807aa0

2.1.1

view details

push time in 2 months

issue commentAndreasMadsen/python-lrcurve

Encoding Error

Thanks. I can't reproduce it but I suspect it is the non-ascii chars in the bundle that d3 ships. They are only used in comments so I used iconv to strip them from the code.

Can you try lrcurve version 1.0.2?

iamgroot42

comment created time in 2 months

push eventAndreasMadsen/python-lrcurve

Andreas Madsen

commit sha 89d6da0a5a6494b627f64f3be5b56ac01a4f6ee7

strip non-ascii chars from js-bundle

view details

Andreas Madsen

commit sha 8a63ffa27f6d7ab8c0268a487047b2e0c6e806cb

bump version 1.0.2

view details

push time in 2 months

issue commentAndreasMadsen/python-lrcurve

Feature request: add a way to save the figure as a png/pdf/... file

The graph is rendered in the browser using SVG (not PNG, PDF, or JPEG). The SVG could, in theory, be saved but you would then have to convert it. LaTeX, Word, Google Docs, etc. does not support SVG.

To save it as a PNG, PDF, or JPEG, it would have to be rendered using a completely different engine, so it would look rather different.

If you have a more concrete suggestion on how to this, that isn't extremely complex, then we can consider it.

durandg12

comment created time in 3 months

startedAndreasMadsen/python-lrcurve

started time in 3 months

Pull request review commentnearform/node-clinic-doctor

Get analysis result out of `tool.check()` or `tool.visualize()`

+'use strict'++const fs = require('fs')+const v8 = require('v8')+const { test } = require('tap')+const async = require('async')+const rimraf = require('rimraf')+const ClinicDoctor = require('../index.js')++test('cmd - test check - data exists', function (t) {+  const tool = new ClinicDoctor({ dest: './foo' })++  function cleanup (err, dirname) {+    t.ifError(err)++    t.match(dirname, /^foo(\/|\\)[0-9]+\.clinic-doctor$/)++    rimraf(dirname, function (err) {+      t.ifError(err)+      t.end()+    })+  }++  tool.collect(+    [process.execPath, '-e', 'setTimeout(() => {}, 400)'],+    function (err, dirname) {+      if (err) return cleanup(err, dirname)++      tool.check(dirname, function (err, result) {+        if (err) return cleanup(err, dirname)++        t.ok(result)+        t.same(result.issue, 'data')+        t.same(result.recommendation.title, 'data analysis issue')

This should not work.

goto-bus-stop

comment created time in 3 months

Pull request review commentnearform/node-clinic-doctor

Get analysis result out of `tool.check()` or `tool.visualize()`

 class ClinicDoctor extends events.EventEmitter {       fs.createWriteStream(outputFilename),       function (err) {         clearInterval(checkHeapInterval)-        callback(err)+        if (err) {+          callback(err)+        } else {+          callback(null, result)

Having visualize output a structured object is a bit odd. If anything, it should output the file stream. A better separation of logic would be collect() -> analyze() -> visualize(). Where visualize() takes the analyze() output. I do see the incompatibility, but maybe analyze() should output streams?

I don't have any strong opinions. A valid alternative is also to just force the API consumer to call both methods if they want both a structured object and a file.

goto-bus-stop

comment created time in 3 months

PublicEvent

push eventAndreasMadsen/python-lrcurve

Andreas Madsen

commit sha b9fb48992cacea7c64e2bc874308343024dcead2

add nearform research mention

view details

push time in 3 months

push eventAndreasMadsen/python-lrcurve

Andreas Madsen

commit sha 1ab423cd8da10fdf7683631499dcb4f3aed14b20

add readme gif

view details

push time in 3 months

pull request commentnearform/node-clinic-doctor

Get analysis result out of `tool.check()` or `tool.visualize()`

Some feedback if you don't mind.

  • "Doctor check" is cute, but I think you should choose a name that makes sense for the entire clinic suite. Maybe just analyze.

  • Include the raw data, for future projects we may wish to utilize that.

  • Consider excluding results.recommendation for now, it looks quite ad-hoc and I'm not sure it is required.

goto-bus-stop

comment created time in 3 months

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2019-11-13-1404

delete time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha aed52cd08b932f0f715d619e04a9eba1868fd43e

Updates from Overleaf

view details

Andreas Madsen

commit sha f9de9d004bb2dc2ee28577cd1760d0a00c185836

Merge overleaf-2019-11-13-1404 into master

view details

push time in 3 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-13-1404

created branch time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 00969594b3a8b539813f22080312f980bf291a14

add gated NAU/NMU results

view details

push time in 3 months

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2019-11-13-1353

delete time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha e2fb3e978742c25456a8142b88cb72e48af81cec

Updates from Overleaf

view details

Andreas Madsen

commit sha 33e0f492b43d71d024164c38d5e3e132bd209027

Merge overleaf-2019-11-13-1353 into master

view details

push time in 3 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-13-1353

created branch time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha f0dc7c59614739f69111608a70ccfe31ec69e156

use correct R_z

view details

push time in 3 months

pull request commentAndreasMadsen/mathfn

Fixed logBeta call for bigger numbers.

Thanks, but it needs tests. Also, I would highly recommend that you switch to my cephes implementation instead, it is much less likely to contain errors. https://github.com/nearform/node-cephes#double--cephesbetaa-double-b-double

VladimirKadlec

comment created time in 3 months

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2019-11-12-1254

delete time in 3 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-12-1254

created branch time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 89b72ca44f8899074aee76cf0f5ce8a3c20d4b97

Updates from Overleaf

view details

Andreas Madsen

commit sha 30818515ca73b660ec2960d564de4af94057c43d

Merge remote-tracking branch 'origin/overleaf-2019-11-12-1248'

view details

push time in 3 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-12-1248

created branch time in 3 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 072b91f8c13225d0777cfa7e584390798bf5c487

upload cumsum results

view details

push time in 3 months

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2019-11-08-1314

delete time in 4 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 8f62af2e7d14c773a9cf8e70046d07ab2a29bdf5

Updates from Overleaf

view details

Andreas Madsen

commit sha 14ac831347dd6399250f7bdd05b015c7ae395ea7

Merge overleaf-2019-11-08-1314 into master

view details

push time in 4 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-08-1314

created branch time in 4 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 2a629e7e5bb961c2d1d47cad3b06a618f7d6b495

results

view details

push time in 4 months

delete branch AndreasMadsen/stable-nalu

delete branch : overleaf-2019-11-07-0936

delete time in 4 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha bfb7a050c540b1666aa6045445a268c0372dff50

Updates from Overleaf

view details

Andreas Madsen

commit sha d8d88a956e4b68dc29931fdfcd603cae35298dee

Merge overleaf-2019-11-07-0936 into master

view details

push time in 4 months

create barnchAndreasMadsen/stable-nalu

branch : overleaf-2019-11-07-0936

created branch time in 4 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 0afd4e9fcdd1c8a883350b645b36d9a9b7076672

update nalu-gate experiment

view details

push time in 4 months

startedjoeynmt/joeynmt

started time in 4 months

pull request commentAndreasMadsen/interpreted

Remove timings in test/fixture

Why not just actual = actual.replace(/\s*# time=[0-9.]+m?s/g, '');?

fnogatz

comment created time in 4 months

push eventAndreasMadsen/interpreted

Falco Nogatz

commit sha 16bcad8014c141732b9a104403cc9c8be3c83eef

Use latest node.js and LTS versions in Travis CI (#11)

view details

push time in 4 months

PR merged AndreasMadsen/interpreted

Use latest node.js and LTS versions in .travis.yml

The newest TAP uses JS features only added in recent node.js versions. It makes sense to (only) support the latest node.js and LTS versions (see Travis CI documentation), so I updated .travis.yml accordingly.

+2 -3

0 comment

1 changed file

fnogatz

pr closed time in 4 months

issue commentAndreasMadsen/interpreted

Adding interpreted as dependency crashes `npm audit`

I can reproduce the error.

fnogatz

comment created time in 4 months

push eventAndreasMadsen/interpreted

Andreas Madsen

commit sha b0c73662c70580178aa52ea2d0ac25a1d7a83afc

update test fixtures

view details

Andreas Madsen

commit sha c1f62710373972b27488f4c7f0b48731d611df36

version 1.0.1

view details

push time in 4 months

push eventAndreasMadsen/interpreted

Falco Nogatz

commit sha e143b1b26af3a8163adc2f03df3cefd8fe1804b4

Update devDep tap@14; Use --no-coverage for tap calls (#8)

view details

push time in 4 months

PR merged AndreasMadsen/interpreted

Update devDep tap@14; Use --no-coverage for tap calls

tap@12 has a transitive dependency on diff@ <3.5.0, which has a vulnerability found by npm audit and GitHub Alerts.

I also added --no-coverage option for all tap runners, as coverage reports are enabled by default since tap@13.

+3 -3

1 comment

2 changed files

fnogatz

pr closed time in 4 months

pull request commentAndreasMadsen/interpreted

Update devDep tap@14; Use --no-coverage for tap calls

Thanks.

fnogatz

comment created time in 4 months

push eventAndreasMadsen/clarify

dependabot[bot]

commit sha 038dea834f7d5c4f0bc8534851ef32b6524da292

Bump eslint from 2.13.1 to 6.5.1 (#13) Bumps [eslint](https://github.com/eslint/eslint) from 2.13.1 to 6.5.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v2.13.1...v6.5.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 4 months

PR merged AndreasMadsen/clarify

Bump eslint from 2.13.1 to 6.5.1 dependencies

Bumps eslint from 2.13.1 to 6.5.1. <details> <summary>Release notes</summary>

Sourced from eslint's releases.

v6.5.1

  • 0d3d7d9 Docs: fix typo in no-magic-numbers (#12345) (Josiah Rooney)
  • 447ac87 Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) (#12339) (Kai Cataldo)
  • b6ff73c Sponsors: Sync README with website (ESLint Jenkins)

v6.5.0

  • 73596cb Update: Add enforceForSwitchCase option to use-isnan (#12106) (Milos Djermanovic)
  • d592a24 Fix: exclude \u000d so new line won't convert to text (fixes #12027) (#12031) (zamboney)
  • e85d27a Fix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231) (Milos Djermanovic)
  • b349bf7 Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247) (Milos Djermanovic)
  • 7dc1ea9 Fix: no-useless-return autofix removes comments (#12292) (Milos Djermanovic)
  • 0e68677 Fix: no-extra-bind autofix removes comments (#12293) (Milos Djermanovic)
  • 6ad7e86 Fix: no-extra-label autofix removes comments (#12298) (Milos Djermanovic)
  • acec201 Fix: no-undef-init autofix removes comments (#12299) (Milos Djermanovic)
  • d89390b Fix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230) (Barrie Treloar)
  • 334ca7c Update: no-useless-rename also reports default values (fixes #12301) (#12322) (Kai Cataldo)
  • 41bfe91 Update: Fix handling of chained new expressions in new-parens (#12303) (Milos Djermanovic)
  • 160b7c4 Chore: add autofix npm script (#12330) (Kai Cataldo)
  • 04b6adb Chore: enable eslint-plugin-jsdoc (refs #11146) (#12332) (Kai Cataldo)
  • 9b86167 Docs: Add new ES environments to Configuring ESLint (#12289) (Milos Djermanovic)
  • c9aeab2 Docs: Add supported ECMAScript version to README (#12290) (Milos Djermanovic)
  • 8316e7b Fix: no-useless-rename autofix removes comments (#12300) (Milos Djermanovic)
  • 29c12f1 Chore: cache results in runtime-info (#12320) (Kai Cataldo)
  • f5537b2 Fix: prefer-numeric-literals autofix removes comments (#12313) (Milos Djermanovic)
  • 11ae6fc Update: Fix call, new and member expressions in no-extra-parens (#12302) (Milos Djermanovic)
  • a7894eb New: add --env-info flag to CLI (#12270) (Kai Cataldo)
  • 61392ff Sponsors: Sync README with website (ESLint Jenkins)
  • 2c6bf8e Docs: English fix (#12306) (Daniel Nixon)
  • 6f11877 Sponsors: Sync README with website (ESLint Jenkins)
  • 2e202ca Docs: fix links in array-callback-return (#12288) (Milos Djermanovic)
  • e39c631 Docs: add example for CLIEngine#executeOnText 3rd arg (#12286) (Kai Cataldo)
  • d4f9a16 Update: add support for JSXFragments in indent rule (fixes #12208) (#12210) (Kai Cataldo)
  • c6af95f Sponsors: Sync README with website (ESLint Jenkins)
  • 8cadd52 Sponsors: Sync README with website (ESLint Jenkins)
  • f9fc695 Chore: enable default-param-last (#12244) (薛定谔的猫)
  • 9984c3e Docs: Update README team and sponsors (ESLint Jenkins)

v6.4.0

  • e915fff Docs: Improve examples and clarify default option (#12067) (Yuping Zuo)
  • 540296f Update: enforceForClassMembers option to accessor-pairs (fixes #12063) (#12192) (Milos Djermanovic)
  • d3c2334 Update: flag nested block with declaration as error (#12193) (David Waller)
  • b2498d2 Update: Fix handling of property names in no-self-assign (#12105) (Milos Djermanovic)
  • 1ee61b0 Update: enforceForClassMembers computed-property-spacing (fixes #12049) (#12214) (Milos Djermanovic)
  • 520c922 Docs: Added naming convention details to plugin usage (#12202) (Henrique Barcelos)
  • f826eab Fix: Allow line comment exception in object-curly-spacing (fixes #11902) (#12216) (Milos Djermanovic)
  • db2a29b Update: indentation of comment followed by semicolon (fixes #12232) (#12243) (Kai Cataldo)
  • ae17d1c Fix: no-sequences is reporting incorrect locations (#12241) (Milos Djermanovic)
  • 365331a Fix: object-shorthand providing invalid fixes for typescript (#12260) (Brad Zacher)
  • 1c921c6 New: add no-import-assign (fixes #12237) (#12252) (Toru Nagashima)
  • 3be04fd New: Add prefer-regex-literals rule (fixes #12238) (#12254) (Milos Djermanovic) </tr></table> ... (truncated) </details> <details> <summary>Changelog</summary>

Sourced from eslint's changelog.

v6.5.1 - September 30, 2019

  • 0d3d7d9 Docs: fix typo in no-magic-numbers (#12345) (Josiah Rooney)
  • 447ac87 Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) (#12339) (Kai Cataldo)
  • b6ff73c Sponsors: Sync README with website (ESLint Jenkins)

v6.5.0 - September 29, 2019

  • 73596cb Update: Add enforceForSwitchCase option to use-isnan (#12106) (Milos Djermanovic)
  • d592a24 Fix: exclude \u000d so new line won't convert to text (fixes #12027) (#12031) (zamboney)
  • e85d27a Fix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231) (Milos Djermanovic)
  • b349bf7 Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247) (Milos Djermanovic)
  • 7dc1ea9 Fix: no-useless-return autofix removes comments (#12292) (Milos Djermanovic)
  • 0e68677 Fix: no-extra-bind autofix removes comments (#12293) (Milos Djermanovic)
  • 6ad7e86 Fix: no-extra-label autofix removes comments (#12298) (Milos Djermanovic)
  • acec201 Fix: no-undef-init autofix removes comments (#12299) (Milos Djermanovic)
  • d89390b Fix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230) (Barrie Treloar)
  • 334ca7c Update: no-useless-rename also reports default values (fixes #12301) (#12322) (Kai Cataldo)
  • 41bfe91 Update: Fix handling of chained new expressions in new-parens (#12303) (Milos Djermanovic)
  • 160b7c4 Chore: add autofix npm script (#12330) (Kai Cataldo)
  • 04b6adb Chore: enable eslint-plugin-jsdoc (refs #11146) (#12332) (Kai Cataldo)
  • 9b86167 Docs: Add new ES environments to Configuring ESLint (#12289) (Milos Djermanovic)
  • c9aeab2 Docs: Add supported ECMAScript version to README (#12290) (Milos Djermanovic)
  • 8316e7b Fix: no-useless-rename autofix removes comments (#12300) (Milos Djermanovic)
  • 29c12f1 Chore: cache results in runtime-info (#12320) (Kai Cataldo)
  • f5537b2 Fix: prefer-numeric-literals autofix removes comments (#12313) (Milos Djermanovic)
  • 11ae6fc Update: Fix call, new and member expressions in no-extra-parens (#12302) (Milos Djermanovic)
  • a7894eb New: add --env-info flag to CLI (#12270) (Kai Cataldo)
  • 61392ff Sponsors: Sync README with website (ESLint Jenkins)
  • 2c6bf8e Docs: English fix (#12306) (Daniel Nixon)
  • 6f11877 Sponsors: Sync README with website (ESLint Jenkins)
  • 2e202ca Docs: fix links in array-callback-return (#12288) (Milos Djermanovic)
  • e39c631 Docs: add example for CLIEngine#executeOnText 3rd arg (#12286) (Kai Cataldo)
  • d4f9a16 Update: add support for JSXFragments in indent rule (fixes #12208) (#12210) (Kai Cataldo)
  • c6af95f Sponsors: Sync README with website (ESLint Jenkins)
  • 8cadd52 Sponsors: Sync README with website (ESLint Jenkins)
  • f9fc695 Chore: enable default-param-last (#12244) (薛定谔的猫)
  • 9984c3e Docs: Update README team and sponsors (ESLint Jenkins)

v6.4.0 - September 13, 2019

  • e915fff Docs: Improve examples and clarify default option (#12067) (Yuping Zuo)
  • 540296f Update: enforceForClassMembers option to accessor-pairs (fixes #12063) (#12192) (Milos Djermanovic)
  • d3c2334 Update: flag nested block with declaration as error (#12193) (David Waller)
  • b2498d2 Update: Fix handling of property names in no-self-assign (#12105) (Milos Djermanovic)
  • 1ee61b0 Update: enforceForClassMembers computed-property-spacing (fixes #12049) (#12214) (Milos Djermanovic)
  • 520c922 Docs: Added naming convention details to plugin usage (#12202) (Henrique Barcelos)
  • f826eab Fix: Allow line comment exception in object-curly-spacing (fixes #11902) (#12216) (Milos Djermanovic)
  • db2a29b Update: indentation of comment followed by semicolon (fixes #12232) (#12243) (Kai Cataldo)
  • ae17d1c Fix: no-sequences is reporting incorrect locations (#12241) (Milos Djermanovic) </tr></table> ... (truncated) </details> <details> <summary>Commits</summary>

This version was pushed to npm by eslint, a new releaser for eslint since your current version. </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 4 months

create barnchAndreasMadsen/talk-properbility-in-tfjs-ch1

branch : gh-pages

created branch time in 4 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha e1303d13c3d851e4c82fa6fa29cc62fd464e0d8a

add read paper links

view details

push time in 5 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 1bf60a52a134d2441879950891d2013480214edc

fix title

view details

push time in 5 months

push eventAndreasMadsen/stable-nalu

Andreas Madsen

commit sha 088c28b4325ac32e300147896cd8acc8e1966ec3

update readme and add social image

view details

push time in 5 months

PublicEvent

startedAndreasMadsen/stable-nalu

started time in 5 months

issue closedAndreasMadsen/htmlparser-benchmark

Unable to benchmark a parser that returns a Promise

I tried to benchmark an HTML parser I'm working on that returns a Promise for its results. This benchmark was unable to work with that parser, however, most likely because Node doesn't wait for unresolved Promises, it just moves on and terminates if everything else besides those Promises has completed.

I was able to get around that problem with these small changes:

Benchmark.prototype._file = function (item, done) {
	var self = this;

	fs.readFile(item.file, 'utf8', function (err, html) {
		if (err) return done(err);

		var tic = process.hrtime();
		var parserResult = self._parser(html, function (err) {
			var toc = process.hrtime(tic);

			if (err) {
				done(err, toc);
			} else {
				self.emit('progress', item.key);
				done(null, toc);
			}
		});

		if (parserResult instanceof Promise) {
			var keepAlive = setTimeout(function() {}, 1E9);
			parserResult.then(function() { clearTimeout(keepAlive); });
		}
	});
};

Now that I've got your benchmark working for me, however, I'm probably going to abandon the Promise-returning version of my parser since it turned out to be 10 times slower than my synchronous parser! Nevertheless, someone else might want this capability, so I thought I'd offer my changes as a suggestion. Please let me know if you're interested and would want to see these changes submitted as a pull request.

closed time in 5 months

kshetline

issue commentAndreasMadsen/htmlparser-benchmark

Unable to benchmark a parser that returns a Promise

Sorry. If there really is an issue, you should isolate it to not depend on any module and open an issue at https://github.com/nodejs/node.

This benchmark was unable to work with that parser, however, most likely because Node doesn't wait for unresolved Promises, it just moves on and terminates if everything else besides those Promises has completed.

I highly doubt this is true. You can always use util.callbackify to turn a promise into a callback. Secondly, "wait for unresolved Promises" isn't really a thing. resolving promises happens without interrupts as resolves or rejects are scheduled as microtask, thus there is nothing to wait for. Of course the resolve() or reject() call themself, are waiting for something but that is unrelated to promises.

kshetline

comment created time in 5 months

more