profile
viewpoint
Alamofire Alamofire http://alamofire.org Elegant Networking in Swift

startedAlamofire/Alamofire

started time in an hour

fork Azraeltulips/Alamofire

Elegant HTTP Networking in Swift

fork in 2 hours

startedAlamofire/Alamofire

started time in 2 hours

startedAlamofire/Alamofire

started time in 3 hours

fork ShashikantBhadke/Alamofire

Elegant HTTP Networking in Swift

fork in 10 hours

startedAlamofire/AlamofireImage

started time in 11 hours

startedAlamofire/AlamofireImage

started time in 11 hours

startedAlamofire/Alamofire

started time in 11 hours

fork hamdshah/Alamofire

Elegant HTTP Networking in Swift

fork in 13 hours

issue commentAlamofire/Alamofire

Including base-64-encoded image in json body of a .POST triggering crash every time in Xcode 6.4

Is it right to send encode image through postman { "image":"encode detail" } i have deserialize issue

ghost

comment created time in 14 hours

startedAlamofire/Alamofire

started time in 15 hours

startedAlamofire/Alamofire

started time in 15 hours

startedAlamofire/Alamofire

started time in 17 hours

startedAlamofire/Alamofire

started time in 17 hours

issue openedAlamofire/Alamofire

Upload Progress Method don't called when use netfox

What did you do?

i have my project with Alamofire i used uploadProgress() function on upload request like this :

uploadRequest = AF.upload(
            multipartFormData: { (multipartFormData) in
                multipartFormData.append(fileUrl, withName: "file")
                multipartFormData.append("\(id)".data(using: String.Encoding.utf8, allowLossyConversion: false)!, withName: "customer_id")
            },

            to: Constants.kAddMedia, headers: Constants.kHeaders)
            .uploadProgress { (prgs) in
                progress(Float(prgs.fractionCompleted))
            }
            .responseJSON { response in

              // do my stuff 
        }

    }

What did you expect to happen?

.uploadProgress { (prgs) in
            progress(Float(prgs.fractionCompleted))
        }

called and call the progress handler , i have tried print(prgs.fractionCompleted) but not called too

What happened instead?

The function never called unless i removed the netfox line from app delegate

NFX.sharedInstance().start()

Alamofire Environment

Alamofire version: 5.0.0-rc.2 (the problem happened with previous versions too) Xcode version: 11.0 (11A420a) Swift version: 5 Platform(s) running Alamofire: macOS version running Xcode: 10.15 (19A583)

created time in 19 hours

fork serbancoroiu/Alamofire

Elegant HTTP Networking in Swift

fork in 19 hours

startedAlamofire/Alamofire

started time in 19 hours

startedAlamofire/Alamofire

started time in 21 hours

startedAlamofire/Alamofire

started time in a day

fork Santiago0412/Alamofire

Elegant HTTP Networking in Swift

fork in a day

startedAlamofire/Alamofire

started time in a day

startedAlamofire/Alamofire

started time in a day

fork jamesbouker/Alamofire

Elegant HTTP Networking in Swift

fork in a day

issue commentAlamofire/Alamofire

Swift 4 support

^ This note regarding Swift 3.2 is resolved now.

pkc456

comment created time in a day

startedAlamofire/Alamofire

started time in a day

issue openedAlamofire/AlamofireImage

init(memoryCapacity:diskCapacity:diskPath:)' is unavailable in UIKit for Mac

Using latest Xcode 11.0 building for mac I get the following build error:

init(memoryCapacity:diskCapacity:diskPath:)' is unavailable in UIKit for Mac

Would be awesome if that could be fixed!

created time in a day

startedAlamofire/Alamofire

started time in a day

startedAlamofire/Alamofire

started time in a day

startedAlamofire/Alamofire

started time in a day

startedAlamofire/Alamofire

started time in a day

fork aliashlar/Alamofire

Elegant HTTP Networking in Swift

fork in 2 days

issue commentAlamofire/AlamofireImage

af_setImage on ios13 causes app to crash

in 13.1 simulator still hangs the debugger in the same position. any clue how to overcome this?

tomeron11

comment created time in 2 days

issue openedAlamofire/Alamofire

Restful API in background mode not working!

What did you do?

ℹ I want to call rest api in background mode in ios.

class Networking { static let sharedInstance = Networking() public var sessionManager: Alamofire.SessionManager // most of your web service clients will call through sessionManager public var backgroundSessionManager: Alamofire.SessionManager // your web services you intend to keep running when the system backgrounds your app will use this

private init() {
    self.sessionManager = Alamofire.SessionManager(configuration: URLSessionConfiguration.default)
self.backgroundSessionManager = Alamofire.SessionManager(configuration: URLSessionConfiguration.background(withIdentifier: "com.nestedlogics.background"))
self.backgroundSessionManager.startRequestsImmediately = true
}

}

In AppDelegate.swift

func application(_ application: UIApplication, handleEventsForBackgroundURLSession identifier: String, completionHandler: @escaping () -> Void) {

    Networking.sharedInstance.backgroundSessionManager.backgroundCompletionHandler = completionHandler
}

Also in capabilities I have enabled Background Fetch!

What did you expect to happen?

ℹ It should complete rest API request in background mode without any error.

What happened instead?

ℹ The request callback give me failure: in result Error code -999 cancelled.

Alamofire Environment

**Alamofire version:4.8.1 **Xcode version:10.2.1 **Swift version:5 **Platform(s) running Alamofire:ios 13.1 **macOS version running Xcode:10.15 Beta

Demo Project

ℹ Please link to or upload a project we can download that reproduces the issue.

created time in 2 days

startedAlamofire/AlamofireNetworkActivityIndicator

started time in 2 days

issue openedAlamofire/Alamofire

Sending a POST with UUID obj inside parameters crashes app

What did you do?

Send a POST request with a UUID inside the parameters dictionary

What did you expect to happen?

The UUID object should have been encoded into a String.

What happened instead?

App Crashes, with LLDB showing the following:

Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Invalid type in JSON write (__NSConcreteUUID)'

Alamofire Environment

Alamofire version: 4.8.2 Xcode version: 11 Swift version: 5 Platform(s) running Alamofire: iOS macOS version running Xcode: 10.15

created time in 2 days

startedAlamofire/Alamofire

started time in 2 days

startedAlamofire/Alamofire

started time in 2 days

startedAlamofire/Alamofire

started time in 2 days

startedAlamofire/Alamofire

started time in 2 days

fork 75902641/Alamofire

Elegant HTTP Networking in Swift

fork in 2 days

fork woodtengfei/Alamofire

Elegant HTTP Networking in Swift

fork in 2 days

pull request commentAlamofire/Alamofire

feat (Response) : update debugDescription

I've updated my PR to use the debugDescription implementation from Alamofire 5, which includes the body data.

rain2540

comment created time in 2 days

fork sultani0802/Alamofire

Elegant HTTP Networking in Swift

fork in 2 days

push eventAlamofire/Alamofire

Jon Shier

commit sha dbccbbb0dd03533c5e7c95e94beafa5c8186827a

Update Source/URLEncodedFormEncoder.swift

view details

push time in 2 days

Pull request review commentAlamofire/Alamofire

Stable encoded parameter order for URLEncodedFormEncoder

 public final class URLEncodedFormEncoder {     /// Creates an instance from the supplied parameters.     ///     /// - Parameters:-    ///   - arrayEncoding:     The `ArrayEncoding` to use. `.brackets` by default.-    ///   - boolEncoding:      The `BoolEncoding` to use. `.numeric` by default.-    ///   - dataEncoding:      The `DataEncoding` to use. `.base64` by default.-    ///   - dateEncoding:      The `DateEncoding` to use. `.deferredToDate` by default.-    ///   - keyEncoding:       The `KeyEncoding` to use. `.useDefaultKeys` by default.-    ///   - spaceEncoding:     The `SpaceEncoding` to use. `.percentEscaped` by default.-    ///   - allowedCharacters: The `CharacterSet` of allowed (non-escaped) characters. `.afURLQueryAllowed` by default.-    public init(arrayEncoding: ArrayEncoding = .brackets,+    ///   - alphabetizeKeyValuePairs: Whether or to sort the encoded key value pairs. `true` by default.
    ///   - alphabetizeKeyValuePairs: Whether or not to sort the encoded key value pairs. `true` by default.
jshier

comment created time in 2 days

fork dvarangotSG/Alamofire

Elegant HTTP Networking in Swift

fork in 2 days

startedAlamofire/Alamofire

started time in 2 days

issue commentAlamofire/Alamofire

Intermittently Slow Network Requests

did you fix this problem?

skeezus

comment created time in 2 days

startedAlamofire/Alamofire

started time in 2 days

issue closedAlamofire/Alamofire

Expected release date Alamofire 5 Final version - Swift 5.1 (Xcode 11)

[*] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

I wanted to upgrade my project to Swift 5.1 and go to Xcode 11. One of the dependencies in my project is Alamofire.

What did you expect?

I expected that with the release of the final version of Xcode 11, I would be able to transfer the project to Swift 5.1 and use all the cool things with the Xcode 11.

What happened instead?

Instead, 3 weeks after the release of Xcode 11, Alamofire has a release candidate version and I can’t use the new IDE and transfer the project to Swift 5.1

Alamofire Environment

Alamofire version: Alamofire 5.0.0-rc.2 Xcode version: Xcode 11.1 Swift version: Swift 5.1 Platform(s) running Alamofire: iOS 13 macOS version running Xcode: macOS 10.15

closed time in 3 days

anatoliykant

issue commentAlamofire/Alamofire

Expected release date Alamofire 5 Final version - Swift 5.1 (Xcode 11)

Alamofire 4 and 5 work fine under Xcode 11, all versions.

anatoliykant

comment created time in 3 days

issue openedAlamofire/Alamofire

The behavior of Alamofire differs on WatchKit and iOS.

What did you do?

ℹ I send the same request in the Watch kit Extension and iOS.

What did you expect to happen?

ℹ I expect that response is returned success in both OS.

What happened instead?

ℹ My request from iOS is successful, but if the same request sends in WatcKit Extension, It will be a failure. Http code which is returned from the server is 401. I investigated this error in logs and some cookies didn't receive to server.

//Session Create let watchSessionManager: Session = { let configuration = URLSessionConfiguration.default let session = Session(configuration: configuration) return session }()

// example request in project let headers: HTTPHeaders = ["X-Requested-With": "XMLHttpRequest", "Content-Type": "application/x-www-form-urlencoded; charset=utf-8"] let parameters: Parameters = [] watchSessionManager.request("....",method: .post, parameters: parameters,encoding: URLEncoding.default, headers: headers).responseData { (response) in }

Alamofire Environment

**Alamofire version:5.0.0-rc.2 **Xcode version:11.0 **Swift version:6 **Platform(s) running Alamofire: WatchOS 6 , iOS 13

created time in 3 days

issue openedAlamofire/Alamofire

Expected release date Alamofire 5 Final version - Swift 5.1 (Xcode 11)

[*] I've read, understood, and done my best to follow the *CONTRIBUTING guidelines.

What did you do?

I wanted to upgrade my project to Swift 5.1 and go to Xcode 11. One of the dependencies in my project is Alamofire.

What did you expect?

I expected that with the release of the final version of Xcode 11, I would be able to transfer the project to Swift 5.1 and use all the cool things with the Xcode 11.

What happened instead?

Instead, 3 weeks after the release of Xcode 11, Alamofire has a release candidate version and I can’t use the new IDE and transfer the project to Swift 5.1

Alamofire Environment

Alamofire version: Alamofire 5.0.0-rc.2 Xcode version: Xcode 11.1 Swift version: SWIFT 5.1 Platform(s) running Alamofire: iOS macOS version running Xcode: macOS 10.15

created time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

fork HeroOnline/Alamofire

Elegant HTTP Networking in Swift

fork in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

issue commentAlamofire/Alamofire

Alamofire 5 - Parameters

Thanks @jshier, another question, if possible, Alamofire 5 manage the session configuration in background ?

marinofaggiana

comment created time in 3 days

issue commentAlamofire/AlamofireImage

UIImage.af_inflate(): Failed to grow buffer crash

@mickyzinho That doesn't seem related to this issue.

@iosdevben I was unable to speak to anyone about this issue, unfortunately.

It would interesting to see if anyone is seeing this crash on iOS 13. Perhaps this was fixed during that release?

DarrenAndes

comment created time in 3 days

issue closedAlamofire/AlamofireImage

ImageDownloader never works

ℹ Please fill out this template when filing an issue. All lines beginning with an ℹ symbol instruct you with what info we expect. You can delete those lines once you've filled in the info.

Per our *CONTRIBUTING guidelines, we use GitHub for bugs and feature requests, not general support. Other issues should be opened on Stack Overflow with the tag alamofireimage.

Please remove this line and everything above it before submitting.

What did you do?

ℹ Please replace this with what you did.

What did you expect to happen?

ℹ Please replace this with what you expected to happen.

What happened instead?

ℹ Please replace this with of what happened instead.

Alamofire Environment

Alamofire version: Xcode version: Swift version: Platform(s) running AlamofireImage: macOS version running Xcode:

Demo Project

ℹ Please link to or upload a project we can download that reproduces the issue.

closed time in 3 days

iamimsh

issue commentAlamofire/AlamofireImage

ImageDownloader never works

If you create a local ImageDownloader instance and try to download anything, those downloads will be cancelled when the instance goes out of scope and is deinited. To prevent this issue you need to keep a reference to your ImageDownloader around while images are downloading. This is typically done using a singleton, but any method used to keep it alive will work.

iamimsh

comment created time in 3 days

issue closedAlamofire/AlamofireImage

Help! LivePhoto downloading and caching!

my goal do caching and downloading system for livephotos any one did something similar?

closed time in 3 days

BaturitskiyDenis

issue commentAlamofire/AlamofireImage

Help! LivePhoto downloading and caching!

AlamofireImage doesn't currently support live images.

BaturitskiyDenis

comment created time in 3 days

issue closedAlamofire/AlamofireImage

image size is compressed

I used responseImage to get a image. The image's size is 225*146, but the real size is 450*292. How could I get the image with original size ?

closed time in 3 days

PumpkinNXL

issue commentAlamofire/AlamofireImage

image size is compressed

This is the nature of retina devices: an image's native resolution is halved when it's displayed at 2x. The actual resolution of the image is unchanged, it's just displayed at a screen point resolution that's half.

PumpkinNXL

comment created time in 3 days

issue commentAlamofire/AlamofireImage

af_setImage with placeholder image briefly flashes placeholder image even when image is in cache

How are you setting the image in the cell? AlamofireImage checks the cache before setting the placeholder, so you may be getting the flash from a different request being cancelled on code reuse, or some other event order issue.

spnkr

comment created time in 3 days

issue commentAlamofire/AlamofireImage

af_setImage on ios13 causes app to crash

Sounds like it was an issue with iOS 13 that was fixed in 13.1. I'll leave this issue open a while longer in case there are other reports, but it doesn't seem like there's anything for us to do here.

tomeron11

comment created time in 3 days

issue closedAlamofire/AlamofireImage

Error Domain=NSURLErrorDomain Code=-1202 "The certificate for this server is invalid

Image not load. getting error when i load the image.

2019-10-11 11:07:34.697971+0530 ABCMobile[6924:2083244] Connection 11: default TLS Trust evaluation failed(-9843) 2019-10-11 11:07:34.698030+0530 ABCMobile[6924:2083244] Connection 11: TLS Trust encountered error 3:-9843 2019-10-11 11:07:34.698048+0530 ABCMobile[6924:2083244] Connection 11: encountered error(3:-9843) 2019-10-11 11:07:34.699320+0530 ABCMobile[6924:2083244] Connection 11: unable to determine interface type without an established connection 2019-10-11 11:07:34.699836+0530 ABCMobile[6924:2083244] Task <03DD0ADE-1638-41D9-B779-6543C536539A>.<13> HTTP load failed, 0/0 bytes (error code: -1202 [3:-9843]) 2019-10-11 11:07:34.701356+0530 ABCMobile[6924:2083742] Task <03DD0ADE-1638-41D9-B779-6543C536539A>.<13> finished with error [-1202] Error Domain=NSURLErrorDomain Code=-1202 "The certificate for this server is invalid. You might be connecting to a server that is pretending to be “abc.xyz.com” which could put your confidential information at risk." UserInfo={NSLocalizedRecoverySuggestion=Would you like to connect to the server anyway?, _kCFStreamErrorDomainKey=3, NSErrorPeerCertificateChainKey=( "<cert(0x128879800) s: *.pacificabs.com i: RapidSSL RSA CA 2018>", "<cert(0x12887a200) s: RapidSSL RSA CA 2018 i: DigiCert Global Root CA>" ), NSErrorClientCertificateStateKey=0, NSErrorFailingURLKey=https://abc.xyz.com/Image/UserImage/c66ca0dc-3cd2-41eb-872f-5bb7ff09cbb2.png, NSErrorFailingURLStringKey=https://abc.xyz.com/Image/UserImage/c66ca0dc-3cd2-41eb-872f-5bb7ff09cbb2.png, NSUnderlyingError=0x281ecd230 {Error Domain=kCFErrorDomainCFNetwork Code=-1202 "(null)" UserInfo={_kCFStreamPropertySSLClientCertificateState=0, kCFStreamPropertySSLPeerTrust=<SecTrustRef: 0x282270a20>, _kCFNetworkCFStreamSSLErrorOriginalValue=-9843, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9843, kCFStreamPropertySSLPeerCertificates=( "<cert(0x128879800) s: *.pacificabs.com i: RapidSSL RSA CA 2018>", "<cert(0x12887a200) s: RapidSSL RSA CA 2018 i: DigiCert Global Root CA>" )}}, _NSURLErrorRelatedURLSessionTaskErrorKey=( "LocalDataTask <03DD0ADE-1638-41D9-B779-6543C536539A>.<13>" ), _kCFStreamErrorCodeKey=-9843, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <03DD0ADE-1638-41D9-B779-6543C536539A>.<13>, NSURLErrorFailingURLPeerTrustErrorKey=<SecTrustRef: 0x282270a20>, NSLocalizedDescription=The certificate for this server is invalid. You might be connecting to a server that is pretending to be “abc.xyz.com” which could put your confidential information at risk.} 2019-10-11 11:07:34.791273+0530 ABCMobile[6924:2083244] [] tcp_input [C11.2:3] flags=[R.] seq=2594700783, ack=1391590276, win=0 state=FIN_WAIT_1 rcv_nxt=2594700783, snd_una=1391590275 2019-10-11 11:07:43.938050+0530 ABCMobile[6924:2083757] Connection 12: default TLS Trust evaluation failed(-9843) 2019-10-11 11:07:43.938139+0530 ABCMobile[6924:2083757] Connection 12: TLS Trust encountered error 3:-9843 2019-10-11 11:07:43.938179+0530 ABCMobile[6924:2083757] Connection 12: encountered error(3:-9843) 2019-10-11 11:07:43.940587+0530 ABCMobile[6924:2083757] Connection 12: unable to determine interface type without an established connection 2019-10-11 11:07:43.940993+0530 ABCMobile[6924:2083757] Task <C17912AF-FC9C-4D76-AAB6-95D73C4A712C>.<14> HTTP load failed, 0/0 bytes (error code: -1202 [3:-9843]) 2019-10-11 11:07:43.943060+0530 ABCMobile[6924:2083742] Task <C17912AF-FC9C-4D76-AAB6-95D73C4A712C>.<14> finished with error [-1202] Error Domain=NSURLErrorDomain Code=-1202 "The certificate for this server is invalid. You might be connecting to a server that is pretending to be “abc.xyz.com” which could put your confidential information at risk." UserInfo={NSLocalizedRecoverySuggestion=Would you like to connect to the server anyway?, _kCFStreamErrorDomainKey=3, NSErrorPeerCertificateChainKey=( "<cert(0x12801e000) s: *.pacificabs.com i: RapidSSL RSA CA 2018>", "<cert(0x128044000) s: RapidSSL RSA CA 2018 i: DigiCert Global Root CA>" ), NSErrorClientCertificateStateKey=0, NSErrorFailingURLKey=https://abc.xyz.com/Image/UserImage/c66ca0dc-3cd2-41eb-872f-5bb7ff09cbb2.png, NSErrorFailingURLStringKey=https://abc.xyz.com/Image/UserImage/c66ca0dc-3cd2-41eb-872f-5bb7ff09cbb2.png, NSUnderlyingError=0x281ecdce0 {Error Domain=kCFErrorDomainCFNetwork Code=-1202 "(null)" UserInfo={_kCFStreamPropertySSLClientCertificateState=0, kCFStreamPropertySSLPeerTrust=<SecTrustRef: 0x28226eb50>, _kCFNetworkCFStreamSSLErrorOriginalValue=-9843, _kCFStreamErrorDomainKey=3, _kCFStreamErrorCodeKey=-9843, kCFStreamPropertySSLPeerCertificates=( "<cert(0x12801e000) s: *.pacificabs.com i: RapidSSL RSA CA 2018>", "<cert(0x128044000) s: RapidSSL RSA CA 2018 i: DigiCert Global Root CA>" )}}, _NSURLErrorRelatedURLSessionTaskErrorKey=( "LocalDataTask <C17912AF-FC9C-4D76-AAB6-95D73C4A712C>.<14>" ), _kCFStreamErrorCodeKey=-9843, _NSURLErrorFailingURLSessionTaskErrorKey=LocalDataTask <C17912AF-FC9C-4D76-AAB6-95D73C4A712C>.<14>, NSURLErrorFailingURLPeerTrustErrorKey=<SecTrustRef: 0x28226eb50>, NSLocalizedDescription=The certificate for this server is invalid. You might be connecting to a server that is pretending to be “abc.xyz.com” which could put your confidential information at risk.} 2019-10-11 11:07:44.003372+0530 ABCMobile[6924:2083143] [] tcp_input [C12.2:3] flags=[R.] seq=2456623032, ack=3372388621, win=0 state=FIN_WAIT_1 rcv_nxt=2456623032, snd_una=3372388620

Thanks in Advance

closed time in 3 days

barotbhavesh

issue commentAlamofire/AlamofireImage

Error Domain=NSURLErrorDomain Code=-1202 "The certificate for this server is invalid

Sorry, we use our GitHub project for bug reports and feature requests. In the future, you should open questions like this on Stack Overflow.

Cheers. 🍻


From our Contribution Guidelines

Asking Questions

We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

barotbhavesh

comment created time in 3 days

issue closedAlamofire/Alamofire

Alamofire 5 upload multipartFormData with parameters?

I have a multiPartFormData upload for an image that needs to send my .php the id that wants to upload the info to

I want to know how to add parameters to alamofire 5 upload

When I try to autocomplete or look on the internet for some1 that already did it I cant find anything.

alamofire 5 xCode 10 swift 5 iOs 12.4 macOS 10.14.5 (18F132)

This is my code so far.

let urlAlert = URL(string: urlAlertS)! let headerS: HTTPHeaders = [ "Authorization": "Bearer (HelperGlobalVars.shared.access_token)", "Accept": "application/json" ]
let parameterS: Parameters = ["alertId": nId ?? 1, "image": image]

AF.upload( multipartFormData: { multipartFormData in multipartFormData.append(image!.jpegData(compressionQuality: 0.5)!, withName: "upload_data" , fileName: "file.jpeg", mimeType: "image/jpeg") }, to: urlAlert, method: .put , headers: headerS) .response { resp in print(resp) }

closed time in 3 days

Yustruck

issue commentAlamofire/Alamofire

Alamofire 5 upload multipartFormData with parameters?

Sorry, we use our GitHub project for bug reports and feature requests. In the future, you should open questions like this on Stack Overflow and tag alamofire.

Cheers. 🍻


From our Contribution Guidelines

Asking Questions

We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.

Yustruck

comment created time in 3 days

pull request commentAlamofire/Alamofire

feat (Response) : add info for debugDescription

@rain2540 Looks like we'll be doing a 4.9.1 release after all. If you can update your PR to use the debugDescription implementation from Alamofire 5, which includes the body data, we can make this PR part of that release.

rain2540

comment created time in 3 days

PR opened Alamofire/Alamofire

Remove Dynamic Bundle Identifier - v4

Same as #2966 but for version 4.

+4 -2

0 comment

1 changed file

pr created time in 3 days

create barnchAlamofire/Alamofire

branch : bug/remove-dynamic-identifier-v4

created branch time in 3 days

PR opened Alamofire/Alamofire

Remove Dynamic Bundle Identifier

Issue Link :link:

#2938

Goals :soccer:

This PR removes the dynamic bundle identifier originally added to address iTMS-90806 and #2925. Turns out this doesn't play well with pre-built products or Carthage in general.

Implementation Details :construction:

This reverts the dynamic bundle identifier and moves back to the static one, with the addition of a specific watchOS identifier, since that's the only platform it was really needed for.

Testing Details :mag:

No new tests.

+4 -6

0 comment

1 changed file

pr created time in 3 days

create barnchAlamofire/Alamofire

branch : bug/remove-dynamic-identifier

created branch time in 3 days

issue commentAlamofire/Alamofire

[Alamofire 5] Upload API Access Control

Uploadable being public is a byproduct of the UploadRequest initializer previously being public. It's not really well designed for public consumption, but we'll consider it.

boborz

comment created time in 3 days

issue commentAlamofire/Alamofire

Alamofire 5 - Parameters

There is no top-level API to pass pre-encoded parameters while also having access to the various request parameters like method. There are a few things you can do here:

  • Create your request as a URLRequest with the appropriate httpBody and pass that request to Alamofire: AF.request(urlRequest).
  • Use a real XML parameter encoder (there are libraries) and create your own ParameterEncoder to wrap it. This would allow you to encode any Encodable type as XML for your requests. You can use the ParameterEncoders the Alamofire ships with as a guide.

I suppose the ability to provide pre-encoded Data in the top level APIs would be useful too.

marinofaggiana

comment created time in 3 days

fork netcanis/Alamofire

Elegant HTTP Networking in Swift

fork in 3 days

PR opened Alamofire/Alamofire

Move Automatic Resume Behavior to After the First Response Handler is Added

Issue Link :link:

No specific issue, but this change makes using Alamofire APIs that "chain" onto Requests fully safe, rather than there being an implicit race between adding those behaviors and the request completing.

Goals :soccer:

This PR moves the automatic resume behavior from within Session's Request set up logic, which called resume right after a URLSessionTask is created, to after the appending of a response serializer.

Implementation Details :construction:

This PR adds an additional property to the internal RequestDelegate protocol to allow Requests to query whether startRequestsImmediately is set. Additionally, logic has been added in appendResponseSerializer to, while accessing mutableState, check whether the Request can transition to the resumed state, and, if so, enqueues a check for startsImmediately on the underlyingQueue. If that value istrue,resume()will be called, which already handles duplicateresume` calls.

Testing Details :mag:

No additional tests were added, but a few were updated to ensure they call response handlers and resume the request.

+23 -18

0 comment

3 changed files

pr created time in 3 days

push eventAlamofire/Alamofire

Jon Shier

commit sha 848b74bb144930fed99fe182d83b44d1731b57ad

Move state check inside the lock.

view details

push time in 3 days

startedAlamofire/Alamofire

started time in 3 days

push eventAlamofire/Alamofire

Jon Shier

commit sha ffea215b52af829153b190229ec760529abb581c

Put delegate access on the underlying queue.

view details

push time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 3 days

startedAlamofire/Alamofire

started time in 4 days

startedAlamofire/Alamofire

started time in 4 days

fork haojianzong/AlamofireImage

AlamofireImage is an image component library for Alamofire

fork in 4 days

startedAlamofire/Foundation

started time in 4 days

fork ConfianceLabs/AlamofireImage

AlamofireImage is an image component library for Alamofire

fork in 4 days

push eventAlamofire/Alamofire

Jon Shier

commit sha 402dcff02ebcc5595d276415830323e1a8240900

Move automatic resume after appending first serializer.

view details

Jon Shier

commit sha 57434880cde0130c2c43019a7713d5f7f727ba17

Fix tests.

view details

push time in 4 days

startedAlamofire/AlamofireImage

started time in 4 days

fork zhiycn/Alamofire

Elegant HTTP Networking in Swift

fork in 5 days

startedAlamofire/Alamofire

started time in 5 days

more