profile
viewpoint
Adlai Holler Adlai-Holler @google Redwood City, CA

Adlai-Holler/ArrayDiff 99

A Swift utility to make updating table views/collection views trivially easy and reliable.

Adlai-Holler/Atomic 33

A Swift microframework for very easy atomic values.

Adlai-Holler/CoreDataOperation 3

A fast, safe, flexible operation class for updating data stored in Core Data, written in Swift.

Adlai-Holler/AsyncDisplayKitExtensions 2

Some Swift integrations I've found useful with AsyncDisplayKit.

Adlai-Holler/AsyncDisplayKitGrowingTextCellDemo 1

An attempt to build a table view cell that contains a growing text view for iOS using AsyncDisplayKit

Adlai-Holler/BondPlusCoreData 1

An NSFetchedResultsController-backed DynamicArray implementation

adcooley/Bond 0

A Swift binding framework

Adlai-Holler/ADLYRetainingCache 0

An NSCache subclass that allows you to force the retention of objects

Adlai-Holler/AHFetchedResultsKit 0

A simple library to make handling NSFetchedResultsController delegate messages a lot cleaner and safer.

create barnchAdlai-Holler/engine

branch : grctx

created branch time in 6 days

PR opened flutter/engine

Update more class names from GrContext to GrDirectContext

This name change has to do with SkDeferredDisplayList, which Flutter does not use. As far as Flutter is concerned, this is a no-op.

Continuation of the migration started in #19962.

+6 -6

0 comment

4 changed files

pr created time in 6 days

delete branch Adlai-Holler/engine

delete branch : external_tex_ctx

delete time in 2 months

pull request commentflutter/engine

android_external_texture: Use the available GrDirectContext arg

@chinmaygarde ?

Adlai-Holler

comment created time in 2 months

PR opened flutter/engine

android_external_texture: Use the available GrDirectContext arg

getGrContext is going away, plus we already have the fully-powered-up GrDirectContext available and we previously weren't using it.

+3 -2

0 comment

1 changed file

pr created time in 2 months

create barnchAdlai-Holler/engine

branch : external_tex_ctx

created branch time in 2 months

delete branch Adlai-Holler/engine

delete branch : more_direct_ctx

delete time in 3 months

pull request commentflutter/engine

Migrate a few last places to GrDirectContext

Looks like the mac failure is infra. Rerun/land?

Adlai-Holler

comment created time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha c6634ad48dd537da0828a623dfae9c326d72998e

Formatting

view details

push time in 3 months

PR opened flutter/engine

Migrate a few last places to GrDirectContext

This is a followup to #19962 to cover a few places where we were still using GrContext. No functional impact.

+10 -10

0 comment

7 changed files

pr created time in 3 months

create barnchAdlai-Holler/engine

branch : more_direct_ctx

created branch time in 3 months

delete branch Adlai-Holler/engine

delete branch : direct_context_factory

delete time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

@gaaclarke @chinmaygarde Any chance we can get this in the bank today?

Adlai-Holler

comment created time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

build_and_test_linux_unopt_debug failure seems like an infra flake

Adlai-Holler

comment created time in 3 months

push eventAdlai-Holler/engine

skia-flutter-autoroll

commit sha 0e31e16a7f877bfa2ff2941507512fb596683acb

Roll Skia from a75dc33a677f to c8bc99ff6a8a (4 revisions) (#20001)

view details

skia-flutter-autoroll

commit sha c4920336e6aa409ab09f801b18c72aac8dd4e89c

Roll Fuchsia Linux SDK from FYoGW-y7o... to vzpWHX5jS... (#20002)

view details

skia-flutter-autoroll

commit sha b06a511c950b8dd6064693752f48cda07eff10c2

Roll Skia from c8bc99ff6a8a to 809a99819e70 (2 revisions) (#20004)

view details

nturgut

commit sha debb36da5d88bcfc334b57da5f52c4052ad5c5df

Address platform changes in the integration tests. (#20008)

view details

Siva

commit sha 3bb6cc265ef2bfeb055b3cc1ac556f3b4f5ee0da

Manual merge of Dart a3815b6590...24c7666def (#19967) * Manual merge or Dart into flutter a3815b6590...24c7666def dart-lang/sdk@24c7666def Update tests that have the current version number hardcoded dart-lang/sdk@f88ce7aef5 Increase Dart version to 2.10 * Update language version. * Update license. * Hpdate language version. * Update license.

view details

skia-flutter-autoroll

commit sha 26a22a6378b96fce4cc6a6dbfad27ef08bf41210

Roll Skia from 809a99819e70 to 8513867ced39 (6 revisions) (#20009)

view details

Jonah Williams

commit sha 3596b9b8b4dc49137b02ac736675f1509c82c828

remove usage of dartdev command (#20011) * remove usage of dartdev command so that gclient runhooks can re-generate package_config.json

view details

Jonah Williams

commit sha 9dac7148e100334a2cabb97118d5b7646f001559

[null-safety] fix real type failures in web engine (#20010) remove extra null checks

view details

Jonah Williams

commit sha 10adbbd0c5fd1c15e853885ff691aa475b292e74

fix gclient runhooks for windows (#20014) * fix gclient runhooks for windows

view details

Jason Simmons

commit sha 02c11acc240bb417f9589f10921ad4b70de9b19f

Add Dart 2.10 annotations to the web engine sources (#20019)

view details

Jason Simmons

commit sha d43e1dd5784cf7d8574c9f457e666cad6a9334d1

Disable the web SDK API conformance test until the analyzer is updated for Dart 2.10 (#20023)

view details

Jason Simmons

commit sha b48566470c5e8758e5ea472044b09b6364e166eb

Upgrade the analyzer package to version 0.39.15 for Dart 2.10 support (#20024)

view details

nturgut

commit sha c0ac43da9740724262c5bb4bba2b960273d504bd

Add a todo to felt (PR to rerun the tree) (#20025)

view details

Adlai Holler

commit sha 7d1c45449180c7de250f82cb4acdfc3356f82743

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

Adlai Holler

commit sha 73d37d113ad5188a50c02be5f9eda2ee3c39ff13

Nolint vulkan swapchain

view details

push time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

Issue filed at https://github.com/flutter/flutter/issues/62222

Looks like we have only infra failures remaining on the CI.

Adlai-Holler

comment created time in 3 months

issue openedflutter/flutter

Lint failure on vulkan_swapchain_stub.cc, <vulkan.h> file not found

In https://github.com/flutter/engine/pull/19962 this lint failure was discovered and a NOLINT was added to the file at issue.

We should debug this and remove the NOLINT.

created time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

Thanks for the reply! I've added the NOLINT. Where should I file an issue? This repo doesn't seem to support them.

Adlai-Holler

comment created time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 82806bf4b95d853086d8ca8a4e07b160a50d489e

Nolint vulkan swapchain

view details

push time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

Hi Chinmay! It's been about 6 years, I think!

Adlai-Holler

comment created time in 3 months

pull request commentflutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

The remaining failures seem like a tooling issue? <vulkan.h> file not found.

@jason-simmons thoughts on this? It's a big CL and I'm happy to talk more about the reason for it, but we'll have to do it eventually so we might as well rip the bandaid off. There's other API changes coming that are currently blocked by this (for instance, SkImage::MakeCrossContextFromPixmap should take a GrDirectContext argument instead of a GrContext one.

Adlai-Holler

comment created time in 3 months

push eventAdlai-Holler/engine

skia-flutter-autoroll

commit sha 50a0767bbd98012cfc3fdd3283e91303566f3cd2

Roll Fuchsia Linux SDK from ms0pkbUq8... to FYoGW-y7o... (#19984)

view details

Todd Volkert

commit sha 48f90888a6aa8d2373bf93590ffc4ddebde7d5fa

Add support for playing alert sound on MacOS (#19970) flutter/flutter#62143

view details

Emmanuel Garcia

commit sha 933c8b844170c3ccdf73c9c7da478e92c3d4a4d5

bool SubmitFrame -> void SubmitFrame (#18984)

view details

skia-flutter-autoroll

commit sha 66e929c07ff9b5c8fff539396d7bd3d123b79383

Roll Skia from 024d745fcc62 to 9eea916c05aa (4 revisions) (#19992)

view details

skia-flutter-autoroll

commit sha eafda789b4584be84b6ba41589759adbd4c9698c

Roll Skia from 9eea916c05aa to f617b4d9c2b8 (1 revision) (#19994)

view details

skia-flutter-autoroll

commit sha 1abef724451423e6f0bb868d404e604a043cfc7f

Roll Skia from f617b4d9c2b8 to 33419346946d (1 revision) (#19999)

view details

skia-flutter-autoroll

commit sha 798182e85490b9723ffd2f41c0640308a64d8d87

Roll Skia from 33419346946d to a75dc33a677f (6 revisions) (#20000)

view details

Adlai Holler

commit sha 65c67a6e6a746144f0f5ef49ce459cb68999b88d

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 61e43f6e7dccb38b6b23aa462fbe9d518523edbc

Fix metal external texture

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha ba0e3f05faa137ef7ae902aaae220da7ddc049d0

Clean up

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 919a9fb97e7a6c997dc788b8fbfe40957af58f24

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 4306614e81d3204e57e261e8b0970d6206d3e8f4

Declare type

view details

push time in 3 months

push eventAdlai-Holler/engine

Felipe Archondo

commit sha 1820dbedd3d77805d9b01d98ce8386d2d1e6d73f

fix and re-enable SessionConnection unit tests (#19812) [fuchsia] fix and re-enable SessionConnection unittests This change waits until Scenic is initialized before beginning the test logic. This should fix the issue where the test starts running before or during Scenic startup.

view details

skia-flutter-autoroll

commit sha 5df5cbb28ad80f89c0a92a7691eb1cbd5b38f7af

Roll Skia from b25e0650ddd8 to 024d745fcc62 (1 revision) (#19978)

view details

Emmanuel Garcia

commit sha 88ebc371068b4e8afd0e7e533ea1cd152362f45f

Remove android view from the Mutator stack (#19972)

view details

Adlai Holler

commit sha 4bee9fcde1a9d492034d17fb171769d3a1b7f214

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

Adlai Holler

commit sha a0ca2e8f18dbd8515ec9e1938cc3d47fb1729dd2

Just go for it all the way

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha aee56ca40613d4375b2cbdb10765d57cb890c6ec

And more

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 50386f808604dccf90c6f563c829f8fe72b844c5

More

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 184f5d053c6352608fb24eb4a6d9f357bda5862b

but wait, there's more!

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha a0ec3fb324c9776311a18c816e7a6e201bebe053

Embedder

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha b421a50e760fa78d1f966023a2767a615ff2c53f

io_manager

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha 458cfd92e077b8c00670f76bd5488e04bbbaaf84

Few more places

view details

push time in 3 months

push eventAdlai-Holler/engine

skia-flutter-autoroll

commit sha 0483794dcca3eaf90aad82336550a65be807ab4b

Roll Skia from 184f6013466b to c0e711019b91 (2 revisions) (#19964)

view details

gaaclarke

commit sha 21efd7325e389881de4b46f946a2314db246bb3c

Made the linter print out more information in its output and fixed bugs (#19895)

view details

skia-flutter-autoroll

commit sha 626244a72c5d53cc6d00c840987f9059faed511a

Roll Skia from c0e711019b91 to cc848b59f805 (3 revisions) (#19966)

view details

skia-flutter-autoroll

commit sha e52a6f96bfd5f9bde0d2e07044bbf7cdcd28abce

Roll Skia from cc848b59f805 to 72db7173488e (2 revisions) (#19969)

view details

skia-flutter-autoroll

commit sha 9dca199c4d5f29c5db067c456c0a4e81e65fc4a2

Roll Skia from 72db7173488e to d318489a1566 (2 revisions) (#19971)

view details

skia-flutter-autoroll

commit sha 5ffd64f64d5d09c8f5bb7e808fcf441a767fa193

Roll Skia from d318489a1566 to abd75556630d (1 revision) (#19973)

view details

skia-flutter-autoroll

commit sha 3cfe35767a3e4f89709959de052ab93abfe85b17

Roll Fuchsia Linux SDK from hXTFDVnq1... to ms0pkbUq8... (#19974)

view details

skia-flutter-autoroll

commit sha db44964574ec20b03c568096366d8c87e8eda29f

Roll Skia from abd75556630d to b8fe9093351f (2 revisions) (#19975)

view details

skia-flutter-autoroll

commit sha b7d99725998a1f65a2e0c4acb5516472c35795fb

Roll Skia from b8fe9093351f to 446b974be827 (1 revision) (#19976)

view details

skia-flutter-autoroll

commit sha 246331bdec9aa4ca8c87efeac0335bc44e64c5f3

Roll Skia from 446b974be827 to b25e0650ddd8 (1 revision) (#19977)

view details

Adlai Holler

commit sha 621cbf09b3e73ff998ddb7605b428648c1711e7a

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

Adlai Holler

commit sha 45dbbbf057b4af88d6bc8cd9d22e6dc16507b5fd

Format

view details

Adlai Holler

commit sha 7443b60d0b278f332020631546e98e26fb5163c3

Fix test surface

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha f77d83a13dae5879104dd566d92fd9e156c4f813

Fix test surface

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha c511e5bad9d853d9c6a9f7439d2fa985ac282498

Format

view details

push time in 3 months

push eventAdlai-Holler/engine

Adlai Holler

commit sha dd74d1853ecd17756bdd932b5126f566c5f47a5a

Use the GrDirectContext factories instead of deprecated GrContext ones This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

view details

push time in 3 months

PR opened flutter/engine

Use the GrDirectContext factories instead of deprecated GrContext ones

This is part of a larger effort to expose the difference between GrDirectContext, which runs on the GPU thread and can directly perform operations like uploading textures, and GrRecordingContext, which can only queue up work to be delivered to the GrDirectContext later.

Over time, GrContext will be replaced by:

  • GrDirectContext in cases where we know that we have the GPU access / with functions that require it.
  • GrRecordingContext in cases where we aren't sure / with functions that do not need to perform such actions.
+78 -78

0 comment

33 changed files

pr created time in 3 months

create barnchAdlai-Holler/engine

branch : direct_context_factory

created branch time in 3 months

more