profile
viewpoint
Aleksandra Budnik AMBudnik Handsoncode Gdynia Support Manager

AMBudnik/awesome-angularjs 1

:cyclone: A list of awesome AngularJs services, directives, utilities and resources.

AMBudnik/awesome-opensource-apps 1

:house::information_source: Curated list of awesome open source crafted web & mobile applications - Learn, Fork, Contribute & Most Importantly Enjoy!

AMBudnik/awesome-react-components 0

Catalog of React Components & Libraries

AMBudnik/color-picker 0

Color-picker sample for Handsontable

AMBudnik/fixedMate 0

Simple slider.

issue openedhandsontable/docs

Introduction - rephrase the sentence

Description

I think that we should avoid using other projects names

Handsontable is loved by users because it gives them the same experience as Google Sheets or Excel.

Links

Introduction page - https://handsontable.com/docs/8.1.0/tutorial-introduction.html

created time in 14 hours

issue openedhandsontable/docs

Selecting ranges

Description

  • I would add Use <kbd>SHIFT</kbd> to select range of cells as we already mentioned

Use CMD on Mac or CTRL on Windows to select non-contiguous ranges of cells.

In the first part of the page.

  • we should also mention multiple layers in

Choose between selecting a single cell, a range of adjacent cells and multiple ranges of non-contiguous cells.

and

multiple - Multiple non-contiguous ranges of cells can be selected.

  • The

To retrieve the selected cells as an array of arrays, you should use getSelected() or getSelectedRange() methods.

does not mention the change with getSelectedLast() that came with the multi-layer selection

  • grey <kbd>Get data</kbd> button under the second demo causes a console error Zrzut ekranu 2020-10-23 o 14 39 13 The same happens when we open the same demo in JSFiddle.

  • 3rds demo 'Log to console' button produces the console log below

Uncaught TypeError: Cannot read property 'getData' of undefined

  • we mention some exotic classes being used for selection

area-1, area-2

but do not show a demo where we use them.

  • there is no demo for using selectCell, deselectCell

  • There's no info about selecting all the cells from a column when col header is clicked (+same for rows)

Links

selecting ranges - https://handsontable.com/docs/8.1.0/demo-selecting-ranges.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 14 hours

issue openedhandsontable/docs

Customizing borders - improvements

Description

As mentioned by @pnowak in https://github.com/handsontable/support/issues/259#issuecomment-711638090 we should improve this page.

It could be mentioned that outside of settings, customBorders plugin can be used by contextMenu. the default style is 1px black

I would also add an example on using setCellMeta to add borders and/or the use of plugin methods like https://handsontable.com/docs/8.1.0/CustomBorders.html#setBorders

Links

support task (origin) - https://github.com/handsontable/support/issues/259

created time in 15 hours

issue openedhandsontable/docs

Conditional formatting - text formatting, console error and missing styling in a demo

Description

Here's the first part of the page

Zrzut ekranu 2020-10-23 o 12 34 44

where

  • silver is actually #EEE and it is not the same color on the text (a lot darker) than in the table
  • Nissan column is not italic?
  • 'green bold text,' has a different share or green

Additionally, clicking on the 'Log to console' button shows

samples.js:133 Uncaught TypeError: Cannot read property 'getData' of undefined

in the console

Links

conditional formatting - https://handsontable.com/docs/8.1.0/demo-conditional-formatting.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 16 hours

issue openedhandsontable/handsontable

[8.0.0+] maxCols/Rows with hiddenColumns/rows and larger dataset produces unexpected selection issues and table rendering

Description

<!--- Tell us what happens and what should happen --> maxCols/Rows with hiddenColumns/rows and larger dataset produces unexpected selection issues and table rendering.

Important: It happens only when your dataset contains more rows and columns than defined by maxCols and maxRows.

Case 1

Hide all the rows and columns

  1. We set up maxCols: 5 and maxRows: 5, and hide 5 row and 5 columns
  2. Go to https://jsfiddle.net/AMBudnik/ae54b7fg/ (7.4.2) - it is ok, we cannot see any data
  3. Go to https://jsfiddle.net/AMBudnik/7326rz5n/ (8.0.0) - you get the rest of the columns that were supposed to be blocked by maxCols / maxRows.

7.4.2 Result Zrzut ekranu 2020-10-23 o 10 07 50

8.0.0 Result Zrzut ekranu 2020-10-23 o 10 09 08

Case 2

Hide some of the rows and columns

  1. We set up maxCols: 5 and maxRows: 5, and hide 2 row and 2 columns
  2. Go to https://jsfiddle.net/AMBudnik/ae54b7fg/ (7.4.2) - it is ok, we the rest of the dataset (3 columns x 3 rows)
  3. Go to https://jsfiddle.net/AMBudnik/3xp7qmrs/ (8.0.0) - you should see C, D, and E columns but we get 2 more; we should see 3 rows but we get 5.

7.4.2 Result Zrzut ekranu 2020-10-23 o 10 11 13

8.0.0 Result Zrzut ekranu 2020-10-23 o 10 12 37

Additional complications

Not only rendering of the rows and columns is impaired, but we can also experience a lot of side effects.

  • selection of headers is broken. Go to https://jsfiddle.net/AMBudnik/3xp7qmrs/ and select some row and column headers. Then try to use CMD/CTRL + A to select all
  • selecting cells from rows that should not display produces console error handsontable.full.js:16893 Uncaught TypeError: Cannot read property 'sourceToRendered' of null
  • context menu does not allow to add any columns
  • editing cells in the unwanted cells is not saved
  • while removing rows via context menu we still get new rows so it always equals 5
  • you can hide rows and columns by context menu but you still get new rows and cols from your dataset. When you reach the last column/row from your dataset option for hiding does not work.
  • removing all the columns does not work Zrzut ekranu 2020-10-23 o 10 23 44 Zrzut ekranu 2020-10-23 o 10 23 51

Demo

<!--- Provide a link to a live example on JSFiddle or Codepen or fill the following demo with your settings --> https://jsfiddle.net/AMBudnik/5dr78L6y/ 8.1.0 - broken https://jsfiddle.net/AMBudnik/djLsqf4u/ 8.0.0 - broken https://jsfiddle.net/AMBudnik/Lmxjrtk0/ 7.4.2 - working well

Your environment

  • Handsontable version: 8.0.0+
  • Browser Name and version: Chrome 86
  • Operating System: macOS Catalina 10.15.6

created time in 19 hours

issue commenthandsontable/handsontable

Numeric fields are not emptied when data function returns null – previous value persists.

Thank you for sharing the issue description @craigmarvelley Would you be able to replicate the same issue by emulating server response in a JSFiddle? I've made a starter that can help https://jsfiddle.net/AMBudnik/0vnz53rj/

craigmarvelley

comment created time in 20 hours

issue commenthandsontable/handsontable

Updating dateFormat with datePickerConfig causes error in the console

Thank you for sharing the good news @rikkert! I see that the issue @aninde referenced is also fixed by Pikaday 1.8.2. We need to test it out.

aninde

comment created time in 20 hours

issue openedhandsontable/docs

Comments - error in the console after clicking the 'Log to console' button

Description

  • Do we need

I think all of them are pretty self-explanatory.

We should avoid using 1st-person declarations. I would replace that sentence with a demo with contextMenu enabled.

  • change 'declare it' to 'declare them' in

As comments are stored in the table's/column's/cell's meta data object, you can declare it as any other property of that type.

  • change 'at (1,1)' to 'at (1,1) coordinates' in

In this example we're adding a "Hello world!" comment to a cell at (1,1).

  • replace 'For More info,' with 'For more info,'

  • 'example implementation' demo shows the 'getData' error in the console on the 'Lod to console' click

  • it seems that after API's first paragraph we removed something to cause this paragraph seems to share the same info as the first part o the page + we get some random demo below with no description. I would add

  1. an example with comments custom context menu
  2. by-plugin comment declaration

Links

comments - https://handsontable.com/docs/8.1.0/demo-comments_.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Fix 'getData' console error across multiple pages in the documentation

Description

We found multiple pages with @pnowak where when clicked on 'Log to console' button the same error is thrown.

Zrzut ekranu 2020-10-22 o 14 26 12

Links

    • [ ] Scrolling - #227
    • [ ] Pre-populating rows - #228
    • [ ] Stretching columns - #229
    • [ ] Sorting - #232
    • [ ] Multi-column sorting (same log issue) - #234
    • [ ] Password (same log issue) - #238

created time in 2 days

issue openedhandsontable/docs

Password - error in the console after clicking the 'Log to console' button

Description

'Custom hash symbol' demo when we click 'Log in console' shows an error

Zrzut ekranu 2020-10-22 o 14 26 12

Related issues

  • Scolling (same log issue) - #227
  • Pre-populating rows (same log issue) - #228
  • Stretching columns (same log issue) - #229
  • Sorting (same log issue) - https://github.com/handsontable/docs/issues/232

Links

password - https://handsontable.com/docs/8.1.0/demo-password.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Auto fill - small changes

Description

  • Avoid using other application names
  • 'Log to console' button produces a console error for the first demo
  • 'to adding' sounds odd

Additionally, to adding new rows when it comes to the edge of the table bottom we need change autoInsertRow to true.

Links

Autofill - https://handsontable.com/docs/8.1.0/demo-auto-fill.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Summary calculations - provide some changes

Description

  • we should mention on the start that using the summaries does not generate the empty row itself.
  • The first example (demo) does not have any description. It looks like something is missing there.
  • 'Nested Rows plugin' in

This allows many possible usages: for example, you can easily calculate a total for a group in a group parent combining this plugin with the Nested Rows plugin.

returns 404.

  • change 'ot' to 'it' in

Takes a custom function and applies ot to the values in the specified column and row range.

  • 'forceNumeric' is not well explained. We say that when used the '9a' becomes '9' but 'a9' does not. There is also no reference to that option within https://handsontable.com/docs/8.1.0/Options.html

  • the 'forceNumeric' in

If your table doesn't contain only numeric data, you can either skip the non-numeric entries in the calculation, throw an error or try to parse them to float using the forceNumeric option.

lack code formatting

  • suppressDataTypeErrors option could have a working demo

  • 'count' counts only cells that are 'null'. Empty string is not counted - we should let the users know. Demo https://jsfiddle.net/AMBudnik/qbpw9rfv/

Links

Summary calculations - https://handsontable.com/docs/8.1.0/demo-summary-calculations.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Filtering - issues

Description

  • '(gets by the getData method)' doesn't seem right

  • 'Filter from the outside the table' demo does not appear in JSFiddle and produces the following error in the console Zrzut ekranu 2020-10-22 o 12 48 30

Links

Filtering - https://handsontable.com/docs/8.1.0/demo-filtering.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Multi-column sorting - error in the console after clicking the 'Log to console' button

Description

When we click the 'Log to console' button in all of the demos we get a console error.

Zrzut ekranu 2020-10-22 o 11 37 22

Additional issues

  • typo - change 'alghoritm' to 'algorithm'

  • Plugin API is missing some methods

Zrzut ekranu 2020-10-22 o 11 06 21

Zrzut ekranu 2020-10-22 o 11 44 21

Related issues

  • Scolling (same log issue) - #227
  • Pre-populating rows (same log issue) - #228
  • Stretching columns (same log issue) - #229
  • Sorting (same log issue) - https://github.com/handsontable/docs/issues/232

Links

Multi-column sorting - https://handsontable.com/docs/8.1.0/demo-multicolumn-sorting.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Collapsing columns - small fixes

Description

  • change 'Node' to 'Note' in

Node: You'll need to enable the Nested Headers plugin in order for this plugin to work properly.

  • add a link to 'Nested Headers' in that redirect to https://handsontable.com/docs/demo-nested-headers.html

(created with the Nested Headers plugin)

  • '(gets by the getData method),' doesn't seem to sound right

Links

Collapsing columns - https://handsontable.com/docs/8.1.0/demo-collapsing-columns.html support task (origin) - https://github.com/handsontable/support/issues/259

created time in 2 days

issue openedhandsontable/docs

Sorting - error in the console after clicking the 'Log to console' button

Description

When we click the 'Log to console' button below all the demos we get a console error.

Zrzut ekranu 2020-10-22 o 10 47 06

Additional issues

  • typo - change 'alghoritm' to 'algorithm'

  • 'columns' anchor in the 'Plugin options for certain columns only' paragraph redirects to a wrong URL.

  • Plugin API is missing some methods

Zrzut ekranu 2020-10-22 o 11 06 21

Zrzut ekranu 2020-10-22 o 11 06 07

Relates issues

  • Scrolling - (same log issue) - #227
  • Pre-populating rows (same log issue) - #228
  • Stretching columns (same log issue) - #229

Links

Sorting - https://handsontable.com/docs/8.1.0/demo-sorting.html support task (origin) - handsontable/support#259

created time in 2 days

issue openedhandsontable/docs

Hiding columns - misleading information

Description

On the page we state that

You can show/hide certain columns straight from the Context menu using the following keys: hidden_columns_show and hidden_columns_hide.

But the demo below this description uses the default context menu.

data: Handsontable.helper.createSpreadsheetData(5,12),
  colHeaders: true,
  rowHeaders: true,
  contextMenu: true,
  hiddenColumns: {
    columns: [3, 5, 9],
    indicators: true
}

Wouldn't it be better to use those defined keys or provide two demos,

  • first with default demo to show that enabling hiding shows 'Hide column' / 'Show column'
  • second with the hidden_columns_show and hidden_columns_hide keys only

Other issues on the page

  • the 'gets data' doesn't seem to sound good in

Rows being hidden are included in a DataMap (gets by the getData method), but they aren't rendered.

  • remove one 'See the examples section for more details.' from the 'Additional options' paragraph.

Zrzut ekranu 2020-10-22 o 10 33 43

I would just leave the one at the end. They both redirect to the same place on the page.

Related issue

  • hidden rows - basically the same set of issues - https://github.com/handsontable/docs/issues/230

Links

hiding columns - https://handsontable.com/docs/8.1.0/demo-hiding-columns.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Hiding rows - misleading information

Description

On the page we state that

You can show/hide certain rows straight from the Context menu using the following keys: hidden_rows_show and hidden_rows_hide.

But the demo below this description uses the default context menu

data: Handsontable.helper.createSpreadsheetData(12,5),
  colHeaders: true,
  rowHeaders: true,
  contextMenu: true,
  hiddenRows: {
    rows: [3, 5, 9],
    indicators: true
}

Wouldn't it be better to use those defined keys or provide two demos,

  • first with default demo to show that enabling hiding shows 'Hide row' / 'Show row'
  • second with the hidden_rows_show and hidden_rows_hide keys only

Other issues on the page

  • the 'gets data' doesn't seem to sound good in

Rows being hidden are included in a DataMap (gets by the getData method), but they aren't rendered.

  • remove one 'See the examples section for more details.' from the 'Additional options' paragraph. Zrzut ekranu 2020-10-22 o 10 10 17

I would just leave the one at the end. They both redirect to the same place on the page.

Links

hiding rows - https://handsontable.com/docs/8.1.0/demo-hiding-rows.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Stretching columns - error in the console after clicking the 'Log to console' button

Description

When we click the 'Log to console' button of the second demo (used StretchH all columns paragraph) below the demo we get a console error.

Zrzut ekranu 2020-10-22 o 09 51 49

The first and last examples do not show this error.

Related issues

  • scolling (same log issue) - #227
  • Pre-populating rows (same log issue) - #228

Links

stretching columns - https://handsontable.com/docs/8.1.0/demo-stretching.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Pre-populating rows - error in the console after clicking the 'Log to console' button

Description

When we click the 'Log to console' button below the demo we get a console error.

Zrzut ekranu 2020-10-22 o 09 46 56

Relates issues

  • scolling (same log issue) - https://github.com/handsontable/docs/issues/227

Links

Pre-populating rows - https://handsontable.com/docs/8.1.0/demo-pre-populating.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Scrolling - error in the console after clicking the 'Log to console' button

Description

When we click the 'Log to console' button below the demo we get a console error.

Zrzut ekranu 2020-10-22 o 08 42 01

Additionally, I would also add links to the ~offset method mentioned in the description

You can experiment with the viewportColumnRenderingOffset and viewportRowRenderingOffset config options, which define this behavior, to improve the performance of your app.

Links

Scrolling - https://handsontable.com/docs/8.1.0/demo-scrolling.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Autocomplete - add sample and mention 'filteringCaseSensitive' option

Description

Our autocomplete page looks comprehensive and complete but we do not even mention that there's an option called 'filteringCaseSensitive'.

Zrzut ekranu 2020-10-22 o 08 33 58

This option works as described so it would be great to add some info about it. Demo (v8.1.0) for tests https://jsfiddle.net/AMBudnik/dhw4vqgL/

Relates issues

  • missing 'filter' example - https://github.com/handsontable/docs/issues/224

Links

<!--- [mandatory] Add a link (or links) to the page that should be improved or contains a mistake --> filteringCaseSensitive option (autocomplete only) - https://handsontable.com/docs/8.1.0/Options.html#filteringCaseSensitive autocomplete - https://handsontable.com/docs/8.1.0/demo-autocomplete.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue openedhandsontable/docs

Autocomplete - add sample and mention 'filter' option

Description

Our autocomplete page looks comprehensive and complete but we do not even mention that there's an option called 'filter'.

Zrzut ekranu 2020-10-22 o 08 28 54

This option works as described so it would be great to add some info about it. Demo (v8.1.0) for tests https://jsfiddle.net/AMBudnik/yt0pd7s2/

Links

filter option (autocomplete only) - https://handsontable.com/docs/8.1.0/Options.html#filter autocomplete - https://handsontable.com/docs/8.1.0/demo-autocomplete.html support task (origin) - https://handsontable.com/docs/8.1.0/demo-autocomplete.html

created time in 2 days

issue closedhandsontable/handsontable

Row heights can't be smaller than 22 pixels

Description: Limit on row-height to 22 pixels

In our project we have many grids designed and displayed on an in-house desktop application, we plan to display the same grids on browsers, however most of our grids are not being displayed correctly because of the limit of row height to 22 pixels.

Unfortunately, the problem is blocking because it's impossible for us to adjust all of our grids to take into account this limitation. And at the moment most of what we have already is highly impacted

Example: image

Steps to reproduce

I don't believe the steps to reproduce are necessary, problem has been previously identified, please check

image

Your environment

  • Handsontable version: 8.1.0
  • Browser Name and version: Firefox 81.0.1 (64 bits)
  • Operating System: Windows 10

closed time in 3 days

SereneA

issue commenthandsontable/handsontable

Row heights can't be smaller than 22 pixels

Welcome @SereneA

I can see that you've quoted me. I guess that now we can update those examples with one that uses line-height for TDs http://jsfiddle.net/AMBudnik/au351vpb/ it makes the row with data as height as the content. As the content takes less space the height is not 22px it is 14px.

Zrzut ekranu 2020-10-21 o 13 26 09

You can set a smaller height to only some of the rows http://jsfiddle.net/AMBudnik/d05ktc23/

Zrzut ekranu 2020-10-21 o 13 26 57

You also can cut the text visually by developing a custom renderer like here - http://jsfiddle.net/AMBudnik/ovcyxfL5/ renderer-example

Those are some of the methods that may or may not cover all the needs. Nevertheless, the quoted reply is a part of an issue that is still opened and we should avoid duplicating subjects. I need to close this ticket and keep the origin ticket opened. I will, however, make sure to update you once we provide a solid support for narrowing rows within https://github.com/handsontable/handsontable/issues/4021.

SereneA

comment created time in 3 days

issue commenthandsontable/handsontable

Hidden columns reappear if we run updateSettings

Hi @giorgitus at the first glance it does not look like the same issue. Can you tell me a bit more about your settings/options? We can discuss this over email - support@handsontable.com

AMBudnik

comment created time in 3 days

issue commenthandsontable/vue-handsontable-official

Repeatedly changing the height will cause it to crash.

HI @sinbino

that's an interesting finding.

I was able to hang the resizing process on 15. And then it became nearly immune to change while having more than 40 for the non-crashable example. Then I tried to be more gentle and wanted 2-3 seconds before clicking the button. At 15 it started to lag and at 18 it was already broken.

Version 8.0.0 https://jsfiddle.net/pf3Lw5qt/ works the same.

I do not see any abnormalities in the Performance Monitor. We get the initial load and a flat line while clicking the button 18 times.

pm-test

And here's a screenshot from the time after 17 click when table was frozen till the last render of the table.

perf-tab

sinbino

comment created time in 3 days

issue openedhandsontable/docs

Vuex example - incorrect initial readOnly setup for the JSFiddle demo

Description

When we visit the website the checkbox is not checked and data is editable. When we click the 'EDIT' button to enter JSFiddle demo the data is editable but the checkbox is checked. This may cause some confusion.

Page Zrzut ekranu 2020-10-20 o 11 41 13

JSFiddle Zrzut ekranu 2020-10-20 o 11 41 27

Links

vuex example - https://handsontable.com/docs/8.1.0/frameworks-wrapper-for-vue-vuex-example.html support task (origin) - https://github.com/handsontable/support/issues/258

created time in 4 days

issue openedhandsontable/docs

Using the hot-column component (Vue) - fix some issue

Description

  • The page itself has some console errors Zrzut ekranu 2020-10-20 o 10 51 06

  • when we use the 'EDIT' button below the 'Object data source' example we get a table that does not look the same as the one on the page.

Zrzut ekranu 2020-10-20 o 10 53 39 page

Zrzut ekranu 2020-10-20 o 10 53 48 JSFiddle

  • we could add a link to the page that explains what is the LRU Zrzut ekranu 2020-10-20 o 10 56 53

  • the 'Using the renderer/editor components with v-model' demo when provided with 10 as the input value select first and second cell. Zrzut ekranu 2020-10-20 o 11 02 43

  • typo - change 'addition' to 'additional' in

To use an external editor component with Handsontable, you'll need to create an addition "bridge" component[...]

  • typo - change 'in in' to 'it in'

The editor implementation is pretty straightforward: you need to import your dependency, place in in your editor template

Links

Using the hot-column component (Vue) - https://handsontable.com/docs/8.1.0/frameworks-wrapper-for-angular-custom-editor-example.html support task (origin) - https://github.com/handsontable/support/issues/258

created time in 4 days

issue openedhandsontable/docs

Custom editor example (Angular) - broken example

Description

The first JSFiddle example (the one that provides placeholders) produces console errors if you open it up in the JSFiddle

Zrzut ekranu 2020-10-20 o 10 31 45

To replicate the issue click the Zrzut ekranu 2020-10-20 o 10 32 53 button and then just try to edit any cell in the fiddle. It works OK on the website.

Links

Custom editor example (Angular) - https://handsontable.com/docs/8.1.0/frameworks-wrapper-for-angular-custom-editor-example.html

created time in 4 days

issue commenthandsontable/docs

Column Filter Input Loses Focus

Hi @scarletfog we had some users testing this example the same way and being convinced that we have an issue.

As @wojciechczerniak explained it is not an issue as the following example wasn't designed the way it would support the following user action. I think that we could arrange a new example - maybe provide only 5-6 columns.

AMBudnik

comment created time in 4 days

issue commenthandsontable/handsontable

Column Filter Input Loses Focus

Issue moved to handsontable/docs #220 via ZenHub

ajangles

comment created time in 4 days

issue closedhandsontable/handsontable

Column Filter Input Loses Focus

Description

We have 27 columns in out table, and after scrolling to the complete right and selecting a filter, the selected input loses focus and subsequently the inputs are all out of order and the columns are out of alignment

Steps to reproduce

  1. Create table with large amount of columns and add filters
  2. Scroll to the right
  3. Start typing in a filter input

Demo

This demo is pretty extreme in number of columns perhaps, but easily represents the problem:

https://jsfiddle.net/n2t8vhzs/

handsontablefilter

handsontablefilter

Your environment

  • Handsontable version: 7.4.2
  • Browser Name and version: All browsers
  • Operating System: Windows 10

closed time in 4 days

ajangles

issue openedhandsontable/docs

Column Filter Input Loses Focus

@ajangles commented on Fri Jun 05 2020

Description

We have 27 columns in out table, and after scrolling to the complete right and selecting a filter, the selected input loses focus and subsequently the inputs are all out of order and the columns are out of alignment

Steps to reproduce

  1. Create table with large amount of columns and add filters
  2. Scroll to the right
  3. Start typing in a filter input

Demo

This demo is pretty extreme in number of columns perhaps, but easily represents the problem:

https://jsfiddle.net/n2t8vhzs/

handsontablefilter

handsontablefilter

Your environment

  • Handsontable version: 7.4.2
  • Browser Name and version: All browsers
  • Operating System: Windows 10

@AMBudnik commented on Fri Jun 05 2020

Thank you for sharing the issue report, Javier.

I can see that you use our Filter as you type example from the Filtering tutorial https://handsontable.com/docs/7.4.2/demo-filtering.html

I have replicated the issue in v 7.4.2 as well as our new beta2-rev11 of v 8.0.0. https://jsfiddle.net/AMBudnik/1svhojaz/

Tested on Chrome 80 / macOS Catalina Related issue https://github.com/handsontable/handsontable/issues/5541 (fixed fo v7.0.0)


@AMBudnik commented on Mon Jul 06 2020

It works the same in 8.0.0-beta2-rev18 https://jsfiddle.net/moewkuL3/


@AMBudnik commented on Tue Aug 11 2020

The issue remains the same in v 8.0.0 https://jsfiddle.net/w5as0juk/


@wojciechczerniak commented on Sun Oct 18 2020

The demo in our documentation is a very simple one. Custom code should be adjusted if you want more columns.

With multiple columns and virtual rendering circumstances change. Inputs here, are reused, events are binded to wrong columns. When I try to filter last column, conditions are attached to column with an index 6, no results are shown. Focus is lost or scroll occurs because rerender reuses the input in totaly different column.

@ajangles @AMBudnik if there is a bug please provide a valid reproduction, otherwise we will have to close this issue.


@AMBudnik commented on Tue Oct 20 2020

We had many requests to fix this "issue" so as this is not a bug, we should move this topic to /docs and consider replacing the example with something else.

created time in 4 days

issue commenthandsontable/handsontable

Column Filter Input Loses Focus

We had many requests to fix this "issue" so as this is not a bug, we should move this topic to /docs and consider replacing the example with something else.

ajangles

comment created time in 4 days

issue closedhandsontable/handsontable

Failed to mimify npm run production

Description

When I compile my project in laravel and vuejs in npm prod mode it throws me the following errors, when it is configured in developer it does not happen, obviously when it does not mimic, what could be happening? in my instances I use this to fill the table that comes from php this. $ refs.hotTableComponent.hotInstance.loadData (data);

Steps to reproduce

<!--- Provide steps to reproduce this issue -->

  1. DOMException: "Node cannot be inserted at the specified point in the hierarchy"
  2. this.hotInstance is null
  3. this.$refs.hotTableComponent.hotInstance is null

Your environment

  • Handsontable version:8.0.0
  • Browser Name and version: Mozilla / version73.0.1
  • Operating System: Windows 7 64bit

closed time in 4 days

inicio015

issue commenthandsontable/handsontable

Failed to mimify npm run production

I got the app and replied by email.

inicio015

comment created time in 4 days

issue commenthandsontable/ngHandsontable

Error: Cannot set property 'isHotTableEnv' of undefined

You're right @minalkumar2893 this PR describes that the isHotTableEnv is removed https://github.com/handsontable/handsontable/pull/6625 I will confirm and come back to you.

minalkumar2893

comment created time in 5 days

issue openedhandsontable/docs

Using the HotColumn component - small impovements

Description

  • the object data source link does not work Zrzut ekranu 2020-10-19 o 14 24 44

  • the autoColumnSize in note that autoColumnSize is enabled by default should be a link to https://handsontable.com/docs/Options.html#autoColumnSize

Links

Using the HotColumn component - https://handsontable.com/docs/8.1.0/frameworks-wrapper-for-react-hot-column.html

created time in 5 days

issue commenthandsontable/handsontable

Failed to mimify npm run production

Hi @inicio015

Could you send me the project zipped to support@handsontable.com ? I will build the app on my device and check what causes the issue.

inicio015

comment created time in 5 days

issue openedhandsontable/docs

Re-check links for handsontable-pro repository

Description

Hey @scarletfog!

@pnowak found that there are multiple links in our Release Notes that does not work (as they redirect to the handsontale-pro repository)

Version of RN - broken link number 6.2.0: #148, 6.1.0: #146, #149, #151, #154, 6.0.1: #142, #144, 5.0.2: #105, #107, 5.0.1: #29, 5.0.0: #87, 4.0.0: #72, 3.0.0: #65, #67, #69, 2.0.0: #43, #44, #47, #49, 1.18.0: #33, 1.16.0: #24, 1.15.1: #11, #23, 1.15.0: #13, #12, #15, #19, #6, 1.14.3: #2,

As the repo is no longer available I guess that we can just remove the link. It would be hard to find other links that were related to the task (issue report, pull request, commit).

Links

release notes - https://handsontable.com/docs/8.1.0/tutorial-release-notes.html

created time in 5 days

issue closedhandsontable/handsontable

Performance and CPU wastage issue due to some handsontable properties.

Description

I am using multiple handsontable instances on my webpage and facing major performance issue when I render multiple handsontables on the page (more than around 20 tables with around 25 columns and 100 rows for example). After using chrome's devTools I got to know that scripting and cpu usage was there even in case the page was ideal. I did a console log in timer function of zone.js file and it was being called infinitely in case of any single table creation. The issue in code which I found was somehow due to the two properties of handsontable ( filters and columnSorting ) and after setting these two properties as false simultaneously, the console log of zone.js file doesn't get called infinitely and CPU usage and scripting size is also shown as zero in case the page is ideal. But even after removing these two properties my page responsiveness decreases and it hangs a lot in case of multiple tables.

Your environment

  • Handsontable version: 6.2.2
  • Browser Name and version: Chrome 75
  • Operating System: Windows

closed time in 5 days

meta-rohit-singhavi

issue commenthandsontable/handsontable

Performance and CPU wastage issue due to some handsontable properties.

As we check all the future versions of Handsontable in the Performance Lab I agree that we should close this subject as already checked.

@meta-rohit-singhavi If you see that some particular settings are causing issues between the versions of Handsontable please let me know. I'm monitoring all the emails to support@handsontable.com

meta-rohit-singhavi

comment created time in 5 days

issue commenthandsontable/docs

Options>cells - change definition of coordinates

It is confusing a bit :)

Basically, when we have an array of arrays (['A1', 'B1', 'C1']) as a dataset it looks like this

Zrzut ekranu 2020-10-19 o 11 25 08

The A1 is under coordinates 0, 0.

But when we use an array of objects as a dataset ({A: 'A1', B: 'B1', C: 'C1'}) then the column index is replaced by property (object key).

Zrzut ekranu 2020-10-19 o 11 29 16

The A1 is under coordinates 0, 'A'.

AMBudnik

comment created time in 5 days

issue commenthandsontable/docs

setDataAtCell - define that if source is not provided it is described as 'edit'

@scarletfog you're right. The emptySelectedCells also is described as 'edit' change.

Demo https://jsfiddle.net/AMBudnik/098nw1am/

AMBudnik

comment created time in 5 days

PullRequestReviewEvent

pull request commenthandsontable/handsontable

Remove optional marking for params in setDataAtCell [DOCS]

OK, so I think that we can close this PR and chat about possible code samples at https://github.com/handsontable/docs/issues/181

scarletfog

comment created time in 5 days

issue commenthandsontable/docs

setDataAtCell - remove [optional] marking for 2nd and 3rd paramater of the function

@scarletfog That's true. Hm... however, if we check this example https://jsfiddle.net/AMBudnik/0kqp24ha/, where there's only the first (required) parameter, we get an error. Maybe adding some examples would remove all the confusion.

AMBudnik

comment created time in 5 days

PullRequestReviewEvent

issue commenthandsontable/vue-handsontable-official

8.0.0 bind data with vuex state not render

Until we create the mounted() guide requested here https://github.com/handsontable/docs/issues/158 we should stick to the rule that

The page should begin by reminding that mounted event is fired after a component is rendered in DOM, so this is not the correct place to insert initial state. The initial state should be set in data or created.

This is in line with what other guides say:

Use mounting hooks if you need to access or modify the DOM of your component immediately before or after the initial render.

Do not use mounting hooks if you need to fetch some data for your component on initialization.

Source: https://www.digitalocean.com/community/tutorials/vuejs-component-lifecycle#mounting-dom-insertio

muei

comment created time in 8 days

issue openedhandsontable/docs

Cell function - multiple changes

Description

  • add some JSFiddle - a situation when you have different editor, renderer, and validator cries for a demo.

  • attach the link to a broken anchor

[[separate page|Custom-cell-editor]]

  • change 'are' to 'is'

Each of those functions are responsible

  • change 'in details' to 'in detail'.

We will now discuss the purpose of the aforementioned functions in details.

  • update the 'Native cell renderers' list. Even when we skip the baseRenderer we still should mention htmlRenderer Zrzut ekranu 2020-10-16 o 13 43 28 src https://github.com/handsontable/handsontable/blob/0ec29f9cab9e0d9df1af99287c1211e87779737a/src/renderers/index.js#L6

  • I would really want to have this info Zrzut ekranu 2020-10-16 o 13 50 29 mentioned in the Performance tutorial https://handsontable.com/docs/8.1.0/tutorial-performance-tips.html Many users are not aware of that fact

  • Is the numeric cell using the [NumericEditor] ?(https://github.com/handsontable/handsontable/blob/0ec29f9cab9e0d9df1af99287c1211e87779737a/src/editors/numericEditor.js) Zrzut ekranu 2020-10-16 o 14 05 38

  • when I set the cell to be type: 'numeric' I get functions as a return for editor, renderer, and validator - not undefined.

Zrzut ekranu 2020-10-16 o 14 26 08

demo https://jsfiddle.net/AMBudnik/dqsucrk2/ And this is actually the same result as I would call the options listed at the end of the page Zrzut ekranu 2020-10-16 o 14 29 57

Demo https://jsfiddle.net/AMBudnik/7u90daxs/

Links

Cell function - https://handsontable.com/docs/8.1.0/tutorial-cell-function.html support task (origin) - https://github.com/handsontable/support/issues/258

created time in 8 days

issue openedhandsontable/docs

Add missing cell types

Description

This page https://handsontable.com/docs/8.1.0/tutorial-cell-function.html is missing the 'time' cell type.

Zrzut ekranu 2020-10-16 o 14 11 17

and this page https://handsontable.com/docs/8.1.0/tutorial-cell-types.html doesn't mention select as being a cell type. We do not use it as a type https://handsontable.com/docs/8.1.0/demo-select.html

Zrzut ekranu 2020-10-16 o 14 12 39

but it is on the list of cell types

Zrzut ekranu 2020-10-16 o 14 12 59

Links

cell types - https://handsontable.com/docs/8.1.0/tutorial-cell-types.html select - https://handsontable.com/docs/8.1.0/demo-select.html time - https://handsontable.com/docs/8.1.0/demo-time.html options - type - https://handsontable.com/docs/8.1.0/Options.html#type

created time in 8 days

issue openedhandsontable/docs

Cell editor - provide a JSFiddle

Description

We provide a huge amount of text on that page. There are a lot of code samples. But there is not a single JSFiddle demo for users to test the code.

If you read the tutorial for the first time the amount of knowledge is intimidating and bringing a code sample after each section would allow the developer to test it out and play with those options and functions they've just learned.

Links

cell editor tutorial - https://handsontable.com/docs/8.1.0/tutorial-cell-editor.html

created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commenthandsontable/handsontable

Changing columnHeader

Hey @clarissa123 please provide a code same and a project description - I'll be waiting on support@handsontable.com

myisis

comment created time in 8 days

PullRequestReviewEvent

issue commenthandsontable/docs

fillHandle - wrong default set up

{autoInsertRow: false} or leave it as true

good question. I would say that {autoInsertRow: false}. Why?

  • we share some examples where
// enable plugin in all directions and with autoInsertRow as true
fillHandle: true,

fillHandle: {
  // enable plugin in both directions and with autoInsertRow as false
  autoInsertRow: false,
},

and by default, we cannot add new rows while doing the fill handle.

AMBudnik

comment created time in 8 days

PullRequestReviewEvent

issue openedhandsontable/docs

Cel editor - multiple changes

Intro

We may recreate the tutorial. It seems that this page hasn't been updated for a while. On the other hand, I do not believe that those essentials changed.

Description

  • The first link in the list - Responsibility of EditorManager class - doesn't seem to redirect us.
  • There are some small typos on the page. Under the first part

Zrzut ekranu 2020-10-15 o 14 52 06

here are the changes (marked in bold)

Handsontable separates the process of displaying the cell value from the process of changing the value. Renderers are responsible for presenting the data and editors for altering it. As a renderer has only one simple task: get the actual value of the cell and return its representation as an HTML code they can be a single function. Editors, however, need to handle user input (that is, mouse and keyboard events), validate data, and behave according to validation results, so putting all those functionalities into a single function wouldn't be a good idea. That's why Handsontable editors are represented by editor classes.

Since Handsontable 0.10.0 we have rewritten most of the editors' modules to make them (hopefully) more understandable, predictable, and easier to extend. This tutorial will give you a comprehensive understanding of how the whole process of cell editing works, how Handsontable Core manages editors, how the editor life cycle looks like, and finally - how to create your own editors.

However, I personally do not understand the intention of this sentence.

As a renderer has only one simple task: get the actual value of the cell and return its representation as an HTML code they can be a single function

Then in the next sentence, we say that editors are validating the cell (which is a job for a cell validator).

Editors, however, need to handle user input (that is, mouse and keyboard events), validate data, and behave according to validation results[..]

I wasn't sure about this change

Since Handsontable 0.10.0 we have rewritten most of the editors' modules to make them (hopefully) more understandable, predictable, and easier to extend.

cause most of the sentence originally used singular form but now it makes more sense as at the beginning we use 'most of the'.

  • Editor Manager part

Zrzut ekranu 2020-10-15 o 15 03 29

  • The comma after 'method which is run' seems to be unnecessary
  • I would change 'reference for' to 'reference to'
  • Changes 'behaviour' to 'behavior'
  • We might be missing some 'The' for EditorManager

Zrzut ekranu 2020-10-15 o 15 31 59

  • change 'proper' to 'a proper'
  • I would change 'displaying editor' to 'opening editor'
  • change 'based on user behavior' to 'based on user action'

Zrzut ekranu 2020-10-15 o 15 36 36

  • add 'a' - Selecting a proper editor
  • change 'for all cells in table' to 'for all cells in the table'
  • 'in other words' add a comma after 'words'
  • add 'a' - 'instance of certain editor class'

EditorManager will then get an instance of editor class and the first very important thing to remember is: there is always one instance of certain editor class in a single table, in other words each editor class object is a singleton within a single table, which means that its constructor will be invoked only once per table.

This sentence is too long. We should make it simpler.

  • change 'should display' to 'opens' in

If any of those events is triggered, EditorManager calls editor's beginEditing() method, which should display the editor.

  • change 'should end' to 'ends'.

When editor is opened the EditorManager waits for user event that should end cell edition.

  • change 'should try to save' to 'saves'

which should try to save changes

  • change 'user press' to 'user presses' in

For example, your editor might use ARROW_UP and ARROW_DOWN events to perform some actions (for example increasing or decreasing cell value) and you don't want EditorManager to close the editor when user press those keys.

  • This sentence does not seem to be correct. As I assume we need to call stopImmediatePropagation to abort beforeKeyDown.

If you register a listener for beforeKeyDown, that call stopImmediatePropagation() on event object EditorManager won perform its default action.

  • change 'behaviour' to 'behavior'

More on overriding EditorManager's behaviour

  • I think that this

However, if you are creating some more complex editors, you might want to override some of the common methods, in which case you should always invoke the original method and then perform other operations, specific to your editor.

should be changed to

However, if you are creating some more complex editors, you might want to override some of the common methods. In that case, you should always invoke the original method and then perform other operations, specific to your editor.

Links

  • cell editor - https://handsontable.com/docs/8.1.0/tutorial-cell-editor.html
  • support task (origin) - https://github.com/handsontable/support/issues/258

created time in 9 days

issue commenthandsontable/docs

Options>data - add missing information about data declaration on the columns level

Yup, columns can be a better place. We want to keep things clean and avoid ambiguity.

AMBudnik

comment created time in 9 days

PullRequestReviewEvent

issue openedhandsontable/docs

Custom plugin - apply some changes

Description

  • code style anchor in the last paragraph redirects to 404.

We support ECMAScript 6 and follow code style (inspired by Airbnb JavaScript Style), so those standards are required for the new plugins.

  • I wouldn't call creating a new Handsontable plugin an easy task. Especially, as the Skeleton README is not sharing too many hints or tips.

Writing a new plugin is not a difficult task, simply cloning the Skeleton template will give you a good starting point.

  • I would remove the following paragraph. It does not share any valuable information and it indicates that we are willing to merge Clients' custom plugins to Handsontable just like that.

Note that creating a plugin for personal needs is usually easier than writing an application destined for use by other developers. Such code has to be properly described, documented, frequently updated and supported. If you think that your plugin meets those requirements then consider sharing it with us. Get in touch for more details.

I think that we should be able to share some valuable information on how to create a plugin. Now it is just a page that tells me - visit this link (link to Skeleton).

Links

  • custom plugin tutorial - https://handsontable.com/docs/8.1.0/tutorial-custom-plugin.html

created time in 9 days

issue openedhandsontable/docs

List of callback that operates on source parameter - update the list

Description

On the Callbacks tutorial page, we have the following list

List of callback that operates on source parameter:

  • afterChange
  • afterCreateCol
  • afterCreateRow
  • afterSetDataAtCell
  • afterSetDataAtRowProp
  • afterValidate
  • beforeChange
  • beforeChangeRender
  • beforeCreateCol
  • beforeCreateRow
  • beforeValidate

However, the list is not complete. As we use the term 'List of callbacks', and not 'List of some of the callbacks' I assume that we should list all of them.

At the same time I confirm that all the hooks that are currently listed are still valid (sharing the source).

Missing hooks

  • afterRemoveCol - https://handsontable.com/docs/8.1.0/Hooks.html#event:afterRemoveCol
  • afterRemoveRow - https://handsontable.com/docs/8.1.0/Hooks.html#event:afterRemoveRow
  • afterSetSourceDataAtCell - https://handsontable.com/docs/8.1.0/Hooks.html#event:afterSetSourceDataAtCell
  • beforeRemoveCol - https://handsontable.com/docs/8.1.0/Hooks.html#event:beforeRemoveCol
  • beforeRemoveRow - https://handsontable.com/docs/8.1.0/Hooks.html#event:beforeRemoveRow

Links

  • List of callback that operates on source parameter - https://handsontable.com/docs/8.1.0/tutorial-using-callbacks.html#page-source-definition

created time in 9 days

issue openedhandsontable/docs

Definition for source argument - multiple changes

Description

  • the auto definition (changes marked in bold)

auto - Action triggered by Handsontable and reason for it is releated directly with settings aplied to Handsontable. For instance afterCreateRow will be fired with this when minSpareRows will be greater then 0;

should be changed to (fixing typos)

auto - Action triggered by Handsontable and reason for it is related directly with settings applied to Handsontable. For instance , afterCreateRow will be fired with this when minSpareRows will be greater than 0;

  • We should add a link to https://handsontable.com/docs/Autofill.html for AutoFill plugin text below

Autofill.fill - Action triggered by the AutoFill plugin;

  • We should add a link to https://handsontable.com/docs/demo-context-menu.html for ContextMenu plugin mentions in all the options below

ContextMenu.clearColumns - Action triggered by the ContextMenu plugin after the "Clear column" has been clicked; ContextMenu.columnLeft - Action triggered by the ContextMenu plugin after the "Insert column on the left" has been clicked; ContextMenu.columnRight - Action triggered by the ContextMenu plugin after the "Insert column on the right" has been clicked; ContextMenu.removeColumn - Action triggered by the ContextMenu plugin after the "Remove column" has been clicked; ContextMenu.removeRow - Action triggered by the ContextMenu plugin after the "Remove Row" has been clicked; ContextMenu.rowAbove - Action triggered by the ContextMenu plugin after the "Insert row above" has been clicked; ContextMenu.rowBelow - Action triggered by the ContextMenu plugin after the "Insert row below" has been clicked;

  • update information about the option name for adding columns. (Changes are in bold)

ContextMenu.columnLeft - Action triggered by the ContextMenu plugin after the "Insert column on the left" has been clicked; ContextMenu.columnRight - Action triggered by the ContextMenu plugin after the "Insert column on the right" has been clicked;

change to

ContextMenu.columnLeft - Action triggered by the ContextMenu plugin after the "Insert column left" has been clicked; ContextMenu.columnRight - Action triggered by the ContextMenu plugin after the "Insert column right" has been clicked;

(demo for check https://handsontable.com/docs/8.1.0/demo-context-menu.html)

  • We should add a link to https://handsontable.com/docs/demo-copy-paste.html for CopyPaste plugin text

CopyPaste.paste - Action triggered by the CopyPaste plugin after the value has been pasted;

  • We should add a link to https://handsontable.com/docs/UndoRedo.html for UndoRedo plugin text in both sentences

UndoRedo.redo - Action triggered by the UndoRedo plugin after the change has been redone; UndoRedo.undo - Action triggered by the UndoRedo plugin after the change has been undone;

  • We should add a link to https://handsontable.com/docs/demo-summary-calculations.html for ColumnSummary plugin text in both sentences

ColumnSummary.set - Action triggered by the ColumnSummary plugin after the calculation has been done; ColumnSummary.reset - Action triggered by the ColumnSummary plugin after the calculation has been reset.

Links

custom build - https://handsontable.com/docs/8.1.0/tutorial-using-callbacks.html

created time in 9 days

issue commenthandsontable/handsontable

getCellMeta creates metadata for non-existing cells

If the cell does not exist, why get anything at all? Possibly throw an error?

Yes. That is what I would expect. However, I remember having a similar discussion before with the team and opinions were mixed. So I wanted to attach the Status: To be discussed label instead of the bug.

ottosson

comment created time in 9 days

issue commenthandsontable/vue-handsontable-official

8.0.0 bind data with vuex state not render

Hi @muei have you tried the $nextTick way to handle data change within the mounted() hook?

muei

comment created time in 9 days

issue openedhandsontable/react-handsontable

Using `setState` within `afterFilter` hook call results in the cancelation of filtering

Description

<!--- Tell us what happens and what should happen --> Using setState within afterFilter hook call results in the cancelation of filtering.

Steps to reproduce

<!--- Provide steps to reproduce this issue -->

  1. Filter out any values via filter by value option.

Result The values as still there. They are removed if you comment our the setState method in the afterFilter hook.

Demo

<!--- Provide a link to a live example on JSFiddle or Codepen or fill the following demo with your settings --> https://jsfiddle.net/eudmgt63/2/

Related issues

  • https://github.com/handsontable/react-handsontable/issues/132
  • (forum origin) https://forum.handsontable.com/t/call-setstate-in-after-hooks-will-not-trigger-rerender/4761

Your environment

  • React wrapper version: 4.0.0
  • Handsontable version: 8.0.0
  • Browser Name and version: Chrome 86
  • Operating System: macOS Catalina 10.15.6

created time in 9 days

issue commenthandsontable/handsontable

getCellMeta creates metadata for non-existing cells

Hi @ottosson I replicated the same behavior. It seems that when we call a cell that is distant (not a next index) we do not get all the cells between, just the new one

data: Handsontable.helper.createSpreadsheetData(10, 6),
...
const y = hot.getCellMeta(20, 0);

Zrzut ekranu 2020-10-15 o 09 23 07

However, this behavior changed in v 8.0.0 https://jsfiddle.net/AMBudnik/ums2p8kv/ as in 7.4.2 https://jsfiddle.net/AMBudnik/g7p6mhyq/ we would get all the cell meta values, which is 71 records.

But the question is, should we allow receiving anything besides undefined for calling cell meta for cells that do not exist? We'd need to discuss the subject.

ottosson

comment created time in 9 days

PullRequestReviewEvent

issue openedhandsontable/docs

NPM tasks - broken link

Description

The anchor of our code style redirects to an unexisting page (error 404).

Zrzut ekranu 2020-10-14 o 15 04 58

Links

NPM Tasks (Custom build page) - https://handsontable.com/docs/8.1.0/tutorial-custom-build.html#page-tasks support task (origin) - https://github.com/handsontable/support/issues/258

created time in 10 days

issue openedhandsontable/docs

beforeKeyDown use case - fix demo

Description

When you enter the demo below the beforeKeyDown use case paragraph and use ENTER at least three times you get some console errors.

Zrzut ekranu 2020-10-14 o 14 53 17

Links

beforeKeyDown use case (Callbacks) - https://handsontable.com/docs/8.1.0/tutorial-using-callbacks.html#page-beforeKeyDown related issue - same page - https://github.com/handsontable/docs/issues/203 support task (origin) - https://github.com/handsontable/support/issues/258

created time in 10 days

issue openedhandsontable/docs

Creating custom languages - rephrasing needed

Description

The first sentence of the Creating custom languages and Language file paragraph says

It's really important for us, that the community is a important part of the growth of our library. We encourage you to create and share your translations!

Besides the fact of the typo here is a important part (a > an) we use important twice in one sentence.

Links

Creating custom languages - https://handsontable.com/docs/8.1.0/tutorial-internationalization.html#custom-languages support task (origin) - https://github.com/handsontable/support/issues/258

created time in 10 days

issue openedhandsontable/docs

Using callbacks - missing JSFiddle link

Description

We are missing JSFiddle demo buttons on the Callback tutorial page. As far as I can understand that the first demo with multiple checkboxes is complex, then the second one under the beforeKeyDown use case paragraph should have a demo button.

Links

Callbacks tutorial - https://handsontable.com/docs/8.1.0/tutorial-using-callbacks.html#page-beforeKeyDown

created time in 10 days

issue openedhandsontable/docs

Performance tips - provide a link to Grid Resizing Tutorial

Description

On the Performance Tips page, we define that it's repaying for the performance to set up a fixed height and width for the table. That might be intuitive or not, but what is actually making that change is mentioned in the What if dimensions are not set up paragraph of the Grid Resizing page.

Zrzut ekranu 2020-10-14 o 13 39 06

I think that we should provide a link or a quote to complete the description of grid sizing importance when it comes to performance-related setups.

Links

performance tips - https://handsontable.com/docs/8.1.0/tutorial-performance-tips.html grid resizing - https://handsontable.com/docs/8.1.0/tutorial-grid-sizing.html#manual-resizing

created time in 10 days

issue openedhandsontable/docs

Manual resizing - missing element in a JSFiddle demo

Description

When we open the JSFiddle demo we can see that the <kbd>Expand</kbd> button is missing.

DOCS Zrzut ekranu 2020-10-14 o 13 16 28

FIDDLE Zrzut ekranu 2020-10-14 o 13 16 59

The logic is attached as we can see that the following error

Uncaught TypeError: Cannot read property 'addEventListener' of null

triggerBtn.addEventListener('click', function() {
   if (triggerBtn.textContent === 'Collapse') {
     triggerBtn.textContent = 'Expand';
     blueboxElem.className = blueboxElem.className.replace(' expanded', '');

Links

manual resizing page - https://handsontable.com/docs/8.1.0/tutorial-grid-sizing.html#manual-resizing support task (origin) - https://github.com/handsontable/support/issues/258

created time in 10 days

issue commenthandsontable/handsontable

getSelectedRange returns invalid range after row removal

You're right @ottosson this information is not updated after we remove a row.

We can see that we need to select the cells once again to get the updated value - https://jsfiddle.net/AMBudnik/sbk5td7g/ (printing 'to' selection on a button click).

I am not sure, though, if that is a bug, cause the selection is not re-triggered. If we do not re-select the range why should we get a new value? I'll keep this issue opened for a discussion.

As a workaround for having the range updated we can call the selectAll() once again https://jsfiddle.net/AMBudnik/67jL8s1h/

ottosson

comment created time in 10 days

issue commenthandsontable/handsontable

fixedColumnsLeft with rowHeaders hidden creates a 1px shift

Those issues might be related. I would prefer to keep them in one place. Nevertheless, we may end up separating them after doing the investigation.

Maxoudela

comment created time in 10 days

issue commenthandsontable/handsontable

Scrollbar CSS Must Be Global

Thank you for mentioning the scroll subject. I remember having issues while trying to customize the scrollbar.

aarondfrancis

comment created time in 10 days

issue commenthandsontable/handsontable

Txt area comments - display issues on Firefox

Now it does not work for me on Chrome 85 and Handsontable 8.1.0

aninde

comment created time in 10 days

issue openedhandsontable/docs

The cascading configuration model - broken link

Description

There's a broken link in The cascading configuration model paragraph under

See it yourself: http://jsperf.com/extending-settings

Links

The cascading configuration model - https://handsontable.com/docs/8.1.0/tutorial-setting-options.html#page-cascading

created time in 11 days

issue openedhandsontable/docs

data source - description improvement

Description

I would change the paragraph naming Object data source with column as a function as it indicates that my data is a function. Ad what happens in the demo is setting up columns option as a function.

Links

Object data source with column as a function - https://handsontable.com/docs/8.1.0/tutorial-data-sources.html#page-column-func

created time in 11 days

issue commenthandsontable/docs

Data source - improve the paragraph naming

Having the data named hiddenData also appears to be unnecessary.

AMBudnik

comment created time in 11 days

issue openedhandsontable/docs

Data source - correct the typo

Description

There's a typo in the Object data source with column as a function paragraph.

That could be a good choice, when do you want bind data more dynamically.

We should use when you want bind or when you do want bind

Links

data source docs - https://handsontable.com/docs/8.1.0/tutorial-data-sources.html#page-column-func

created time in 11 days

issue openedhandsontable/docs

Data source - improve the paragraph naming

Description

We both agreed with @pnowak that the paragraph called Array data source with hidden columns should be renamed to something that does not indicate that the hiddenColumns are used.

Links

Array data source with hidden columns - https://handsontable.com/docs/8.1.0/tutorial-data-sources.html#page-array-hidden

created time in 11 days

issue closedhandsontable/handsontable

vue wrapper handsontable production build is not displaying table

Description

<!--- Tell us what happens and what should happen -->

its workign in development mode but after build is not displying table throwing error: vue.runtime.esm.js:1888 DOMException: Failed to execute 'insertBefore' on 'Node': This node type does not support this method.

Steps to reproduce

<!--- Provide steps to reproduce this issue -->

  1. npm run build

Demo

Your environment

  • Handsontable version:8.0.0
  • Browser Name and version: chrome
  • Operating System: ubuntu18.o4
  • Vue wrapper version: 5.0.1
  • Handsontable version: 8.0.0
  • vuejs : 2.6.11

closed time in 11 days

subbiahbb

issue commenthandsontable/handsontable

vue wrapper handsontable production build is not displaying table

If anyone would have the same issue with the newest wrapper for Vue please send me a message at support@handsontable.com

subbiahbb

comment created time in 11 days

issue commenthandsontable/handsontable

fixedColumnsLeft with rowHeaders hidden creates a 1px shift

Thanks to @aninde we discussed that it is OK on Chrome but is not working well on Firefox

Zrzut ekranu 2020-10-13 o 13 29 44 (effect on scrolling to the bottom, then left)

Maxoudela

comment created time in 11 days

issue commenthandsontable/handsontable

Submenu custom name does not work

Hi @giorgitus the issue hasn't been added to a milestone yet. I will make sure to inform you and other users listed above after fixing this issue.

AMBudnik

comment created time in 11 days

issue commenthandsontable/handsontable

fixedColumnsLeft with rowHeaders hidden creates a 1px shift

Hi @Maxoudela

if you define the height for your IMG the issue should be gone https://jsfiddle.net/L9k2dvbc/

Maxoudela

comment created time in 11 days

issue openedhandsontable/docs

uncheckedTemplate - wrong return set up

Description

The returned value in docs is falsewhile the getSettings() method returns undefined.

Go to demo console to check the result https://jsfiddle.net/AMBudnik/2yt6nzxd/

Links

uncheckedTemplate docs - https://handsontable.com/docs/8.1.0/Options.html#uncheckedTemplate

created time in 11 days

PullRequestReviewEvent

Pull request review commenthandsontable/handsontable

Add information about returned values for some hooks [DOCS]

 const REGISTERED_HOOKS = [    * @param {CellCoords} start Object containing information about first filled cell: `{row: 2, col: 0}`.    * @param {CellCoords} end Object containing information about last filled cell: `{row: 4, col: 1}`.    * @param {Array[]} data 2D array containing information about fill pattern: `[["1", "Ted"], ["1", "John"]]`.+   * @returns {*|boolean} If false, then the the autofill action will be canceled.

then the the autofill - 2 x 'the'

scarletfog

comment created time in 11 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedhandsontable/docs

renderer - small adjustments

Description

I do not think that those commas and dots are necessary.

Zrzut ekranu 2020-10-12 o 14 56 36

Especially cause they are not used across the docs. Examples

  • preventOverflow (dots only) - https://handsontable.com/docs/8.1.0/Options.html#preventOverflow
  • selectionMode (dots only) - https://handsontable.com/docs/8.1.0/Options.html#selectionMode
  • editor (only one dot at the end) - https://handsontable.com/docs/8.1.0/Options.html#editor
  • type (only one dot at the end) - https://handsontable.com/docs/8.1.0/Options.html#type

This makes me think that we do not have any specs on how to construct unordered lists.

Links

renderer docs - https://handsontable.com/docs/8.1.0/Options.html#renderer

created time in 12 days

issue openedhandsontable/docs

persistentState - wrong default set up

Description

We define that the default value of the persistentState option is

Zrzut ekranu 2020-10-12 o 14 39 27

But the getSettings() tells us that it is

Zrzut ekranu 2020-10-12 o 14 40 15

Demo https://jsfiddle.net/AMBudnik/2yt6nzxd/

Links

persistentState docs - https://handsontable.com/docs/8.1.0/Options.html#persistentState

created time in 12 days

issue openedhandsontable/docs

enterBeginsEditing - description improvement

Description

We should remove the reference to other projects in the description of enterBeginsEditing.

Links

  • enterBeginsEditing docs - https://handsontable.com/docs/8.1.0/Options.html#enterBeginsEditing

created time in 12 days

issue openedhandsontable/docs

fillHandle - wrong default set up

Description

We define the default value for the fillHandle to be true. But in the console for the getSettings() we can see that the default value is

Zrzut ekranu 2020-10-12 o 13 06 37

Demo for the console of the getSettings() method https://jsfiddle.net/AMBudnik/42qotga3/

Links

fillHandle docs - https://handsontable.com/docs/8.1.0/Options.html#fillHandle

created time in 12 days

issue openedhandsontable/docs

enterMoves - change parameter order in default value

Description

Here's how we define the default value for the enterMoves

Zrzut ekranu 2020-10-12 o 13 00 05

but generally, the console would switch those parameters

Go to this demo https://jsfiddle.net/AMBudnik/42qotga3/ and check the console for the enterMoves log.

Result Zrzut ekranu 2020-10-12 o 13 02 57

Links

enterMoves docs - https://handsontable.com/docs/8.1.0/Options.html#enterMoves

created time in 12 days

more