profile
viewpoint

ADmad/cakephp-jwt-auth 158

A CakePHP plugin for authenticating using JSON Web Tokens

ADmad/CakePHP-HybridAuth 80

CakePHP plugin for HybridAuth

ADmad/cakephp-social-auth 46

A CakePHP plugin which allows you to authenticate using social providers like Facebook/Google/Twitter.

AD7six/cakephp-shadow-translate 42

A 3.x+ CakePHP plugin for efficiently managing data translations

ADmad/cakephp-i18n 40

A CakePHP plugin with I18n related tools.

ADmad/cakephp-sequence 40

CakePHP plugin for maintaining a contiguous sequence of records

ADmad/cakephp-glide 34

CakePHP plugin for using Glide image manipulation library

ADmad/cakephp-tree 9

CakPHP plugin for working with tree structures

ADmad/cakephp-duplicatable 2

CakePHP plugin for duplicating entities including related data

ADmad/cakephp 1

CakePHP: The Rapid Development Framework for PHP - Official Repository

push eventSocialConnect/auth

Dominik Bauernfeind

commit sha 014e37936d25e1db10c756bca554dd3f01d7d38c

Update README.md Fix broken link in to architecture documentation

view details

ADmad

commit sha d3bbee5fb6c1196b6ddfc9bcf642657641fd0e92

Merge pull request #168 from dominikb/patch-1 Fix broken link in readme

view details

push time in 7 hours

PR merged SocialConnect/auth

Fix broken link in readme

Type: documentation

Link to issue: -

In raising this pull request, I confirm the following (please check boxes):

  • [x] I have read and understood the Contributing Guidelines.
  • [x] I have checked that another pull request for this purpose does not exist.
  • [ ] I wrote some tests for this PR.

Small description of change:

Fix broken link to architecture documentation

+2 -2

0 comment

1 changed file

dominikb

pr closed time in 7 hours

PR opened cakephp/cakephp

Fix docblock

<!---

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

Always follow the contribution guidelines when submitting a pull request. In particular, make sure existing tests still pass, and add tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.

-->

+4 -4

0 comment

1 changed file

pr created time in a day

create barnchcakephp/cakephp

branch : ADmad-patch-1

created branch time in a day

Pull request review commentcakephp/cakephp

Remove setting dynamic properties referencing components.

 public function components(?ComponentRegistry $components = null): ComponentRegi     /**      * Add a component to the controller's registry.      *-     * This method will also set the component to a property.+     * After loading a component it will be be accessible as a property through Controller::__get().

So should the text be changed to ..it will be be accessible as a dynamic property.?

ADmad

comment created time in a day

PullRequestReviewEvent

pull request commentcakephp/debug_kit

Docs: add doc for new variablesPanelMaxDepth config

RST is a weird beast, I still often make mistakes 😛.

LordSimal

comment created time in 2 days

push eventcakephp/debug_kit

Kevin Pfeifer

commit sha d4b24e98b53cf25602ef141e49e95321c1daf938

add doc for new variablesPanelMaxDepth config

view details

Kevin Pfeifer

commit sha 7b2b26fef1cbd941a3933e19c7355c7413bc9f40

Update docs/en/index.rst Co-authored-by: ADmad <ADmad@users.noreply.github.com>

view details

ADmad

commit sha 047262c6492b73b6f6cce488c9797a8e15dc8765

Fix formatting

view details

ADmad

commit sha 578d36238845d49ea69fda2db331a4f7b5a67e1b

Merge pull request #847 from LordSimal/master Docs: add doc for new variablesPanelMaxDepth config

view details

push time in 2 days

PR merged cakephp/debug_kit

Docs: add doc for new variablesPanelMaxDepth config

ref #846

+6 -0

0 comment

1 changed file

LordSimal

pr closed time in 2 days

push eventLordSimal/debug_kit

ADmad

commit sha 047262c6492b73b6f6cce488c9797a8e15dc8765

Fix formatting

view details

push time in 2 days

Pull request review commentcakephp/debug_kit

Docs: add doc for new variablesPanelMaxDepth config

 Configuration  * ``DebugKit.ignoreAuthorization`` - Set to true to ignore Cake Authorization plugin for DebugKit requests. Disabled by default. +* ``DebugKit.variablesPanelMaxDepth`` - Defines how many levels of nested data should be shown in the variables tab. Default is 5.+  WARNING: Increasing the max depth level can lead to an out of memory error.
  WARNING: Increasing the max depth level can lead to an out of memory error.::
LordSimal

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcakephp/debug_kit

Docs: add doc for new variablesPanelMaxDepth config

 Configuration  * ``DebugKit.ignoreAuthorization`` - Set to true to ignore Cake Authorization plugin for DebugKit requests. Disabled by default. +* | ``DebugKit.variablesPanelMaxDepth`` - Defines how many levels of nested data should be shown in the variables tab. Default is 5.+  | WARNING: Increasing the max depth level can lead to an out of memory error.
* ``DebugKit.variablesPanelMaxDepth`` - Defines how many levels of nested data should be shown in the variables tab. Default is 5.
  WARNING: Increasing the max depth level can lead to an out of memory error.
LordSimal

comment created time in 2 days

Pull request review commentcakephp/cakephp

Fix regression in Router::reverse() handling pass data

 public static function reverseToArray($params): array         }         $pass = $params['pass'] ?? []; +        $template = $params['_matchedRoute'] ?? null;

In the past I have wondered if storing the full route instance instead of just the template would be useful. It would have been for this case :). Perhaps something to consider for 5.0.

markstory

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentcakephp/cakephp

Fix regression in Router::reverse() handling pass data

 public static function reverseToArray($params): array         }         $pass = $params['pass'] ?? []; +        $template = $params['_matchedRoute'] ?? null;         unset(             $params['pass'],             $params['_matchedRoute'],             $params['_name']         );-        foreach ($pass as $i => $passedValue) {-            // Remove passed values that are also route keys-            if (in_array($passedValue, $params, true)) {-                unset($pass[$i]);+        $route = null;+        if ($template) {+            // Locate the route that was used to match this route+            // so we can access the pass parameter configuration.+            foreach (static::getRouteCollection()->routes() as $maybe) {+                if ($maybe->template === $template) {+                    $route = $maybe;+                    break;+                }             }         }-        $params = array_merge($params, array_values($pass));+        if ($route) {+            // If we found a route, slice off the number of passed args.+            $routePass = $route->options['pass'] ?? [];+            $pass = array_slice($pass, count($routePass));

So essentially only the value matching * should remain in $pass isn't it?

markstory

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentcakephp/cakephp

Fix regression in Router::reverse() handling pass data

 public static function reverseToArray($params): array         }         $pass = $params['pass'] ?? []; +        $template = $params['_matchedRoute'] ?? null;         unset(             $params['pass'],             $params['_matchedRoute'],             $params['_name']         );-        foreach ($pass as $i => $passedValue) {-            // Remove passed values that are also route keys-            if (in_array($passedValue, $params, true)) {-                unset($pass[$i]);+        $route = null;+        if ($template) {+            // Locate the route that was used to match this route+            // so we can access the pass parameter configuration.+            foreach (static::getRouteCollection()->routes() as $maybe) {+                if ($maybe->template === $template) {+                    $route = $maybe;+                    break;+                }             }         }-        $params = array_merge($params, array_values($pass));+        if ($route) {

True, the returned array would be "unusable", so I guess this is fine.

markstory

comment created time in 2 days

Pull request review commentcakephp/cakephp

Fix regression in Router::reverse() handling pass data

 public static function reverseToArray($params): array         }         $pass = $params['pass'] ?? []; +        $template = $params['_matchedRoute'] ?? null;         unset(             $params['pass'],             $params['_matchedRoute'],             $params['_name']         );-        foreach ($pass as $i => $passedValue) {-            // Remove passed values that are also route keys-            if (in_array($passedValue, $params, true)) {-                unset($pass[$i]);+        $route = null;+        if ($template) {+            // Locate the route that was used to match this route+            // so we can access the pass parameter configuration.+            foreach (static::getRouteCollection()->routes() as $maybe) {+                if ($maybe->template === $template) {+                    $route = $maybe;+                    break;+                }             }         }-        $params = array_merge($params, array_values($pass));+        if ($route) {

Should there be an exception instead when no route matching the template is found? Trying to reverse an array which doesn't match to any existing routes doesn't seem very useful.

markstory

comment created time in 2 days

PullRequestReviewEvent

PR merged cakephp/authentication

Allow skipping the challenge exception generation for Http Basic/Digest Auth.

Also updated HttpBasicAuthenticator to set proper result status depending on whether credentials are missing or identity is not found.

Refs #497.

+68 -29

1 comment

4 changed files

ADmad

pr closed time in 2 days

push eventcakephp/authentication

ADmad

commit sha 87bb6c18629d9e2790cc47848d9aba29713845b7

Update HttpBasicAuthenticator to set proper result status.

view details

ADmad

commit sha 4dbc3734c6e01f89b62453f3eb121b80ef034564

Allow skipping the challlenge exception generation for Http Basic/Digest Auth.

view details

ADmad

commit sha bd8eeadbb2a87c4a61cd9b4f28f059a28c6e3422

Merge pull request #498 from cakephp/http-basic-auth-challenge Allow skipping the challenge exception generation for Http Basic/Digest Auth.

view details

push time in 2 days

delete branch cakephp/authentication

delete branch : http-basic-auth-challenge

delete time in 2 days

push eventcakephp/authentication

ADmad

commit sha e8af9751b879c3019a30b414328f1620e0f42c67

Overwrite "algorithms" config instead of merging.

view details

Mark Story

commit sha 9dc2d7359743ec6869e4482a230e7bbc4d0b9e61

Merge pull request #501 from cakephp/jwt-auth-algos Overwrite "algorithms" config instead of merging.

view details

Mark Story

commit sha 6c6291bad56add2a947eaaf01a0d68d1c350f66e

Merge pull request #500 from cakephp/2.next Bump firebase/php-jwt to v5.5.

view details

Mark Story

commit sha 2866fdfaa20a6e72fac86c54cbccc2fd8d788d48

Fix typo in docs deploy

view details

Mark Story

commit sha 3222adba7045776cc6b8f65cea9b3da8465d857e

Fix test failures on lowest build.

view details

push time in 2 days

Pull request review commentcakephp/debug_kit

add ability to change variables panel max depth via config + add notice in panel

     printf('<p class="warning">%s</p>', $error); endif; +if (isset($varsMaxDepth)) {+    $msg = sprintf(__d('debug_kit', '%s levels of nested data shown.'), $varsMaxDepth);+    $msg .= __d('debug_kit', 'You can overwrite this via the config key');+    $msg .= ' <strong>DebugKit.variablesPanelMaxDepth</strong>';+    $msg .= __d('debug_kit', ' | Increasing the depth value can lead to an out of memory error.');

Pretty please :)

LordSimal

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentcakephp/debug_kit

add ability to change variables panel max depth via config + add notice in panel

     printf('<p class="warning">%s</p>', $error); endif; +if (isset($varsMaxDepth)) {+    $msg = sprintf(__d('debug_kit', '%s levels of nested data shown.'), $varsMaxDepth);+    $msg .= __d('debug_kit', 'You can overwrite this via the config key');+    $msg .= ' <strong>DebugKit.variablesPanelMaxDepth</strong>';+    $msg .= __d('debug_kit', ' | Increasing the depth value can lead to an out of memory error.');

That takes up lot of space. Perhaps keep it in the info itself using <br>. Also a space is need before You can....

LordSimal

comment created time in 2 days

PullRequestReviewEvent
more