profile
viewpoint
遗忘
839 8398a7 Kyoto, Japan https://8398a7.github.io vim/vscode, typescript/ruby/golang, react/chef/rails/docker/k8s/aws/gcp

8398a7/action-slack 163

Provides the function of slack notification to GitHub Actions.

8398a7/abilitysheet 38

This app is ability sheet for beatmania iidx music of level 12.

8398a7/collaborative_filtering 2

This gem provides a collaborative filtering in ruby.

8398a7/dotfiles 2

my dotfiles

8398a7/api-abilitysheet 1

api for abilitysheet by gin(golang) and docker

8398a7/cka-practice 1

The vagrant environment used when practicing CKA.

8398a7/connected-react-router-redux 1

It's a HoC that updates the reducer when using connected-react-router.

8398a7/crystal 1

The Crystal Programming Language

8398a7/8398a7.github.io 0

My portfolio.

startedfelixge/fgprof

started time in 3 days

issue closedterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

I have issues

I can't update the min size of the node group.

I'm submitting a...

  • [x] bug report
  • [ ] feature request
  • [ ] support request - read the FAQ first!
  • [ ] kudos, thank you, warm fuzzy

What is the current behavior?

InvalidParameterException: desiredSize is not valid

If this is a bug, how to reproduce? Please include a code sample if relevant.

First create a node group with min: 1, desired: 1, max: 2. Then if I try to update to min: 2, desired: 2, max: 3, I get an error.

This is because the desired size change is ignored. https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v12.1.0/modules/node_groups/node_groups.tf#L48

      ~ scaling_config {
            desired_size = 1
            max_size     = 3
          ~ min_size     = 1 -> 2
        }

What's the expected behavior?

I want to be able to change it to a min size greater than the desired size we specified when we first created the node group.

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version:
  • OS:
  • Terraform version: 0.12.28

Any other relevant info

closed time in 4 days

8398a7

issue commentterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

I'm really sorry. Multiple node groups were covered and I was still mistaken. Your explanation is correct...

8398a7

comment created time in 4 days

IssuesEvent

issue commentterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

But it still seems to be acting that way. I can't make the min size larger than the desired size specified at the beginning.

  1. Create a node group with min: 1, desired: 1, max: 3
  2. Change the desired size from AWS console to 2
  3. Change the min size to 2 in terraform

At this time, the desired size is 2 in preview, but when you actually apply it, an error appears as if the desired size is 1. It seems that the min size cannot exceed the desired size specified at the beginning when creating the node group.

8398a7

comment created time in 4 days

issue closedterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

I have issues

I can't update the min size of the node group.

I'm submitting a...

  • [x] bug report
  • [ ] feature request
  • [ ] support request - read the FAQ first!
  • [ ] kudos, thank you, warm fuzzy

What is the current behavior?

InvalidParameterException: desiredSize is not valid

If this is a bug, how to reproduce? Please include a code sample if relevant.

First create a node group with min: 1, desired: 1, max: 2. Then if I try to update to min: 2, desired: 2, max: 3, I get an error.

This is because the desired size change is ignored. https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v12.1.0/modules/node_groups/node_groups.tf#L48

      ~ scaling_config {
            desired_size = 1
            max_size     = 3
          ~ min_size     = 1 -> 2
        }

What's the expected behavior?

I want to be able to change it to a min size greater than the desired size we specified when we first created the node group.

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version:
  • OS:
  • Terraform version: 0.12.28

Any other relevant info

closed time in 4 days

8398a7

issue commentterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

Sorry, I was mistaken. I thought I was getting an error when I changed the desired size from something other than terraform, because the setting kept remaining in terraform first.

In fact, it didn't happen. Thanks for the support.

8398a7

comment created time in 4 days

issue openedterraform-aws-modules/terraform-aws-eks

Error if the desired size is less than the min size

I have issues

I can't update the min size of the node group.

I'm submitting a...

  • [x] bug report
  • [ ] feature request
  • [ ] support request - read the FAQ first!
  • [ ] kudos, thank you, warm fuzzy

What is the current behavior?

InvalidParameterException: desiredSize is not valid

If this is a bug, how to reproduce? Please include a code sample if relevant.

First create a node group with min: 1, desired: 1, max: 2. Then if I try to update to min: 2, desired: 2, max: 3, I get an error.

This is because the desired size change is ignored. https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v12.1.0/modules/node_groups/node_groups.tf#L48

      ~ scaling_config {
            desired_size = 1
            max_size     = 3
          ~ min_size     = 1 -> 2
        }

What's the expected behavior?

I want to be able to change it to a min size greater than the desired size we specified when we first created the node group.

Are you able to fix this problem and submit a PR? Link here if you have already.

Environment details

  • Affected module version:
  • OS:
  • Terraform version: 0.12.28

Any other relevant info

created time in 7 days

delete branch 8398a7/tidb-operator

delete branch : fix-template

delete time in 9 days

issue closedpingcap/tidb-operator

Deployment fails with monitor-secret.yaml in tidb-cluster chart

Bug Report

What version of Kubernetes are you using? client: v1.18.5 (macOS) server: 1.16.6-beta.0 (docker-desktop)

What version of TiDB Operator are you using?

$ > helm search repo tidb-cluster
NAME                    CHART VERSION   APP VERSION     DESCRIPTION
pingcap/tidb-cluster    v1.1.2                          A Helm chart for TiDB Cluster
$ > kubectl exec tidb-controller-manager-5749f98d8-crhw5 -- tidb-controller-manager -V
TiDB Operator Version: version.Info{GitVersion:"v1.1.2", GitCommit:"04c96f3b1b35f0196f4298c15b6c12559976b57b", GitTreeState:"clean", BuildDate:"2020-07-01T11:43:16Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

This is after the provisional action described in What did you see instead?. Before that, there is nothing because the deployment has failed.

$ > kubectl get sc,pvc
NAME                                             PROVISIONER          AGE
storageclass.storage.k8s.io/hostpath (default)   docker.io/hostpath   66m

NAME                                             STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/pd-tidb-cluster-pd-0       Bound    pvc-f9c558f7-ba0b-451f-8f7d-287f60eb3efd   1Gi        RWO            hostpath       18m
persistentvolumeclaim/tikv-tidb-cluster-tikv-0   Bound    pvc-178327c5-b522-4baa-8224-5addc7ff6c4c   10Gi       RWO            hostpath       17m

What's the status of the TiDB cluster pods?

This is after the provisional action described in What did you see instead?. Before that, there is nothing because the deployment has failed.

$ > kubectl get po -o wide
NAME                                      READY   STATUS    RESTARTS   AGE   IP          NODE             NOMINATED NODE   READINESS GATES
tidb-cluster-discovery-77dc784b5f-7qcc6   1/1     Running   0          18m   10.1.0.35   docker-desktop   <none>           <none>
tidb-cluster-monitor-58f47cc95f-jjp8c     3/3     Running   0          18m   10.1.0.33   docker-desktop   <none>           <none>
tidb-cluster-pd-0                         1/1     Running   0          18m   10.1.0.34   docker-desktop   <none>           <none>
tidb-cluster-tidb-0                       2/2     Running   0          17m   10.1.0.37   docker-desktop   <none>           <none>
tidb-cluster-tikv-0                       1/1     Running   0          18m   10.1.0.36   docker-desktop   <none>           <none>
tidb-controller-manager-5749f98d8-crhw5   1/1     Running   0          60m   10.1.0.12   docker-desktop   <none>           <none>
tidb-scheduler-6f6786b685-xq8kb           2/2     Running   0          60m   10.1.0.11   docker-desktop   <none>           <none>

What did you do?

$ > helm upgrade tidb-cluster pingcap/tidb-cluster -i --wait -n tidb-admin --set pd.storageClassName=hostpath,tikv.storageClassName=hostpath,pd.replicas=1,tikv.replicas=1,tidb.replicas=1,monitor.create=true,monitor.grafana.create=false
Error: UPGRADE FAILED: template: tidb-cluster/templates/monitor-secret.yaml:1:7: executing "tidb-cluster/templates/monitor-secret.yaml" at <(.Values.monitor.create) and (.Values.monitor.grafana.create)>: can't give argument to non-function .Values.monitor.create

What did you expect to see?

Successful deployment.

What did you see instead?

I'm using helm v3.2.4.

$ > helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"}

I don't know if it's a problem with the version of helm, but I fixed it as follows.

diff --git a/charts/tidb-cluster/templates/monitor-secret.yaml b/charts/tidb-cluster/templates/monitor-secret.yaml
index f1df734..903feb5 100644
--- a/charts/tidb-cluster/templates/monitor-secret.yaml
+++ b/charts/tidb-cluster/templates/monitor-secret.yaml
@@ -1,4 +1,4 @@
-{{- if (.Values.monitor.create) and (.Values.monitor.grafana.create) }}
+{{- if and .Values.monitor.create .Values.monitor.grafana.create }}
 apiVersion: v1
 kind: Secret
 metadata:

The deployment is now a success. May I issue a PR?

closed time in 9 days

8398a7

push event8398a7/tidb-operator

Song Gao

commit sha c01863415ecb311d2de49896cd79a8b6f1e2702d

Refactor TiKV auto-scaling (#2862)

view details

Song Gao

commit sha 17b9cc51fd9ce0c7f599a4ee7caffe8986d3b9ce

Make pod webhook able to manage tikv group pod (#2846)

view details

Yecheng Fu

commit sha db5360e7b57922dfc6019245940989aa8dc02b05

don't dump statefulset spec on update event (#2844) Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

view details

Yecheng Fu

commit sha 398dbbb5e5507c9ac6c595bcf38003d4e9d15dc2

add new pull e2e Jenkins file (#2872) Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>

view details

839

commit sha 863fb805a33d88e33f9c2f24048d0068407ac459

Fixed syntax for "and" conditions (#2869) Fixes a deployment error. ``` <(.Values.monitor.create) and (.Values.monitor.grafana.create)>: can't give argument to non-function .Values.monitor.create ``` We have confirmed that both helm2[1] and helm3[2] work. [1]: https://v2.helm.sh/docs/chart_template_guide/#operators-are-functions [2]: https://helm.sh/docs/chart_template_guide/function_list/#and Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Yecheng Fu <fuyecheng@pingcap.com>

view details

push time in 9 days

push event8398a7/dotfiles

839

commit sha 3ccf1130a854603139156d6018e2b2997ca8820c

[zsh] rubyのbinを追加

view details

push time in 10 days

push event8398a7/dotfiles

839

commit sha 20aaa20d9f26c81d40db38118e3553ed7b4de8ba

[zsh] asdfに乗り換え

view details

push time in 10 days

push event8398a7/dotfiles

839

commit sha 48de6f0937b04f8bdd029e27e9ea62ec8aed0a6b

[git] pull時のrebase設定を追加

view details

839

commit sha 665982dad4723eb746a3798aa5fc75ae5de9ffe9

[git] テンプレを使わないようにする設定の追加

view details

839

commit sha 3b969e816c03469beca002769ca839cd933a0015

[idea] 相対行の表示

view details

839

commit sha 7383f00785b7f7ea1b1650981595384c1f2ef981

[zsh] 使わない設定の除去

view details

839

commit sha 3e36c8a6d9fe9050c6cd1565684af0c964c0c3ee

[zsh] cargoの追加

view details

839

commit sha 4723ace5db862f61ce66b012467eec51b3cf5ada

asdfに乗り換え

view details

push time in 10 days

PR opened pingcap/tidb-operator

Fixed syntax for "and" conditions

<!-- Thank you for contributing to TiDB Operator! Please read TiDB Operator's CONTRIBUTING document BEFORE filing this PR. -->

What problem does this PR solve? <!--add and issue link with summary if exists-->

Fixes a deployment error.

<(.Values.monitor.create) and (.Values.monitor.grafana.create)>: can't give argument to non-function .Values.monitor.create

I have confirmed that both helm2 and helm3 work.

https://v2.helm.sh/docs/chart_template_guide/#operators-are-functions https://helm.sh/docs/chart_template_guide/function_list/#and

What is changed and how does it work?

Fixed syntax.

Check List <!--REMOVE the items that are not applicable-->

Tests <!-- At least one of them must be included. -->

  • Manual test (add detailed scripts or steps below)

I used a v1.16 series k8s cluster. The following command is used to check the operation.

kubectl create ns tidb-admin
helm repo add pingcap https://charts.pingcap.org/
kubectl apply -f https://raw.githubusercontent.com/pingcap/tidb-operator/master/manifests/crd.yaml
helm upgrade tidb-operator pingcap/tidb-operator -i --wait -n tidb-admin
helm upgrade tidb-cluster pingcap/tidb-cluster -i --wait -n tidb-admin \
  --set schedulerName=tidb-scheduler,pd.storageClassName=hostpath,tikv.storageClassName=hostpath,pd.replicas=1,tikv.replicas=1,tidb.replicas=1,monitor.create=true,monitor.grafana.create=true

Code changes

  • Has Helm chart code change

Related changes

None.

Does this PR introduce a user-facing change?:

No.

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnch8398a7/tidb-operator

branch : fix-template

created branch time in 11 days

fork 8398a7/tidb-operator

TiDB operator creates and manages TiDB clusters running in Kubernetes.

https://pingcap.com/docs/v3.0/tidb-in-kubernetes/tidb-operator-overview/

fork in 11 days

issue commentpingcap/tidb-operator

Deployment fails with monitor-secret.yaml in tidb-cluster chart

@DanielZhangQD When I tried it, I saw the same problem with helm2.

helm 2 docs: https://v2.helm.sh/docs/chart_template_guide/#operators-are-functions helm 3 docs: https://helm.sh/docs/chart_template_guide/function_list/#and

So I would like to change it and submit a PR as I don't think it will affect compatibility. Thanks for the confirmation.

8398a7

comment created time in 11 days

push event8398a7/action-slack

839

commit sha e3e162494b9469bc4aa6a66be9259acede13b0f7

add ignore file

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha f42375e0d42ed0249c2fa645fc8b4f24df910b36

remove unnecessary method definition

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha c998daad4cd21a67d73f20ca0eaf0e0f1bc4fc4e

Refactoring the design

view details

839

commit sha 6ae9bdd9dcfd66cb84f88700cf12d3e6a4699f44

Split the test in a pull request

view details

839

commit sha 7f6c76178624accc74d0eba85d17c1439bb59edb

Refactoring environment variable for test

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 641cdbed8ccd3b9c7f3fb374d90a1798693874bf

Update issue templates

view details

push time in 11 days

issue closed8398a7/action-slack

Single quote in commit message causes an error

I got this error from a Slack integration that worked fine before:

##[error]Unexpected identifier

After a bit of digging, I realized that it was the fact that the first commit message of the branch had a single quote in it, which means the PR name also had it. It seems that action-slack doesn't escape the strings properly, and errors out.

This was on v2.

closed time in 11 days

xird

issue comment8398a7/action-slack

Single quote in commit message causes an error

Please open again if there is reproduction information.

xird

comment created time in 11 days

push event8398a7/action-slack

839

commit sha 5554d54387dbc43e881544ece8bd9f4e59e0093e

[npm] upgrade

view details

push time in 11 days

created tag8398a7/action-slack

tagv3.5.0

Provides the function of slack notification to GitHub Actions.

created time in 11 days

push event8398a7/action-slack

push time in 11 days

push event8398a7/action-slack

839

commit sha c9ce76ae3274c708bf27181956ebffaa1eb32f96

[#3] wip

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 1628a07d70cf3c01cf8806960dbad60401769bbf

[#3] [command] npm run release

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha e88a10ce196321c62a6167166add1500aa9ff638

[#3] [command] npm run release

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 4d95341b68ed162e612f542e8b6d64c5b567596f

[#86] Added testing of the matrix

view details

839

commit sha 1710f98dd40c4521769cf48b5c6cd2d4a2ecd1b3

[#86] Update the documentation for the matrix

view details

839

commit sha 8d1aab316db3b8bab2196fc07283643776d9cca4

[#86] Rename the helper to a test file

view details

839

commit sha 30b1dafd7f8f92e3f72db347e452f9469c178694

Merge pull request #89 from 8398a7/issue/86 Issue/86

view details

839

commit sha 1f634631d04fc0ff89920f6904664fa3eef1798e

bump 3.5.0

view details

839

commit sha 3d4daca3fcf3758543d429ca9ad76d4fbe7beb4e

Add matrix integration test

view details

839

commit sha b3f6a5be72501f9075b3124dab66dc3961c49f7a

[#3] Merge branch 'master' into v3

view details

839

commit sha 2a54761ded8f0bbb41bb84944008ce77f3f9a528

[#3] [command] npm run release

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 3d4daca3fcf3758543d429ca9ad76d4fbe7beb4e

Add matrix integration test

view details

839

commit sha 07a56817da506a297e3c69e53cdcbd439ab6ff79

Merge branch 'master' into pre

view details

839

commit sha 540bda3005f51c70a52a1704d142c0faf5313ea1

[command] npm run release

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 3d4daca3fcf3758543d429ca9ad76d4fbe7beb4e

Add matrix integration test

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 77ac519c612f454dcc4a398012720622dfa579f8

[#84] Fixed the part that is in full render

view details

839

commit sha e4f2e943faef145327e6f4c8ad66fd67accca091

[#84] Fixed the wrong index to use

view details

839

commit sha 35a18b2af8e1c4c1d063718db017e19f7b58a227

[#84] Fixed domain

view details

839

commit sha 56b82f0a7cc1fc8355754da3330718c0c2874970

Merge pull request #85 from 8398a7/issue/84 [#84] Fixed the part that is in full render

view details

839

commit sha 67512b9ea3c72a771ee7a00b4af02d9b42ba78b5

Fixed typo

view details

839

commit sha 6793e3b1294d8a95a315f511f9e1ebd93490b02b

[#87] action fields back in

view details

839

commit sha bf53614664c6e9783f030dee02f2f0c2701c6b40

[#87] Add description of action

view details

839

commit sha b1097ec8c611d1ed685e600ac727140a7ba449d4

Merge pull request #88 from 8398a7/issue/87 Issue/87

view details

839

commit sha 4d95341b68ed162e612f542e8b6d64c5b567596f

[#86] Added testing of the matrix

view details

839

commit sha 1710f98dd40c4521769cf48b5c6cd2d4a2ecd1b3

[#86] Update the documentation for the matrix

view details

839

commit sha 8d1aab316db3b8bab2196fc07283643776d9cca4

[#86] Rename the helper to a test file

view details

839

commit sha 30b1dafd7f8f92e3f72db347e452f9469c178694

Merge pull request #89 from 8398a7/issue/86 Issue/86

view details

839

commit sha 1f634631d04fc0ff89920f6904664fa3eef1798e

bump 3.5.0

view details

839

commit sha c0750c8a2455ec46e28fc91a0233994d30ebdf97

Add matrix integration test

view details

839

commit sha fd3ea26194f0f0519c392aad45f6c90dc927085a

Merge branch 'master' into pre

view details

839

commit sha 771711b565158272c8508272eab5e1e53a7e898a

[command] npm run release

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha c0750c8a2455ec46e28fc91a0233994d30ebdf97

Add matrix integration test

view details

push time in 11 days

push event8398a7/action-slack

839

commit sha 1f634631d04fc0ff89920f6904664fa3eef1798e

bump 3.5.0

view details

push time in 11 days

issue closed8398a7/action-slack

Matrix seems to confuse action-slack...

For a workflow using a matrix like:

build: strategy: matrix: os: [ubuntu-18.04, ubuntu-20.04] runs-on: ${{ matrix.os }}

I get the fields AS_JOB and AS_TOOK undefined. See attached screenshot. Without matrix it all works fine.

Screen Shot 2020-06-29 at 10 05 20

closed time in 11 days

FonsRademakers

delete branch 8398a7/action-slack

delete branch : issue/86

delete time in 11 days

push event8398a7/action-slack

839

commit sha 4d95341b68ed162e612f542e8b6d64c5b567596f

[#86] Added testing of the matrix

view details

839

commit sha 1710f98dd40c4521769cf48b5c6cd2d4a2ecd1b3

[#86] Update the documentation for the matrix

view details

839

commit sha 8d1aab316db3b8bab2196fc07283643776d9cca4

[#86] Rename the helper to a test file

view details

839

commit sha 30b1dafd7f8f92e3f72db347e452f9469c178694

Merge pull request #89 from 8398a7/issue/86 Issue/86

view details

push time in 11 days

PR merged 8398a7/action-slack

Issue/86

close #86

+323 -159

0 comment

8 changed files

8398a7

pr closed time in 11 days

PR opened 8398a7/action-slack

Issue/86

close #86

+323 -159

0 comment

8 changed files

pr created time in 11 days

push event8398a7/action-slack

839

commit sha 8d1aab316db3b8bab2196fc07283643776d9cca4

[#86] Rename the helper to a test file

view details

push time in 11 days

create barnch8398a7/action-slack

branch : issue/86

created branch time in 11 days

issue openedpingcap/tidb-operator

Deployment fails with monitor-secret.yaml in tidb-cluster chart

Bug Report

What version of Kubernetes are you using? client: v1.18.5 (macOS) server: 1.16.6-beta.0 (docker-desktop)

What version of TiDB Operator are you using?

$ > helm search repo tidb-cluster
NAME                    CHART VERSION   APP VERSION     DESCRIPTION
pingcap/tidb-cluster    v1.1.2                          A Helm chart for TiDB Cluster
$ > kubectl exec tidb-controller-manager-5749f98d8-crhw5 -- tidb-controller-manager -V                                                     TiDB Operator Version: version.Info{GitVersion:"v1.1.2", GitCommit:"04c96f3b1b35f0196f4298c15b6c12559976b57b", GitTreeState:"clean", BuildDate:"2020-07-01T11:43:16Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

What storage classes exist in the Kubernetes cluster and what are used for PD/TiKV pods?

$ > kubectl get sc,pvc
NAME                                             PROVISIONER          AGE
storageclass.storage.k8s.io/hostpath (default)   docker.io/hostpath   66m

NAME                                             STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/pd-tidb-cluster-pd-0       Bound    pvc-f9c558f7-ba0b-451f-8f7d-287f60eb3efd   1Gi        RWO            hostpath       18m
persistentvolumeclaim/tikv-tidb-cluster-tikv-0   Bound    pvc-178327c5-b522-4baa-8224-5addc7ff6c4c   10Gi       RWO            hostpath       17m

What's the status of the TiDB cluster pods?

$ > kubectl get po -o wide
NAME                                      READY   STATUS    RESTARTS   AGE   IP          NODE             NOMINATED NODE   READINESS GATES
tidb-cluster-discovery-77dc784b5f-7qcc6   1/1     Running   0          18m   10.1.0.35   docker-desktop   <none>           <none>
tidb-cluster-monitor-58f47cc95f-jjp8c     3/3     Running   0          18m   10.1.0.33   docker-desktop   <none>           <none>
tidb-cluster-pd-0                         1/1     Running   0          18m   10.1.0.34   docker-desktop   <none>           <none>
tidb-cluster-tidb-0                       2/2     Running   0          17m   10.1.0.37   docker-desktop   <none>           <none>
tidb-cluster-tikv-0                       1/1     Running   0          18m   10.1.0.36   docker-desktop   <none>           <none>
tidb-controller-manager-5749f98d8-crhw5   1/1     Running   0          60m   10.1.0.12   docker-desktop   <none>           <none>
tidb-scheduler-6f6786b685-xq8kb           2/2     Running   0          60m   10.1.0.11   docker-desktop   <none>           <none>

What did you do?

$ > helm upgrade tidb-cluster pingcap/tidb-cluster -i --wait -n tidb-admin --set pd.storageClassName=hostpath,tikv.storageClassName=hostpath,pd.replicas=1,tikv.replicas=1,tidb.replicas=1,monitor.create=true,monitor.grafana.create=false                                           Error: UPGRADE FAILED: template: tidb-cluster/templates/monitor-secret.yaml:1:7: executing "tidb-cluster/templates/monitor-secret.yaml" at <(.Values.monitor.create) and (.Values.monitor.grafana.create)>: can't give argument to non-function .Values.monitor.create

What did you expect to see? Successful deployment

What did you see instead?

I'm using helm v3.2.4.

$ > helm version                                                                                                                           version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.3"}

I don't know if it's a problem with the version of helm, but I fixed it as follows.

diff --git a/charts/tidb-cluster/templates/monitor-secret.yaml b/charts/tidb-cluster/templates/monitor-secret.yaml
index f1df734..903feb5 100644
--- a/charts/tidb-cluster/templates/monitor-secret.yaml
+++ b/charts/tidb-cluster/templates/monitor-secret.yaml
@@ -1,4 +1,4 @@
-{{- if (.Values.monitor.create) and (.Values.monitor.grafana.create) }}
+{{- if and .Values.monitor.create .Values.monitor.grafana.create }}
 apiVersion: v1
 kind: Secret
 metadata:

The deployment is now a success. May I issue a PR?

created time in 12 days

issue commentaws/containers-roadmap

[EKS] [request]: Rolling update to change instance type for Managed Nodes

@badaldavda I believe the proposed method for any sort of nodegroup update is a new nodegroup and then a deletion of the old one.

In this case, the user would need to take the following steps

  1. Adding taint to old node groups
  2. Move the Pod to a new node group
  3. When the move is complete, delete the old node group

Now when I delete a group of nodes, it looks like all nodes start the termination process at the same time. I don't want them to be deleted at the same time, so I think you'll need to move the Pod yourself in step 2. This is a lot of work, and I'd also like to see managed node groups be able to update rolling instance types.

badaldavda

comment created time in 12 days

issue comment8398a7/action-slack

Breaking change in minor a update?

I found the cause. If you remove name: sandbox jon, it works.

The problem that you can't get the file when you change the name seems to be difficult to solve because of the API specification. If I were to solve it, I'd have to tell the action-slack the name like this:

    uses: 8398a7/action-slack@v3
    with:
      status: failure
      fields: job,author
      text: "Testing failure message to PR. Hello world!."
      author_name: ""
      override_job_name: sandbox jon
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

I saw it. Can the github token be taken in the specified way as well? GITHUB_TOKEN: ${{ github.token }}

The documentation states the following, can you try it here? GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

If it tells you a public repository, I'll investigate.

Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

Oh, you need to specify GITHUB_TOKEN if you want to use a job.

    uses: 8398a7/action-slack@v3
    with:
      status: failure
      fields: job,author
      text: "Testing failure message to PR. Hello world!."
      author_name: ""
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

refs: https://action-slack.netlify.app/fields

Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

Are you using matrix? It's a known issue that it is undefined in that case.

refs: #86

Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

The link between action and workflow is the same, except the field name and display name have been changed.

action https://github.com/8398a7/action-slack/blob/v3.1.0/src/client.ts#L226 workflow https://github.com/8398a7/action-slack/blob/v3.4.0/src/fields.ts#L169

The feature you are looking for may be the newly added job field. https://action-slack.netlify.app/fields

Veetaha

comment created time in 15 days

push event8398a7/action-slack

839

commit sha 77ac519c612f454dcc4a398012720622dfa579f8

[#84] Fixed the part that is in full render

view details

839

commit sha e4f2e943faef145327e6f4c8ad66fd67accca091

[#84] Fixed the wrong index to use

view details

839

commit sha 35a18b2af8e1c4c1d063718db017e19f7b58a227

[#84] Fixed domain

view details

839

commit sha 56b82f0a7cc1fc8355754da3330718c0c2874970

Merge pull request #85 from 8398a7/issue/84 [#84] Fixed the part that is in full render

view details

839

commit sha 67512b9ea3c72a771ee7a00b4af02d9b42ba78b5

Fixed typo

view details

839

commit sha 6793e3b1294d8a95a315f511f9e1ebd93490b02b

[#87] action fields back in

view details

839

commit sha bf53614664c6e9783f030dee02f2f0c2701c6b40

[#87] Add description of action

view details

839

commit sha b1097ec8c611d1ed685e600ac727140a7ba449d4

Merge pull request #88 from 8398a7/issue/87 Issue/87

view details

839

commit sha 8d1eb81de98776ad8749a8f07c1c2f44e90df56b

[#3] Merge branch 'master' into v3

view details

839

commit sha 523352d26c2af734355cfd156de43a2d9d049de6

[#3] [command] npm run release

view details

push time in 15 days

delete branch 8398a7/action-slack

delete branch : issue/87

delete time in 15 days

push event8398a7/action-slack

839

commit sha 6793e3b1294d8a95a315f511f9e1ebd93490b02b

[#87] action fields back in

view details

839

commit sha bf53614664c6e9783f030dee02f2f0c2701c6b40

[#87] Add description of action

view details

839

commit sha b1097ec8c611d1ed685e600ac727140a7ba449d4

Merge pull request #88 from 8398a7/issue/87 Issue/87

view details

push time in 15 days

PR merged 8398a7/action-slack

Issue/87

refs: #87

+28 -1

0 comment

3 changed files

8398a7

pr closed time in 15 days

PR opened 8398a7/action-slack

Issue/87

refs: #87

+28 -1

0 comment

3 changed files

pr created time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

The reason for this was that the roles of action and workflow are very similar. I think workflow is a higher level feature, so I would recommend it if you want to replace it.

Veetaha

comment created time in 15 days

create barnch8398a7/action-slack

branch : issue/87

created branch time in 15 days

issue comment8398a7/action-slack

Breaking change in minor a update?

I'm sorry. There's no excuse for this. I put it in because the notification doesn't fail, but I'd like to put the action back in v3.

Veetaha

comment created time in 15 days

issue comment8398a7/action-slack

Matrix seems to confuse action-slack...

Until this issue is closed, it is not supported.

FonsRademakers

comment created time in 16 days

issue comment8398a7/action-slack

Matrix seems to confuse action-slack...

Thanks for the report. The specific repositories were noted, which helped me to find the cause of the problem.

Currently action-slack does not know what items are specified via matrix. You will need to add one more key to yaml to solve this problem. The problem itself isn't too difficult to solve and will be addressed in the near future.

Current projections.

steps:
  - uses: 8398a7/action-slack@v3
    with:
      status: ...
      fields: ...
    env:
      GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
      MATRIX_CONTEXT: ${{ toJson(matrix) }} # Required when using matrix
    if: always()
FonsRademakers

comment created time in 17 days

issue comment8398a7/action-slack

Compact format like travis

I haven't investigated the behavior when using matrix, so there may be a possibility of mixing it up. Also, no screenshots seem to be attached... 😢

8398a7

comment created time in 17 days

push event8398a7/action-slack

839

commit sha 67512b9ea3c72a771ee7a00b4af02d9b42ba78b5

Fixed typo

view details

push time in 17 days

delete branch 8398a7/action-slack

delete branch : issue/84

delete time in 18 days

push event8398a7/action-slack

839

commit sha 77ac519c612f454dcc4a398012720622dfa579f8

[#84] Fixed the part that is in full render

view details

839

commit sha e4f2e943faef145327e6f4c8ad66fd67accca091

[#84] Fixed the wrong index to use

view details

839

commit sha 35a18b2af8e1c4c1d063718db017e19f7b58a227

[#84] Fixed domain

view details

839

commit sha 56b82f0a7cc1fc8355754da3330718c0c2874970

Merge pull request #85 from 8398a7/issue/84 [#84] Fixed the part that is in full render

view details

push time in 18 days

PR merged 8398a7/action-slack

[#84] Fixed the part that is in full render

close #84

+20 -16

1 comment

3 changed files

8398a7

pr closed time in 18 days

issue closed8398a7/action-slack

Fix handling of links that do not contain sharps

It's now a full render.

closed time in 18 days

8398a7

push event8398a7/action-slack

839

commit sha 35a18b2af8e1c4c1d063718db017e19f7b58a227

[#84] Fixed domain

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha fee5c7a42564c0e7d67e528a59c4266bb70cce48

[#84] Fixed domain

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha e4f2e943faef145327e6f4c8ad66fd67accca091

[#84] Fixed the wrong index to use

view details

push time in 18 days

PR opened 8398a7/action-slack

[#84] Fixed the part that is in full render

close #84

+15 -11

0 comment

1 changed file

pr created time in 18 days

create barnch8398a7/action-slack

branch : issue/84

created branch time in 18 days

issue opened8398a7/action-slack

Fix handling of links that do not contain sharps

It's now a full render.

created time in 18 days

push event8398a7/action-slack

839

commit sha 9c11c0088ece8446ca44863c544821741e3d4bdb

bump 3.4.0

view details

839

commit sha b016e18753ba8ab85c01a5ee668e8c22b0b47e54

Fixed slack web hook url

view details

839

commit sha a658209b71b680f8475b030bed6aa8e5d1054539

Change to minimum information

view details

839

commit sha a82a344376304619bddbe474700407ce9f514bb4

Update example image

view details

839

commit sha 1aa0dc6b6162de8c3c17b1882e8a8e144d9e97a4

Merge branch 'master' into pre

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha a82a344376304619bddbe474700407ce9f514bb4

Update example image

view details

839

commit sha 94caccfe7fad2b0487ad7ee8add2f17cf4bae813

[#3] Merge branch 'master' into v3

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha a82a344376304619bddbe474700407ce9f514bb4

Update example image

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha a658209b71b680f8475b030bed6aa8e5d1054539

Change to minimum information

view details

839

commit sha 2def931933a6a0d226036dd634306b29c0e65ab8

[#3] Merge branch 'master' into v3

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha a658209b71b680f8475b030bed6aa8e5d1054539

Change to minimum information

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 4ae1ce2ff17b6a9304b152f236657fc29de339d1

Change to minimum information

view details

push time in 18 days

push event8398a7/action-slack

push time in 18 days

push event8398a7/action-slack

839

commit sha 638fd02b2f2ab04e2688ae101ddbbdeb4ab7d6cb

wip

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 0733701aebf57c74fd4ff7f883aabb7cae770abf

wip

view details

push time in 18 days

issue comment8398a7/action-slack

Compact format like travis

It doesn't support branch information that action-slack doesn't have, but we've provided it as a basic feature. refs: https://action-slack.netlify.app/usecase/02-custom

If you need branch information, I'm always open to contributions! Thanks for the suggestions and discussion.

8398a7

comment created time in 18 days

created tag8398a7/action-slack

tagv3.4.0

Provides the function of slack notification to GitHub Actions.

created time in 18 days

push event8398a7/action-slack

839

commit sha b016e18753ba8ab85c01a5ee668e8c22b0b47e54

Fixed slack web hook url

view details

839

commit sha c68ef06f0453ff793265b5f723c692e413ba48b7

[#3] Merge branch 'master' into v3

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha b016e18753ba8ab85c01a5ee668e8c22b0b47e54

Fixed slack web hook url

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 66bc99e95d2f441a43d4c47d0c1ed1b97719379d

[#70] Separate the processing for fields

view details

839

commit sha e576ab94d43258f94b3b08e2cd8cefa6731e96c3

[#70] Allowed to get values from environment variables

view details

839

commit sha 08dd888abf37024bc8e7f565059db37d19026acf

[#70] If a field contains all, it takes all values

view details

839

commit sha 40eb203af01066bbba54307c4042898a1caf99b2

[#70] Add custom type integration test

view details

839

commit sha fd0c769355002779e31c15ae814a1189692d9436

[#70] Fixed for eslint

view details

839

commit sha a51e685b8dad8ec06880bb0c37ccca57154d05cc

[#70] Update documents

view details

839

commit sha adbc60639122eaca818f776cbd300ef2c6ba8f15

Merge pull request #83 from 8398a7/issue/70 Issue/70

view details

839

commit sha 9c11c0088ece8446ca44863c544821741e3d4bdb

bump 3.4.0

view details

839

commit sha 3043815234ec1ebbd226cb4c49ce11097dc1947a

[#3] Merge branch 'master' into v3

view details

839

commit sha e184b97e6b725fb7936a5e856bf84aa761d2ff6d

[#3] [command] npm run release

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 9c11c0088ece8446ca44863c544821741e3d4bdb

bump 3.4.0

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 41063c65192d0f33857aedee0ddb615f4edf7a73

bump 3.3.1

view details

839

commit sha 66bc99e95d2f441a43d4c47d0c1ed1b97719379d

[#70] Separate the processing for fields

view details

839

commit sha e576ab94d43258f94b3b08e2cd8cefa6731e96c3

[#70] Allowed to get values from environment variables

view details

839

commit sha 08dd888abf37024bc8e7f565059db37d19026acf

[#70] If a field contains all, it takes all values

view details

839

commit sha 40eb203af01066bbba54307c4042898a1caf99b2

[#70] Add custom type integration test

view details

839

commit sha fd0c769355002779e31c15ae814a1189692d9436

[#70] Fixed for eslint

view details

839

commit sha a51e685b8dad8ec06880bb0c37ccca57154d05cc

[#70] Update documents

view details

839

commit sha adbc60639122eaca818f776cbd300ef2c6ba8f15

Merge pull request #83 from 8398a7/issue/70 Issue/70

view details

839

commit sha de791aefedae69b2487e51e08465a10a01e5f13a

Merge branch 'master' into pre

view details

839

commit sha f275a1bc1e368e20f783e71176c7381adb67b800

[command] npm run release

view details

push time in 18 days

delete branch 8398a7/action-slack

delete branch : issue/70

delete time in 18 days

push event8398a7/action-slack

839

commit sha 66bc99e95d2f441a43d4c47d0c1ed1b97719379d

[#70] Separate the processing for fields

view details

839

commit sha e576ab94d43258f94b3b08e2cd8cefa6731e96c3

[#70] Allowed to get values from environment variables

view details

839

commit sha 08dd888abf37024bc8e7f565059db37d19026acf

[#70] If a field contains all, it takes all values

view details

839

commit sha 40eb203af01066bbba54307c4042898a1caf99b2

[#70] Add custom type integration test

view details

839

commit sha fd0c769355002779e31c15ae814a1189692d9436

[#70] Fixed for eslint

view details

839

commit sha a51e685b8dad8ec06880bb0c37ccca57154d05cc

[#70] Update documents

view details

839

commit sha adbc60639122eaca818f776cbd300ef2c6ba8f15

Merge pull request #83 from 8398a7/issue/70 Issue/70

view details

push time in 18 days

PR merged 8398a7/action-slack

Issue/70

close #70

+514 -274

1 comment

14 changed files

8398a7

pr closed time in 18 days

issue closed8398a7/action-slack

Compact format like travis

Ok, sad, but if you could add the time the job took and the compact (travis like) formatting I would be very happy.

closed time in 18 days

8398a7

PR opened 8398a7/action-slack

Issue/70

close #70

+514 -274

0 comment

14 changed files

pr created time in 18 days

push event8398a7/action-slack

839

commit sha a51e685b8dad8ec06880bb0c37ccca57154d05cc

[#70] Update documents

view details

push time in 18 days

push event8398a7/action-slack

push time in 18 days

create barnch8398a7/action-slack

branch : issue/70

created branch time in 18 days

push event8398a7/action-slack

839

commit sha 65b889d4db131fddea429f985285e9e558c8d82e

wip

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 913b578e53e6c18539104d6dd1be3dbc6539e366

wip

view details

push time in 18 days

push event8398a7/action-slack

839

commit sha 2d7b5a7e3cb577e985a1d6cf86bc56b9c5ec28ca

wip

view details

push time in 18 days

more