profile
viewpoint
Jinseo Park 64json Atlanta, GA https://jasonpark.me/ Owner of @algorithm-visualizer

64json/DuoCoder 212

Duolingo for Coders

64json/64json.github.io 136

:star: Jinseo Park's Website

64json/AlgorithmVisualizer 111

This repository has moved to:

64json/gt-scheduler 46

:calendar: GT Scheduler

64json/CodeHigh 15

CodeHigh is a platform for coders to compete real-time.

64json/Hot-Repos 8

Periodically share links of hot GitHub repositories on FB

64json/candidates-newsfeed 6

제19대 대통령선거 후보자 뉴스피드

64json/personal-sites 6

List of Hackathon Hackers' personal sites.

64json/Automatic-HackDFW-The-Game-Solver 4

Automatic HackDFW The Game Solver

64json/gt-schedule-crawler 4

:robot: GT Schedule Crawler

push eventgoogleinterns/guide-doge

dependabot[bot]

commit sha 77d99e8794fc1f8e122a3c74278a6f717ca6ddc6

Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Jinseo Park

commit sha 7d6a89f0d9accbb35b402ed8c20a1ad2950b6865

Merge pull request #79 from googleinterns/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.2 to 6.5.3

view details

push time in a day

PR merged googleinterns/guide-doge

Reviewers
Bump elliptic from 6.5.2 to 6.5.3 dependencies

Bumps elliptic from 6.5.2 to 6.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li>See full diff in <a href="https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in a day

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 08a6faca68446fcbd0db0d0e6eaba6350181b2ea

Update data.service.ts

view details

Jinseo Park

commit sha eb5a1754e18433d5d99a26f2dc0b04b957ade72d

Merge pull request #76 from googleinterns/fix-configmeta-failure Fix undeterministic test failure

view details

push time in 2 days

PR merged googleinterns/guide-doge

Reviewers
Fix undeterministic test failure

Found out it was caused by one of the tests feeding 'INVALID_DATASET_NAME' as dataset name.

The test has always been throwing an error, but Jasmine ignored the error depending on the randomized order of running tests, which made it undeterministically succeeded.

https://github.com/googleinterns/guide-doge/blob/3a79f33fad0066751b90477b8b0d5fe7ca0d6c34/src/services/data/data.service.spec.ts#L45

+1 -0

2 comments

1 changed file

64json

pr closed time in 2 days

startedgo-gitea/gitea

started time in 2 days

pull request comment64json/gt-scheduler

Updated cookies to only expire after 4 years

Oh geez, thanks for finding that out and fixing it!

vkameswaran

comment created time in 2 days

push event64json/gt-scheduler

vkameswaran

commit sha e0d11f8accaa9d6b158389a135b5eac16490d0a2

Updated cookies to only expire after 4 years

view details

Jinseo Park

commit sha 05578e38abd1a104361e5ed31e162179f94fe52c

Merge pull request #9 from vkameswaran/cookie-fixes Updated cookies to only expire after 4 years

view details

push time in 2 days

PR merged 64json/gt-scheduler

Updated cookies to only expire after 4 years

A recent update caused all cookies (and hence saved schedules) to be cleared when the browser is closed. I have added an explicit validity period to the cookies, which should keep the cookies active for 4 years from the time they are set.

+2 -2

0 comment

2 changed files

vkameswaran

pr closed time in 2 days

startednfischer/shelljs-transpiler

started time in 2 days

startedfelixrieseberg/macintosh.js

started time in 2 days

push eventgoogleinterns/guide-doge

HarrisonPearl

commit sha 1da3da69c17ef64b3fe75d9fc42b4d8340920b04

adds haptic trigers to data entities

view details

HarrisonPearl

commit sha cc3d7b544c04533951620ff17da09afbe3aa24d8

mapped data to objects haptic intensity

view details

HarrisonPearl

commit sha c4e91d1959b5e6673915373cb820af592f3e6dd5

updated testing with color and radius fetching helper functions

view details

HarrisonPearl

commit sha 80d264e665111ea38765bdaf4f31c242136c5118

adds testing for hover event listers triggering color attribute changes

view details

HarrisonPearl

commit sha 4f467210f45f9cc28d16849d233ffc0a2c4f53fc

reformats testing for typescript best practices

view details

HarrisonPearl

commit sha 71ce3c5139b65562660c035e787255edf72dd896

updated data entities' position setup and testing

view details

HarrisonPearl

commit sha 9b9a997c64663634d6651d55fd16d5050af4d4ea

removed use of forEach, style changes

view details

HarrisonPearl

commit sha 0a767d636fe7dbba4245905bbab7a4e52b4e9737

Merge pull request #69 from googleinterns/hapticTriggers adds haptic triggers to data entities, updates testing coverage and style

view details

Jinseo Park

commit sha 9de86f5ba66403d59092683450879dc490f5b97a

Use fs.promises

view details

Jinseo Park

commit sha 96faaf06dabaa9248ceea33d2704acf726a9ccf9

Rename colors defined in ts

view details

Jinseo Park

commit sha 2a21004358ab6a5fd1e2e2c2cfed257cfdccd691

Merge pull request #71 from googleinterns/geo-render-data Render geographic data on map

view details

Jinseo Park

commit sha 98db240f683b8ce0927c17523891e3406e9301d0

Merge branch 'master' into geo-data-table

view details

push time in 4 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 295f180d7709a79bf783cf73d963ea5f566db980

Render country data

view details

Jinseo Park

commit sha 716933c0ff4371c99da5addbdd58577c07d041f4

Merge branch 'geo-zoom-pan' into geo-render-data

view details

Jinseo Park

commit sha 2c959ce07ff6ce49270aea95aad0080775adf66d

Refactor before implementing appending territory of other level than country

view details

Jinseo Park

commit sha 149b0e16a8a497a6e6058e01d3d264adc8f7fe5b

Change script to create hierarchical geo data

view details

Jinseo Park

commit sha 1ddf18e6689a6f30758ab40af3be6af005ca3cd8

Combine topology into world.json

view details

Jinseo Park

commit sha 88252433df732ae4acff7e5cde37ab94a9b269c0

Define types in a separate file

view details

Jinseo Park

commit sha 24c7437d066729c13e51ba54dbf1ce61cf79487b

Separate raw types

view details

Jinseo Park

commit sha d1027f8c69351ed9b3ceec9b7d39a578b8e0819b

Render city, subcontinent, and continent

view details

Jinseo Park

commit sha 8eac2e0916c1316e1410c15dbb78fd538c0899ce

Add comments and minor clean up

view details

Jinseo Park

commit sha 7ce0242a7bf58dcc8c2fe263e18bf4f0af9cefdf

Add tests for geo-map.d3

view details

Jinseo Park

commit sha 3049035445b14e14266a56cd1ebc9e4e0bbef4bb

Use TerritoryLevel as key for the world object

view details

Jinseo Park

commit sha 496fd8bd7744ec102cfd9f8a9fbfabbe32656e19

Update tests

view details

Jinseo Park

commit sha a8514fe912ca3ea627d7bf3c4cc571efc80a0afd

Transform raw world data to flattened mutually-linked hierarchical data

view details

Jinseo Park

commit sha 68eae8ca403f635b8b1ed9f39442d504d322929c

Update tests

view details

Jinseo Park

commit sha f48a4f0bdfa5ca6af26b1690ac51dc396fecb758

Refactoring

view details

Jinseo Park

commit sha 064f0b1364a94f1583049ed919a39cd29bdefc5d

Remove unused stuff

view details

Jinseo Park

commit sha 3fe6ce0576b5d5df589fff68638a55d51e0808ee

Move constant territory ids to mocks.spec

view details

Jinseo Park

commit sha 3a6c677537505b778f0d1aa366c8308a5ed0485c

Create MockGeoMapD3 to access protected values

view details

Jinseo Park

commit sha e40b801fc5aebbacb718a58f698644b554006f6e

Empty commit

view details

Jinseo Park

commit sha 66b98305a75c68ce048e31a6f4def090d62310a7

Merge remote-tracking branch 'origin/master' into geo-render-data

view details

push time in 4 days

PR merged googleinterns/guide-doge

Reviewers
Render geographic data on map
  • Combine topology, country data, and city data into world.json.
  • Flatten the hierarchical territory data and create mutual links between parent and child territories upon loading world.json.
  • Render city/country/subcontinent/continent-level data on the map.
+762 -329

0 comment

22 changed files

64json

pr closed time in 4 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 9de86f5ba66403d59092683450879dc490f5b97a

Use fs.promises

view details

Jinseo Park

commit sha 96faaf06dabaa9248ceea33d2704acf726a9ccf9

Rename colors defined in ts

view details

push time in 4 days

pull request commentgoogleinterns/guide-doge

Fix undeterministic test failure

I guess it is related to the microtask of observable.subscribe, the expect is executed before the subscription microtasks are flushed so it takes the old value of observable. If this is the case, other tests of our services may also have this unintentional success issue.

iirc and debugged it correctly, it never used the old value of observable, and the subscription callback always threw an error.

I think it is because the subscription happens within beforeEach. By the time the subscription callback throws an error, it doesn't propagate back to beforeEach and just gets lost.

64json

comment created time in 4 days

startedleits/MeetingBar

started time in 5 days

PR opened googleinterns/guide-doge

Reviewers
Add tests for geo map / navigation
+285 -22

0 comment

9 changed files

pr created time in 5 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 3010db221eb48c6934f1b728ba075e1de18e9154

Merge remote-tracking branch 'origin/a11y-refactoring' into geo-shortcut

view details

Jinseo Park

commit sha f356b553fe061621dbc9256a39094cc491ea2eeb

Fix test

view details

Jinseo Park

commit sha 3848924b84f1b4a590925ad1deb2b9705d940a38

Merge branch 'geo-shortcut' into geo-map-tests

view details

push time in 5 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha f356b553fe061621dbc9256a39094cc491ea2eeb

Fix test

view details

push time in 5 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha c51a06704650e94d9887ed638fc2231d9663c9a2

added new dataset and vrScatterplot handling

view details

Carlos Villapudua

commit sha 0dc6b968361e9f67452f013c7f85a8b2490e7a0a

change all posit. to y/need to find how check type

view details

cvillapudua

commit sha 9325b42dd4f046c6a5d5b668407de3fb1e29b9d7

changed data pts to be closer to viewer

view details

Carlos Villapudua

commit sha 0f3bf23533ed7cb540511f1914a0d006c525db5d

cleaned up code of print statmts + erased sleep fn

view details

Carlos Villapudua

commit sha ea1a6c2c0249c06572088398fb5a3edd53a893e7

cleaned up code to match suggestions from PR#57

view details

Carlos Villapudua

commit sha eea6022d1706db30b6ef5481f99a78c020baa2a3

Merge branch 'vrDataset' of https://github.com/googleinterns/guide-doge into vrDataset

view details

Carlos Villapudua

commit sha 81ea861368d4c3480c205fc622ea5a9afece0ae6

added time scale function for x of xyz sets

view details

Carlos Villapudua

commit sha 2d5a044bdbfef17993543edb0db72b8a722ffede

Merge master into vrDataset - ascene not loading

view details

Carlos Villapudua

commit sha 08a8f4f48f09fd6588a9e12eb25f2cce636ece65

changed event listener from load to loaded

view details

Carlos Villapudua

commit sha 5d11e236ef907bbc9126424574478ff196865beb

moved print statements inside event listener

view details

Carlos Villapudua

commit sha 195b7c69b9661dd4265bd0810b5500c2177cc564

Revert "added time scale function for x of xyz sets" This reverts commit 81ea861368d4c3480c205fc622ea5a9afece0ae6.

view details

Carlos Villapudua

commit sha 960622870949fbd5a7a27bb76113d91830725856

added newer testing file -not done w/ position tst

view details

Carlos Villapudua

commit sha 688886553da3a593d88f3cd986994fd12abe9601

added camera to a-scene

view details

Carlos Villapudua

commit sha 81315834b22cf3eb82ec3e5a3643a02f1b1f8e17

fixed vrDataset to return 3 measures

view details

Carlos Villapudua

commit sha d11c6b8afdf8aa7403e3c19d23903e0572bf962b

changing legend style on scatterplot meta

view details

Carlos Villapudua

commit sha baa29910010a90c7423467d90dcf822697d6e3b4

fixed tests and added"categories" field to vr data

view details

Carlos Villapudua

commit sha 3d08bd7850554acf922b622909cd32743b0eee24

fixed grid testing errors

view details

cvillapudua

commit sha f94d597164bbb75e1b4219cbcaae70e9395b4ea4

Merge branch 'master' into vrDataset

view details

Carlos Villapudua

commit sha c4fc93d8260f80e27b5b7986122200f2f53d5a1b

merged conflicting files in master and vrDataset

view details

Carlos Villapudua

commit sha 44925d7be1dc34571d717f6e9db47a2d02b9b6f9

renamed files to parallel timeless dimensions

view details

push time in 5 days

create barnchgoogleinterns/guide-doge

branch : geo-map-tests

created branch time in 5 days

PR opened googleinterns/guide-doge

Reviewers
Fix undeterministic test failure

Found out it was caused by one of the tests feeding 'INVALID_DATASET_NAME' as dataset name.

The test has always been throwing an error, but Jasmine ignored the error depending on the randomized order of running tests, which made it undeterministically succeeded.

https://github.com/googleinterns/guide-doge/blob/3a79f33fad0066751b90477b8b0d5fe7ca0d6c34/src/services/data/data.service.spec.ts#L45

+1 -0

0 comment

1 changed file

pr created time in 5 days

create barnchgoogleinterns/guide-doge

branch : fix-configmeta-failure

created branch time in 5 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha c51a06704650e94d9887ed638fc2231d9663c9a2

added new dataset and vrScatterplot handling

view details

Carlos Villapudua

commit sha 0dc6b968361e9f67452f013c7f85a8b2490e7a0a

change all posit. to y/need to find how check type

view details

cvillapudua

commit sha 9325b42dd4f046c6a5d5b668407de3fb1e29b9d7

changed data pts to be closer to viewer

view details

Carlos Villapudua

commit sha 0f3bf23533ed7cb540511f1914a0d006c525db5d

cleaned up code of print statmts + erased sleep fn

view details

Carlos Villapudua

commit sha ea1a6c2c0249c06572088398fb5a3edd53a893e7

cleaned up code to match suggestions from PR#57

view details

Carlos Villapudua

commit sha eea6022d1706db30b6ef5481f99a78c020baa2a3

Merge branch 'vrDataset' of https://github.com/googleinterns/guide-doge into vrDataset

view details

Carlos Villapudua

commit sha 81ea861368d4c3480c205fc622ea5a9afece0ae6

added time scale function for x of xyz sets

view details

Carlos Villapudua

commit sha 2d5a044bdbfef17993543edb0db72b8a722ffede

Merge master into vrDataset - ascene not loading

view details

Carlos Villapudua

commit sha 08a8f4f48f09fd6588a9e12eb25f2cce636ece65

changed event listener from load to loaded

view details

Carlos Villapudua

commit sha 5d11e236ef907bbc9126424574478ff196865beb

moved print statements inside event listener

view details

Carlos Villapudua

commit sha 195b7c69b9661dd4265bd0810b5500c2177cc564

Revert "added time scale function for x of xyz sets" This reverts commit 81ea861368d4c3480c205fc622ea5a9afece0ae6.

view details

Carlos Villapudua

commit sha 960622870949fbd5a7a27bb76113d91830725856

added newer testing file -not done w/ position tst

view details

Carlos Villapudua

commit sha 688886553da3a593d88f3cd986994fd12abe9601

added camera to a-scene

view details

Carlos Villapudua

commit sha 81315834b22cf3eb82ec3e5a3643a02f1b1f8e17

fixed vrDataset to return 3 measures

view details

Carlos Villapudua

commit sha d11c6b8afdf8aa7403e3c19d23903e0572bf962b

changing legend style on scatterplot meta

view details

Carlos Villapudua

commit sha baa29910010a90c7423467d90dcf822697d6e3b4

fixed tests and added"categories" field to vr data

view details

Carlos Villapudua

commit sha 3d08bd7850554acf922b622909cd32743b0eee24

fixed grid testing errors

view details

cvillapudua

commit sha f94d597164bbb75e1b4219cbcaae70e9395b4ea4

Merge branch 'master' into vrDataset

view details

Carlos Villapudua

commit sha c4fc93d8260f80e27b5b7986122200f2f53d5a1b

merged conflicting files in master and vrDataset

view details

Carlos Villapudua

commit sha 44925d7be1dc34571d717f6e9db47a2d02b9b6f9

renamed files to parallel timeless dimensions

view details

push time in 5 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha c51a06704650e94d9887ed638fc2231d9663c9a2

added new dataset and vrScatterplot handling

view details

Carlos Villapudua

commit sha 0dc6b968361e9f67452f013c7f85a8b2490e7a0a

change all posit. to y/need to find how check type

view details

cvillapudua

commit sha 9325b42dd4f046c6a5d5b668407de3fb1e29b9d7

changed data pts to be closer to viewer

view details

Carlos Villapudua

commit sha 0f3bf23533ed7cb540511f1914a0d006c525db5d

cleaned up code of print statmts + erased sleep fn

view details

Carlos Villapudua

commit sha ea1a6c2c0249c06572088398fb5a3edd53a893e7

cleaned up code to match suggestions from PR#57

view details

Carlos Villapudua

commit sha eea6022d1706db30b6ef5481f99a78c020baa2a3

Merge branch 'vrDataset' of https://github.com/googleinterns/guide-doge into vrDataset

view details

Carlos Villapudua

commit sha 81ea861368d4c3480c205fc622ea5a9afece0ae6

added time scale function for x of xyz sets

view details

Carlos Villapudua

commit sha 2d5a044bdbfef17993543edb0db72b8a722ffede

Merge master into vrDataset - ascene not loading

view details

Carlos Villapudua

commit sha 08a8f4f48f09fd6588a9e12eb25f2cce636ece65

changed event listener from load to loaded

view details

Carlos Villapudua

commit sha 5d11e236ef907bbc9126424574478ff196865beb

moved print statements inside event listener

view details

Carlos Villapudua

commit sha 195b7c69b9661dd4265bd0810b5500c2177cc564

Revert "added time scale function for x of xyz sets" This reverts commit 81ea861368d4c3480c205fc622ea5a9afece0ae6.

view details

Carlos Villapudua

commit sha 960622870949fbd5a7a27bb76113d91830725856

added newer testing file -not done w/ position tst

view details

Carlos Villapudua

commit sha 688886553da3a593d88f3cd986994fd12abe9601

added camera to a-scene

view details

Carlos Villapudua

commit sha 81315834b22cf3eb82ec3e5a3643a02f1b1f8e17

fixed vrDataset to return 3 measures

view details

Carlos Villapudua

commit sha d11c6b8afdf8aa7403e3c19d23903e0572bf962b

changing legend style on scatterplot meta

view details

Carlos Villapudua

commit sha baa29910010a90c7423467d90dcf822697d6e3b4

fixed tests and added"categories" field to vr data

view details

Carlos Villapudua

commit sha 3d08bd7850554acf922b622909cd32743b0eee24

fixed grid testing errors

view details

cvillapudua

commit sha f94d597164bbb75e1b4219cbcaae70e9395b4ea4

Merge branch 'master' into vrDataset

view details

Carlos Villapudua

commit sha c4fc93d8260f80e27b5b7986122200f2f53d5a1b

merged conflicting files in master and vrDataset

view details

Carlos Villapudua

commit sha 44925d7be1dc34571d717f6e9db47a2d02b9b6f9

renamed files to parallel timeless dimensions

view details

push time in 5 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha c51a06704650e94d9887ed638fc2231d9663c9a2

added new dataset and vrScatterplot handling

view details

Carlos Villapudua

commit sha 0dc6b968361e9f67452f013c7f85a8b2490e7a0a

change all posit. to y/need to find how check type

view details

cvillapudua

commit sha 9325b42dd4f046c6a5d5b668407de3fb1e29b9d7

changed data pts to be closer to viewer

view details

Carlos Villapudua

commit sha 0f3bf23533ed7cb540511f1914a0d006c525db5d

cleaned up code of print statmts + erased sleep fn

view details

Carlos Villapudua

commit sha ea1a6c2c0249c06572088398fb5a3edd53a893e7

cleaned up code to match suggestions from PR#57

view details

Carlos Villapudua

commit sha eea6022d1706db30b6ef5481f99a78c020baa2a3

Merge branch 'vrDataset' of https://github.com/googleinterns/guide-doge into vrDataset

view details

Carlos Villapudua

commit sha 81ea861368d4c3480c205fc622ea5a9afece0ae6

added time scale function for x of xyz sets

view details

Carlos Villapudua

commit sha 2d5a044bdbfef17993543edb0db72b8a722ffede

Merge master into vrDataset - ascene not loading

view details

Carlos Villapudua

commit sha 08a8f4f48f09fd6588a9e12eb25f2cce636ece65

changed event listener from load to loaded

view details

Carlos Villapudua

commit sha 5d11e236ef907bbc9126424574478ff196865beb

moved print statements inside event listener

view details

Carlos Villapudua

commit sha 195b7c69b9661dd4265bd0810b5500c2177cc564

Revert "added time scale function for x of xyz sets" This reverts commit 81ea861368d4c3480c205fc622ea5a9afece0ae6.

view details

Carlos Villapudua

commit sha 960622870949fbd5a7a27bb76113d91830725856

added newer testing file -not done w/ position tst

view details

Carlos Villapudua

commit sha 688886553da3a593d88f3cd986994fd12abe9601

added camera to a-scene

view details

Carlos Villapudua

commit sha 81315834b22cf3eb82ec3e5a3643a02f1b1f8e17

fixed vrDataset to return 3 measures

view details

Carlos Villapudua

commit sha d11c6b8afdf8aa7403e3c19d23903e0572bf962b

changing legend style on scatterplot meta

view details

Carlos Villapudua

commit sha baa29910010a90c7423467d90dcf822697d6e3b4

fixed tests and added"categories" field to vr data

view details

Carlos Villapudua

commit sha 3d08bd7850554acf922b622909cd32743b0eee24

fixed grid testing errors

view details

cvillapudua

commit sha f94d597164bbb75e1b4219cbcaae70e9395b4ea4

Merge branch 'master' into vrDataset

view details

Carlos Villapudua

commit sha c4fc93d8260f80e27b5b7986122200f2f53d5a1b

merged conflicting files in master and vrDataset

view details

Carlos Villapudua

commit sha 44925d7be1dc34571d717f6e9db47a2d02b9b6f9

renamed files to parallel timeless dimensions

view details

push time in 5 days

startedkongmunist/asciiZOOM

started time in 6 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 7cb0012733b6efb07e6c3b0ab3f341ac259da965

Fix a bug in break silence

view details

Jinseo Park

commit sha 927ab4e782a9d82a2f5b2a6e115d640e5570c799

Read out active datum/measure

view details

push time in 6 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 0c19cccb4313fcec6d46d638acc54489e65452d0

Replace punctuations with plain text for screen reader

view details

Jinseo Park

commit sha cff77e21d6175886e2bf73e5ca7dc02d08a72e2f

Change default silence duration

view details

Jinseo Park

commit sha 23120d8c19252fe19a5fab2d25ae7979c25d94ed

Add ranking column

view details

push time in 6 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha f1a681e352c1469bfa01dc465b057d87ddce309c

Rewrite in switch/case

view details

Jinseo Park

commit sha 64f665268c1dacdf79309a91cc3599d3ebc10a6b

Suggest users to press '?' after silence

view details

push time in 6 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha c3feb6e17f3edd012fc3ae0ace89c03975ff9575

Implement navigating shortcuts

view details

push time in 6 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 87e2ffb7b09bc494fe265be0576ae498d9c289f1

Simplify paths in importers

view details

push time in 7 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 78d533ac7a32a13bcac8ce50150b16d34a61e345

Minor fixes

view details

push time in 7 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 14d6662a06a49301abdd20e963d75e98fab95533

Create a unified a11y directive and let metas provide a11y component importers

view details

Jinseo Park

commit sha 2ba78870e2c338b31aa56a2c9db4492829ccc048

Fix tests

view details

Jinseo Park

commit sha 9a255c8fa1f63e6bbd87510a27df211d79f2f501

Change a11y.directive test description

view details

Jinseo Park

commit sha e87da1920df1ade124b3fe781cfdc1663c22acc9

Merge branch 'a11y-refactoring' into geo-shortcut

view details

push time in 7 days

PR opened googleinterns/guide-doge

Reviewers
A11y refactoring
  • Create a unified a11y directive.
  • Let metas provide which a11y components to attach.
+184 -404

0 comment

21 changed files

pr created time in 7 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 9a255c8fa1f63e6bbd87510a27df211d79f2f501

Change a11y.directive test description

view details

push time in 7 days

create barnchgoogleinterns/guide-doge

branch : a11y-refactoring

created branch time in 7 days

create barnchgoogleinterns/guide-doge

branch : geo-shortcut

created branch time in 8 days

push event64json/gt-scheduler

Jinseo Park

commit sha 3b4c50d134f358ee5ea254c967d3bced87b792c7

Associate studio section with lecture section and add disclaimer

view details

push time in 8 days

push event64json/gt-scheduler

Jinseo Park

commit sha 5a8bfdbb1fb8421174b9cfd6550d4eaf483522bd

Support multiple course filters

view details

push time in 8 days

push event64json/gt-scheduler

Jinseo Park

commit sha 09d14d1ceda4bf02ffec920a24ad26a4321ef663

Clean up

view details

push time in 8 days

push event64json/gt-scheduler

Jinseo Park

commit sha 8f7e718c7b67af19bc541a97173f47c801437a8f

Rename jsx to js

view details

push time in 8 days

push event64json/gt-scheduler

Jinseo Park

commit sha 6dc7e6952ba434034682dde3c4e7477ebd799278

Rewrite using hooks

view details

push time in 8 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha 95529bcffcb6bf3a2a663adaafc8d25907641ba4

Merge branch 'multiple-datasets-support' of https://github.com/googleinterns/guide-doge into multiple-datasets-support creating local m-d-s branch

view details

Carlos Villapudua

commit sha d5c8b9629746d8bf3f798cbcec815d3813c94aca

adding data and queryOptions

view details

Carlos Villapudua

commit sha 7405a508aa31aef28661b78467b6987c8b0a9629

adding ascene

view details

Chunnien Chan

commit sha ada92c1508b7206e79951f8f19f92345c2e8e6b8

Add UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha a2a6b3c9e77d6cbdd9f89ef734b807e4a7f47e68

Rename summarization preference

view details

Chunnien Chan

commit sha 838296e7e53dfdc40b3eab7f53a47b13a55f1efa

(WIP) Add summarization directive and component

view details

Jinseo Park

commit sha e49060cbf33dc5de955668c17d910789dc93ce64

Fix adding multiple a11y components

view details

Carlos Villapudua

commit sha 8f6ff0e699db52c2db3170784a6386721856867e

Merge branch 'multiple-datasets-support' of https://github.com/googleinterns/guide-doge into multiple-datasets-support taking new changes

view details

Carlos Villapudua

commit sha 20635568d0afe6f61d3b32704be190b8fe71ca13

got webVR to recognize data in scatterplot comp but need to assign meta outside of file

view details

Carlos Villapudua

commit sha d9ec9171a66b3673cca2f7103e02df54b1a4edab

Merge branch 'webVRAddData' of https://github.com/googleinterns/guide-doge into webVRAddData

view details

Chunnien Chan

commit sha ec84598934cb93a3ed472661a0e72c357998c8f4

Add summarization directive and component

view details

Chunnien Chan

commit sha e13d35ca585cbf6c90b9cb7e89edf5336501c172

Add visit count protoform summarization to UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha 8c329d2dabc62d92d6706990d4cb094e03466fc7

Show summaries in the order of validity

view details

Chunnien Chan

commit sha eca2eda8a605a20c3ffb24b3fc5e6d1feccad3af

Fix summarization component not reflect preference

view details

Chunnien Chan

commit sha bb595568e3e8f236da5c6638cef56a86cf864932

Capitalize summaries

view details

Chunnien Chan

commit sha 6d57cd6f032bd9032f79ae6779be10f630aabfee

Modify default config value of UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha f62ff1411c5a25a81b380ba52d0f60d54627d086

(WIP) Add UserWorkdayHolidayExpDataset

view details

Carlos Villapudua

commit sha 59b736baaeeb5d2200efad7173803a7061654450

generate data from component - need access frm qry

view details

Carlos Villapudua

commit sha 931810941300d5bf8e82d22ba6537a03118cc11d

scatter comp. accesses data thru meta - stillneed to fix d3 scat testing

view details

Carlos Villapudua

commit sha 8ee9993b5f8fa5884f96eafaff5cf364fc06cb6e

merging master and webVRadddata

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha 95529bcffcb6bf3a2a663adaafc8d25907641ba4

Merge branch 'multiple-datasets-support' of https://github.com/googleinterns/guide-doge into multiple-datasets-support creating local m-d-s branch

view details

Carlos Villapudua

commit sha d5c8b9629746d8bf3f798cbcec815d3813c94aca

adding data and queryOptions

view details

Carlos Villapudua

commit sha 7405a508aa31aef28661b78467b6987c8b0a9629

adding ascene

view details

Chunnien Chan

commit sha ada92c1508b7206e79951f8f19f92345c2e8e6b8

Add UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha a2a6b3c9e77d6cbdd9f89ef734b807e4a7f47e68

Rename summarization preference

view details

Chunnien Chan

commit sha 838296e7e53dfdc40b3eab7f53a47b13a55f1efa

(WIP) Add summarization directive and component

view details

Jinseo Park

commit sha e49060cbf33dc5de955668c17d910789dc93ce64

Fix adding multiple a11y components

view details

Carlos Villapudua

commit sha 8f6ff0e699db52c2db3170784a6386721856867e

Merge branch 'multiple-datasets-support' of https://github.com/googleinterns/guide-doge into multiple-datasets-support taking new changes

view details

Carlos Villapudua

commit sha 20635568d0afe6f61d3b32704be190b8fe71ca13

got webVR to recognize data in scatterplot comp but need to assign meta outside of file

view details

Carlos Villapudua

commit sha d9ec9171a66b3673cca2f7103e02df54b1a4edab

Merge branch 'webVRAddData' of https://github.com/googleinterns/guide-doge into webVRAddData

view details

Chunnien Chan

commit sha ec84598934cb93a3ed472661a0e72c357998c8f4

Add summarization directive and component

view details

Chunnien Chan

commit sha e13d35ca585cbf6c90b9cb7e89edf5336501c172

Add visit count protoform summarization to UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha 8c329d2dabc62d92d6706990d4cb094e03466fc7

Show summaries in the order of validity

view details

Chunnien Chan

commit sha eca2eda8a605a20c3ffb24b3fc5e6d1feccad3af

Fix summarization component not reflect preference

view details

Chunnien Chan

commit sha bb595568e3e8f236da5c6638cef56a86cf864932

Capitalize summaries

view details

Chunnien Chan

commit sha 6d57cd6f032bd9032f79ae6779be10f630aabfee

Modify default config value of UserWorkdayHolidayDataset

view details

Chunnien Chan

commit sha f62ff1411c5a25a81b380ba52d0f60d54627d086

(WIP) Add UserWorkdayHolidayExpDataset

view details

Carlos Villapudua

commit sha 59b736baaeeb5d2200efad7173803a7061654450

generate data from component - need access frm qry

view details

Carlos Villapudua

commit sha 931810941300d5bf8e82d22ba6537a03118cc11d

scatter comp. accesses data thru meta - stillneed to fix d3 scat testing

view details

Carlos Villapudua

commit sha 8ee9993b5f8fa5884f96eafaff5cf364fc06cb6e

merging master and webVRadddata

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha e40b801fc5aebbacb718a58f698644b554006f6e

Empty commit

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha cb2e919e7137b6ccebed60a6df97e3e0577e272b

Disable double click to zoom

view details

Jinseo Park

commit sha ce90715568ab6e5047c29795ec42c75c4d9bc76e

Fix scale functions

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 32cc7bab584c69cc458d96b8825903dbfac72eab

Adjust unit when searching

view details

Jinseo Park

commit sha 8e0468d7017d7441816966cb9ba530f75fc3ee2c

Filter out data with no activeUsers

view details

Jinseo Park

commit sha 8b8c7d7e0669a7a45bb4ba75c8bb05f576607594

Adjust unit when changing territory filter

view details

Jinseo Park

commit sha 974e2c54a88085538a9d9b1728a1f41c6d21fc17

Animate changing viewport

view details

Jinseo Park

commit sha bf21018b41f1e37eba3945ebc008e96c0da4dfaa

Click territory to enter

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha f48a4f0bdfa5ca6af26b1690ac51dc396fecb758

Refactoring

view details

Jinseo Park

commit sha 064f0b1364a94f1583049ed919a39cd29bdefc5d

Remove unused stuff

view details

Jinseo Park

commit sha 3fe6ce0576b5d5df589fff68638a55d51e0808ee

Move constant territory ids to mocks.spec

view details

Jinseo Park

commit sha 3a6c677537505b778f0d1aa366c8308a5ed0485c

Create MockGeoMapD3 to access protected values

view details

Jinseo Park

commit sha d73116f5fa6479cc3ac7e54bd8658c7ad088664a

Merge branch 'geo-render-data' into geo-data-table

view details

Jinseo Park

commit sha e3cdafae80eac28d709eccae05d69ae2ac000079

Fix broken tests

view details

push time in 9 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 3fe6ce0576b5d5df589fff68638a55d51e0808ee

Move constant territory ids to mocks.spec

view details

Jinseo Park

commit sha 3a6c677537505b778f0d1aa366c8308a5ed0485c

Create MockGeoMapD3 to access protected values

view details

push time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 064f0b1364a94f1583049ed919a39cd29bdefc5d

Remove unused stuff

view details

push time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha f48a4f0bdfa5ca6af26b1690ac51dc396fecb758

Refactoring

view details

push time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 8c3e2020ef0a07154eed3eb61dbfb62a36af2454

Implement zooming and panning

view details

Jinseo Park

commit sha 78207e16f23a153ed9c18a820a307bb4d251f051

Merge remote-tracking branch 'origin/geo-data' into geo-zoom-pan

view details

Jinseo Park

commit sha 2522a9b0d9732f0a1df27895f7d2259637245049

Add tests for geo-map.d3

view details

Jinseo Park

commit sha 4e0b9589abcf135779a830cd712a45f485307415

Merge pull request #70 from googleinterns/geo-zoom-pan Implement zooming and panning on map

view details

push time in 10 days

PR merged googleinterns/guide-doge

Reviewers
Implement zooming and panning on map

Tests will be written in a separate PR once GeoMapD3 is completed.

+245 -32

0 comment

7 changed files

64json

pr closed time in 10 days

Pull request review commentgoogleinterns/guide-doge

Implement zooming and panning on map

+import { ElementRef } from '@angular/core';+import { Subject } from 'rxjs';+import { GeoMapD3, RenderOptions } from './geo-map.d3';+import { GeoDatum } from '../datasets/queries/geo.query';++describe('GeoMapD3', () => {+  let containerElement: HTMLElement;+  let svgElement: HTMLElement;+  let renderOptions: RenderOptions;+  let geoMapD3: GeoMapD3;++  beforeEach(() => {+    svgElement = document.createElement('svg');+    containerElement = document.createElement('div');+    containerElement.appendChild(svgElement);+    renderOptions = {+      elementRef: new ElementRef<HTMLElement>(containerElement),+      width: 256,+      height: 256,+      topoJsonUrl: 'https://cdn.jsdelivr.net/npm/world-atlas@2/countries-110m.json',+      data$: new Subject<GeoDatum[]>(),+    };+    geoMapD3 = new GeoMapD3(renderOptions);+  });++  afterEach(() => {+    geoMapD3.clear();+  });++  it('should instantiate.', () => {+    expect(geoMapD3).toBeInstanceOf(GeoMapD3);+  });++  it('should render the map.', async () => {+    await geoMapD3.render();++    const landElement = svgElement.querySelector('.geo_map-land');+    const boundaryElement = svgElement.querySelector('.geo_map-boundary');++    expect(landElement).toBeTruthy();+    expect(boundaryElement).toBeTruthy();+  });++  it('should rerender the map on zooming.', async () => {+    await geoMapD3.render();++    const landElement = svgElement.querySelector('.geo_map-land')!;+    const dAttribute = landElement.getAttribute('d');++    // TODO: better way?+    // tslint:disable-next-line:no-string-literal+    geoMapD3['zoom'].scaleTo(geoMapD3['svg'], 100);

I'll fix this in #71 as well.

64json

comment created time in 10 days

PR merged googleinterns/guide-doge

Reviewers
Implement geo query and dataset
  • Implement geo query.
  • Implement geo dataset.
  • Add tests for both.
+348 -44

0 comment

12 changed files

64json

pr closed time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 9446bdf3241b2d1d7b64e07c4ee0b040ae9f3b81

wip

view details

Jinseo Park

commit sha 6bc030842d6d04d348fd0616f37864a9543fd829

Merge branch 'city-data' into geo-data

view details

Jinseo Park

commit sha d9bfd42833401feddc126c903258cb3c576d0b3e

Implement geo dataset and query, and add tests for them

view details

Jinseo Park

commit sha de0a6ea98698e659733b9f5972865fc940202eee

Add comment to createGeoQuery

view details

Jinseo Park

commit sha 1365fef4a41c6b75c77664fc84bfc61c907edc96

Merge remote-tracking branch 'origin/master' into geo-data

view details

Jinseo Park

commit sha 68683c5b047454cc180db10698c3b90d702f9f2b

Merge pull request #65 from googleinterns/geo-data Implement geo query and dataset

view details

push time in 10 days

Pull request review commentgoogleinterns/guide-doge

Implement geo query and dataset

+import { generateCube } from '../../models/data-cube/generation';+import { cities, continentNames, countryNames, subcontinentNames } from '../../assets/cities.json';+import { Category } from '../../models/data-cube/types';+import { activeUserMeasure, eventCountMeasure, revenueMeasure } from '../../models/data-cube/presets';+import { createGeoQuery, GeoQuery, TerritoryLevel } from './geo.query';+import { DAY } from '../../utils/timeUnits';++describe('GeoQuery', () => {+  let geoQuery: GeoQuery;+  const endDate = new Date();+  const startDate = new Date(endDate.getTime() - 30 * DAY);++  beforeEach(async () => {+    const cityCategory: Category = {+      name: 'city',+      values: Object.entries(cities).map(([cityId, city]) => ({+        name: cityId,+        weight: city.population,+      })),+    };+    const categories = [cityCategory];+    const measures = [activeUserMeasure, revenueMeasure, eventCountMeasure];+    const dataCube = generateCube(categories, measures);+    const measureNames = measures.map(measure => measure.name);+    geoQuery = createGeoQuery(dataCube, measureNames, cities);+  });++  describe('should query geo data in the following unit:', () => {+    it('City', () => {+      const geoData = geoQuery({+        range: [startDate, endDate],+        unit: TerritoryLevel.CITY,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => geoDatum.id in cities)).toBeTrue();+    });++    it('Country', () => {+      const geoData = geoQuery({+        range: [startDate, endDate],+        unit: TerritoryLevel.COUNTRY,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => geoDatum.id in countryNames)).toBeTrue();+    });++    it('Subcontinent', () => {+      const geoData = geoQuery({+        range: [startDate, endDate],+        unit: TerritoryLevel.SUBCONTINENT,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => geoDatum.id in subcontinentNames)).toBeTrue();+    });++    it('Continent', () => {+      const geoData = geoQuery({+        range: [startDate, endDate],+        unit: TerritoryLevel.CONTINENT,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => geoDatum.id in continentNames)).toBeTrue();+    });+  });++  describe('should filter with the following territory:', () => {+    it('Atlanta (City)', () => {+      const atlantaCityId = '1840013660';+      const geoData = geoQuery({+        range: [startDate, endDate],+        territory: {+          level: TerritoryLevel.CITY,+          id: atlantaCityId,+        },+        unit: TerritoryLevel.CITY,+      });+      expect(geoData[0].id).toBe(atlantaCityId);+    });++    it('South Korea (Country)', () => {+      const southKoreaCountryId = '410';+      const geoData = geoQuery({+        range: [startDate, endDate],+        territory: {+          level: TerritoryLevel.COUNTRY,+          id: southKoreaCountryId,+        },+        unit: TerritoryLevel.CITY,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => cities[geoDatum.id].countryId === southKoreaCountryId)).toBeTrue();+    });++    it('Eastern Europe (Subcontinent)', () => {+      const easternEuropeSubcontinentId = '151';+      const geoData = geoQuery({+        range: [startDate, endDate],+        territory: {+          level: TerritoryLevel.SUBCONTINENT,+          id: easternEuropeSubcontinentId,+        },+        unit: TerritoryLevel.CITY,+      });+      expect(geoData.length > 0).toBeTrue();+      expect(geoData.every(geoDatum => cities[geoDatum.id].subcontinentId === easternEuropeSubcontinentId)).toBeTrue();+    });++    it('Oceania (Continent)', () => {+      const oceaniaContinentId = '009';

I'll reflect these changes in #71 to avoid merge conflicts.

64json

comment created time in 10 days

Pull request review commentgoogleinterns/guide-doge

Implement geo query and dataset

 export function inOneOfDateRanges(dateRanges: [Date, Date][], rangeOptions: Rang       });   }; }++export function inCities(cityIds: string[]): Filter {+  return (categories: Category[]) => {+    const cityIndex = categories.findIndex(+      category => category.name === 'city',+    );+    return (row: Row) => {+      const cityId = row.header[cityIndex] as string;

DataCube is designed to have string | number as a header, but city header is always string.

64json

comment created time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 302d002a0f630cd8bad7fe9fb539213d8d1e58c2

Calculate opaque color instead of using opacity to improve rendering performance

view details

Jinseo Park

commit sha 092dd60576a1718f5e01674dc8829a0bdf78575a

Fit territory in the center of viewport

view details

push time in 10 days

Pull request review commentgoogleinterns/guide-doge

Implement geo query and dataset

+import { betweenDates, inCities } from '../../models/data-cube/filters';+import { DataCube } from '../../models/data-cube/data-cube.model';+import { Filter, MeasureValues } from '../../models/data-cube/types';++export enum TerritoryLevel {+  CONTINENT,+  SUBCONTINENT,+  COUNTRY,+  CITY,+}++export interface Territory {+  level: TerritoryLevel;+  id: string;+}++export interface GeoQueryOptions {+  /** The date range to filter geo data with. */+  range: [Date, Date];+  /** The territory to filter geo data with. */+  territory?: Territory;+  /** The territory level of each geo datum. */+  unit: TerritoryLevel;+}++export interface GeoDatum {+  id: string;+  values: MeasureValues;+}++export type GeoQuery = (options: GeoQueryOptions) => GeoDatum[];++export interface City {+  countryId: string;+  subcontinentId: string;+  continentId: string;+  name: string;+  lat: number;+  lng: number;+  population: number;+}++/**+ * Create a geo query function. The query function takes GeoQueryOptions and returns an array of GeoDatum.+ *+ * @param dataCube The data cube to query the raw rows from.+ * @param measureNames The measures to query.+ * @param cities The mapping from city id to city object.+ */+export function createGeoQuery<S>(+  dataCube: DataCube,+  measureNames: string[],+  cities: Record<string, City>,+): GeoQuery {+  return queryOptions => {+    const [startDate, endDate] = queryOptions.range;++    const cityCategoryName = 'city';+    const dateCategoryName = 'date';++    const dateFilter = betweenDates(startDate, endDate, { excludeStart: true });+    const cityFilter = queryOptions.territory && inCities(getCityIds(cities, queryOptions.territory));++    const rows = dataCube.getDataFor({+      categoryNames: [cityCategoryName],+      measureNames,+      filters: [dateFilter, cityFilter].filter((filter): filter is Filter => filter !== undefined),+      sortBy: [dateCategoryName],+    });++    // merge rows to the given unit (e.g., merge city rows to country rows)+    const rowGroups: Record<string, MeasureValues> = {};

Map.get returns T | undefined, which requires me to have non-undefined assertion every time while it is actually never undefined in the above case.

64json

comment created time in 10 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 0b4fc089f5d1be78ce04920a851dde9716073141

Implement hierarchical navigating features

view details

Jinseo Park

commit sha d5ed882828b127a40d27867ca5597ca1d942a970

Only show subordinate units

view details

Jinseo Park

commit sha 15111bc0032a5906a50c631db203022f78c7e5c9

Enter the only territory in table when clicked

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha a8514fe912ca3ea627d7bf3c4cc571efc80a0afd

Transform raw world data to flattened mutually-linked hierarchical data

view details

Jinseo Park

commit sha 68eae8ca403f635b8b1ed9f39442d504d322929c

Update tests

view details

Jinseo Park

commit sha bdb49dbae906deffdd56f188fc6034f014d47c59

Merge branch 'geo-render-data' into geo-data-table

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha a8514fe912ca3ea627d7bf3c4cc571efc80a0afd

Transform raw world data to flattened mutually-linked hierarchical data

view details

Jinseo Park

commit sha 68eae8ca403f635b8b1ed9f39442d504d322929c

Update tests

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 63f786c86d3b7df0554e562ac12fe7cf0cadae50

Fix minor stuff

view details

Jinseo Park

commit sha 14ac99bf38be9707d1c3d9d2a29281896df90241

Move TerritoryLevel to under geo.types

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha a4cb8bef9e2140c22511aa507dc78fa7547b1dc3

Transform to flattened mutually-linked hierarchical world data

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 3049035445b14e14266a56cd1ebc9e4e0bbef4bb

Use TerritoryLevel as key for the world object

view details

Jinseo Park

commit sha 496fd8bd7744ec102cfd9f8a9fbfabbe32656e19

Update tests

view details

Jinseo Park

commit sha c084487930797a76f4adf3b9f19df9160d893732

Merge branch 'geo-render-data' into geo-data-table

view details

push time in 11 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 3049035445b14e14266a56cd1ebc9e4e0bbef4bb

Use TerritoryLevel as key for the world object

view details

Jinseo Park

commit sha 496fd8bd7744ec102cfd9f8a9fbfabbe32656e19

Update tests

view details

push time in 11 days

create barnchgoogleinterns/guide-doge

branch : geo-data-table

created branch time in 11 days

startedRomakita/tsed-issue-882

started time in 12 days

startedwip/app

started time in 12 days

startedhill/recursive-github-profile

started time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 7ce0242a7bf58dcc8c2fe263e18bf4f0af9cefdf

Add tests for geo-map.d3

view details

push time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 8eac2e0916c1316e1410c15dbb78fd538c0899ce

Add comments and minor clean up

view details

push time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha d1027f8c69351ed9b3ceec9b7d39a578b8e0819b

Render city, subcontinent, and continent

view details

push time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 24c7437d066729c13e51ba54dbf1ce61cf79487b

Separate raw types

view details

push time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 88252433df732ae4acff7e5cde37ab94a9b269c0

Define types in a separate file

view details

push time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 149b0e16a8a497a6e6058e01d3d264adc8f7fe5b

Change script to create hierarchical geo data

view details

Jinseo Park

commit sha 1ddf18e6689a6f30758ab40af3be6af005ca3cd8

Combine topology into world.json

view details

push time in 12 days

startedgood-bull-schedules/Good-Bull-Schedules

started time in 12 days

startedSaltyQuetzals/TAMU-Howdy-Data

started time in 12 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 2c959ce07ff6ce49270aea95aad0080775adf66d

Refactor before implementing appending territory of other level than country

view details

push time in 13 days

pull request commentjunhoyeo/github-rank-in-dimigo

[WIP] Migrate to actions with TypeScript, MongoDB

Great project and great idea to migrate to GitHub Actions! I have several idea suggestions:

  1. [Migrate storage to MongoDB]: How do you think of uploading the crawled data to GitHub Pages instead of MongoDB? In that way, there's no need to set up a backend server at all, and everything runs on GitHub. (I'm currently using this way for one of my project, and it seems pretty solid.)
  2. [Provide API for requesting new user to be in allowlist]: I think it would be great if you place ALLOWLIST file in the root that contains a username in each line. Then people can easily create a PR by editing the file on GitHub. I believe this way will bring a good amount of stars on this repo!
junhoyeo

comment created time in 13 days

startedAngelhack-LIBI/team-libi-frontend-sai

started time in 13 days

startedAngelhack-LIBI/team-libi-backend

started time in 13 days

startedangelhack-seoul-2020-specialty/back-end

started time in 13 days

startedsindresorhus/css-in-readme-like-wat

started time in 13 days

startedglorious-codes/glorious-demo

started time in 13 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha 1f34beb4540c2baa84e461c0f00ab9ee7167247c

new changes

view details

Carlos Villapudua

commit sha 3275c7a6f4accd7e11fdfae3ca62d633e5abe7c7

package-lock change

view details

Carlos Villapudua

commit sha 2c893e5431804da263a233f1da44d95a3ac160c9

added createGridPlanes

view details

Carlos Villapudua

commit sha 948ff5097390b040b39b2a578045ee957fd972a1

got rid of import aframe in polyfill.ts and moved to vr comp

view details

HarrisonPearl

commit sha f612c762d1f4cb98faab8427dfbe69f1e2a2f008

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha 3247b9c66f407f4d1f1a839c8ef5a65137ec8cc1

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha d9d30998a8f00cc1a63283f5cc4a37567af442e3

added https flag to ng serve, updated a-frame embedded scene style

view details

HarrisonPearl

commit sha 77fe3939c334aaec6323a5de2d7ef1a2fbda69ad

added super-hands and aframe-extas dependencies. Set up controller tracking and object interactions

view details

Carlos Villapudua

commit sha a98ecf99bf076d97d9bb5bf8c6fe00a937885bb5

added tests for sky/grid presence

view details

HarrisonPearl

commit sha 52815bc10070cba51028e5eec4c2bdf0ba537364

added d3 functions to set up event listeners for hover state changes on data objects

view details

HarrisonPearl

commit sha 58a74389a4b0dc248b12474d95656d0a7bd08e6e

added controller haptic dependencies and triggers

view details

HarrisonPearl

commit sha 5a3dce3f9b9d5301277a6e8717eff3f309e82e4e

seperated d3 code for scatterplots and haptic plots. Reverted scatterplot.d3 to latest version on branch accessibilityVR

view details

HarrisonPearl

commit sha e78e0d5354f6ae37cc74fff7657eecb4b84cd62c

testing updated, function descriptions added, code clean up

view details

Carlos Villapudua

commit sha db778e7f243ef764bc2f4c5e0bcabb6adee212ea

Merge branch 'master' into addingPlanesVR merging master with addingPlanesVR

view details

Carlos Villapudua

commit sha 682a66d645f1a9418787c3670c17b182275023aa

fixed testing for sky and grid elements

view details

cvillapudua

commit sha ca3cfd24de5cfa1b0b2a1f1dfc1f1766d5b96f0b

Merge pull request #50 from googleinterns/addingPlanesVR Adding planes to webVR scene

view details

HarrisonPearl

commit sha 730064b8fcb0eff0f16b3b7eb7a75a812ea0e70d

responding to pr 59 comments. Condensed d3 set up functions, switched to css selection, style changes

view details

dependabot[bot]

commit sha 0797fa453f94b7f59f2873d20029f477d5506763

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

HarrisonPearl

commit sha 012a1405aa9214e32bc164fb82a819df19559f69

moved event listener setup logic into helper modifyColorOnStateChange

view details

HarrisonPearl

commit sha 61b6545b7718707edf5e443d185817640c9dd711

linting fixes (whitespace removal, simplifications)

view details

push time in 13 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 2522a9b0d9732f0a1df27895f7d2259637245049

Add tests for geo-map.d3

view details

push time in 13 days

Pull request review commentgoogleinterns/guide-doge

Render a world map

+import { Component, ElementRef, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';+import { GeoMapD3, RenderOptions } from '../../d3/geo-map.d3';+import { A11yPlaceholderDirective } from '../../directives/a11y-placeholder/a11y-placeholder.directive';+import { GeoMapMeta } from '../../datasets/metas/geo-map.meta';++@Component({+  selector: 'app-geo-map',+  templateUrl: './geo-map.component.html',+  styleUrls: ['./geo-map.component.scss'],+})+export class GeoMapComponent implements RenderOptions, OnInit, OnDestroy {+  @ViewChild(A11yPlaceholderDirective, { static: true }) a11yPlaceholder: A11yPlaceholderDirective<GeoMapComponent>;++  @Input() meta: GeoMapMeta;+  @Input() height = 500;+  @Input() width = 800;+  @Input() topoJsonUrl = 'https://cdn.jsdelivr.net/npm/world-atlas@2/countries-10m.json';

Currently not, but I was thinking of putting it in a dataset preference to choose among countries-10m.json, countries-50m.json, and countries-110m.json, etc. in the future.

64json

comment created time in 13 days

Pull request review commentgoogleinterns/guide-doge

Render a world map

+import * as d3 from 'd3';+import { BaseD3, RenderOptions as BaseRenderOptions } from './base.d3';+import * as topojson from 'topojson';++export interface RenderOptions extends BaseRenderOptions {+  topoJsonUrl: string;+}++export class GeoMapD3 extends BaseD3<RenderOptions> {+  render() {+    super.render();++    this.renderMap().catch(console.error);+  }++  async renderMap() {+    const { height, width, topoJsonUrl } = this.renderOptions;++    const projection = d3.geoNaturalEarth1()+      .scale(153)

It was originally from here, but I ended up rewriting nearly everything including this line in #70.

64json

comment created time in 13 days

Pull request review commentgoogleinterns/guide-doge

Render a world map

+import * as d3 from 'd3';+import { BaseD3, RenderOptions as BaseRenderOptions } from './base.d3';+import * as topojson from 'topojson';++export interface RenderOptions extends BaseRenderOptions {+  topoJsonUrl: string;+}++export class GeoMapD3 extends BaseD3<RenderOptions> {+  render() {+    super.render();++    this.renderMap().catch(console.error);+  }++  async renderMap() {+    const { height, width, topoJsonUrl } = this.renderOptions;++    const projection = d3.geoNaturalEarth1()+      .scale(153)+      .translate([width / 2, height / 2])+      .precision(.1);+    const path = d3.geoPath()+      .projection(projection);+    const graticule = d3.geoGraticule();

For me as well hahaa

64json

comment created time in 13 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha 1f34beb4540c2baa84e461c0f00ab9ee7167247c

new changes

view details

Carlos Villapudua

commit sha 3275c7a6f4accd7e11fdfae3ca62d633e5abe7c7

package-lock change

view details

Carlos Villapudua

commit sha 2c893e5431804da263a233f1da44d95a3ac160c9

added createGridPlanes

view details

Carlos Villapudua

commit sha 948ff5097390b040b39b2a578045ee957fd972a1

got rid of import aframe in polyfill.ts and moved to vr comp

view details

HarrisonPearl

commit sha f612c762d1f4cb98faab8427dfbe69f1e2a2f008

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha 3247b9c66f407f4d1f1a839c8ef5a65137ec8cc1

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha d9d30998a8f00cc1a63283f5cc4a37567af442e3

added https flag to ng serve, updated a-frame embedded scene style

view details

HarrisonPearl

commit sha 77fe3939c334aaec6323a5de2d7ef1a2fbda69ad

added super-hands and aframe-extas dependencies. Set up controller tracking and object interactions

view details

Carlos Villapudua

commit sha a98ecf99bf076d97d9bb5bf8c6fe00a937885bb5

added tests for sky/grid presence

view details

HarrisonPearl

commit sha 52815bc10070cba51028e5eec4c2bdf0ba537364

added d3 functions to set up event listeners for hover state changes on data objects

view details

HarrisonPearl

commit sha 58a74389a4b0dc248b12474d95656d0a7bd08e6e

added controller haptic dependencies and triggers

view details

HarrisonPearl

commit sha 5a3dce3f9b9d5301277a6e8717eff3f309e82e4e

seperated d3 code for scatterplots and haptic plots. Reverted scatterplot.d3 to latest version on branch accessibilityVR

view details

HarrisonPearl

commit sha e78e0d5354f6ae37cc74fff7657eecb4b84cd62c

testing updated, function descriptions added, code clean up

view details

Carlos Villapudua

commit sha db778e7f243ef764bc2f4c5e0bcabb6adee212ea

Merge branch 'master' into addingPlanesVR merging master with addingPlanesVR

view details

Carlos Villapudua

commit sha 682a66d645f1a9418787c3670c17b182275023aa

fixed testing for sky and grid elements

view details

cvillapudua

commit sha ca3cfd24de5cfa1b0b2a1f1dfc1f1766d5b96f0b

Merge pull request #50 from googleinterns/addingPlanesVR Adding planes to webVR scene

view details

HarrisonPearl

commit sha 730064b8fcb0eff0f16b3b7eb7a75a812ea0e70d

responding to pr 59 comments. Condensed d3 set up functions, switched to css selection, style changes

view details

dependabot[bot]

commit sha 0797fa453f94b7f59f2873d20029f477d5506763

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

HarrisonPearl

commit sha 012a1405aa9214e32bc164fb82a819df19559f69

moved event listener setup logic into helper modifyColorOnStateChange

view details

HarrisonPearl

commit sha 61b6545b7718707edf5e443d185817640c9dd711

linting fixes (whitespace removal, simplifications)

view details

push time in 13 days

push eventgoogleinterns/guide-doge

Carlos Villapudua

commit sha 1f34beb4540c2baa84e461c0f00ab9ee7167247c

new changes

view details

Carlos Villapudua

commit sha 3275c7a6f4accd7e11fdfae3ca62d633e5abe7c7

package-lock change

view details

Carlos Villapudua

commit sha 2c893e5431804da263a233f1da44d95a3ac160c9

added createGridPlanes

view details

Carlos Villapudua

commit sha 948ff5097390b040b39b2a578045ee957fd972a1

got rid of import aframe in polyfill.ts and moved to vr comp

view details

HarrisonPearl

commit sha f612c762d1f4cb98faab8427dfbe69f1e2a2f008

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha 3247b9c66f407f4d1f1a839c8ef5a65137ec8cc1

fixed hidden vr button + header by adding embedded tag to a-scene

view details

HarrisonPearl

commit sha d9d30998a8f00cc1a63283f5cc4a37567af442e3

added https flag to ng serve, updated a-frame embedded scene style

view details

HarrisonPearl

commit sha 77fe3939c334aaec6323a5de2d7ef1a2fbda69ad

added super-hands and aframe-extas dependencies. Set up controller tracking and object interactions

view details

Carlos Villapudua

commit sha a98ecf99bf076d97d9bb5bf8c6fe00a937885bb5

added tests for sky/grid presence

view details

HarrisonPearl

commit sha 52815bc10070cba51028e5eec4c2bdf0ba537364

added d3 functions to set up event listeners for hover state changes on data objects

view details

HarrisonPearl

commit sha 58a74389a4b0dc248b12474d95656d0a7bd08e6e

added controller haptic dependencies and triggers

view details

HarrisonPearl

commit sha 5a3dce3f9b9d5301277a6e8717eff3f309e82e4e

seperated d3 code for scatterplots and haptic plots. Reverted scatterplot.d3 to latest version on branch accessibilityVR

view details

HarrisonPearl

commit sha e78e0d5354f6ae37cc74fff7657eecb4b84cd62c

testing updated, function descriptions added, code clean up

view details

Carlos Villapudua

commit sha db778e7f243ef764bc2f4c5e0bcabb6adee212ea

Merge branch 'master' into addingPlanesVR merging master with addingPlanesVR

view details

Carlos Villapudua

commit sha 682a66d645f1a9418787c3670c17b182275023aa

fixed testing for sky and grid elements

view details

cvillapudua

commit sha ca3cfd24de5cfa1b0b2a1f1dfc1f1766d5b96f0b

Merge pull request #50 from googleinterns/addingPlanesVR Adding planes to webVR scene

view details

HarrisonPearl

commit sha 730064b8fcb0eff0f16b3b7eb7a75a812ea0e70d

responding to pr 59 comments. Condensed d3 set up functions, switched to css selection, style changes

view details

dependabot[bot]

commit sha 0797fa453f94b7f59f2873d20029f477d5506763

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

HarrisonPearl

commit sha 012a1405aa9214e32bc164fb82a819df19559f69

moved event listener setup logic into helper modifyColorOnStateChange

view details

HarrisonPearl

commit sha 61b6545b7718707edf5e443d185817640c9dd711

linting fixes (whitespace removal, simplifications)

view details

push time in 13 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha b1390689f1214cb6ffa3ad61573915d12868cd3d

Add raw city data and a binary to refine them

view details

Jinseo Park

commit sha fe582f16fa2ba8287b0e96f5f79ae22e8a4be170

Update refine_city_data

view details

Jinseo Park

commit sha 1ea95505e99e9ce3bfbfd6d2f34025d38e3ac401

Fix wrongly parsing country/city name with comma

view details

Jinseo Park

commit sha 6d9a9a25cfca6175d291d2be8c1606033caeec7a

Populate country/subcontinent/continent info

view details

Jinseo Park

commit sha 7a29ffb28121437743d68b09828a1c10877c43ac

Add missing dependency

view details

Jinseo Park

commit sha 2e37d05d4b541d6d0d2c964a76cf8f1384e14220

Add attribution

view details

Jinseo Park

commit sha 184365188324f73db9db7f80d1ea012543913640

Merge pull request #63 from googleinterns/city-data Add raw city data and a binary to refine them

view details

push time in 13 days

PR merged googleinterns/guide-doge

Reviewers
Add raw city data and a binary to refine them

Run bin/refine_city_data would do the following:

  1. Fetch country data.
  2. Read city data and convert CSV to JSON.
  3. Filter out unnecessary data to reduce size.
  4. Combine city and country data.
  5. Write the combined data to src/assets/cities.json.
+15660 -76

2 comments

8 changed files

64json

pr closed time in 13 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha 2e37d05d4b541d6d0d2c964a76cf8f1384e14220

Add attribution

view details

push time in 13 days

push eventgoogleinterns/guide-doge

Jinseo Park

commit sha b7531816407b5042da0f58695d802c6cfa6fbcc4

Add geo-map component/d3/dataset

view details

Jinseo Park

commit sha ec8aba5de74f501f87bf71dd891ed4a397b54cbb

Render world map

view details

Jinseo Park

commit sha fd584f96dcb9a96a4d0057373cb598b09858857e

Merge remote-tracking branch 'origin/master' into geo-map

view details

Jinseo Park

commit sha 14f07c657d247d31ed1d7649990460cc33319278

Create renderMap method

view details

Jinseo Park

commit sha ce9863c24bc711504a719431b9bc26ed259ee9ef

Add topoJsonUrl to renderOptions

view details

Jinseo Park

commit sha b89be2be12dfc075cb1aa9f836e3f37ce866bbab

Fix/add tests

view details

Jinseo Park

commit sha 6b4c5a04ec937404a5df9a6afc3412176c4f6bd8

Merge remote-tracking branch 'origin/master' into geo-map

view details

Jinseo Park

commit sha 786da9702c515243485802e5b730d6e18d00e127

Fix module dependency

view details

Jinseo Park

commit sha 21b7af4d820abad1b327da26d7b0ef3ed98a3dbe

Use enum for meta type

view details

Jinseo Park

commit sha 7e7c945d6851e96b9b0f1e7627c930e56156dd8c

Merge remote-tracking branch 'origin/master' into geo-map

view details

Jinseo Park

commit sha ead3759d6c82130a61a35f5a91dd1916832f2039

Update tests

view details

Jinseo Park

commit sha 04bc2e9995b417fd66530d1def93c7e068fbdd81

Add tests for geo map component

view details

Jinseo Park

commit sha f40a6739c17512e30b961c329b93691e734fcb39

Add more tests

view details

Jinseo Park

commit sha 6b6ace3018d390f72c3abef0ff3e287b17e89e4a

Merge pull request #61 from googleinterns/geo-map Render a world map

view details

push time in 13 days

more