profile
viewpoint

1ace/archlinux-meson-cross-riscv64-linux-gnu 1

Meson cross file for archlinux's RISC-V 64 cross compilers

1ace/sway 1

i3-compatible Wayland compositor

1ace/archlinux-meson-cross-aarch64-linux-gnu 0

Meson cross file for archlinux's aarch64 cross compilers

1ace/conda 0

OS-agnostic, system-level binary package manager and ecosystem

1ace/CoverYourApps 0

A teaching platform aimed at non-technically savvy people that teaches computer security best practices.

1ace/docker-cli 0

The Docker CLI

1ace/docker-credential-helpers 0

Programs to keep Docker login credentials safe by storing in platform keystores

1ace/docs.gl 0

OpenGL Reference Documentation

1ace/EGL-Registry 0

EGL API and Extension Registry

1ace/gputop 0

A GPU profiling tool

startedRust-SDL2/rust-sdl2

started time in 2 hours

issue commentdocker/compose

(Regression) Pressing CTRL+C on `docker-compose up` hangs when using containers with restart: unless-stopped|always

I'm encountering the same bug, and I have a test-case that can be run from a CI:

services:

  server:
    image: alpine
    command: /bin/sleep infinity
    restart: always

  client-test:
    image: alpine
    command: /bin/true

If you remove the restart line:

~/bug $ docker compose up --abort-on-container-exit
[+] Running 3/0
 ⠿ Network bug_default          Created 0.0s
 ⠿ Container bug-server-1       Created 0.0s
 ⠿ Container bug-client-test-1  Created 0.0s
Attaching to bug-client-test-1, bug-server-1
bug-client-test-1 exited with code 0
Aborting on container exit...
[+] Running 2/2
 ⠿ Container bug-server-1       Stopped 10.3s
 ⠿ Container bug-client-test-1  Stopped 0.0s
ERRO[0010] 0
~/bug $ 

If you leave the restart line:

~/bug $ docker compose up --abort-on-container-exit
[+] Running 3/0
 ⠿ Network bug_default          Created 0.0s
 ⠿ Container bug-server-1       Created 0.0s
 ⠿ Container bug-client-test-1  Created 0.0s
Attaching to bug-client-test-1, bug-server-1
bug-client-test-1 exited with code 0
Aborting on container exit...
[+] Running 2/2
 ⠿ Container bug-server-1       Stopped 10.2s
 ⠿ Container bug-client-test-1  Stopped 0.0s
ERRO[0010] 0

and it never returns.

joanbm

comment created time in 2 days

delete branch 1ace/sway

delete branch : allow-ipc-on-proprietary-drivers

delete time in 25 days

PR opened swaywm/sway

sway: allow IPCs on proprietary drivers

Proprietary drivers require --unsupported-gpu to be allowed, and IPCs require no option to be passed.

The only way to satisfy both is to run IPCs before checking for proprietary drivers.


I have an nvidia card (I didn't know better 8 years ago, unfortunately), but since they've finally added support for Wayland I've installed the nvidia driver on my machine, but to my surprise sway reload stopped working as a result.

I understand having to pass --unsupported-gpu to run sway itself, but I think having to pass that to execute IPC commands is a bit much, so instead of the complex solution of allowing this flag but not others in the IPC path, I opted to simply move the check after it.

+2 -1

0 comment

1 changed file

pr created time in a month

create barnch1ace/sway

branch : allow-ipc-on-proprietary-drivers

created branch time in a month

startedwillmcgugan/textual

started time in a month

startedsharkwouter/minigalaxy

started time in a month

startedluxtorpeda-dev/luxtorpeda

started time in a month

push event1ace/mesa

Emma Anholt

commit sha 3eadb03db775cc41bbc58e67b37115540eb480e0

ci/lvp: Skip some slow tests under ASan. depending on the runner's load, we might see timeouts. The subgroupbroadcast one has hit us a couple times this week. Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13346>

view details

Jordan Justen

commit sha 9a7e54b87f399f387048e5e21be9ee45f4ddb398

intel/genxml: Update genxml to support tessellation/geometry distribution Rework: - Fix 3DSTATE_VFG opcode (Lionel) - Fix distribution mode values (Sagar) - Update 3DSTATE_VFG fields (Anuj) Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Anuj Phogat

commit sha 1d224e7f14e366534d3942976801f959b963d540

genxml/gen125: Update 3DSTATE_TE fields Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Anuj Phogat

commit sha efa27572a15b1bb6ee88d0556c2af06dc501215d

iris: Enable geometry distribution Using recommended values based on performance studies across a range of workloads. Rework: * Always enable geometry distribution * Set ListCutIndexEnable if primitive restart is enabled * Set distribution mode based on TEEnable v2: - Flag missing IRIS_DIRTY_VFG bit (Ken) Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Anuj Phogat

commit sha 867e2e0716ed4a753a5591542a91cca31613f46f

anv: Enable geometry distribution Using recommended values based on performance studies across a range of workloads. Rework: * Always enable geometry distribution * Set ListCutIndexEnable if primitive restart is enabled * Set distribution mode based on TEEnable * Add comment explaining the 3DSTATE_VFG bits (Sagar) v2: - Emit 3DSTATE_VFG dynamically based on primitive restart (Ken) Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Anuj Phogat

commit sha 20c0ca75f55409f279a23a415f5c7dd70a012665

iris: Enable tessellation redistribution This patch adds Tessellation Distribution on top of Geometry Distribution. Using recommended values based on performance studies across a range of workloads. Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Anuj Phogat

commit sha a98ece61e9109963da525592a6890ad1166a0993

anv: Enable tessellation redistribution This patch adds Tessellation Distribution on top of Geometry Distribution. Using recommended values based on performance studies across a range of workloads. Rework: - Add comment for new packet bits (Sagar) Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com> Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12091>

view details

Dave Airlie

commit sha c4323dc846d1b894ab86ce7d0eb98409085c6a18

brw/nir: remove unused function prototypes. These got moved into common code a good while ago. Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13328>

view details

Ian Romanick

commit sha ae99ea6f4ddb90f7120b4986709a9e9064037f94

nir/loop_unroll: Always unroll loops that iterate at most once Two carchase compute shaders (shader-db) and two Fallout 4 fragment shaders (fossil-db) were helped. Based on the NIR of the shaders, all four had structures like for (i = 0; i < 1; i++) { ... for (...) { ... } } All HSW+ platforms had similar results. (Ice Lake shown) total loops in shared programs: 6033 -> 6031 (-0.03%) loops in affected programs: 4 -> 2 (-50.00%) helped: 2 HURT: 0 All Intel platforms had similar results. (Ice Lake shown) Instructions in all programs: 143692018 -> 143692006 (-0.0%) SENDs in all programs: 6947154 -> 6947154 (+0.0%) Loops in all programs: 38285 -> 38283 (-0.0%) Cycles in all programs: 8434822225 -> 8434476815 (-0.0%) Spills in all programs: 191665 -> 191665 (+0.0%) Fills in all programs: 298822 -> 298822 (+0.0%) In the presense of loop unrolling like this, the change in cycles is not accurate. v2: Rearrange the logic in the if-condition to read a little better. Suggested by Tim. Closes: #5089 Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13323>

view details

Boris Brezillon

commit sha 6d44b21d4fdea89673541de265f69258747c5499

vulkan: Fix weak symbol emulation when compiling with MSVC Mapping unimplemented entrypoints to a global function pointer variable initialized to NULL is a bit cumbersome, and actually led to a bug in the vk_xxx_dispatch_table_from_entrypoints() template: the !override case didn't have the right check on the source table entries. Instead of fixing that case, let's simplify the logic by creating a stub function and making the alternatename pragma point to this stub. This way we get rid of all those uneeded xxx_Null symbols/variables and simplify the tests in vk_xxxx_dispatch_table_from_entrypoints(). Cc: mesa-stable Fixes: 98c622a96e28 ("vulkan: Update dispatch table gen for Windows") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13348>

view details

Iago Toral Quiroga

commit sha 8e6f5aab336d3bf84aae604b51e07529380b5019

v3dv: fix TLB buffer to image copy path for 3D images Another instance of not taking the Z offset from the right place. We had not seen this one until now because we typically use the TFU path, where we also fixed this same issue in commit df1d08533c4. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13356>

view details

Bas Nieuwenhuizen

commit sha b4aa5a3fdd0ec2b3ac3c019e1c323208c0fa1faf

radv: Fix modifier property query. radv_get_modifier_flags read the format properties, doesn't write any. Setting the central format properties based on the drm format properties doesn't make any sense. Fixes: 5dee0d9da96 "radv: switch to VK_FORMAT_FEATURE_2_XXX/VkFormatProperties3KHR" Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5498 Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Tested-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13357>

view details

Boris Brezillon

commit sha fd467492349ee32cd196a8bd747269404965e3b1

vulkan: Set unused entrypoints to vk_entrypoint_stub when compiling with MSVC If we don't do that we hit the assert(entry[i] != NULL) added by commit 6d44b21d4fd ("vulkan: Fix weak symbol emulation when compiling with MSVC"). Fixes: 6d44b21d4fd ("vulkan: Fix weak symbol emulation when compiling with MSVC") Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13355>

view details

Jason Ekstrand

commit sha 071437d29d9ebe5f1dbc4e14e63fd8a3861ce6f9

vulkan/log: Tweak our handling of a couple error enums VK_ERROR_INITIALIZATION_FAILED can happen as part of device creation and isn't really an instance error in that case. VK_ERROR_EXTENSION_NOT_PRESENT, on the other hand, is always an instance thing and we should handle it as such. Fixes: 0cad3beb2a0d ("vulkan/log: Add common vk_error and vk_errorf helpers") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13341>

view details

Jason Ekstrand

commit sha 116e23e3855a28e74e09517d0005200fd139dc88

vulkan/log: Don't assert on non-client-visible objects We already have code to deal with non-client-visible objects but we were asserting if it didn't fall into one of the clearly mappable error cases. However, we didn't have a mapping for VK_ERROR_NOT_PERMITTED which can happen during object creation. Let's just be sloppy and drop the assert. Worst case, the client gets an error with no object. Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13341>

view details

Mike Blumenkrantz

commit sha f769f34680d516850c6efd64669bf601efcd4425

nir/print: print bindless info as applicable this is useful to know Reviewed-by: Jesse Natalie <jenatali@microsoft.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13204>

view details

Jason Ekstrand

commit sha b79e978ae48c2c4a7059a7f5eb695c6b0362ac60

vulkan/wsi/win32: Delete the wrapper entrypoints Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13352>

view details

Emma Anholt

commit sha f839b9599f863fa5bb1a6a6c24bbb621b7a1b4c9

loader: Avoid enumerating drm devices just to get an fd's PCI ID. Cuts 1/3 of the runtime of the VA-API unit tests (which do a separate pipe-loader init per test) on radeonsi on my system by not faffing around in sysfs so much. Reviewed-by: Adam Jackson <ajax@redhat.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13324>

view details

Danylo Piliaiev

commit sha 1c0eb7aa78bac4494dbff0c502a8c09e23a4c123

ir3/freedreno: account for component in build_tessfactor_base The burden was put on the caller, which caused: - Reading of tess levels back in TCS not accounting for component - Reading patch outputs in TES account for component twice Fixes vkd3d tests: - test_tessellation_read_tesslevel - test_tessellation_primitive_id - test_line_tessellation_dxbc Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13338>

view details

Eric Engestrom

commit sha 70df31f5e04c73e9fd6290fad505f0187501ac80

docs: update calendar for 21.3.0-rc1 Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13368>

view details

push time in a month

pull request commentcontainers/podman

Allow identical duplicate volumes and mounts

Are you running Docker Compose v2.0?

Yes, I am actually; I'll try docker-compose v1.x when I'm back in the office on Monday. I'll also try to compile podman with this change to see if it helps, I didn't have time to do this on Friday but I'm hoping I'll be able to next week.

There's a known issue with v2.0 against Podman where this is showing up.

Ah, I don't know why I missed #11822 when I searched earlier. I've subscribed to that issue now, and providing downgrading docker-compose fixes this problem, I'll stick with it for now. I'm also happy to help test patches to get v2 compatibility :slightly_smiling_face:

mheon

comment created time in 2 months

startedrgolangh/gnome-shell-extension-containers

started time in 2 months

pull request commentcontainers/podman

Allow identical duplicate volumes and mounts

Sorry, I assumed you knew this wasn't just a "duplicate -v in the command line" issue and chose not to fix it. Apologies if my first message was a bit too strong :pray:

mheon

comment created time in 2 months

pull request commentcontainers/podman

Allow identical duplicate volumes and mounts

This docker-compose.yml reproduces the issue:

version: "3.7"

services:
  postgres:
    image: postgres:alpine
    environment:
      PGDATA: /var/lib/postgresql/data/pgdata
      POSTGRES_PASSWORD: random
    volumes:
      - postgres_data:/var/lib/postgresql/data

volumes:
  postgres_data:
$ docker-compose up
[+] Running 3/1
 ⠿ Network tmp_default         Created                                                                             0.1s
 ⠿ Volume "tmp_postgres_data"  Created                                                                             0.0s
 ⠿ Container tmp-postgres-1    Created                                                                             0.0s
Attaching to tmp-postgres-1
tmp-postgres-1  | The files belonging to this database system will be owned by user "postgres".
tmp-postgres-1  | This user must also own the server process.
[...]
$ export DOCKER_HOST="unix://$XDG_RUNTIME_DIR/podman/podman.sock"
$ docker compose up
[+] Running 2/0
 ⠿ Network tmp_default         Created                                                                             0.0s
 ⠿ Volume "tmp_postgres_data"  Created                                                                             0.0s
 ⠋ Container tmp-postgres-1    Creating                                                                            0.0s
Error response from daemon: fill out specgen: /var/lib/postgresql/data: duplicate mount destination
mheon

comment created time in 2 months

pull request commentcontainers/podman

Allow identical duplicate volumes and mounts

@rhatdan:

I don't see why we should be bug for bug compatible with Docker.

Being able to run the images everyone using docker is able to run sounds like something podman should strive for, don't you think? And this isn't about adding a bug, it's about not failing when a bug is present in the image podman is told to run.

I've arrived here because I'm trying to transition my company over to podman, but this is the bug I'm currently stuck on: docker accepts using the official postgres image as is, while podman rejects it and it looks like (unless this PR is merged) my only option is to copy the postgres Dockerfile, remove the duplicate VOLUME line, and have to build it and ship this alongside our app.

Surely you agree merging this PR to be compatible with docker is the more reasonable option, even if it might not be as helpful to users making copy/paste typos as the current fatal error?

I hope you'll reconsider :slightly_smiling_face:

mheon

comment created time in 2 months

issue commentMicrosoftDocs/sql-docs

Unable to locate package msodbcsql17

@WilliamAntonRohm I get that you're trying to be helpful, but a quick glance at the first message (or any other) would've shown you your links are entirely irrelevant to the packaging issue Microsoft is experiencing and which is breaking installs for their users.

svatos-jirka

comment created time in 2 months

issue commentMicrosoftDocs/sql-docs

Unable to locate package msodbcsql17

@David-Engel it's down again :cry:

If packages.microsoft.com is that unreliable, is there an alternative server we can use so that our builds don't get broken every few weeks?

The alternative you (Microsoft) are leaving to your users is to move away from Microsoft tools & services, which I don't think you (Microsoft) want, so you (David) might want to let your management know they need to prioritize availability if Microsoft wants to retain their users :disappointed:

(of course in my case we're stuck because a customer of ours insists on using mssql, which makes this issue even more infuriating for us...)

svatos-jirka

comment created time in 2 months

push event1ace/mesa

Christian Gmeiner

commit sha cfa8828c62b55dbefdd5f29bdd60007582d0ddac

util/bitset: add bitwise AND, OR and NOT Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 79067c4744be6d9afd3e11053e48aaf35503278b

util/tests: add bitwise AND, OR and NOT tests Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 7b62fb45588030920b853526dd9f45953dae27e5

util/bitset: add right shift Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 0c243b3f9800951da8c78faa8529d0c8d2341858

util/tests: add bitset SHR tests Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 6171bc22436ef3958fd21d1126db55fea4a7e14b

util/bitset: add left shift Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 3d3a4b9b01cd9baa316308c2bb38a3775c35eceb

util/tests: add bitset SHL tests Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 3d65cea6ee56c2192d333632bf28460d2857af0a

util/bitset: s/BITSET_SET_RANGE/BITSET_SET_RANGE_INSIDE_WORD Prep work for the next commit. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha b3b03e33c9f11adb0c4d84311a651ea6016a0885

util/bitset: add BITSET_SET_RANGE(..) This version works across word boundary. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 54ea23da510328c1eabd5604b3e9d1f29ebdc8c8

util/tests: add set bit range test This simple test validates that it is possible to set bits across word bounary. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 3b52d64474b4edd8ce223ca15cb18db2d4cae56c

freedreno/isa: add leading zero's Changes the output format slightly but its needed when we want to switch to more generic version of isaspec. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha c3b14ade55aa3fd24012bcd009005f64af352b5a

freedreno/isa: simplify custom_target Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 6c3befdd7017bfec7034a03e931913200fa1fc51

freedreno/isa: add next_instruction(..) In during the next commits we will change to a generated version of next_instruction(..) based on the actual isa. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha d29a6e2db55cf020cc2d0647a741111decaa4821

freedreno/isa: add defines for fprintf(..) usage In the long run they will be replaces with some generated defines. If we do this early it keeps the diffs of the next changes small. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 3d6a3b3c7c7eda691d34f5dc6e101bb3d14f80c8

freedreno/isa: store max size for needed bitset We will use this information later to create a correctly sized BITSET. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 59e6258e4f34038705ff69dc41a3901b225a18e4

freedreno/isa: generate ir3-isa.h This header contains the bitmask_t struct typedef that will be used by the isaspec. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 3c634e956bcd45b06e806efdeb31e22dac8d3dbb

freedreno/isa: generate isaspec-decode.h Generate a 'glue' header file to be able to support different ISAs. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha 35877cd7b8ce9777e7b6a6c7a9c53e7ca41f6f6a

freedreno/isa: add bitmask_t to encode.py Prep work for the next change. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha ea42a3bee55642537b98651c4c3129bc630f3400

freedreno/isa: add bitmask to/from uint64_t helper Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha a5bbd087755571cbf42edfc50db4316c2f6b14fa

freedreno/isa: add BITMASK_WORDS define This new define will be used by a more generic deocde(..) and encode(..) functions. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

Christian Gmeiner

commit sha a6b82d1c8c40a9aea5f3ae93327c0d72b78fb661

freedreno/isa: add store_instruction(..) Makes it possible to store an encoded instruction in a generic ISA specific way. Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11321>

view details

push time in 2 months

PR closed mesa3d/mesa

egl: set TSD as NULL after deinit

When eglReleaseThread() is called from application's destructor (API with attribute((destructor))), it crashes due to invalid memory access.

In this case, _egl_TLS is freed in the flow of _eglAtExit() as below but _egl_TLS is not set to NULL.

When eglReleaseThread() is called from application's destructor (API with attribute((destructor))), it crashes due to invalid memory access.

In this case, _egl_TLS is freed in the flow of _eglAtExit() as below but egl_TLS is not set to NULL.

    eglDestroyThreadInfo
        |__ _eglFiniTSD
                |__ _eglAtExit
                    |__ __run_exit_handlers
                        |__ exit

Later when the eglReleaseThread is called from application's destructor, it ends-up accessing the freed _egl_TLS pointer.

    eglReleaseThread -> in libEGL_mesa
        |__ eglReleaseThread -> in libEGL(glvnd)
             |__ destructor() -> App's destructor

To resolve the invalid access, setting the _egl_TLS pointer as NULL after freeing it.

+1 -0

1 comment

1 changed file

maniraj87

pr closed time in 2 months

pull request commentmesa3d/mesa

egl: set TSD as NULL after deinit

Hi @maniraj87! Thanks for the PR; from a quick glance it looks correct, but unfortunately this repo is just a read-only mirror for the real repo which lives at https://gitlab.freedesktop.org/mesa/mesa

Could you re-post your commit to that repository that the developers can take a look at it? Feel free to tag me there as well; I'm @eric there :+1:

I'll close this PR but feel free to reply here if you have any questions :slightly_smiling_face:

maniraj87

comment created time in 2 months

issue commentdrgrib/dotmap

test fail with python3.10

@Alessandro-Barbieri for this specific error, it's because the Abstract Base Classes were moved from collections to collections.abc (the old module path was deprecated since python 3.3), so the fix is probably as simple as replacing the former with the latter in the import statement, with a try/except ImportError if python < 3.3 needs to be supported :) (Full disclosure: I haven't even looked at the code, so it might be doing something special with the imports)

try:
    from collections.abc import OrderedDict, MutableMapping
except ImportError:
    from collections import OrderedDict, MutableMapping
Alessandro-Barbieri

comment created time in 2 months

issue commentdrgrib/dotmap

test fail with python3.10

@drgrib you might want to consider opening up your project to group maintainership so that the project can outlive your interest in it :slightly_smiling_face:

One option to do that with minimal effort is to go to collectives like @jazzband for instance; if you'd like to know more about them, their guidelines page has all the details.

(There are others collectives, this is just the one I'm familiar with.)

Alessandro-Barbieri

comment created time in 2 months

startedlighttransport/nanostl

started time in 2 months

startedOlshansk/interview

started time in 2 months

startedviraptor/reverse-interview

started time in 2 months

startedr-lyeh/gamebook

started time in 2 months

startedCaerind/AwesomeCppGameDev

started time in 2 months

startedmlabbe/nativefiledialog

started time in 3 months

push event1ace/mesa

Roland Scheidegger

commit sha 49337ec410ae5a8d6e9282e2fefc43c9d638a5e8

gallium: add rasterizer depth_clamp enable bit This is required for d3d10+, which has depth_clamp always enabled regardless of depth_clip (in contrast to OpenGL, where enabling depth_clamp disables depth_clip). There doesn't seem to be a GL extension for it, but it will be used for lavapipe to implement VK_EXT_depth_clip_enable. Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12260>

view details

Roland Scheidegger

commit sha 1a554fd61037c9133bf5a4a1f1dd0f1edba97096

lavapipe: implement VK_EXT_depth_clip_enable v2: fix pipeline creation, need a deep copy for rasterization state now Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12260>

view details

Mike Blumenkrantz

commit sha 7f5a3530125629a3553427988d04e75c31312ade

aux/trace: use private refcounts for samplerviews this avoids having the driver bypass the samplerview wrapper and destroying the samplerview prematurely, e.g., spec@sgis_generate_mipmap@gen-texsubimage Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12546>

view details

Chia-I Wu

commit sha e14bec2ef31331caa69bb58671f40b730b131db7

venus: refactor vn_instance_enumerate_physical_devices Move device enumeration to a new function. v2: separate success and fail paths, rename functions (suggested by Ryan) Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> (v1) Reviewed-by: Ryan Neph <ryanneph@google.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12723>

view details

Chia-I Wu

commit sha ca1622830eb5635f2982804334790bf9458de885

venus: separate physical device init and filter It is not an error when a physical device is filtered out. But it is an error when a physical device fails to initialize. Fixed dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail. v2: separate success and fail paths Fixes: 7dfac808 ("venus: no supported device is not an error") Signed-off-by: Chia-I Wu <olvaffe@gmail.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> (v1) Reviewed-by: Ryan Neph <ryanneph@google.com> (v1) Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12723>

view details

Bas Nieuwenhuizen

commit sha b05cd10b8e49a04f3382112ee568b61853fbda0e

nir: Avoid visiting instructions multiple times in nir_instr_free_and_dce. Sadly need to poke a bit in the src internals to avoid using yet another heap allocated datastructure. Fixes: 52515485723 ("nir: Add a nir_instr_remove that recursively removes dead code.") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5323 Reviewed-by: Emma Anholt <emma@anholt.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12726>

view details

Emma Anholt

commit sha 947f585e91000f5cdd94626b7903de8232fdba77

nir_to_tgsi: Fix indirect addressing of atomic counters. It's not actually a given that the offset within the counter buffer is a constant. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Emma Anholt

commit sha 4a4a889de3dc1c0c1d7e446992ae442f74f3a0c2

nir_to_tgsi: Don't forget to add sampler views with our samplers. While softpipe and i915 didn't really care, virgl very much does. tgsi_scan also insisted that the texture ops and the decls matched, which led to deduplicating the switch statemnts. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Emma Anholt

commit sha d24893e7357d6ff87c10904f8bfdf8115f7e1210

nir_to_tgsi: Add support for memory_barrier_tcs_patch. glsl_to_tgsi translated both cases of ir_barrier to TGSI's BARRIER, so map both of glsl_to_nir's ir_barrier outputs to the same. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Emma Anholt

commit sha ed1fb1f03be5e0cb5fb9a36dc0b089f3ff4ee8de

nir_to_tgsi: Clean up some unnecessary pointers-to-uregs. This was used at one point to do ntt_store_def() or something I think. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Emma Anholt

commit sha bd8de1680307e240eea6b73109fd5bbfb312a30c

nir_to_tgsi: Switch ssa_temp[] to be a ureg_src. After ntt_store_def(), all uses want it to be a ureg_src. This will let us fold abs/neg/swizzles in. Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Emma Anholt

commit sha db930bd91bf1677d134f2737f6b7c502cf551c84

nir_to_tgsi: Allow SSA defs to include swizzles, abs, and neg. This will let some copy prop happen automatically, avoiding MOVs to temps. Most importantly, though, it means that virgl won't see (unused channel) swizzles from channels beyond the bounds of sysvals, which trigger shader compile failures on the host. softpipe shader-db: total instructions in shared programs: 2946336 -> 2934777 (-0.39%) instructions in affected programs: 374676 -> 363117 (-3.09%) total temps in shared programs: 565552 -> 564139 (-0.25%) temps in affected programs: 18138 -> 16725 (-7.79%) Reviewed-by: Rob Clark <robdclark@chromium.org> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

view details

Jason Ekstrand

commit sha 7b21def9c21297e9f0bef1aed344ace28333022b

intel/fs: Add support for atomic_fadd Rework: - Enable float32 atomic add with LSC (Sagar) - disassemble new opcode (Caio) Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Jason Ekstrand

commit sha 7f2395046f5e0b09821a22d45bf22ce41f0b09cb

anv: Advertise support for shaderBufferFloat32AtomicAdd Rework: (Sagar) - Enable shaderBufferFloat32AtomicAdd for XeHPG Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Sagar Ghuge

commit sha 527468f56f45de49971622052b172f7cffb38617

intel/compiler: Add 64-bit A64 float logical opcode support Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Sagar Ghuge

commit sha 9ffd05b41ecebc70f2b1b58f4d155a409858ae2a

anv: Advertise support for shaderBufferFloat64AtomicMinMax v1: - Just check has_lsc (Jason) Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Sagar Ghuge

commit sha 75e28b8777086fcdbb76555324157959602421dd

intel/compiler: Add support to handle 64-bit atomics with A32 messages v1: (Jason) - Fix parentheses Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Sagar Ghuge

commit sha 5f66e5e56d78a3b4b9720735669500a2434d287b

anv: No need to lower to A64 messages for 64-bit atomics With LSC support, we can do 64-bit atomics with A32/64 messages. Signed-off-by: Sagar Ghuge <sagar.ghuge@intel.com> Suggested-by: Jason Ekstrand <jason@jlekstrand.net> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12566>

view details

Ilia Mirkin

commit sha 269cbc8a4de3142f9ef559956ce903e5f550a1ce

a4xx: add some better documentation for compute registers These were driven by seeing 0x1c (and other) values set by blob, as well as comparing to equivalent a3xx documentation. Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12784>

view details

Ilia Mirkin

commit sha fb5deb2b4a02890d316d6f926186599f7b539d90

a4xx/computerator: add initial backend This backend provides very basic a4xx support. It's enough to run kernels with explicit stg/etc ops, but not with stgb/ldgb type access. There is no perfcounter support hooked up yet either. Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12784>

view details

push time in 3 months

startedkmar/Sweet16Font

started time in 3 months

startedKhronosGroup/SPIRV-LLVM-Translator

started time in 3 months

more