profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/0xTim/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Tim Condon 0xTim @brokenhandsio Manchester, UK https://www.timc.dev All things server-side Swift! 🚀 Vapor Core Team

0xTim/CodeMobileWorkshop 1

Code from the CodeMobile Workshop

0xTim/Alamofire 0

Elegant HTTP Networking in Swift

0xTim/async-http-client 0

HTTP client library built on SwiftNIO

0xTim/async-kit 0

Sugary extensions for the SwiftNIO library

issue closedvapor/postgres-kit

PostGIS "geometry" type

Moved here from the fluent-kit repo.

I have a PSQL database with the PostGIS extension installed, and I am trying to add a geometry type column in a Fluent model and migration.

A geometry column can have any of the values of the picture at the end, but I plan on using only one type of geometry in a column (point, linestring, polygon, etc...). I'm pretty lost on how to add thisgeometry type to the migration using the .custom(Any) type. I can add the data just fine using Strings, but I would like to get the column type correct on the migrations too.

Hope someone can point me to the right direction. Thanks!

Column in PSQL (could be a general geometry one to allow multiple types of geometries). image

Sample value: image

From the PostGIS documentation: http://postgis.net/workshops/postgis-intro/geometries.html

image

closed time in 9 hours

codingmanu
PullRequestReviewEvent

pull request commentvapor/fluent-kit

Make very slow `Migration.defaultName` accessor twice as fast

Given the discussions on Discord, I have no major objections to this. For the record my main concern is that future versions of Swift will end up breaking migrations but I suspect we'll hit that issue pretty quickly were it to happen

gwynne

comment created time in a day

pull request commentvapor/fluent-kit

WIP: starting null query tests

Yeah until you get your first contributions merged in it needs to be approved each time unfortunately

jaredh159

comment created time in a day

PullRequestReviewEvent

Pull request review commentsoto-project/soto-core

Async/await

 let package = Package(     dependencies: [         .package(url: "https://github.com/apple/swift-log.git", from: "1.4.0"),         .package(url: "https://github.com/apple/swift-metrics.git", "1.0.0"..<"3.0.0"),-        .package(url: "https://github.com/apple/swift-nio.git", from: "2.16.1"),-        .package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.7.2"),-        .package(url: "https://github.com/apple/swift-nio-transport-services.git", from: "1.0.0"),-        .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.3.0"),+        .package(url: "https://github.com/apple/swift-nio.git", .upToNextMajor(from: "2.32.0")),

Any particular reason to this being upToNextMajor? I seem to remember it moving to from in a previous PR. Either way the whole manifest should be consistent

adam-fowler

comment created time in a day

PullRequestReviewEvent

push eventMihaelIsaev/vapor

David Roman

commit sha 21af9d0935733ffaa2832e473779d01edcf6ed84

Correctly pass `SocketAddress` through to `Request` convenience initialiser (#2685) * Fix missing assignment in `Request` convenience init * Fix typo

view details

Richard Turton

commit sha 69b0e257b1a86c1eaa1767563a093e208fdb8fab

Fix Xcode 13 RC build failure by not sending an optional to free() (#2687)

view details

Tim Condon

commit sha cda9f0407e2f2d4ecc09c4f0b708c476deb70b23

Merge branch 'main' into master

view details

push time in 2 days

pull request commentvapor/fluent-kit

WIP: starting null query tests

Personally I don't see an issue with this. You could always wrap the tests in a test case that asserts that the environment variable is set so anyone running the tests in Xcode has a hint on what to set.

@gwynne thoughts

jaredh159

comment created time in 2 days

issue commentvapor/fluent-kit

Polymorphic relations

No progress on this I'm afraid. @gwynne I'm assuming this isn't really on our radar and something we should tag with help-wanted to see if we can get a community PR?

tanner0101

comment created time in 2 days

pull request commentrazeware/emitron-iOS

Pr/564

@VegetarianZombie Looks like there are some build failures in some of the tests

VegetarianZombie

comment created time in 2 days

PR closed razeware/emitron-iOS

Fix issue 552 - Retain Filters between runs

<!-- 🚀 Thank you for contributing! -->

<!-- Describe your changes clearly and use examples if possible. -->

<!-- If this PR fixes an issue, then please link to that issue. If the PR is large (or likely to be), it would be prudent to open a discussion in advance of the PR to avoid doing large amounts of work that might not get merged. -->

<!-- When this PR is merged, a new version of emitron will be pushed to Testflight automatically -->

This pull request fixes Issue 552 - Retain Filters between runs

+20 -11

6 comments

3 changed files

adesugbaa

pr closed time in 2 days

pull request commentrazeware/emitron-iOS

Fix issue 552 - Retain Filters between runs

@adesugbaa Thanks for the PR! Your commits have been added to #603 and will be part of that PR which has some tests if you'd like to take a look at how that was achieved.

Sorry it's taken so long to get your stuff merged in! I'll close this in favour of #603

adesugbaa

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentsoto-project/soto-core

Add AWSPayload.asyncSequence

+//===----------------------------------------------------------------------===//+//+// This source file is part of the Soto for AWS open source project+//+// Copyright (c) 2017-2021 the Soto project authors+// Licensed under Apache License v2.0+//+// See LICENSE.txt for license information+// See CONTRIBUTORS.txt for the list of Soto project authors+//+// SPDX-License-Identifier: Apache-2.0+//+//===----------------------------------------------------------------------===//++#if compiler(>=5.5)++import NIOCore++@available(macOS 12.0, iOS 15.0, watchOS 8.0, tvOS 15.0, *)+extension AWSPayload {+    /// Construct a stream payload from a `NIOFileHandle`

Only comment after a quick read through of this is that it's not clear where NIOFileHandle comes from or is used in this extension

adam-fowler

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentvapor/postgres-kit

PostGIS "geometry" type

Have a look at https://github.com/rabc/fluent-postgis for PostGIS support

codingmanu

comment created time in 2 days

pull request commentsoto-project/soto

Replace NIO with NIOCore where applicable

Cool as long as it's something we export that should be fine. My thinking was to avoid headaches in the future when SwiftPM fixes the bug of making all targets in the dependency tree available to everything at some point in the future

adam-fowler

comment created time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

created tagvapor/vapor

tag4.48.7

💧 A server-side Swift web framework.

created time in 3 days

release vapor/vapor

4.48.7

released time in 3 days

push eventvapor/vapor

Richard Turton

commit sha 69b0e257b1a86c1eaa1767563a093e208fdb8fab

Fix Xcode 13 RC build failure by not sending an optional to free() (#2687)

view details

push time in 3 days

PR merged vapor/vapor

Fix Xcode 13 RC build failure

<!-- 🚀 Thank you for contributing! -->

<!-- Describe your changes clearly and use examples if possible. -->

Using the SDK in Xcode 13 RC, free() expects a non-optional parameter. This change unwraps the optional cwd before passing it.

Resolves #2686

+3 -1

0 comment

1 changed file

jrturton

pr closed time in 3 days

issue closedvapor/vapor

Package won't compile with Xcode 13 Release Candidate

<!-- 🚀 Thank you for contributing! --->

Describe the bug

Similar to the issue affecting SwiftNIO (https://github.com/apple/swift-nio/pull/1956), the package fails to compile in the Xcode 13 Release Candidate (Version 13.0 (13A233)), due to free now expecting a non-nullable argument.

To Reproduce

  1. Open the package with Xcode Version 13.0 (13A233)
  2. Attempt to build
  3. Build fails in DirectoryConfiguration.swift on the call to free

Expected behavior

The package builds

Environment

macOS Big Sur 11.6 Xcode Version 13.0 (13A233) Vapor as at commit 21af9d09

closed time in 3 days

jrturton
PullRequestReviewEvent

pull request commentvapor/vapor

Add support for async/await

@davdroman Done!

0xTim

comment created time in 3 days

push eventvapor/vapor

AZm87

commit sha 5113bfcb0dbcfaefdc043acd8e161046eb4fbb65

Fix `comparePreference` function when only one media type specified (#2670)

view details

Adam Fowler

commit sha a8bd13fa10b14d2c014f002a4eed0558f66bcf6f

Default HTTPServer.Configuration.supportPipelining to true (#2677)

view details

David Roman

commit sha 21af9d0935733ffaa2832e473779d01edcf6ed84

Correctly pass `SocketAddress` through to `Request` convenience initialiser (#2685) * Fix missing assignment in `Request` convenience init * Fix typo

view details

Tim Condon

commit sha 9741efbc84bcaf3d835d8cacb0ab39812fe7ff0d

Merge branch 'main' into async-await

view details

push time in 3 days